rack-mini-profiler 0.1.20 → 0.1.21

data/CHANGELOG

@@ -1,93 +1,99 @@
-28-June-2012 - Sam  
- 
-  * Started change log
-  * Corrected profiler so it properly captures POST requests (was supressing non 200s)
-  * Amended Rack.MiniProfiler.config[:user_provider] to use ip addres for identity 
-  * Fixed bug where unviewed missing ids never got cleared
-  * Supress all '/assets/' in the rails tie (makes debugging easier)
-  * record_sql was mega buggy
-
-9-July-2012 - Sam 
-
-  * Cleaned up mechanism for profiling in production, all you need to do now
-	is call Rack::MiniProfiler.authorize_request to get profiling working in
-	production 
-	* Added option to display full backtraces pp=full-backtrace
-	* Cleaned up railties, got rid of the post authorize callback
-	* Version 0.1.3
-
-12-July-2012 - Sam 
-
-  * Fixed incorrect profiling steps (was not indenting or measuring start time right
-	* Implemented native PG and MySql2 interceptors, this gives way more accurate times
-	* Refactored context so its a proper class and not a hash 
-	* Added some more client probing built in to rails
-	* More tests
-
-18-July-2012 - Sam 
-  
-  * Added First Paint time for chrome
-  * Bug fix to ensure non Rails installs have mini profiler
-  * Version 0.1.7
-
-30-July-2012 - Sam 
-  
-  * Made compliant with ancient versions of Rack (including Rack used by Rails2)
-  * Fixed broken share link 
-  * Fixed crashes on startup (in MemoryStore and FileStore)
-  * Version 0.1.8
-  * Unicode fix 
-  * Version 0.1.9
-
-7-August-2012 - Sam
-
-  * Added option to disable profiler for the current session (pp=disable / pp=enable)
-  * yajl compatability contributed by Sven Riedel 
-
-10-August-2012 - Sam 
-
-  * Added basic prepared statement profiling for postgres 
-
-20-August-2012 - Sam 
-  
-  * 1.12.pre 
-  * Cap X-MiniProfiler-Ids at 10, otherwise the header can get killed
-
-3-September-2012 - Sam
-
-  * 1.13.pre
-  * pg gem prepared statements were not being logged correctly 
-  * added setting config.backtrace_ignores = [] - an array of regexes that match on caller lines that get ignored
-  * added setting config.backtrace_includes = [] - an array of regexes that get included in the trace by default 
-  * cleaned up the way client settings are stored
-  * made pp=full-backtrace "sticky"
-  * added pp=normal-backtrace to clear the "sticky" state
-  * change "pp=sample" to work with "caller" no need for stack trace gem
-
-4-September-2012 - Sam 
-
-  * 1.15.pre
-  * fixed annoying bug where client settings were not sticking 
-  * fixed long standing issue with Rack::ConditionalGet stopping MiniProfiler from working properly
-
-5-September-2012 - Sam 
-
-  * 1.16
-  * fixed long standing problem specs (issue with memory store)
-  * fixed issue where profiler would be dumped when you got a 404 in production (and any time rails is bypassed)
-  * implemented stacktrace properly
-
-9-September-2012 - Sam
-
-  * 1.17
-  * pp=sample was bust unless stacktrace was installed
-
-10-September-2012 - Sam 
-
-  * 1.19
-  * fix compat issue with 1.8.7
-
-12-September-2012 - Sam
-  
-  * 1.20
-  * Added pp=profile-gc , it allows you to profile the GC in Ruby 1.9.3
+28-June-2012 - Sam  
+ 
+  * Started change log
+  * Corrected profiler so it properly captures POST requests (was supressing non 200s)
+  * Amended Rack.MiniProfiler.config[:user_provider] to use ip addres for identity 
+  * Fixed bug where unviewed missing ids never got cleared
+  * Supress all '/assets/' in the rails tie (makes debugging easier)
+  * record_sql was mega buggy
+  * added MemcacheStore
+
+9-July-2012 - Sam 
+
+  * Cleaned up mechanism for profiling in production, all you need to do now
+	is call Rack::MiniProfiler.authorize_request to get profiling working in
+	production 
+	* Added option to display full backtraces pp=full-backtrace
+	* Cleaned up railties, got rid of the post authorize callback
+	* Version 0.1.3
+
+12-July-2012 - Sam 
+
+  * Fixed incorrect profiling steps (was not indenting or measuring start time right
+	* Implemented native PG and MySql2 interceptors, this gives way more accurate times
+	* Refactored context so its a proper class and not a hash 
+	* Added some more client probing built in to rails
+	* More tests
+
+18-July-2012 - Sam 
+  
+  * Added First Paint time for chrome
+  * Bug fix to ensure non Rails installs have mini profiler
+  * Version 0.1.7
+
+30-July-2012 - Sam 
+  
+  * Made compliant with ancient versions of Rack (including Rack used by Rails2)
+  * Fixed broken share link 
+  * Fixed crashes on startup (in MemoryStore and FileStore)
+  * Version 0.1.8
+  * Unicode fix 
+  * Version 0.1.9
+
+7-August-2012 - Sam
+
+  * Added option to disable profiler for the current session (pp=disable / pp=enable)
+  * yajl compatability contributed by Sven Riedel 
+
+10-August-2012 - Sam 
+
+  * Added basic prepared statement profiling for postgres 
+
+20-August-2012 - Sam 
+  
+  * 1.12.pre 
+  * Cap X-MiniProfiler-Ids at 10, otherwise the header can get killed
+
+3-September-2012 - Sam
+
+  * 1.13.pre
+  * pg gem prepared statements were not being logged correctly 
+  * added setting config.backtrace_ignores = [] - an array of regexes that match on caller lines that get ignored
+  * added setting config.backtrace_includes = [] - an array of regexes that get included in the trace by default 
+  * cleaned up the way client settings are stored
+  * made pp=full-backtrace "sticky"
+  * added pp=normal-backtrace to clear the "sticky" state
+  * change "pp=sample" to work with "caller" no need for stack trace gem
+
+4-September-2012 - Sam 
+
+  * 1.15.pre
+  * fixed annoying bug where client settings were not sticking 
+  * fixed long standing issue with Rack::ConditionalGet stopping MiniProfiler from working properly
+
+5-September-2012 - Sam 
+
+  * 1.16
+  * fixed long standing problem specs (issue with memory store)
+  * fixed issue where profiler would be dumped when you got a 404 in production (and any time rails is bypassed)
+  * implemented stacktrace properly
+
+9-September-2012 - Sam
+
+  * 1.17
+  * pp=sample was bust unless stacktrace was installed
+
+10-September-2012 - Sam 
+
+  * 1.19
+  * fix compat issue with 1.8.7
+
+12-September-2012 - Sam
+  
+  * 1.20
+  * Added pp=profile-gc , it allows you to profile the GC in Ruby 1.9.3
+
+17-September-2012
+  * 1.21
+  * New MemchacedStore 
+  * Rails 4 support

data/README.md

@@ -56,7 +56,7 @@ By default, rack-mini-profiler stores its results in a memory store:
 Rack::MiniProfiler.config.storage = Rack::MiniProfiler::MemoryStore
 ```
 
-There are 2 other available storage engines, `RedisStore` and `FileStore`. 
+There are 2 other available storage engines, `RedisStore`, `MemcacheStore`, and `FileStore`.
 
 MemoryStore is stores results in a processes heap - something that does not work well in a multi process environment. 
 FileStore stores results in the file system - something that may not work well in a multi machine environment. 

data/lib/mini_profiler/gc_profiler.rb

@@ -0,0 +1,84 @@
+class Rack::MiniProfiler::GCProfiler
+  
+  def object_space_stats
+    stats = {}
+    ids = Set.new
+    ObjectSpace.each_object { |o|
+      stats[o.class] ||= 1
+      stats[o.class] += 1
+      ids << o.object_id
+    }
+    {:stats => stats, :ids => ids}
+  end
+
+  def diff_object_stats(before,after)
+    diff = {}
+    after.each do |k,v|
+      diff[k] = v - (before[k] || 0)
+    end
+    before.each do |k,v|
+      diff[k] = 0 - v unless after[k]
+    end
+
+    diff
+  end
+
+  def analyze_strings(ids_before,ids_after)
+    result = {}
+    ids_after.each do |id|
+      obj = ObjectSpace._id2ref(id)
+      if String === obj && !ids_before.include?(obj.object_id) 
+        result[obj] ||= 0 
+        result[obj] += 1
+      end
+    end
+    result
+  end
+
+  def profile_gc(app,env)
+    
+    body = [];
+
+    stat_after = nil
+    stat_before = object_space_stats
+    begin
+      GC::Profiler.clear
+      GC::Profiler.enable
+      b = app.call(env)[2]
+      b.close if b.respond_to? :close
+      stat_after = object_space_stats
+      body << GC::Profiler.result
+    ensure
+      GC::Profiler.disable
+    end
+
+    diff = diff_object_stats(stat_before[:stats],stat_after[:stats])
+
+    body << "
+ObjectSpace delta caused by request:
+--------------------------------------------\n"
+    diff.to_a.reject{|k,v| v == 0}.sort{|x,y| y[1] <=> x[1]}.each do |k,v|
+      body << "#{k} : #{v}\n" if v != 0
+    end
+
+    body << "\n
+ObjectSpace stats:
+-----------------\n"
+
+    stat_after[:stats].to_a.sort{|x,y| y[1] <=> x[1]}.each do |k,v|
+      body << "#{k} : #{v}\n" 
+    end
+
+    r = analyze_strings(stat_before[:ids], stat_after[:ids])
+
+    body << "\n
+String stats:
+------------\n"
+
+    r.to_a.sort{|x,y| y[1] <=> x[1] }.take(1000).each do |string,count|
+      body << "#{count} : #{string}\n"
+    end
+
+    return [200, {'Content-Type' => 'text/plain'}, body]
+  end
+end

data/lib/mini_profiler/profiler.rb

@@ -7,6 +7,7 @@ require 'mini_profiler/sql_timer_struct'
 require 'mini_profiler/client_timer_struct'
 require 'mini_profiler/request_timer_struct'
 require 'mini_profiler/storage/abstract_store'
+require 'mini_profiler/storage/memcache_store'
 require 'mini_profiler/storage/memory_store'
 require 'mini_profiler/storage/redis_store'
 require 'mini_profiler/storage/file_store'
@@ -14,6 +15,7 @@ require 'mini_profiler/config'
 require 'mini_profiler/profiling_methods'
 require 'mini_profiler/context'
 require 'mini_profiler/client_settings'
+require 'mini_profiler/gc_profiler'
 
 module Rack
 
@@ -209,7 +211,7 @@ module Rack
       end
 
       if query_string =~ /pp=profile-gc/
-        return profile_gc(env)
+        return Rack::MiniProfiler::GCProfiler.new.profile_gc(@app, env)
       end
 
       MiniProfiler.create_current(env, @config)
@@ -396,63 +398,6 @@ module Rack
       [200, headers, [body]]
     end
 
-
-    def object_space_stats
-      stats = {}
-      ObjectSpace.each_object { |o|
-        stats[o.class] ||= 1
-        stats[o.class] += 1
-      }
-      stats
-    end
-
-    def diff_object_stats(before,after)
-      diff = {}
-      after.each do |k,v|
-        diff[k] = v - (before[k] || 0)
-      end
-      before.each do |k,v|
-        diff[k] = 0 - v unless after[k]
-      end
-
-      diff
-    end
-
-    def profile_gc(env)
-      
-      body = "";
-
-      stat_before = object_space_stats
-      begin
-        GC::Profiler.clear
-        GC::Profiler.enable
-        @app.call(env)
-        body << GC::Profiler.result
-      ensure
-        GC::Profiler.disable
-      end
-      stat_after = object_space_stats
-
-      diff = diff_object_stats(stat_before,stat_after)
-
-      body << "
-ObjectSpace delta caused by request:
---------------------------------------------\n"
-      diff.to_a.reject{|k,v| v == 0}.sort{|x,y| y[1] <=> x[1]}.each do |k,v|
-        body << "#{k} : #{v}\n" if v != 0
-      end
-
-      body << "\n
-ObjectSpace stats:
------------------\n"
-
-      stat_after.to_a.sort{|x,y| y[1] <=> x[1]}.each do |k,v|
-        body << "#{k} : #{v}\n" 
-      end
-
-      return [200, {'Content-Type' => 'text/plain'}, body]
-    end
-
     def analyze(traces, page_struct)
       headers = {'Content-Type' => 'text/plain'}
       body = "Collected: #{traces.count} stack traces. Duration(ms): #{page_struct.duration_ms}"

data/lib/mini_profiler/profiling_methods.rb

@@ -71,8 +71,16 @@ module Rack
           return self.send without_profiling, *args, &orig unless Rack::MiniProfiler.current
 
           name = default_name 
-          name = blk.bind(self).call(*args) if blk
-          
+          if blk
+            name =
+              if respond_to?(:instance_exec)
+                instance_exec(*args, &blk)
+              else
+                # deprecated in Rails 4.x
+                blk.bind(self).call(*args)
+              end
+          end
+
           parent_timer = Rack::MiniProfiler.current.current_timer
           page_struct = Rack::MiniProfiler.current.page_struct
           result = nil

data/lib/mini_profiler/storage/memcache_store.rb

@@ -0,0 +1,51 @@
+module Rack
+  class MiniProfiler
+    class MemcacheStore < AbstractStore
+
+      EXPIRE_SECONDS = 60*60*24
+      MAX_RETRIES = 10
+
+      def initialize(client = nil, prefix = "MPMemcacheStore")
+        require 'dalli' unless defined? Dalli
+        @prefix = prefix
+        @client = client || Dalli::Client.new(['localhost:11211'])
+      end
+
+      def save(page_struct)
+        @client.set("#{@prefix}#{page_struct['Id']}", Marshal::dump(page_struct), EXPIRE_SECONDS)
+      end
+
+      def load(id)
+        raw = @client.get("#{@prefix}#{id}")
+        if raw
+          Marshal::load raw
+        end
+      end
+
+      def set_unviewed(user, id)
+        @client.add("#{@prefix}-#{user}-v", [], EXPIRE_SECONDS)
+        MAX_RETRIES.times do
+          break if @client.cas("#{@prefix}-#{user}-v", EXPIRE_SECONDS) do |ids|
+            ids << id unless ids.include?(id)
+            ids
+          end
+        end
+      end
+
+      def set_viewed(user, id)
+        @client.add("#{@prefix}-#{user}-v", [], EXPIRE_SECONDS)
+        MAX_RETRIES.times do
+          break if @client.cas("#{@prefix}-#{user}-v", EXPIRE_SECONDS) do |ids|
+            ids.delete id
+            ids
+          end
+        end
+      end
+
+      def get_unviewed_ids(user)
+        @client.get("#{@prefix}-#{user}-v") || []
+      end
+
+    end
+  end
+end

data/lib/mini_profiler_rails/railtie.rb

@@ -12,8 +12,9 @@ module MiniProfilerRails
         Rails.env.development? || Rails.env.production?  
       }
 
+      c.skip_paths ||= []
+
       if Rails.env.development?
-        c.skip_paths ||= []
         c.skip_paths << "/assets/"
         c.skip_schema_queries = true
       end

data/lib/rack-mini-profiler.rb

@@ -1,6 +1,6 @@
 require 'mini_profiler/profiler'
 require 'patches/sql_patches'
 
-if defined?(::Rails) && ::Rails::VERSION::MAJOR.to_i == 3
+if defined?(::Rails) && ::Rails::VERSION::MAJOR.to_i >= 3
   require 'mini_profiler_rails/railtie'
 end

data/rack-mini-profiler.gemspec

@@ -1,9 +1,9 @@
 Gem::Specification.new do |s|
 	s.name = "rack-mini-profiler"
-	s.version = "0.1.20"
+	s.version = "0.1.21"
 	s.summary = "Profiles loading speed for rack applications."
-	s.authors = ["Aleks Totic","Sam Saffron", "Robin Ward"]
-	s.description = "Page loading speed displayed on every page. Optimize while you develop, performance is a feature."
+	s.authors = ["Sam Saffron", "Robin Ward","Aleks Totic"]
+	s.description = "Profiling toolkit for Rack applications with Rails integration. Client Side profiling, DB profiling and Server profiling."
 	s.email = "sam.saffron@gmail.com"
 	s.homepage = "http://miniprofiler.com"
 	s.files = [

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: rack-mini-profiler
 version: !ruby/object:Gem::Version
-  version: 0.1.20
+  version: 0.1.21
   prerelease: 
 platform: ruby
 authors:
-- Aleks Totic
 - Sam Saffron
 - Robin Ward
+- Aleks Totic
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-11 00:00:00.000000000 Z
+date: 2012-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -77,8 +77,8 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
-description: Page loading speed displayed on every page. Optimize while you develop,
-  performance is a feature.
+description: Profiling toolkit for Rack applications with Rails integration. Client
+  Side profiling, DB profiling and Server profiling.
 email: sam.saffron@gmail.com
 executables: []
 extensions: []
@@ -95,12 +95,14 @@ files:
 - lib/mini_profiler/context.rb
 - lib/mini_profiler/config.rb
 - lib/mini_profiler/profiling_methods.rb
+- lib/mini_profiler/gc_profiler.rb
 - lib/mini_profiler/client_timer_struct.rb
 - lib/mini_profiler/profiler.rb
 - lib/mini_profiler/storage/memory_store.rb
 - lib/mini_profiler/storage/file_store.rb
 - lib/mini_profiler/storage/redis_store.rb
 - lib/mini_profiler/storage/abstract_store.rb
+- lib/mini_profiler/storage/memcache_store.rb
 - lib/rack-mini-profiler.rb
 - lib/html/jquery.1.7.1.js
 - lib/html/includes.tmpl
@@ -131,7 +133,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -250357363
+      hash: -668836557
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -140,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -250357363
+      hash: -668836557
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24