rack-mini-profiler 0.1 → 0.1.1

data/CHANGELOG.md

@@ -0,0 +1,7 @@
+28-June-2012 - Sam  
+ 
+  * Started change log
+  * Corrected profiler so it properly captures POST requests (was supressing non 200s)
+  * Amended Rack.MiniProfiler.config[:user_provider] to use ip addres for identity 
+  * Fixed bug where unviewed missing ids never got cleared
+  * Supress all '/assets/' in the rails tie (makes debugging easier)

data/README.md

@@ -70,13 +70,3 @@ In a Rails app, this can be done conveniently in an initializer such as config/i
 * skip_schema_queries - Whether or not you want to log the queries about the schema of your tables. Default is 'true'
 
 
-## TODO: prior to release - pull requests welcome
-
-- Stack Traces for SQL called (added but mental, needs to be filtered to something usable) 
-- Decide if we hook up SQL at the driver level (eg mysql gem) or library level (eg active record) - my personal perference is to do driver level hooks (Sam)
-- Add automatic instrumentation for Rails (Controller times, Action times, Partial times, Layout times)
-- Grab / display the parameters of SQL executed for parameterized SQL 
-- Beef up the documentation 
-- Auto-wire-up rails middleware 
-- Review our API and ensure it is trivial
-

data/lib/mini_profiler/profiler.rb

@@ -38,7 +38,7 @@ module Rack
         :backtrace_filter => nil,
         :skip_schema_queries => true,
         :storage => MiniProfiler::MemoryStore,
-        :user_provider => Proc.new{|env| "TODO" }
+        :user_provider => Proc.new{|env| Rack::Request.new(env).ip }
       }
     end
 
@@ -76,16 +76,17 @@ module Rack
 
 		def serve_results(env)
 			request = Rack::Request.new(env)      
-			page_struct = @storage.load(request['id'])
+      id = request['id']
+			page_struct = @storage.load(id)
       unless page_struct
-        @storage.set_viewed(user(env), request['Id']) 
-			  return [404, {}, ["No such result #{request['id']}"]] 
+        @storage.set_viewed(user(env), id) 
+        return [404, {}, ["Request not found: #{request['id']} - user #{user(env)}"]] 
       end
 			unless page_struct['HasUserViewed']
 				page_struct['ClientTimings'].init_from_form_data(env, page_struct)
 				page_struct['HasUserViewed'] = true
         @storage.save(page_struct) 
-        @storage.set_viewed(user(env), page_struct['Id']) 
+        @storage.set_viewed(user(env), id) 
 			end
 
       result_json = page_struct.to_json
@@ -194,10 +195,12 @@ module Rack
       page_struct = current['page_struct']
 			page_struct['Root'].record_time((Time.now - start) * 1000)
 
-			# inject headers, script
+      # no matter what it is, it should be unviewed, otherwise we will miss POST
+      @storage.set_unviewed(user(env), page_struct['Id']) 
+			@storage.save(page_struct)
+			
+      # inject headers, script
 			if status == 200
-				@storage.save(page_struct)
-        @storage.set_unviewed(user(env), page_struct['Id']) 
         
 				# inject header
         if headers.is_a? Hash

data/lib/mini_profiler/storage/redis_store.rb

@@ -4,7 +4,8 @@ module Rack
 
       EXPIRE_SECONDS = 60 * 60 * 24
      
-      def initialize(args = {})
+      def initialize(args)
+        args ||= {}
         @prefix = args[:prefix] || 'MPRedisStore'
       end
 

data/lib/mini_profiler_rails/railtie.rb

@@ -4,9 +4,14 @@ module MiniProfilerRails
     initializer "rack_mini_profiler.configure_rails_initialization" do |app|
 
       # By default, only show the MiniProfiler in development mode
-      Rack::MiniProfiler.configuration[:authorize_cb] = lambda {|env| Rails.env.development? }
+      Rack::MiniProfiler.configuration[:authorize_cb] = lambda { |env|
+        Rails.env.development? && !(env['PATH_INFO'] =~ /^\/assets\//)
+      }
+
+      # The file store is just so much less flaky
       tmp = Rails.root.to_s + "/tmp/miniprofiler"
       Dir::mkdir(tmp) unless File.exists?(tmp)
+      
       Rack::MiniProfiler.configuration[:storage_options] = {:path => tmp}
       Rack::MiniProfiler.configuration[:storage] = Rack::MiniProfiler::FileStore
 
@@ -14,8 +19,6 @@ module MiniProfilerRails
       Rack::MiniProfiler.configuration[:backtrace_remove] = Rails.root.to_s + "/"
       Rack::MiniProfiler.configuration[:backtrace_filter] =  /^\/?(app|config|lib|test)/
 
-      # The file store is just so much less flaky
-
       # Install the Middleware
       app.middleware.insert_before 'Rack::Lock', 'Rack::MiniProfiler'
 

data/rack-mini-profiler.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 	s.name = "rack-mini-profiler"
-	s.version = "0.1"
-	s.summary = "Profiles loading speed for html pages."
+	s.version = "0.1.1"
+	s.summary = "Profiles loading speed for rack applications."
 	s.authors = ["Aleks Totic","Sam Saffron", "Robin Ward"]
 	s.date = "2012-04-02"
 	s.description = "Page loading speed displayed on every page. Optimize while you develop, performance is a feature."
@@ -11,7 +11,8 @@ Gem::Specification.new do |s|
 		'rack-mini-profiler.gemspec',
 	].concat( Dir.glob('lib/**/*').reject {|f| File.directory?(f) || f =~ /~$/ } )
 	s.extra_rdoc_files = [
-		"README.md"
+		"README.md",
+    "CHANGELOG.md"
 	]
 	s.add_runtime_dependency 'rack', '>= 1.1.3' 
   if RUBY_VERSION < "1.9"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-mini-profiler
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -84,6 +84,7 @@ executables: []
 extensions: []
 extra_rdoc_files:
 - README.md
+- CHANGELOG.md
 files:
 - rack-mini-profiler.gemspec
 - lib/mini_profiler/sql_timer_struct.rb
@@ -113,6 +114,7 @@ files:
 - lib/mini_profiler_rails/railtie.rb
 - lib/patches/sql_patches.rb
 - README.md
+- CHANGELOG.md
 homepage: http://miniprofiler.com
 licenses: []
 post_install_message: 
@@ -127,7 +129,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1062659085
+      hash: -779964803
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -136,11 +138,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1062659085
+      hash: -779964803
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: Profiles loading speed for html pages.
+summary: Profiles loading speed for rack applications.
 test_files: []