rack-methodoverride-with-params 1.0.0

data/.gitignore

@@ -0,0 +1 @@
+*.gem

data/LICENSE

@@ -0,0 +1,21 @@
+Copyright (c) 2010 Nick Howard
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+

data/README.md

@@ -0,0 +1,26 @@
+Rack MethodOverride With Params
+===============================
+Rack MethodOverride With Params solves the issue where POST requests with `_method` as a query param do not use `_method`'s value as the HTTP method in Rails etc that use Rack MethodOverride.
+
+It does this by extending `Rack::MethodOverride` and overriding it so it looks at both query params and form params. So you can use it anywhere you were using `Rack::MethodOverride`
+
+To use it with Rack Builder
+
+    require 'rack-methodoverride-with-params'
+    #...
+    use Rack::MethodOverrideWithParams
+
+to use it with Rails
+
+add it to the `Gemfile`
+
+    gem 'rack-methodoverride-with-params'
+
+swap Rack::MethodOverride in `config/environment.rb`
+
+    config.middleware.swap Rack::MethodOverride, Rack::MethodOverrideWithParams
+Contrib
+---------------
+There is not much here, but if you want to play around, clone the project, run the specs and hack away.
+
+I probably won't be actively working on this much as it is really simple, but if you ping me about it on github or twitter(I'm baroquebobcat), I'll help you out.

data/lib/rack-methodoverride-with-params.rb

@@ -0,0 +1 @@
+require File.dirname(__FILE__) + '/rack/methodoverride-with-params'

data/lib/rack/methodoverride-with-params.rb

@@ -0,0 +1,22 @@
+require 'rack'
+#
+module Rack
+  class MethodOverrideWithParams < Rack::MethodOverride
+
+    def call(env)
+      if env["REQUEST_METHOD"] == "POST"
+        req = Request.new(env)
+        method = req.params[METHOD_OVERRIDE_PARAM_KEY] ||
+          env[HTTP_METHOD_OVERRIDE_HEADER]
+        method = method.to_s.upcase
+        if HTTP_METHODS.include?(method)
+          env["rack.methodoverride.original_method"] = env["REQUEST_METHOD"]
+          env["REQUEST_METHOD"] = method
+        end
+      end
+
+      @app.call(env)
+
+    end
+  end
+end

data/rack-methodoverride-with-params.gemspec

@@ -0,0 +1,17 @@
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name     = "rack-methodoverride-with-params"
+  s.version  = "1.0.0"
+  s.platform = Gem::Platform::RUBY
+  s.authors  = ["Nick Howard"]
+  s.email    = ["ndh@baroquebobcat.com"]
+  s.homepage = "http://github.com/baroquebobcat/rack-methodoverride-with-params"
+  s.summary  = %q(A replacement for Rack::MethodOverride that looks at query params and post data.)
+  s.description = %q(Rack::MethodOverride only checks the X-Http-Method-Override header and the form encoded post body for _method. Rack::MethodOverrideWithParams checks both of those _and_ the query params. So, if you POST xml with a url like http://example.com/?_method=delete the application will see it as a delete request.)
+  s.required_rubygems_version = ">= 1.3.6"
+  s.files = `git ls-files`.split("\n")
+  s.require_paths      = ["lib"]
+  s.add_dependency "rack", "~> 1"
+  s.add_development_dependency 'rspec', '~> 2'
+end

data/spec/methodoverride_with_params_spec.rb

@@ -0,0 +1,38 @@
+lib = File.expand_path('../lib/', __FILE__)
+$:.unshift lib unless $:.include?(lib)
+
+require 'rack-methodoverride-with-params'
+
+describe Rack::MethodOverrideWithParams do
+  let(:in_env) { {} }
+  let(:out_env) { subject.call(in_env) }
+  let(:app) {lambda {|env| env}}
+  subject { Rack::MethodOverrideWithParams.new(app)}
+    
+  describe "a get request" do
+    it { app.should_receive(:call).with(in_env); out_env }
+    it { out_env.should == in_env }
+  end
+
+  describe "a post request" do
+    before { 
+      in_env['REQUEST_METHOD']='POST'
+      in_env['rack.input'] = in_env['form_input'] = ''
+      in_env['rack.request.form_input'] = ''
+      in_env["rack.request.form_hash"] = {}
+    }
+    Rack::MethodOverrideWithParams::HTTP_METHODS.each do |method|
+      describe "with _method = #{method} as a post param" do
+        before { in_env["rack.request.form_hash"] = {'_method' => method} }
+     
+        it { out_env['REQUEST_METHOD'].should == method }
+      end
+
+      describe 'with _method = #{method} as a query param' do
+        before { in_env['QUERY_STRING'] = "_method=#{method}" }
+        
+        it { out_env['REQUEST_METHOD'].should == method }
+      end
+    end
+  end
+end

metadata

@@ -0,0 +1,104 @@
+--- !ruby/object:Gem::Specification 
+name: rack-methodoverride-with-params
+version: !ruby/object:Gem::Version 
+  hash: 23
+  prerelease: false
+  segments: 
+  - 1
+  - 0
+  - 0
+  version: 1.0.0
+platform: ruby
+authors: 
+- Nick Howard
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2010-09-28 00:00:00 -06:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: rack
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 1
+        segments: 
+        - 1
+        version: "1"
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 2
+        version: "2"
+  type: :development
+  version_requirements: *id002
+description: Rack::MethodOverride only checks the X-Http-Method-Override header and the form encoded post body for _method. Rack::MethodOverrideWithParams checks both of those _and_ the query params. So, if you POST xml with a url like http://example.com/?_method=delete the application will see it as a delete request.
+email: 
+- ndh@baroquebobcat.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: []
+
+files: 
+- .gitignore
+- LICENSE
+- README.md
+- lib/rack-methodoverride-with-params.rb
+- lib/rack/methodoverride-with-params.rb
+- lib/rack/methodoverride-with-params/version.rb
+- rack-methodoverride-with-params.gemspec
+- spec/methodoverride_with_params_spec.rb
+has_rdoc: true
+homepage: http://github.com/baroquebobcat/rack-methodoverride-with-params
+licenses: []
+
+post_install_message: 
+rdoc_options: []
+
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 23
+      segments: 
+      - 1
+      - 3
+      - 6
+      version: 1.3.6
+requirements: []
+
+rubyforge_project: 
+rubygems_version: 1.3.7
+signing_key: 
+specification_version: 3
+summary: A replacement for Rack::MethodOverride that looks at query params and post data.
+test_files: []
+