rack-insight 0.5.30 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 351bb41ae69905d1b03169864a4b0459220af8df
-  data.tar.gz: ae9f529678066604e1d3cc2a62a72dd7167b8655
+  metadata.gz: 070825bb2f27f4947924252c50492aebadb203d2
+  data.tar.gz: 3fa8d5e8fdf4a4a10fbc1db449deef7e312676ad
 SHA512:
-  metadata.gz: e06a61b347b4f0ec8c90d51ef67e078c4b5a445a28619c1abfa5e61df99a2c061529be0acb3d3a3a881cbd5d1d0263fec3e4050295dd6091f88cc8666d4be38a
-  data.tar.gz: 5f1634ef97c2838a9e63910e264af6cfe1e29fa96b67d6f5fb04a02e591d3e7a95781e8b2df974eea0c47698a51fc9b988fefd1458eecf0777988ebbc75720b2
+  metadata.gz: ebccd9b683fdccc127585cc48e874c4eed6f85b270c8c0b41f91f206d498ca6b19920a26af0287139858cb3f39be01a1d469671f020e921fb13036fc813d09af
+  data.tar.gz: 94e99ba82b5105be008e8fcc40d595428aee16de061c3834f43515e7939a349d6b890872d09ea17780bbd4f503d67273a7192bc4225ae86a12ff4647f9e0bedd

data/{CHANGELOG → CHANGELOG.md}

@@ -1,4 +1,19 @@
-== 0.5.30 / 2015-01-07
+## 0.6 / 2015-03-08
+
+  * Bug Fixes
+
+    * Complete rewrite of `EnableButton` to ensure compatibility with all other Rack apps by Peter Boling
+    * Removed duplicate config entry for `:verbosity` by Peter Boling
+
+  * Other
+
+    * Added Sinatra example to Readme by Peter Boling
+    * spec improvements by Peter Boling
+    * upgrade to latest version of Ruby for development by Peter Boling
+    * Fixed Markdown syntax on CHANGELOG => CHANGELOG.md by Peter Boling
+    * added bin scripts, but do not include in gem package by Peter Boling
+
+## 0.5.30 / 2015-01-07
 
   * Bug Fixes
 
@@ -9,7 +24,7 @@
     * Added working example: https://github.com/pboling/x-cascade_header_rails/tree/rails3
 
 
-== 0.5.29 / 2014-11-06
+## 0.5.29 / 2014-11-06
 
   * Bug Fixes
 
@@ -27,7 +42,7 @@
 
     * Improved Readme by Peter Boling
 
-== 0.5.28 / 2014-01-14
+## 0.5.28 / 2014-01-14
 
   * Bug Fixes
 
@@ -57,7 +72,7 @@
 
 
 
-== 0.5.27 / 2013-09-03
+## 0.5.27 / 2013-09-03
 
   * Other
 
@@ -79,7 +94,7 @@
 
     * Add license and platform to gemspec by Peter Boling
 
-== 0.5.26 / 2013-08-06
+## 0.5.26 / 2013-08-06
 
   * Bug Fixes
 
@@ -93,13 +108,13 @@
 
     * Update README.md by Agis Anastasopoulos
 
-== 0.5.25 / 2013-03-15
+## 0.5.25 / 2013-03-15
 
   * Bug Fixes
 
     * active_record_panel is fixed! [(kjg - Kevin Glowacz)](https://github.com/kjg)
 
-== 0.5.24 / 2013-01-01
+## 0.5.24 / 2013-01-01
 
   * Bug Fixes
 
@@ -107,7 +122,7 @@
 
     * Changed event logging in the instrumentation from `:high` to `:debug` level.
 
-== 0.5.23 / 2012-09-14
+## 0.5.23 / 2012-09-14
 
   * New Features
 
@@ -129,13 +144,13 @@
             handle_error_for(method_name, ex)
           end
 
-== 0.5.22 / 2012-09-14
+## 0.5.22 / 2012-09-14
 
   * New Features
 
     * Improve handling of decoding and marshalling problems with new config options and implementation: (pboling - Peter Boling)
 
-      :database => a hash.  Keys :raise_encoding_errors, and :raise_decoding_errors are self explanatory
+          :database => a hash.  Keys :raise_encoding_errors, and :raise_decoding_errors are self explanatory
                    :raise_encoding_errors
                        When set to true, if there is an encoding error (unlikely)
                        it will cause a 500 error on your site.  !!!WARNING!!!
@@ -155,18 +170,18 @@
 
     * Internal config validation system (pboling - Peter Boling)
 
-== 0.5.21 / 2012-09-13 - Peter Boling
+## 0.5.21 / 2012-09-13
 
-  * Attempting to handle values that get stored in the sqlite db, but which can't be re-marshalled, without failing the entire panel
-  * Much nicer error handling output in panel heading and panel content areas
+  * Attempting to handle values that get stored in the sqlite db, but which can't be re-marshalled, without failing the entire panel (pboling - Peter Boling)
+  * Much nicer error handling output in panel heading and panel content areas (pboling - Peter Boling)
 
-== 0.5.20 / 2012-09-13 - Peter Boling
+## 0.5.20 / 2012-09-13
 
   * Bug Fixes
 
     * Fix panel error handling (pboling - Peter Boling)
 
-== 0.5.19 / 2012-09-13 - Peter Boling
+## 0.5.19 / 2012-09-13
 
   * Other
 
@@ -177,7 +192,7 @@
 
     * Fix redis panel, maybe... (oggy - George Ogata)
 
-== 0.5.18 / 2012-09-13 - Peter Boling
+## 0.5.18 / 2012-09-13
 
   * Bug Fixes
 
@@ -187,11 +202,11 @@
 
     * Fix Typo in templates panel
 
-== 0.5.17 / 2012-09-13 - Peter Boling
+## 0.5.17 / 2012-09-13
 
   * New Features
 
-    * MagicInsight!  WARNING: Magic is dangerous.
+    * MagicInsight!  WARNING: Magic is dangerous.  (pboling - Peter Boling)
 
       * MagicInsight is a new mixin that can be used by any 'stat' type class built for Rack::Bug / LogicalInsight / Rack::Insight.
         Just include Rack::Insight::MagicInsight in your stat class and then to render call:
@@ -201,51 +216,51 @@
         Read the source for Rack::Insight::MagicInsight and heed the warnings.
         MagicInsight is used internally by Rack::Insight for magic panels and the templates panel.
 
-    * panel content now stays out of your page content, by displaying below it.
+    * panel content now stays out of your page content, by displaying below it. (pboling - Peter Boling)
 
   * Bug Fixes
 
-    * Fixed the hardly working TemplatesPanel (Issue 1)
-    * Correct logging/debug statements
-    * Better tracking of which panels are probing
+    * Fixed the hardly working TemplatesPanel (Issue 1) (pboling - Peter Boling)
+    * Correct logging/debug statements (pboling - Peter Boling)
+    * Better tracking of which panels are probing (pboling - Peter Boling)
 
   * Other
 
-    * TemplatesPanel is now more aligned with the Rack::Insight Panel API.
+    * TemplatesPanel is now more aligned with the Rack::Insight Panel API. (pboling - Peter Boling)
 
-== 0.5.16 / 2012-09-11 - Peter Boling
+## 0.5.16 / 2012-09-11
 
   * Other
 
-    * Improved handling of no content for a panel.
+    * Improved handling of no content for a panel. (pboling - Peter Boling)
 
-== 0.5.14-15 / 2012-09-11 - Peter Boling
+## 0.5.14-15 / 2012-09-11
 
   * New Features
 
-    * Panel level configurations for :probes are now supported by default on all panels
-    * Auto-magical panel names
-    * Auto-magical panel probe detection and storage
-    * Auto-magical panel content
-    * Auto-magical table creation (skipped with self.has_table = false in a Panel class definition)
-    * Under construction, or blank, panels have more scaffolding
+    * Panel level configurations for :probes are now supported by default on all panels (pboling - Peter Boling)
+    * Auto-magical panel names (pboling - Peter Boling)
+    * Auto-magical panel probe detection and storage (pboling - Peter Boling)
+    * Auto-magical panel content (pboling - Peter Boling)
+    * Auto-magical table creation (skipped with self.has_table = false in a Panel class definition) (pboling - Peter Boling)
+    * Under construction, or blank, panels have more scaffolding (pboling - Peter Boling)
 
-== 0.5.13 / 2012-09-10 - Peter Boling
+## 0.5.13 / 2012-09-10
 
   * Bug Fixes
 
-    * Fixed the double logging of anything logged with ActiveSupport::BufferedLogger (via the new :panel_configs)
+    * Fixed the double logging of anything logged with ActiveSupport::BufferedLogger (via the new :panel_configs) (pboling - Peter Boling)
 
   * New Features
 
-    * Panel level configuration options for all panels, including extension gems.
+    * Panel level configuration options for all panels, including extension gems. (pboling - Peter Boling)
       Currently this is implemented in the log_panel, and configured as:
         Rack::Insight::Config.configure do |config|
           config[:panel_configs][:log_panel] = {:watch => {'Logger' => :add}}
         end
-    * Count number of Log Entries
+    * Count number of Log Entries (pboling - Peter Boling)
 
-== 0.5.12 / 2012-09-10
+## 0.5.12 / 2012-09-10
 
   * Other
 
@@ -255,69 +270,69 @@
 
     * persistent toolbar position by Alif Rachmawadi
 
-== 0.5.11 / 2012-09-05
+## 0.5.11 / 2012-09-05
 
   * Bug Fixes
 
     * Fixed Encoding::CompatibilityError by Michael Grosser
 
-== 0.5.10 / 2012-09-04 (Peter Boling)
+## 0.5.10 / 2012-09-04
 
   * Bug Fixes
 
-    * Ajax requests for previously cached panel data now go to root (/), which allows it to work on non-root URLs.
+    * Ajax requests for previously cached panel data now go to root (/), which allows it to work on non-root URLs. (pboling - Peter Boling)
 
-== 0.5.9 / 2012-09-04 (Peter Boling)
+## 0.5.9 / 2012-09-04
 
   * New Features
 
-    * FilteredBacktrace was disabled in LogicalInsight.  It's now back.  It is now configurable via the configure block.
+    * FilteredBacktrace was disabled in LogicalInsight.  It's now back.  It is now configurable via the configure block. (pboling - Peter Boling)
 
-== 0.5.8 / 2012-09-04 (Peter Boling)
+## 0.5.8 / 2012-09-04
 
   * Bug Fixes
 
-    * working template_root for rack-insight extension libraries
+    * working template_root for rack-insight extension libraries (pboling - Peter Boling)
 
-== 0.5.7 / 2012-09-03 (Peter Boling)
+## 0.5.7 / 2012-09-03
 
   * Bug Fixes
 
-    * require 'logger' important when using Ruby Logger
+    * require 'logger' important when using Ruby Logger (pboling - Peter Boling)
 
-== 0.5.6 / 2012-08-31 (Peter Boling)
+## 0.5.6 / 2012-08-31
 
   * Other
 
-    * Wrap debug logging in verbose check
-    * Documentation
+    * Wrap debug logging in verbose check (pboling - Peter Boling)
+    * Documentation (pboling - Peter Boling)
 
-== 0.5.5 / 2012-08-31 (Peter Boling)
+## 0.5.5 / 2012-08-31
 
   * New Features
 
     * Extension gems now automatically look for their view templates
-      relative to the panel class file that tries to render them.
+      relative to the panel class file that tries to render them. (pboling - Peter Boling)
     * Two levels of log verbosity filtering to allow re-use of the Rails log, but to not force same level output from
       rack-insight as the rails log is set to for the env.  It will never be more logging than Rails log's env level,
-      but it can, and usually should, be less.
+      but it can, and usually should, be less. (pboling - Peter Boling)
 
-  * Fixed a number of bugs, and refactored some things.  Please let me know if you use it/break it!
+  * Fixed a number of bugs, and refactored some things.  Please let me know if you use it/break it! (pboling - Peter Boling)
 
-== 0.5.0 / 2012-08-29 - transition to rack_insight (Peter Boling)
+## 0.5.0 / 2012-08-29 - transition to rack_insight
 
   * Compatibility
 
     * Restructure gem so Insight is inside a namespace, because I have classes named Insight that are obscured by
       logical_insight gem when loaded.  Logical also seemed like it may be a class name somewhere, hence going back to
-      the Rack namespace a la rack-bug.  Keeping the (now nested) Insight namespace as well, because - genetics.
+      the Rack namespace a la rack-bug.  Keeping the (now nested) Insight namespace as well, because - genetics. (pboling - Peter Boling)
 
-  *Other
+  * Other
 
-    * Fix spelling of retreive => retrieve
-    * Remove redundant time method from cache_panel/stats.rb
+    * Fix spelling of retreive => retrieve (pboling - Peter Boling)
+    * Remove redundant time method from cache_panel/stats.rb (pboling - Peter Boling)
 
-== 0.4.X - last of logical_insight
+## 0.4.X - last of logical_insight
 
   * New features
 
@@ -341,7 +356,7 @@
     * Refactoring and code cleanup (Tim Connor)
     * Testing cleanup - better isolation of Rails vs. non-Rails in tests (Tim Connor)
 
-== 0.3.0 / 2010-05-28
+## 0.3.0 / 2010-05-28
 
   * New features
 
@@ -359,6 +374,6 @@
     * compatibility with current rack-test (Luke Melia & Joey Aghion)
     * update Sinatra sample app (Tim Conner)
 
-== 0.2.1
+## 0.2.1
 
   * The beginning of recorded history

data/README.md

@@ -83,6 +83,28 @@ Using with non-Rails Rack apps
 Just 'use Rack::Insight' as any other middleware.  See the SampleApp in the
 spec/fixtures folder for an example Sinatra app.
 
+This is a minimal setup:
+
+```
+class SinatraExample < Sinatra::Base
+  get '/' do
+    <<-HTML
+      <html>
+        <head>
+        </head>
+        <body>
+          <p>Stink o' Man</p>
+        </body>
+      </html>
+    HTML
+  end
+
+  use Rack::Insight::App
+
+end
+```
+
+
 Configure Rack::Insight
 ---------------------
 

data/lib/rack/insight/config.rb

@@ -67,7 +67,6 @@ module Rack::Insight
       #   end
       :panel_load_paths => [File::join('rack', 'insight', 'panels')],
       :logger => @logger,
-      :verbosity => @verbosity,
       :log_file => @log_file,
       :log_level => @log_level,
       :rails_log_copy => @rails_log_copy, # Only has effect when logger is the Rack::Insight::Logger, or a logger behaving like it

data/lib/rack/insight/enable-button.rb

@@ -1,47 +1,39 @@
 module Rack::Insight
-  class EnableButton
+  class EnableButton < Struct.new :app, :insight
     include Render
 
-    MIME_TYPES = ["text/plain", "text/html", "application/xhtml+xml"]
-
-    def initialize(app, insight)
-      @app = app
-      @insight = insight
-    end
+    CONTENT_TYPE_REGEX = /text\/(html|plain)|application\/xhtml\+xml/
 
     def call(env)
-      @env = env
-      status, headers, body = @app.call(@env)
-
-      if !body.nil? && !body.empty?
-        response = Rack::Response.new(body, status, headers)
-        inject_button(response) if okay_to_modify?(env, response)
-
-        response.to_a
-      else
-        # Do not inject into assets served by rails or other detritus without a body.
-        [status, headers, body]
+      status, headers, response = app.call(env)
+
+      if okay_to_modify?(env, headers)
+        body = response.inject("") do |memo, part|
+          memo << part
+          memo
+        end
+        index = body.rindex("</body>")
+        if index
+          body.insert(index, render)
+          headers["Content-Length"] = body.bytesize.to_s
+          response = [body]
+        end
       end
-    end
 
-    def okay_to_modify?(env, response)
-      return false unless response.ok?
-
-      req = Rack::Request.new(env)
-      content_type, charset = response.content_type.split(";")
-      filters = (env['rack-insight.path_filters'] || []).map { |str| %r(^#{str}) }
-      filter = filters.find { |filter| env['REQUEST_PATH'] =~ filter }
-
-      !filter && MIME_TYPES.include?(content_type) && !req.xhr?
+      [status, headers, response]
     end
 
-    def inject_button(response)
-      full_body = response.body.join
-      full_body.sub! /<\/body>/, render + "</body>"
+    def okay_to_modify?(env, headers)
+      return false unless headers["Content-Type"] =~ CONTENT_TYPE_REGEX
+      return !match_path_filters?(env["rack-insight.path_filters"], env["REQUEST_PATH"])
+    end
 
-      response["Content-Length"] = full_body.bytesize.to_s
+    def match_path_filters?(path_filters, path)
+      to_regex(path_filters).find { |filter| path =~ filter }
+    end
 
-      response.body = [full_body]
+    def to_regex(filters)
+      (filters || []).map { |str| %r(^#{str}) }
     end
 
     def render

data/lib/rack/insight/version.rb

@@ -1,7 +1,7 @@
 module Rack
   module Insight
 
-  VERSION = '0.5.30'
+  VERSION = '0.6.2'
 
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-insight
 version: !ruby/object:Gem::Version
-  version: 0.5.30
+  version: 0.6.2
 platform: ruby
 authors:
 - Peter Boling
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-07 00:00:00.000000000 Z
+date: 2015-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -153,8 +153,9 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.6.3.1
-description: "Debugging toolbar for Rack applications implemented as middleware.\n
-  \   Based on logical-insight and rack-bug. "
+description: |-
+  Debugging toolbar for Rack applications implemented as middleware.
+      Based on logical-insight and rack-bug.
 email:
 - peter.boling@gmail.com
 executables: []
@@ -162,9 +163,9 @@ extensions: []
 extra_rdoc_files:
 - README.md
 - LICENSE
-- CHANGELOG
+- CHANGELOG.md
 files:
-- CHANGELOG
+- CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile
@@ -286,7 +287,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Debugging toolbar for Rack applications implemented as middleware.