rack-insight 0.5.24 → 0.5.25

data/CHANGELOG

@@ -1,5 +1,11 @@
 == HEAD
 
+== 0.5.25 / 2013-03-15
+
+  * Bug Fixes
+
+    * active_record_panel is fixed! [(kjg - Kevin Glowacz)](https://github.com/kjg)
+
 == 0.5.24 / 2013-01-01
 
   * Bug Fixes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-insight (0.5.23)
+    rack-insight (0.5.24)
       rack
       sqlite3 (>= 1.3.3)
       uuidtools (>= 2.1.2)
@@ -10,51 +10,51 @@ GEM
   remote: https://rubygems.org/
   specs:
     columnize (0.3.6)
-    debugger (1.2.0)
+    debugger (1.5.0)
       columnize (>= 0.3.1)
-      debugger-linecache (~> 1.1.1)
-      debugger-ruby_core_source (~> 1.1.3)
-    debugger-linecache (1.1.2)
-      debugger-ruby_core_source (>= 1.1.1)
-    debugger-ruby_core_source (1.1.3)
-    diff-lcs (1.1.3)
-    nokogiri (1.5.4)
-    rack (1.3.5)
-    rack-protection (1.1.4)
+      debugger-linecache (~> 1.2.0)
+      debugger-ruby_core_source (~> 1.2.0)
+    debugger-linecache (1.2.0)
+    debugger-ruby_core_source (1.2.0)
+    diff-lcs (1.2.1)
+    gem-release (0.5.2)
+    nokogiri (1.5.6)
+    rack (1.5.2)
+    rack-protection (1.5.0)
       rack
-    rack-test (0.6.1)
+    rack-test (0.6.2)
       rack (>= 1.0)
-    rake (0.9.2.2)
-    redcarpet (2.1.1)
-    reek (1.2.12)
+    rake (10.0.3)
+    redcarpet (2.2.2)
+    reek (1.2.13)
       ripper_ruby_parser (~> 0.0.7)
       ruby2ruby (~> 1.2.5)
       ruby_parser (~> 2.0)
       sexp_processor (~> 3.0)
     ripper_ruby_parser (0.0.8)
       sexp_processor (~> 3.0)
-    roodi (2.1.0)
-      ruby_parser
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.2)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.2)
+    roodi (2.2.0)
+      ruby_parser (~> 2.3.0)
+    rspec (2.13.0)
+      rspec-core (~> 2.13.0)
+      rspec-expectations (~> 2.13.0)
+      rspec-mocks (~> 2.13.0)
+    rspec-core (2.13.1)
+    rspec-expectations (2.13.0)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.13.0)
     ruby2ruby (1.2.5)
       ruby_parser (~> 2.0)
       sexp_processor (~> 3.0)
     ruby_parser (2.3.1)
       sexp_processor (~> 3.0)
     sexp_processor (3.2.0)
-    sinatra (1.3.1)
-      rack (~> 1.3, >= 1.3.4)
-      rack-protection (~> 1.1, >= 1.1.2)
-      tilt (~> 1.3, >= 1.3.3)
-    sqlite3 (1.3.6)
-    tilt (1.3.3)
+    sinatra (1.4.1)
+      rack (~> 1.5, >= 1.5.2)
+      rack-protection (~> 1.4)
+      tilt (~> 1.3, >= 1.3.4)
+    sqlite3 (1.3.7)
+    tilt (1.3.5)
     uuidtools (2.1.3)
     webrat (0.7.3)
       nokogiri (>= 1.2.0)
@@ -65,7 +65,8 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  debugger
+  debugger (>= 1.5.0)
+  gem-release (>= 0.5.2)
   rack-insight!
   rake
   redcarpet

data/README.md

@@ -1,23 +1,8 @@
 Rack::Insight [![Dependency Status](https://gemnasium.com/pboling/rack-insight.png)](https://gemnasium.com/pboling/rack-insight) [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/pboling/rack-insight) [![Build Status](https://secure.travis-ci.org/pboling/rack-insight.png?branch=master)](https://travis-ci.org/pboling/rack-insight) [![Endorse Me](http://api.coderwall.com/pboling/endorsecount.png)](http://coderwall.com/pboling)
 =============
 
-Rack::Insight began life as an fork of Logical::Insight by LRDesign.
-
-* I started a fork because:
-    * LogicalInsight was namespaced as "Insight"
-        * Causing namespace collisions everywhere I have an Insight model.  I had to re-namespace all the code.
-    * I also needed to build a few extension gems with additional panels, which didn't fully work in LI
-        * Added the Config class to allow for custom panel load paths
-          and many other extensions that don't work in the *use Middleware* declaration.
-
-It should be *even* easier to extend than LogicalInsight was, because extension gems can access the Config class
-and truly bolt-on cleanly.
 
-Having made really significant architectural changes, I'll be keeping Rack::Insight
-a separate project for the foreseeable future.
 
-* Forked From: [logical-insight](http://github.com/LRDesign/logical-insight)
-* Which Was Forked From: [rack-bug](http://github.com/brynary/rack-bug)
 
 Description
 -----------
@@ -41,7 +26,7 @@ Features
         * Log               (can configure which loggers to watch!)
         * Memory
         * SQL               (Failing specs, and I don't use it, someone please pull me a fix!)
-        * Active Record     (Failing specs, and I don't use it, someone please pull me a fix!)
+        * Active Record     (Thanks to [Kevin Glowacz](https://github.com/kjg) for the fix!)
     * Other bundled panels:
         * Sphinx (thanks to Oggy for updating this to the rack-insight panel API)
         * Redis
@@ -153,16 +138,17 @@ Specify the set of panels you want, in the order you want them to appear:
 
     ActionController::Dispatcher.middleware.use "Rack::Insight::App",
       :secret_key => "someverylongandveryhardtoguesspreferablyrandomstring",
-      :panel_files => %w[
+      :panel_files => %w(
         timer_panel
+        active_record_panel
         request_variables_panel
         redis_panel
         templates_panel
         cache_panel
         log_panel
-        memory_panel,
+        memory_panel
         sphinx_panel
-      ]
+      )
 
 By default panel files are looked up by prepending "rack/insight/panels/" and requiring them.
 Subclasses of Rack::Insight::Panel are loaded and added to the toolbar.  This makes
@@ -260,12 +246,63 @@ Authors
 -------
 
 - Maintained by [Peter Boling](mailto:peter.boling@gmail.com)
+  - Contributions from [Kevin Glowacz](https://github.com/kjg) (Fixed Active Record Panel), [Piotr Usewicz](https://github.com/pusewicz) (Use on instead of live), [Nate Greene](https://github.com/natejgreene) (javascript fix), [George Ogata](https://github.com/oggy) (Fixed Redis & Sphinx panels and added AJAX support to them), and [Alif Rachmawadi](https://github.com/subosito) (persistent toolbar position)
 - Based on LogicalInsight by Judson Lester
   - Contributions from Luke Melia, Joey Aghion, Tim Connor, and more
   - Which in turn was based on Rack::Bug by Bryan Helmkamp
 
+A History of Forking
+--------------------
+
+Rack::Insight began life as an fork of Logical::Insight by LRDesign.
+
+* I started a fork because:
+    * LogicalInsight was namespaced as "Insight"
+        * Causing namespace collisions everywhere I have an Insight model.  I had to re-namespace all the code.
+    * I also needed to build a few extension gems with additional panels, which didn't fully work in LI
+        * Added the Config class to allow for custom panel load paths
+          and many other extensions that don't work in the *use Middleware* declaration.
+
+It should be *even* easier to extend than LogicalInsight was, because extension gems can access the Config class
+and truly bolt-on cleanly.
+
+Having made really significant architectural changes, I'll be keeping Rack::Insight
+a separate project for the foreseeable future.
+
+* Forked From: [logical-insight](http://github.com/LRDesign/logical-insight)
+* Which Was Forked From: [rack-bug](http://github.com/brynary/rack-bug)
+
+## Contributing
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Added some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
+6. Create new Pull Request
+
+## Versioning
+
+This library aims to adhere to [Semantic Versioning 2.0.0][semver].
+Violations of this scheme should be reported as bugs. Specifically,
+if a minor or patch version is released that breaks backward
+compatibility, a new version should be immediately released that
+restores compatibility. Breaking changes to the public API will
+only be introduced with new major versions.
+
+As a result of this policy, you can (and should) specify a
+dependency on this gem using the [Pessimistic Version Constraint][pvc] with two digits of precision.
+
+For example:
+
+    spec.add_dependency 'rack-insight', '~> 0.5'
+
+[semver]: http://semver.org/
+[pvc]: http://docs.rubygems.org/read/chapter/16#page74
+
 Thanks
 ------
+
 Rack::Insight owes a lot to both LogicalInsight and Rack::Bug, as the basis projects.  There's a lot of smart
 in there.  Many thanks to Judson, and Bryan for building them.
 

data/lib/rack/insight/config.rb

@@ -12,13 +12,12 @@ module Rack::Insight
     @rails_log_copy = true
     @filtered_backtrace = true
     @panel_configs = {
-      :active_record => {:probes => {'ActiveRecord' => [:class, :allocate]}},
+      :active_record => {:probes => {'ActiveRecord::Base' => [:class, :allocate]}},
       :active_resource => {:probes => {'ActiveResource::Connection' => [:instance, :request]}},
       :cache => {:probes => { 'Memcached'     => [:instance, :decrement, :get, :increment, :set,
                                                                  :add, :replace, :delete, :prepend, :append],
                               'MemCache'      => [:instance, :decr, :get, :get_multi, :incr, :set, :add, :delete],
                               'Dalli::Client' => [:instance, :perform] } },
-      :active_record => {:probes => {'ActiveRecord' => [:class, :allocate]}},
 #      :log_panel => The log panel configures its probes in its initializer
       :sphinx => {:probes => {'Riddle::Client' => [:instance, :request]}},
       :sql => {:probes => Hash[%w{ PostgreSQLAdapter MysqlAdapter SQLiteAdapter

data/lib/rack/insight/public/__insight__/insight.js

@@ -75,44 +75,44 @@ jQuery(function($) {
         $(document).unbind('keydown.insight');
         $('.panel_content').hide();
       });
-    $('#rack-insight ul.panels li a').live('click', function() {
+    $('#rack-insight ul.panels li a').on('click', function() {
         $.insight.panel_id = this.className
         $.insight.switchCurrentPanel()
         $.insight.toggleCurrent()
         return false;
       });
-    $('#rack-insight_debug_window a.back').live('click',function() {
+    $('#rack-insight_debug_window a.back').on('click',function() {
         $(this).parent().hide();
         return false;
       });
-    $('#rack-insight a.remote_call').live('click',function() {
+    $('#rack-insight a.remote_call').on('click',function() {
         $('#rack-insight_debug_window').load(this.href, null, function() {
             $('#rack-insight_debug_window').show();
           })
         return false;
       });
-    $('#rack-insight a.reveal_backtrace').live('click',function() {
+    $('#rack-insight a.reveal_backtrace').on('click',function() {
         $(this).parents("tr").next().toggle();
         return false;
       });
-    $('#rack-insight a.reveal_response').live('click',function() {
+    $('#rack-insight a.reveal_response').on('click',function() {
         $(this).parents("tr").next().next().toggle();
         return false;
       });
-    $('#rack-insight a.insight_close').live('click',function() {
+    $('#rack-insight a.insight_close').on('click',function() {
         $(document).trigger('close.insight');
         return false;
       });
-    $('#request_id_menu').live('change', function(){
+    $('#request_id_menu').on('change', function(){
         $.insight.changeRequest($(this).val())
       });
-    $('#rack-insight_debug_button').live('click',function(){
+    $('#rack-insight_debug_button').on('click',function(){
         new_position = ($('#rack-insight').attr('class')== 'rack-insight_top') ? 'bottom' : 'top';
         document.createCookie('rack-insight_position', new_position);
         $('#rack-insight').removeClass('rack-insight_top rack-insight_bottom').addClass('rack-insight_' + new_position);
         return false;
       });
-    $('#rack-insight_disable_button').live('click',function(){
+    $('#rack-insight_disable_button').on('click',function(){
         document.insightDisable();
         return false;
       });

data/lib/rack/insight/version.rb

@@ -1,7 +1,7 @@
 module Rack
   module Insight
 
-  VERSION = '0.5.24'
+  VERSION = '0.5.25'
 
   end
 end

data/rack-insight.gemspec

@@ -34,5 +34,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec", ">= 2.11.0"
   s.add_development_dependency "sinatra"
   s.add_development_dependency "webrat"
-  s.add_development_dependency "debugger"
+  s.add_development_dependency "debugger", ">= 1.5.0"
+  s.add_development_dependency "gem-release", ">= 0.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-insight
 version: !ruby/object:Gem::Version
-  version: 0.5.24
+  version: 0.5.25
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-02 00:00:00.000000000 Z
+date: 2013-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -181,7 +181,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -189,7 +189,23 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
+- !ruby/object:Gem::Dependency
+  name: gem-release
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.2
 description: ! "Debugging toolbar for Rack applications implemented as\n    middleware.
   \ Based on logical-insight and rack-bug. "
 email:
@@ -357,7 +373,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Debugging toolbar for Rack applications implemented as middleware.