rack-insight 0.5.23 → 0.5.24

data/CHANGELOG

@@ -1,5 +1,13 @@
 == HEAD
 
+== 0.5.24 / 2013-01-01
+
+  * Bug Fixes
+
+    * (Issue #17) Fix 20x performance hit with default log level by changing default log level from `:debug` to `:silent` (Rack::Insight::Logging::VERBOSITY[:silent])
+
+    * Changed event logging in the instrumentation from `:high` to `:debug` level.
+
 == 0.5.23 / 2012-09-14
 
   * New Features
@@ -217,20 +225,20 @@
     * Can use LoggerPanel on ruby stdlib Logger in non-rails app (Tim Connor)
 
   * Bug fixes
-  
+
     * Fix profile, explain and select in the queries tab, fixes issue #22 (ebertech)
-    
+
   * Minor fixes
-  
+
     * Explicitly require 'digest/sha1' (Jérémy Lecour)
     * Eliminate unreachable code in params signature validation (Tim Connor)
 
   * Compatibilty
 
     * Make Redis panel compatible with latest redis-rb gem, without breaking older redis-rb versions (Luke Melia)
-  
+
   * Other
-  
+
     * Refactoring and code cleanup (Tim Connor)
     * Testing cleanup - better isolation of Rails vs. non-Rails in tests (Tim Connor)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-insight (0.5.19)
+    rack-insight (0.5.23)
       rack
       sqlite3 (>= 1.3.3)
       uuidtools (>= 2.1.2)
@@ -9,11 +9,15 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    archive-tar-minitar (0.5.2)
     columnize (0.3.6)
+    debugger (1.2.0)
+      columnize (>= 0.3.1)
+      debugger-linecache (~> 1.1.1)
+      debugger-ruby_core_source (~> 1.1.3)
+    debugger-linecache (1.1.2)
+      debugger-ruby_core_source (>= 1.1.1)
+    debugger-ruby_core_source (1.1.3)
     diff-lcs (1.1.3)
-    linecache19 (0.5.12)
-      ruby_core_source (>= 0.1.4)
     nokogiri (1.5.4)
     rack (1.3.5)
     rack-protection (1.1.4)
@@ -39,19 +43,9 @@ GEM
     rspec-expectations (2.11.2)
       diff-lcs (~> 1.1.3)
     rspec-mocks (2.11.2)
-    ruby-debug-base19 (0.11.25)
-      columnize (>= 0.3.1)
-      linecache19 (>= 0.5.11)
-      ruby_core_source (>= 0.1.4)
-    ruby-debug19 (0.11.6)
-      columnize (>= 0.3.1)
-      linecache19 (>= 0.5.11)
-      ruby-debug-base19 (>= 0.11.19)
     ruby2ruby (1.2.5)
       ruby_parser (~> 2.0)
       sexp_processor (~> 3.0)
-    ruby_core_source (0.1.5)
-      archive-tar-minitar (>= 0.5.2)
     ruby_parser (2.3.1)
       sexp_processor (~> 3.0)
     sexp_processor (3.2.0)
@@ -71,12 +65,12 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  debugger
   rack-insight!
   rake
   redcarpet
   reek (>= 1.2.8)
   roodi (>= 2.1.0)
   rspec (>= 2.11.0)
-  ruby-debug19
   sinatra
   webrat

data/README.md

@@ -1,4 +1,4 @@
-Rack::Insight
+Rack::Insight [![Dependency Status](https://gemnasium.com/pboling/rack-insight.png)](https://gemnasium.com/pboling/rack-insight) [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/pboling/rack-insight) [![Build Status](https://secure.travis-ci.org/pboling/rack-insight.png?branch=master)](https://travis-ci.org/pboling/rack-insight) [![Endorse Me](http://api.coderwall.com/pboling/endorsecount.png)](http://coderwall.com/pboling)
 =============
 
 Rack::Insight began life as an fork of Logical::Insight by LRDesign.
@@ -43,10 +43,10 @@ Features
         * SQL               (Failing specs, and I don't use it, someone please pull me a fix!)
         * Active Record     (Failing specs, and I don't use it, someone please pull me a fix!)
     * Other bundled panels:
+        * Sphinx (thanks to Oggy for updating this to the rack-insight panel API)
         * Redis
         * Speedtracer
-    * Retired panels - if needed they could come back quickly:
-        * Sphinx
+    * Panels under construction:
         * Mongo
     * The API for adding your own panels is simple and very powerful
         * Consistent interface to instrument application code
@@ -54,6 +54,13 @@ Features
         * Easy to add sub-applications for more detailed reports (c.f. SQLPanel)
         * Ask me (pboling) if you need help with this.
 
+Build Status
+---------------------------
+
+Travis-ci: [![Build Status](https://secure.travis-ci.org/pboling/rack-insight.png?branch=master)](https://travis-ci.org/pboling/rack-insight) - Please help if you have time!
+
+CodeClimate: [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/pboling/rack-insight)
+
 Rails quick start
 ---------------------------
 
@@ -153,7 +160,8 @@ Specify the set of panels you want, in the order you want them to appear:
         templates_panel
         cache_panel
         log_panel
-        memory_panel
+        memory_panel,
+        sphinx_panel
       ]
 
 By default panel files are looked up by prepending "rack/insight/panels/" and requiring them.
@@ -211,7 +219,7 @@ Restrict access using a password:
 
 #### custom file path for the request recording database ####
 
-Logical Rack::Insight uses SQLite to store data from requests, and outputs a database
+Rack::Insight uses SQLite to store data from requests, and outputs a database
 file in the root directory. If you need the file to be created at another
 location (i.e. Heroku), you can pass a custom file path.
 
@@ -241,7 +249,7 @@ Setup the probes for the magic panel in a `before_initialize` block in your appl
 Custom Panels
 -------------
 
-See Magic Panels above, remove teh is_magic declaration, and add your own methods.
+See Magic Panels above, remove the is_magic declaration, and add your own methods.
 Look at the panels bundled with this gem for pointers.  Here are some important methods to watch for:
 
 * initialize
@@ -259,7 +267,7 @@ Authors
 Thanks
 ------
 Rack::Insight owes a lot to both LogicalInsight and Rack::Bug, as the basis projects.  There's a lot of smart
-in there.  Many thanks to Evan, Judson, and Bryan for building them.
+in there.  Many thanks to Judson, and Bryan for building them.
 
 Inspiration for Rack::Bug is primarily from the Django debug toolbar.
 Additional ideas from Rails footnotes, Rack's ShowException middleware, Oink,
@@ -273,6 +281,8 @@ MIT. See LICENSE in this directory.
 Notes
 -----
 
+The ActiveRecord panel doesn't seem to work currently.  Probably something minor, but haven't had time to look into it.
+
 Legacy files: would like to re-include them, but they need work
 
     lib/rack/insight/views/panels/mongo.html.erb
@@ -280,9 +290,5 @@ Legacy files: would like to re-include them, but they need work
     lib/rack/insight/panels/mongo_panel/stats.rb
     lib/rack/insight/panels/mongo_panel.rb
 
-    lib/rack/insight/views/panels/sphinx.html.erb
-    lib/rack/insight/panels/sphinx_panel/stats.rb
-    lib/rack/insight/panels/sphinx_panel.rb
-
 This one is mostly just a curiosity
     lib/rack/insight/panels/speedtracer_panel/profiling.rb

data/lib/rack/insight/app.rb

@@ -1,7 +1,7 @@
 require 'rack'
 require "digest/sha1"
-require "rack/insight/config"
 require "rack/insight/logging"
+require "rack/insight/config"
 require "rack/insight/filtered_backtrace"
 require "rack/insight/options"
 require 'rack/insight/magic_insight'

data/lib/rack/insight/config.rb

@@ -8,7 +8,7 @@ module Rack::Insight
     @log_file = STDOUT
     @log_level = ::Logger::DEBUG
     @logger = nil
-    @verbosity = true
+    @verbosity = Rack::Insight::Logging::VERBOSITY[:silent]
     @rails_log_copy = true
     @filtered_backtrace = true
     @panel_configs = {
@@ -20,6 +20,7 @@ module Rack::Insight
                               'Dalli::Client' => [:instance, :perform] } },
       :active_record => {:probes => {'ActiveRecord' => [:class, :allocate]}},
 #      :log_panel => The log panel configures its probes in its initializer
+      :sphinx => {:probes => {'Riddle::Client' => [:instance, :request]}},
       :sql => {:probes => Hash[%w{ PostgreSQLAdapter MysqlAdapter SQLiteAdapter
                   Mysql2Adapter OracleEnhancedAdapter }.map do |adapter|
                     ["ActiveRecord::ConnectionAdapters::#{adapter}", [:instance, :execute]]
@@ -47,8 +48,8 @@ module Rack::Insight
       :log_level => @log_level,
       :rails_log_copy => @rails_log_copy, # Only has effect when logger is the Rack::Insight::Logger, or a logger behaving like it
       # Can set a specific verbosity: Rack::Insight::Logging::VERBOSITY[:debug]
-      :verbosity => @verbosity, # true is equivalent to relying soley on the log level of each logged message
-      :filtered_backtrace => @filtered_backtrace, # Full backtraces, or filtered ones?
+      :verbosity => @verbosity, # true is equivalent to relying solely on the log level of each logged message
+      :filtered_backtrace => @filtered_backtrace, # Full back-traces, or filtered ones?
       :panel_configs => @panel_configs, # Allow specific panels to have their own configurations, and make it extensible
       :silence_magic_insight_warnings => @silence_magic_insight_warnings, # Should Rack::Insight warn when the MagicInsight is used?
       :database => @database # a hash.  Keys :raise_encoding_errors, and :raise_decoding_errors are self explanatory

data/lib/rack/insight/instrumentation/instrument.rb

@@ -71,7 +71,7 @@ module Rack::Insight
       end
 
       def start_event(method_call, arguments)
-        if verbose(:high)
+        if verbose(:debug)
           logger.debug{ "Starting event: #{method_call.context} #{method_call.kind} #{method_call.method}" }
         end
 
@@ -82,7 +82,7 @@ module Rack::Insight
 
       def finish_event(method_call, arguments, start_time, result)
         timing = Timing.new(@start, start_time, Time.now)
-        if verbose(:high)
+        if verbose(:debug)
           logger.debug{ "Finishing event: #{method_call.context} #{method_call.kind} #{method_call.method}" }
         end
         collectors_for(method_call).each do |collector|

data/lib/rack/insight/panels/redis_panel.rb

@@ -1,40 +1,47 @@
 module Rack::Insight
-
   class RedisPanel < Panel
-    require "rack/insight/panels/redis_panel/redis_extension"
-
     require "rack/insight/panels/redis_panel/stats"
 
-    self.has_table = false
-
-    def self.record(redis_command_args, backtrace, &block)
-      return block.call unless Rack::Insight.enabled?
-
-      start_time = Time.now
-      result = block.call
-      total_time = Time.now - start_time
-      stats.record_call(total_time * 1_000, redis_command_args, backtrace)
-      return result
+    def initialize(app)
+      super
+
+      unless is_probing?
+        probe(self) do
+          if defined?(Redis::Client)
+            # Redis >= 3.0.0
+            instrument "Redis::Client" do
+              instance_probe :call
+            end
+          elsif defined?(Redis)
+            # Redis < 3.0.0
+            instrument "Redis" do
+              instance_probe :call_command
+            end
+          end
+        end
+      end
     end
 
-    def self.reset
-      Thread.current["rack-insight.redis"] = Stats.new
+    def request_start(env, start)
+      @stats = Stats.new
     end
 
-    def self.stats
-      Thread.current["rack-insight.redis"] ||= Stats.new
+    def request_finish(env, status, headers, body, timing)
+      store(env, @stats)
+      @stats = nil
     end
 
-    def heading
-      "Redis: %.2fms (#{self.class.stats.queries.size} calls)" % self.class.stats.time
+    def after_detect(method_call, timing, args, message)
+      @stats.record_call(timing.duration, args, method_call)
     end
 
-    def content
-      result = render_template "panels/redis", :stats => self.class.stats
-      self.class.reset
-      return result
+    def heading_for_request(number)
+      stats = retrieve(number).first
+      "Redis: %.2fms (#{stats.queries.size} calls)" % stats.time
     end
 
+    def content_for_request(number)
+      render_template "panels/redis", :stats => retrieve(number).first
+    end
   end
-
 end

data/lib/rack/insight/panels/redis_panel/stats.rb

@@ -8,10 +8,10 @@ module Rack::Insight
         attr_reader :time
         attr_reader :command
 
-        def initialize(time, command_args, backtrace)
+        def initialize(time, command_args, method_call)
           @time = time
           @command = command_args.inspect
-          @backtrace = backtrace
+          @backtrace = method_call.backtrace
         end
 
         def display_time
@@ -28,8 +28,8 @@ module Rack::Insight
         @time = 0.0
       end
 
-      def record_call(time, command_args, backtrace)
-        @queries << Query.new(time, command_args, backtrace)
+      def record_call(time, command_args, method_call)
+        @queries << Query.new(time, command_args, method_call)
         @calls += 1
         @time += time
       end

data/lib/rack/insight/panels/sphinx_panel.rb

@@ -1,39 +1,27 @@
 module Rack::Insight
-
   class SphinxPanel < Panel
-    require "rack/insight/panels/sphinx_panel/sphinx_extension"
     require "rack/insight/panels/sphinx_panel/stats"
 
-    self.has_table = false
-
-    def self.record(*sphinx_command_args, &block)
-      return block.call unless Rack::Insight.enabled?
-
-      start_time = Time.now
-      result = block.call
-      total_time = Time.now - start_time
-      stats.record_call(total_time * 1_000, sphinx_command_args)
-      return result
+    def request_start(env, start)
+      @stats = Stats.new
     end
 
-    def self.reset
-      Thread.current["rack-insight.sphinx"] = Stats.new
+    def request_finish(env, status, headers, body, timing)
+      store(env, @stats)
+      @stats = nil
     end
 
-    def self.stats
-      Thread.current["rack-insight.sphinx"] ||= Stats.new
+    def after_detect(method_call, timing, args, message)
+      @stats.record_call(timing.duration, args, method_call)
     end
 
-    def heading
-      "Sphinx: %.2fms (#{self.class.stats.queries.size} calls)" % self.class.stats.time
+    def heading_for_request(number)
+      stats = retrieve(number).first
+      "Sphinx: %.2fms (#{stats.queries.size} calls)" % stats.time
     end
 
-    def content
-      result = render_template "panels/sphinx", :stats => self.class.stats
-      self.class.reset
-      return result
+    def content_for_request(number)
+      render_template "panels/sphinx", :stats => retrieve(number).first
     end
-
   end
-
 end

data/lib/rack/insight/panels/sphinx_panel/stats.rb

@@ -3,16 +3,28 @@ module Rack::Insight
 
     class Stats
       class Query
+        include Rack::Insight::FilteredBacktrace
+
+        require 'riddle/client'
+        MatchModes = Riddle::Client::MatchModes.invert
+        RankModes = Riddle::Client::RankModes.invert
+        SortModes = Riddle::Client::SortModes.invert
+        AttributeTypes = Riddle::Client::AttributeTypes.invert
+        GroupFunctions = Riddle::Client::GroupFunctions.invert
+        FilterTypes = Riddle::Client::FilterTypes.invert
+
         attr_reader :time
         attr_reader :command
 
-        def initialize(time, *command_args)
+        def initialize(time, command_args, method_call)
+          riddle_command, messages = *command_args
           @time = time
-          if command_args.flatten.first == :search
-            @command = "search: " + decode_message(command_args.first.flatten.last).collect{|k,v| "#{k} => #{v}"}.join(", ")
+          if riddle_command == :search
+            @command = "search: " + decode_message(messages.first).inspect
           else
-            @command = command_args.flatten.first.to_s + ": No more info is available for this Sphinx request type"
+            @command = command_args.inspect + ": No more info is available for this Sphinx request type"
           end
+          @backtrace = method_call.backtrace
         end
 
         def display_time
@@ -23,43 +35,136 @@ module Rack::Insight
           @m = m.clone
           params = ActiveSupport::OrderedHash.new
 
+          # Mode, Limits
           params[:offset] = consume_int
           params[:limit] = consume_int
-          params[:match_mode] = consume_int
-          params[:rank_mode] = consume_int
-          params[:sort_mode] = consume_int
-          params[:sort_by] = consume_string
+          params[:match_mode] = MatchModes[consume_int]
+
+          # Ranking
+          params[:rank_mode] = RankModes[consume_int]
+          if params[:rank_mode] == :expr
+            params[:rank_expr] = consume_string
+          end
+
+          # Sort Mode
+          params[:sorting] = {
+            mode: SortModes[consume_int],
+            by: consume_string,
+          }
+
+          # Query
           params[:query] = consume_string
-          wl = consume_int
-          weights = []
-          wl.times do weights << consume_int end
-          params[:weights] = weights
 
+          # Weights
+          params[:weights] = (1..consume_int).map { consume_int }
+
+          # Index
           params[:index] = consume_string
 
-          consume_string
+          # ID Range
+          consume_int
+          params[:id_range] = consume_64int..consume_64int
+
+          # Filters
+          params[:filters] = (1..consume_int).map do
+            attribute = consume_string
+            type = FilterTypes[consume_int]
+            values =
+              case type
+              when :values
+                (1..consume_int).map { consume_64int }
+              when :range
+                consume_64int..consume_64int
+              when :float_range
+                consume_float..consume_float
+              end
+            exclude = consume_int
+            {attribute: attribute, values: values, exclude: exclude}
+          end
+
+          # Grouping
+          params[:group] = {
+            function: GroupFunctions[consume_int],
+            by: consume_string,
+            max_matches: consume_int,
+            clause: consume_string,
+            retry: {cutoff: consume_int, count: consume_int, delay: consume_int},
+            distinct: consume_string,
+          }
+
+          # Anchor Point
+          if consume_int == 0
+            params[:anchor] = nil
+          else
+            params[:anchor] = {
+              attributes: [consume_string, consume_string],
+              values: [consume_int, consume_int],
+            }
+          end
+
+          # Per Index Weights
+          per_index_weights = params[:per_index_weights] = {}
+          (1..consume_int).each do |key, value|
+            key = consume_string
+            value = consume_int
+            per_index_weights[key] = value
+          end
+
+          # Max Query Time
+          params[:max_query_time] = consume_int
+
+          # Per Field Weights
+          per_field_weights = params[:per_field_weights] = {}
+          (1..consume_int).each do |key, value|
+            key = consume_string
+            value = consume_int
+            per_field_weights[key] = value
+          end
+
+          params[:comments] = consume_string
+
+          return params if Riddle::Client::Versions[:search] < 0x116
+
+          # Overrides
+          overrides = params[:overrides] = {}
+          (1..consume_int).each do
+            key = consume_string
+            type = AttributeTypes[consume_int]
+            method =
+              case type
+              when :float
+                :consume_float
+              when :bigint
+                :consume_64int
+              else
+                :consume_int
+              end
+            values = (1..consume_int).map { send(method) }
+            overrides[key] = values
+          end
+
+          params[:select] = consume_string
+
+          @m.empty? or
+            params[:unknown] = @m
 
-          params[:id_range] = [consume_64int, consume_64int]
           params
         end
 
         def consume_int
-          i = @m.unpack("N").first
-          @m = @m.slice(4, @m.length - 4)
-          i
+          @m.slice!(0, 4).unpack("N").first
         end
 
         def consume_64int
-          i = @m.unpack("NN").first
-          @m = @m.slice(8, @m.length - 8)
-          i
+          @m.slice!(0, 8).unpack("NN").first
+        end
+
+        def consume_float
+          @m.slice!(0, 4).unpack('N').pack('L*').unpack('f').first
         end
 
         def consume_string
-          len = consume_int
-          s = @m.slice(0, len)
-          @m = @m.slice(len, @m.length - len)
-          s
+          @m.slice!(0, consume_int)
         end
       end
 
@@ -72,9 +177,8 @@ module Rack::Insight
         @time = 0.0
       end
 
-      def record_call(time, *command_args)
-
-        @queries << Query.new(time, command_args)
+      def record_call(time, command_args, method_call)
+        @queries << Query.new(time, command_args, method_call)
         @calls += 1
         @time += time
       end

data/lib/rack/insight/public/__insight__/jquery-1.3.2.js

@@ -1266,150 +1266,150 @@ jQuery.each({
 function num(elem, prop) {
 	return elem[0] && parseInt( jQuery.curCSS(elem[0], prop, true), 10 ) || 0;
 }
-var expando = "jQuery" + now(), uuid = 0, windowData = {};
-
-jQuery.extend({
-	cache: {},
-
-	data: function( elem, name, data ) {
-		elem = elem == window ?
-			windowData :
-			elem;
-
-		var id = elem[ expando ];
-
-		// Compute a unique ID for the element
-		if ( !id )
-			id = elem[ expando ] = ++uuid;
-
-		// Only generate the data cache if we're
-		// trying to access or manipulate it
-		if ( name && !jQuery.cache[ id ] )
-			jQuery.cache[ id ] = {};
-
-		// Prevent overriding the named cache with undefined values
-		if ( data !== undefined )
-			jQuery.cache[ id ][ name ] = data;
-
-		// Return the named cache data, or the ID for the element
-		return name ?
-			jQuery.cache[ id ][ name ] :
-			id;
-	},
-
-	removeData: function( elem, name ) {
-		elem = elem == window ?
-			windowData :
-			elem;
-
-		var id = elem[ expando ];
-
-		// If we want to remove a specific section of the element's data
-		if ( name ) {
-			if ( jQuery.cache[ id ] ) {
-				// Remove the section of cache data
-				delete jQuery.cache[ id ][ name ];
-
-				// If we've removed all the data, remove the element's cache
-				name = "";
-
-				for ( name in jQuery.cache[ id ] )
-					break;
-
-				if ( !name )
-					jQuery.removeData( elem );
-			}
-
-		// Otherwise, we want to remove all of the element's data
-		} else {
-			// Clean up the element expando
-			try {
-				delete elem[ expando ];
-			} catch(e){
-				// IE has trouble directly removing the expando
-				// but it's ok with using removeAttribute
-				if ( elem.removeAttribute )
-					elem.removeAttribute( expando );
-			}
-
-			// Completely remove the data cache
-			delete jQuery.cache[ id ];
-		}
-	},
-	queue: function( elem, type, data ) {
-		if ( elem ){
-	
-			type = (type || "fx") + "queue";
-	
-			var q = jQuery.data( elem, type );
-	
-			if ( !q || jQuery.isArray(data) )
-				q = jQuery.data( elem, type, jQuery.makeArray(data) );
-			else if( data )
-				q.push( data );
-	
-		}
-		return q;
-	},
-
-	dequeue: function( elem, type ){
-		var queue = jQuery.queue( elem, type ),
-			fn = queue.shift();
-		
-		if( !type || type === "fx" )
-			fn = queue[0];
-			
-		if( fn !== undefined )
-			fn.call(elem);
-	}
-});
-
-jQuery.fn.extend({
-	data: function( key, value ){
-		var parts = key.split(".");
-		parts[1] = parts[1] ? "." + parts[1] : "";
-
-		if ( value === undefined ) {
-			var data = this.triggerHandler("getData" + parts[1] + "!", [parts[0]]);
-
-			if ( data === undefined && this.length )
-				data = jQuery.data( this[0], key );
-
-			return data === undefined && parts[1] ?
-				this.data( parts[0] ) :
-				data;
-		} else
-			return this.trigger("setData" + parts[1] + "!", [parts[0], value]).each(function(){
-				jQuery.data( this, key, value );
-			});
-	},
-
-	removeData: function( key ){
-		return this.each(function(){
-			jQuery.removeData( this, key );
-		});
-	},
-	queue: function(type, data){
-		if ( typeof type !== "string" ) {
-			data = type;
-			type = "fx";
-		}
-
-		if ( data === undefined )
-			return jQuery.queue( this[0], type );
-
-		return this.each(function(){
-			var queue = jQuery.queue( this, type, data );
-			
-			 if( type == "fx" && queue.length == 1 )
-				queue[0].call(this);
-		});
-	},
-	dequeue: function(type){
-		return this.each(function(){
-			jQuery.dequeue( this, type );
-		});
-	}
+var expando = "jQuery" + now(), uuid = 0, windowData = {};
+
+jQuery.extend({
+	cache: {},
+
+	data: function( elem, name, data ) {
+		elem = elem == window ?
+			windowData :
+			elem;
+
+		var id = elem[ expando ];
+
+		// Compute a unique ID for the element
+		if ( !id )
+			id = elem[ expando ] = ++uuid;
+
+		// Only generate the data cache if we're
+		// trying to access or manipulate it
+		if ( name && !jQuery.cache[ id ] )
+			jQuery.cache[ id ] = {};
+
+		// Prevent overriding the named cache with undefined values
+		if ( data !== undefined )
+			jQuery.cache[ id ][ name ] = data;
+
+		// Return the named cache data, or the ID for the element
+		return name ?
+			jQuery.cache[ id ][ name ] :
+			id;
+	},
+
+	removeData: function( elem, name ) {
+		elem = elem == window ?
+			windowData :
+			elem;
+
+		var id = elem[ expando ];
+
+		// If we want to remove a specific section of the element's data
+		if ( name ) {
+			if ( jQuery.cache[ id ] ) {
+				// Remove the section of cache data
+				delete jQuery.cache[ id ][ name ];
+
+				// If we've removed all the data, remove the element's cache
+				name = "";
+
+				for ( name in jQuery.cache[ id ] )
+					break;
+
+				if ( !name )
+					jQuery.removeData( elem );
+			}
+
+		// Otherwise, we want to remove all of the element's data
+		} else {
+			// Clean up the element expando
+			try {
+				delete elem[ expando ];
+			} catch(e){
+				// IE has trouble directly removing the expando
+				// but it's ok with using removeAttribute
+				if ( elem.removeAttribute )
+					elem.removeAttribute( expando );
+			}
+
+			// Completely remove the data cache
+			delete jQuery.cache[ id ];
+		}
+	},
+	queue: function( elem, type, data ) {
+		if ( elem ){
+	
+			type = (type || "fx") + "queue";
+	
+			var q = jQuery.data( elem, type );
+	
+			if ( !q || jQuery.isArray(data) )
+				q = jQuery.data( elem, type, jQuery.makeArray(data) );
+			else if( data )
+				q.push( data );
+	
+		}
+		return q;
+	},
+
+	dequeue: function( elem, type ){
+		var queue = jQuery.queue( elem, type ),
+			fn = queue.shift();
+		
+		if( !type || type === "fx" )
+			fn = queue[0];
+			
+		if( fn !== undefined )
+			fn.call(elem);
+	}
+});
+
+jQuery.fn.extend({
+	data: function( key, value ){
+		var parts = key.split(".");
+		parts[1] = parts[1] ? "." + parts[1] : "";
+
+		if ( value === undefined ) {
+			var data = this.triggerHandler("getData" + parts[1] + "!", [parts[0]]);
+
+			if ( data === undefined && this.length )
+				data = jQuery.data( this[0], key );
+
+			return data === undefined && parts[1] ?
+				this.data( parts[0] ) :
+				data;
+		} else
+			return this.trigger("setData" + parts[1] + "!", [parts[0], value]).each(function(){
+				jQuery.data( this, key, value );
+			});
+	},
+
+	removeData: function( key ){
+		return this.each(function(){
+			jQuery.removeData( this, key );
+		});
+	},
+	queue: function(type, data){
+		if ( typeof type !== "string" ) {
+			data = type;
+			type = "fx";
+		}
+
+		if ( data === undefined )
+			return jQuery.queue( this[0], type );
+
+		return this.each(function(){
+			var queue = jQuery.queue( this, type, data );
+			
+			 if( type == "fx" && queue.length == 1 )
+				queue[0].call(this);
+		});
+	},
+	dequeue: function(type){
+		return this.each(function(){
+			jQuery.dequeue( this, type );
+		});
+	}
 });/*!
  * Sizzle CSS Selector Engine - v0.9.3
  *  Copyright 2009, The Dojo Foundation

data/lib/rack/insight/version.rb

@@ -1,7 +1,7 @@
 module Rack
   module Insight
 
-  VERSION = '0.5.23'
+  VERSION = '0.5.24'
 
   end
 end

data/lib/rack/insight/views/panels/sphinx.html.erb

@@ -16,6 +16,7 @@
       <tr>
         <th>Time&nbsp;(ms)</th>
         <th>Command</th>
+        <th class="backtrace"></th>
       </tr>
     </thead>
     <tbody>
@@ -24,7 +25,20 @@
         <tr class="<%= i % 2 == 0 ? "even" : "odd" %>">
           <td><%= query.display_time %></td>
           <td><%= query.command %></td>
+          <td><%= "<a href='#' class='reveal_backtrace'>Show Backtrace</a>" if query.has_backtrace? %></td>
         </tr>
+        <% if query.has_backtrace? %>
+          <tr style="display:none">
+            <td></td>
+            <td colspan="2">
+              <ul>
+                <% query.filtered_backtrace.each do |line| %>
+                  <li><%=h line %></li>
+                <% end %>
+              </ul>
+            </td>
+          </tr>
+        <% end %>
         <% i += 1 %>
       <% end %>
     </tbody>

data/lib/rack/insight/views/toolbar.html.erb

@@ -11,7 +11,7 @@
   @import url(/__insight__/insight.css);
 </style>
 <script>
-  $(function($) {
+  jQuery(function($) {
     $.insight.request_id = <%= request_id %>
     if(document.readCookie('rack-insight_position')) {
       $('#rack-insight').removeClass('rack-insight_top rack-insight_bottom')

data/rack-insight.gemspec

@@ -34,7 +34,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec", ">= 2.11.0"
   s.add_development_dependency "sinatra"
   s.add_development_dependency "webrat"
-  s.add_development_dependency "ruby-debug19"
-
-
+  s.add_development_dependency "debugger"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-insight
 version: !ruby/object:Gem::Version
-  version: 0.5.23
+  version: 0.5.24
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-14 00:00:00.000000000 Z
+date: 2013-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -175,7 +175,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby-debug19
+  name: debugger
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -251,7 +251,6 @@ files:
 - lib/rack/insight/panels/mongo_panel/stats.rb
 - lib/rack/insight/panels/rails_info_panel.rb
 - lib/rack/insight/panels/redis_panel.rb
-- lib/rack/insight/panels/redis_panel/redis_extension.rb
 - lib/rack/insight/panels/redis_panel/stats.rb
 - lib/rack/insight/panels/request_variables_panel.rb
 - lib/rack/insight/panels/speedtracer_panel.rb
@@ -387,4 +386,3 @@ test_files:
 - spec/rcov.opts
 - spec/spec.opts
 - spec/spec_helper.rb
-has_rdoc: 

data/lib/rack/insight/panels/redis_panel/redis_extension.rb

@@ -1,25 +0,0 @@
-if defined?(Redis)
-  Redis.class_eval do
-    if Redis.methods.include?('call_command') # older versions of redis-rb
-      def call_command_with_insight(*argv)
-        Rack::Insight::RedisPanel.record(argv, Kernel.caller) do
-          call_command_without_insight(*argv)
-        end
-      end
-
-      alias_method_chain :call_command, :insight
-
-    elsif defined?(Redis::Client) # newer versions of redis-rb
-
-      Redis::Client.class_eval do
-        def call_with_insight(command, &block)
-          Rack::Insight::RedisPanel.record(command, Kernel.caller) do
-            call_without_insight(command, &block)
-          end
-        end
-      end
-
-      Redis::Client.alias_method_chain :call, :insight
-    end
-  end
-end