rack-insight 0.5.16 → 0.5.17

data/CHANGELOG

@@ -1,10 +1,36 @@
-== 0.5.16 / 2012-09-11
+== HEAD
+
+== 0.5.17 / 2012-09-13 - Peter Boling
+
+  * New Features
+
+    * MagicInsight!  WARNING: Magic is dangerous.
+
+      * MagicInsight is a new mixin that can be used by any 'stat' type class built for Rack::Bug / LogicalInsight / Rack::Insight.
+        Just include Rack::Insight::MagicInsight in your stat class and then to render call:
+
+            render_template 'magic_panel', :magic_insights => your_stat_object, :name => 'panel name'
+
+        Read the source for Rack::Insight::MagicInsight and heed the warnings.
+        MagicInsight is used internally by Rack::Insight for magic panels and the templates panel.
+
+  * Bug Fixes
+
+    * Fixed the hardly working TemplatesPanel (Issue 1)
+    * Correct logging/debug statements
+    * Better tracking of which panels are probing
+
+  * Other
+
+    * TemplatesPanel is now more aligned with the Rack::Insight Panel API.
+
+== 0.5.16 / 2012-09-11 - Peter Boling
 
   * Other
 
     * Improved handling of no content for a panel.
 
-== 0.5.14-15 / 2012-09-11
+== 0.5.14-15 / 2012-09-11 - Peter Boling
 
   * New Features
 
@@ -15,7 +41,7 @@
     * Auto-magical table creation (skipped with self.has_table = false in a Panel class definition)
     * Under construction, or blank, panels have more scaffolding
 
-== 0.5.13 / 2012-09-10
+== 0.5.13 / 2012-09-10 - Peter Boling
 
   * Bug Fixes
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-insight (0.5.14)
+    rack-insight (0.5.16)
       rack
       sqlite3 (>= 1.3.3)
       uuidtools (>= 2.1.2)

data/lib/rack/insight/app.rb

@@ -4,6 +4,8 @@ require "rack/insight/config"
 require "rack/insight/logging"
 require "rack/insight/filtered_backtrace"
 require "rack/insight/options"
+require 'rack/insight/magic_insight'
+require 'rack/insight/default_invocation'
 require "rack/insight/panel"
 require "rack/insight/panel_app"
 require "rack/insight/params_signature"

data/lib/rack/insight/config.rb

@@ -1,7 +1,8 @@
 module Rack::Insight
   class Config
     class << self
-      attr_reader :config, :verbosity, :log_file, :log_level, :rails_log_copy, :filtered_backtrace
+      attr_reader :config, :verbosity, :log_file, :log_level, :rails_log_copy,
+                  :filtered_backtrace, :panel_configs, :silence_magic_insight_warnings
     end
     @log_file = STDOUT
     @log_level = ::Logger::DEBUG
@@ -24,6 +25,7 @@ module Rack::Insight
                   end ] },
       :templates => {:probes => {'ActionView::Template' => [:instance, :render]}}
     }
+    @silence_magic_insight_warnings = false
 
     DEFAULTS = {
       # You can augment or replace the default set of panel load paths.
@@ -42,7 +44,8 @@ module Rack::Insight
       # Can set a specific verbosity: Rack::Insight::Logging::VERBOSITY[:debug]
       :verbosity => @verbosity, # true is equivalent to relying soley on the log level of each logged message
       :filtered_backtrace => @filtered_backtrace, # Full backtraces, or filtered ones?
-      :panel_configs => @panel_configs # Allow specific panels to have their own configurations, and make it extensible
+      :panel_configs => @panel_configs, # Allow specific panels to have their own configurations, and make it extensible
+      :silence_magic_insight_warnings => @silence_magic_insight_warnings # Should Rack::Insight warn when the MagicInsight is used?
     }
 
     @config ||= DEFAULTS
@@ -54,6 +57,7 @@ module Rack::Insight
       @log_file = config[:log_file]
       @verbosity = config[:verbosity]
       @filtered_backtrace = config[:filtered_backtrace]
+      @silence_magic_insight_warnings = config[:silence_magic_insight_warnings]
 
       config[:panel_configs].each do |panel_name_sym, config|
         set_panel_config(panel_name_sym, config)

data/lib/rack/insight/default_invocation.rb

@@ -0,0 +1,22 @@
+# For Magic Panels
+module Rack::Insight
+  class DefaultInvocation < Struct.new :method, :time, :arguments, :result, :backtrace
+    attr_accessor :method, :time, :arguments, :result, :backtrace
+
+    include Rack::Insight::FilteredBacktrace
+    include Rack::Insight::MagicInsight
+
+    def initialize(*args)
+      @method = args[0]
+      @time = [args[1].duration, args[1].delta_t]
+      @arguments = args[2]
+      @result = args[3]
+      @backtrace = args[4]
+    end
+
+    def human_time
+      "%.2fms" % (self.time * 1_000)
+    end
+
+  end
+end

data/lib/rack/insight/instrumentation/client.rb

@@ -2,7 +2,7 @@ require 'rack/insight/instrumentation/package-definition'
 module Rack::Insight::Instrumentation
   module Client
     def probe(collector, &block)
-      self.class.is_probed = true
+      collector.class.is_probing = true
       ::Rack::Insight::Instrumentation::PackageDefinition::probe(collector, &block)
     end
 

data/lib/rack/insight/magic_insight.rb

@@ -0,0 +1,114 @@
+# See the WARNING constant defined below for explanation
+module Rack::Insight
+  module MagicInsight
+
+    # A modicum of sanity
+    SAFETY_REGEX_FILTER = (/(^_)|[=\?!~<>]|save|record|persist|delete|destroy|add|remove|child|parent/).freeze
+
+    WARNING = [
+      "  # PROCEED CAREFULLY!",
+      "  #",
+      "  # Regarding classes which include this module:",
+      "  #",
+      "  # 1. Classes should be built specifically to be rendered by rack-insight,",
+      "  #    and not have destructive methods.",
+      "  # 2. ALL instance methods on the class (generally not from ancestors) will be called,",
+      "  #    so if any are destructive you will cry.",
+      "  # 3. Define ALL: Any instance methods that get past the safety regex filter.",
+      "  # 4. Define safety regex filter: Rack::Insight::MagicInsight::SAFETY_REGEX_FILTER is",
+      "  #",
+      "  #    #{SAFETY_REGEX_FILTER.inspect}",
+      "  #",
+      "  # 5. To reiterate: all methods that do not match the above will be called.",
+      "  #",
+      "  # Classes that desire to be renderable by the magic_panel templates must:",
+      "  #",
+      "  #    include Rack::Insight::MagicInsight.",
+      "  #",
+      "  # 6. This gives explicit approval for rack-insight to call all the instance methods on your class,",
+      "  #    including the kill_server method (if you have one)."
+    ].freeze
+
+    # Regex explanation:
+    #   Rack::Insight - We want to keep methods that come from Rack::Insight included modules
+    #   #<Class: - An ancestor matching this is probably from a class definition like this:
+    #               class FooStats < Struct.new :foo, :bar
+    #              We need to keep :foo and :bar from the anonymous Struct ancestor
+    ANCESTORS_FILTER = /^Rack::Insight|#<Class:/.freeze
+
+    IDIOMS = %w( backtrace time duration timing )
+
+    def self.included(base)
+      # Make sure people want to eat their lunch before we serve it to them.
+      # Allows Rack::Insight namespaced classes to use MagicInsight without warnings.
+      if Rack::Insight::Config.config[:silence_magic_insight_warnings] || base.to_s =~ /^Rack::Insight/
+        # crickets...
+      else
+        warn "Rack::Insight::MagicInsight has been included in #{base}.\n#{WARNING.join("\n")}"
+        raise 'Checking for dupes impossible.' if base.instance_methods.include?(:dirty_ancestors)
+      end
+    end
+
+    def _dirty_ancestors
+      self.class.ancestors[1..-1]
+    end
+
+    def _filtered_ancestors
+      _dirty_ancestors.select {|c| !(c.to_s =~ ANCESTORS_FILTER)}
+    end
+
+    def _dirty_methods
+      self.class.instance_methods - (_filtered_ancestors.map &:instance_methods).flatten
+    end
+
+    def _filtered_methods
+      _dirty_methods.select {|x| !(x =~ Rack::Insight::MagicInsight::SAFETY_REGEX_FILTER)}.sort
+    end
+
+    def _sorted_methods
+      _filtered_methods.sort {|a,b| a.to_s.length <=> b.to_s.length }
+    end
+
+    # If there are two methods matching an idiom, then we only want to render one of the two.
+    # If there are more than two, then make no assumptions
+    def _idiomatic_methods
+      IDIOMS.select {|idiom| _sorted_methods.select { |meth| meth.to_s =~ /#{idiom}/ }.length == 2 }
+    end
+
+    def _has_idioms?
+      !_idiomatic_methods.empty?
+    end
+
+    def _idiomatic_method(method)
+      if self._has_idioms? && method = self._idiomatic_methods.select {|idiom| method.to_s =~ /#{idiom}/}.first
+        method
+      else
+        false
+      end
+    end
+
+    def _my_children
+      "#{!children.empty? ? " (#{children.length} children)" : ''}" if self.respond_to?(:children)
+    end
+
+    # called by the templates
+    def _magic_insight_methods
+      # We want to keep the longer of the methods by num chars in the method name, because these are the ones meant for
+      # humans to see (e.g. human_time, filtered_backtrace, display_time)
+      sorted = _sorted_methods
+      idiomatic = _idiomatic_methods
+      # So we delete the shorter of the two
+      idiomatic.each do |idiom|
+        sorted.each_with_index do |meth, index|
+          # first one found will be the shortest, so delete and move to next idiom
+          if meth.to_s =~ /#{idiom}/
+            sorted.delete_at(index)
+            break # to idiomatic loop
+          end
+        end
+      end
+      sorted
+    end
+
+  end
+end

data/lib/rack/insight/panel.rb

@@ -20,8 +20,8 @@ module Rack::Insight
 
       include Rack::Insight::Logging
 
-      attr_accessor :template_root, :is_probed, :has_table, :is_magic
-      @is_probed = false  # Once a panel is probed this should be set to true
+      attr_accessor :template_root, :is_probing, :has_table, :is_magic
+      @is_probing = false  # Once a panel is probed this should be set to true
       @has_table = true   # default to true.  Panels without tables override with self.has_table = false
       @is_magic = false   # check this to wrap any functionality targeted at magic panels.
 
@@ -37,7 +37,7 @@ module Rack::Insight
 
       def from_file(rel_path)
         old_rel, Thread::current['rack-panel_file'] = Thread::current['rack-panel_file'], rel_path
-        load_paths_to_check = Rack::Insight::Config.config[:panel_load_paths].length
+        num_load_paths_to_check = Rack::Insight::Config.config[:panel_load_paths].length
         Rack::Insight::Config.config[:panel_load_paths].each_with_index do |load_path, index|
           begin
             require File::join(load_path, rel_path)
@@ -45,8 +45,10 @@ module Rack::Insight
           rescue LoadError => e
             # TODO: If probes are defined for this panel, instantiate a magic panel
             # if self.has_custom_probes?
-            if (index + 1) == load_paths_to_check # You have failed me for the last time!
-              warn "Rack::Insight #{e.class}: Unable to find panel specified as '#{rel_path}'.  Looked in the following :panel_load_paths: #{Rack::Insight::Config.config[:panel_load_paths].inspect}."
+            if !verbose(:high) && (index + 1) == num_load_paths_to_check # You have failed me for the last time!
+              warn "Rack::Insight #{e.class} while attempting to load '#{rel_path}' from :panel_load_paths #{Rack::Insight::Config.config[:panel_load_paths].inspect}."
+            elsif verbose(:high)
+              warn "Rack::Insight #{e.class} #{e.message} while attempting to load '#{rel_path}' from :panel_load_paths #{Rack::Insight::Config.config[:panel_load_paths].inspect} (just checked: #{load_path})."
             end
           end
         end
@@ -143,7 +145,14 @@ module Rack::Insight
       if !has_table?
         table_setup(self.name)
       end
-      #puts "Initalization Complete for #{panel_name}\n1. #{self.is_magic?} && 2. #{self.has_table?} && 3. #{self.is_probed?} 4. #{self.has_custom_probes?}"
+    end
+
+    #def inspect
+    #  "M:#{self.bool_prop(:is_magic?)} T:#{self.bool_prop(:has_table?)} P:#{self.bool_prop(:is_probing?)} C:#{self.bool_prop(:has_custom_probes?)} Name: #{name}"
+    #end
+
+    def bool_prop(prop)
+      self.send(prop) ? 'Y' : 'N'
     end
 
     def call(env)
@@ -178,12 +187,11 @@ module Rack::Insight
       true
     end
 
-    def is_probed?
-      !!self.class.is_probed
+    def is_probing?
+      !!self.class.is_probing
     end
 
     def has_custom_probes?(panel_name = self.underscored_name.to_sym)
-      #puts "Rack::Insight::Config.config[:panel_configs][#{panel_name.inspect}]: #{Rack::Insight::Config.config[:panel_configs][panel_name].inspect}"
       Rack::Insight::Config.config[:panel_configs][panel_name].respond_to?(:[]) &&
         !Rack::Insight::Config.config[:panel_configs][panel_name][:probes].nil?
     end
@@ -206,6 +214,7 @@ module Rack::Insight
         if word == 'Panel'
           word = words[-2] # Panel class is Panel... and this won't do.
         end
+        # This bit from rails probably isn't needed here, and wouldn't work anyways.
         #word.gsub!(/(?:([A-Za-z\d])|^)(#{inflections.acronym_regex})(?=\b|[^a-z])/) { "#{$1}#{$1 && '_'}#{$2.downcase}" }
         word.gsub!(/Panel$/,'')
         word.gsub!(/([A-Z\d]+)([A-Z][a-z])/,'\1_\2')
@@ -239,13 +248,13 @@ module Rack::Insight
       if !self.has_table?
         logger.info("#{self.class} is being used without a table") if verbose(:med)
         content
-      elsif self.is_probed?
+      elsif self.is_probing? # Checking probed because we only get here when the subclass panel hasn't overridden this method
         invocations = retrieve(number)
-        if invocations.length > 0 && invocations.first.is_a?(Rack::Insight::Panel::DefaultInvocation)
-          logger.info("Rack::Insight is using magic content for #{self.class}, which is probed")# if verbose(:med)
-          render_template 'default_invocation', :invocations => invocations, :name => self.camelized_name
+        if invocations.length > 0
+          logger.info("Rack::Insight is using #{self.is_magic? ? 'magic' : 'default'} content for #{self.class}, which is probed")# if verbose(:med)
+          render_template 'magic_panel', :magic_insights => invocations, :name => self.camelized_name
         else
-          logger.info("Rack::Insight has no data for magic content for #{self.class}, which is probed")# if verbose(:med)
+          logger.info("Rack::Insight has no data for #{self.is_magic? ? 'magic' : 'default'} content for #{self.class}, which is probed")
           render_template 'no_data', :name => self.camelized_name
         end
       else
@@ -266,9 +275,8 @@ module Rack::Insight
     # Override in subclasses.
     # This is to make magic classes work.
     def after_detect(method_call, timing, args, result)
-      #puts "Default After Detect for #{self.underscored_name}: 1. #{self.is_magic?} && 2. #{self.has_table?} && 3. #{self.is_probed?}"
-      if self.is_magic? && self.has_table? && self.is_probed?
-        store(@env, DefaultInvocation.new(method_call.method.to_s, timing, args, result, method_call.backtrace[2..-1]))
+      if self.is_magic? && self.has_table? && self.is_probing?
+        store(@env, Rack::Insight::DefaultInvocation.new(method_call.method.to_s, timing, args, result, method_call.backtrace[2..-1]))
       end
     end
 
@@ -281,26 +289,6 @@ module Rack::Insight
     def render(template)
     end
 
-    # For Magic Panels
-    class DefaultInvocation < Struct.new :method, :time, :arguments, :result, :backtrace
-      attr_accessor :method, :time, :arguments, :result, :backtrace
-
-      include Rack::Insight::FilteredBacktrace
-
-      def initialize(*args)
-        @method = args[0]
-        @time = [args[1].duration, args[1].delta_t]
-        @arguments = args[2]
-        @result = args[3]
-        @backtrace = args[4]
-      end
-
-      def human_time
-        "%.2fms" % (self.time * 1_000)
-      end
-
-    end
-
   end
 
 end

data/lib/rack/insight/panels/log_panel.rb

@@ -26,7 +26,7 @@ module Rack::Insight
       # Call super before setting up probes in case there are any custom probes configured
       super # will setup custom probes
 
-      unless is_probed?
+      unless is_probing?
         probe(self) do
           # Trying to be smart...
           if defined?(ActiveSupport)

data/lib/rack/insight/panels/templates_panel.rb

@@ -1,45 +1,49 @@
 module Rack::Insight
-
   class TemplatesPanel < Panel
-    require "rack/insight/panels/templates_panel/rendering"
-
-    def initialize(app)
-      super
-
-      @current = nil
-    end
-
+    require "rack/insight/panels/templates_panel/stats"
 
     def request_start(env, start)
-      @current = Rendering.new("root")
+      @stats = Rack::Insight::TemplatesPanel::Stats.new("root")
     end
 
     def request_finish(env, status, headers, body, timing)
-      store(env, @current)
-      @current = nil
+      @stats.finish!
+      store(env, @stats)
+      @stats = nil
     end
 
     def before_detect(method_call, args)
       template_name = method_call.object.virtual_path
-
       rendering = Rendering.new(template_name)
-      @current.add(rendering)
-      @current = rendering
+      @stats.begin_record!(rendering)
     end
 
     def after_detect(method_call, timing, args, result)
-      @current.timing = timing
-      @current = @current.parent
+      @stats.finish_record!(timing.duration)
     end
 
     def heading_for_request(number)
-      "Templates: %.2fms" % (retrieve(number).inject(0.0){|memo, rendering| memo + rendering.duration})
+      "Templates: #{heading_time(number)}"
+    end
+
+    def heading_time(number)
+      stat = retrieve(number).first
+      if stat.respond_to?(:root)
+        if stat.root.respond_to?(:_human_time)
+          stat.root._human_time
+        end
+      end
     end
 
     def content_for_request(number)
-      render_template "panels/templates", :root_rendering => retrieve(number).first
+      stat = retrieve(number).first
+      rendering_root = stat.root if stat.respond_to?(:root)
+      if rendering_root
+        render_template 'magic_panel', :magic_insights => rendering_root.children, :name => "Templates: #{(rendering_root._human_time)}"
+      else
+        render_template 'no_data', :name => self.camelized_name
+      end
     end
 
   end
-
 end

data/lib/rack/insight/panels/templates_panel/rendering.rb

@@ -2,79 +2,69 @@ module Rack::Insight
   class TemplatesPanel
 
     class Rendering
-      attr_accessor :name
+
+      include Rack::Insight::MagicInsight
+
+      attr_accessor :template
+      attr_accessor :partial
       attr_accessor :parent
-      attr_accessor :timing
       attr_reader :children
 
-      def initialize(name, timing = nil)
-        @name = name
-        @timing = timing
-        @children = []
-      end
+      # '_' prevents MagicInsight template from calling the method
+      # Time tracking
+      attr_accessor :_time, :_exclusive_time, :_child_time
 
-      def start_time
-        @timing.start
-      end
-      alias_method :time, :start_time
-
-      def end_time
-        @timing.end
+      def initialize(template)
+        @template = template.to_s
+        @partial = template.partial ? 'yes' : 'no' if template.respond_to?(:partial)
+        @_time = 0
+        @_exclusive_time = 0
+        @_child_time = 0
+        @children = []
+        @parent = nil
       end
 
-      def add(rendering)
+      # called from Stats#begin_record
+      def add!(rendering)
         @children << rendering
         rendering.parent = self
       end
 
-      def delete(rendering)
-        @children.delete(rendering)
+      # LOL what?
+      #def delete(rendering)
+      #  @children.delete(rendering)
+      #end
+
+      def finish!(timing)
+        self._time = timing || 0
+        self._child_time = _calculate_child_time
+        self._exclusive_time = _calculate_exclusive_time
       end
 
-      def duration
-        if @timing
-          @timing.duration
-        else
-          child_duration
-        end
+      def _calculate_exclusive_time
+        _time - _child_time
       end
 
-      def exclusive_duration
-        duration - child_duration
+      def _calculate_child_time
+        children.inject(0.0) { |memo, c| memo + c._time } || 0
       end
 
-      def child_duration
-        children.inject(0.0) { |memo, c| memo + c.duration }
+      def _human_time(t = self._time)
+        "%.2fms" % t
       end
 
-      def duration_summary
+      def time_summary
         if children.any?
-          "%.2fms, %.2f exclusive" % [duration, exclusive_duration]
+          "#{_human_time}, (exclusive: #{_human_time(_exclusive_time)}, child: #{_human_time(_child_time)}"
         else
-          "%.2fms" % (duration)
+          _human_time
         end
       end
-      def html
-        <<-HTML
-            <li>
-              <p>#{name} (#{duration_summary})</p>
 
-        #{children_html}
-            </li>
-        HTML
+      def to_s
+        "#{template} (#{time_summary})#{!children.empty? ? " (#{children.length} children)\n#{children.map {|x| x.to_s}.join("\n")}" : ''}"
       end
 
-      def children_html
-        return "" unless children.any?
-
-        <<-HTML
-            <ul>#{joined_children_html}</ul>
-        HTML
-      end
-
-      def joined_children_html
-        children.map { |c| c.html }.join
-      end
     end
 
   end

data/lib/rack/insight/panels/templates_panel/stats.rb

@@ -0,0 +1,40 @@
+module Rack::Insight
+  class TemplatesPanel
+    class Stats
+      require 'rack/insight/panels/templates_panel/rendering'
+
+      include Rack::Insight::Logging
+
+      attr_reader :root, :current
+
+      def initialize(*args)
+        @root = Rack::Insight::TemplatesPanel::Rendering.new(*args)
+        @current = @root
+      end
+
+      # Track when each template starts being rendered
+      def begin_record!(rendering)
+        @current.add!(rendering) # Add the rendering as a child of the current and make rendering the new current
+        @current = rendering
+      end
+
+      # Track when each template finishes being rendered, move current back up the rendering chain
+      def finish_record!(timing)
+        # This is the one being completed now, and for which we now know the timing duration
+        @current.finish!(timing)
+        # Prepare for the next template to finish
+        @current = @current.parent
+      end
+
+      def finish!
+        @root.finish!(root._calculate_child_time)
+        @current = nil
+      end
+
+      def to_s
+        "#{self.root.to_s}"
+      end
+
+    end
+  end
+end

data/lib/rack/insight/public/__insight__/insight.css

@@ -23,12 +23,18 @@
   cursor: pointer;
 }
 .rack-insight_bottom #rack-insight_toolbar {
-  bottom:0;
   border-top: 2px solid #234f32;
+  height: auto;
+  clear: both;
+  position: relative;
+  z-index: 10;
+  margin-top: -3em;
 }
+
 .rack-insight_top #rack-insight_toolbar {
   top:0;
   border-bottom: 2px solid #234f32;
+  height: auto;
 }
 
 .rack-insight_error #rack-insight_toolbar {
@@ -105,11 +111,11 @@
 }
 
 #rack-insight.rack-insight_top .panel_content {
-  top: 32px;
+  top: auto;
 }
 
 #rack-insight.rack-insight_bottom .panel_content {
-  bottom: 32px;
+  bottom: auto;
 }
 
 #rack-insight .panel_content p a,

data/lib/rack/insight/version.rb

@@ -1,7 +1,7 @@
 module Rack
   module Insight
 
-  VERSION = '0.5.16'
+  VERSION = '0.5.17'
 
   end
 end

data/lib/rack/insight/views/magic_insight.html.erb

@@ -0,0 +1,22 @@
+<tr class="<%=row_class%>">
+  <%- magic_insight._magic_insight_methods.each do |method| %>
+    <%- result = magic_insight.send(method) %>
+    <%- if result.respond_to?(:each) %>
+      <td>
+        <%- result.each do |line| %>
+          <%= line.inspect %><br/>
+        <%- end %>
+      </td>
+    <%- else %>
+      <td>
+        <%= result %>
+      </td>
+    <%- end %>
+    </td>
+  <%- end %>
+  <%- if details %>
+    <td>
+      <a class="reveal_backtrace" href="javascript:void(0);"><%= magic_insight._my_children %></a>
+    </td>
+  <%- end %>
+</tr>

data/lib/rack/insight/views/magic_insights.html.erb

@@ -0,0 +1,67 @@
+<%- if magic_insights.kind_of?(Array) %>
+  <%- magic_insight = magic_insights.last %>
+<%- else %>
+  <%- magic_insight = magic_insights %>
+<%- end %>
+<%- if magic_insight.class.ancestors.include?(Rack::Insight::MagicInsight) %>
+  <table class="sortable">
+    <thead>
+      <tr>
+        <%- magic_insight._magic_insight_methods.each do |method| %>
+          <%- if idiomatic_method = magic_insight._idiomatic_method(method) %>
+            <th><%= idiomatic_method %></th>
+          <%- else %>
+            <th><%= method %></th>
+          <%- end %>
+        <%- end %>
+        <th></th>
+      </tr>
+    </thead>
+    <tbody>
+      <%- if magic_insights.respond_to?(:each) %>
+        <%- i = 1 %>
+        <%- magic_insights.each do |an_object| %>
+          <%- row_class = i % 2 == 0 ? 'even' : 'odd'
+              details = an_object.respond_to?(:children) && !an_object.children.empty?
+          %>
+          <%= render_template 'magic_insight', :magic_insight => an_object, :row_class => row_class, :details => details %>
+          <%- if details %>
+            <tr style="display:none">
+              <td colspan="<%= magic_insight._magic_insight_methods.length + 1%>">
+                <%= render_template 'magic_insights', :magic_insights => an_object.children %>
+              </td>
+            </tr>
+          <%- end %>
+          <%- i += 1 %>
+        <%- end %>
+      <%- else %>
+        <%- details = magic_insights.respond_to?(:children) && !magic_insights.children.empty? %>
+        <%= render_template 'magic_insight', :magic_insight => magic_insights, :row_class => 'odd', :details => details %>
+        <%- if details %>
+          <tr style="display:none">
+            <td colspan="<%= magic_insights._magic_insight_methods.length + 1%>">
+              <%= render_template 'magic_insights', :magic_insights => magic_insights.children %>
+            </td>
+          </tr>
+        <%- end %>
+      <%- end %>
+    </tbody>
+  </table>
+<%- elsif !magic_insight.nil? %>
+  <h3>Magic Panel Template for <%= magic_insight.class %></h3>
+  <p>If you want to have the magic panel template render your data first <strong>read the warning below</strong></p>
+  <h3>WARNING</h3>
+  <p>
+    <pre>
+      <%= Rack::Insight::MagicInsight::WARNING.join('<br/>').gsub(/\s/,'&nbsp;') %>
+    </pre>
+  </p>
+  <p>If you are sure, do the following in your class to be rendered by this template:</p>
+  <p>
+    <pre>
+      include Rack::Insight::MagicInsight
+    </pre>
+  </p>
+<%- else %>
+  <p>nil is non-magical</p>
+<%- end %>

data/lib/rack/insight/views/magic_panel.html.erb

@@ -0,0 +1,2 @@
+<h3><%= name %></h3>
+<%= render_template 'magic_insights', :magic_insights => magic_insights %>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-insight
 version: !ruby/object:Gem::Version
-  version: 0.5.16
+  version: 0.5.17
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-11 00:00:00.000000000 Z
+date: 2012-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -220,6 +220,7 @@ files:
 - lib/rack/insight/app.rb
 - lib/rack/insight/config.rb
 - lib/rack/insight/database.rb
+- lib/rack/insight/default_invocation.rb
 - lib/rack/insight/enable-button.rb
 - lib/rack/insight/filtered_backtrace.rb
 - lib/rack/insight/instrumentation.rb
@@ -231,6 +232,7 @@ files:
 - lib/rack/insight/instrumentation/probe.rb
 - lib/rack/insight/instrumentation/setup.rb
 - lib/rack/insight/logging.rb
+- lib/rack/insight/magic_insight.rb
 - lib/rack/insight/options.rb
 - lib/rack/insight/panel.rb
 - lib/rack/insight/panel_app.rb
@@ -263,6 +265,7 @@ files:
 - lib/rack/insight/panels/sql_panel/query.rb
 - lib/rack/insight/panels/templates_panel.rb
 - lib/rack/insight/panels/templates_panel/rendering.rb
+- lib/rack/insight/panels/templates_panel/stats.rb
 - lib/rack/insight/panels/timer_panel.rb
 - lib/rack/insight/params_signature.rb
 - lib/rack/insight/path-filter.rb
@@ -280,10 +283,12 @@ files:
 - lib/rack/insight/rspec_matchers.rb
 - lib/rack/insight/toolbar.rb
 - lib/rack/insight/version.rb
-- lib/rack/insight/views/default_invocation.html.erb
 - lib/rack/insight/views/enable-button.html.erb
 - lib/rack/insight/views/error.html.erb
 - lib/rack/insight/views/headers_fragment.html.erb
+- lib/rack/insight/views/magic_insight.html.erb
+- lib/rack/insight/views/magic_insights.html.erb
+- lib/rack/insight/views/magic_panel.html.erb
 - lib/rack/insight/views/no_content.html.erb
 - lib/rack/insight/views/no_data.html.erb
 - lib/rack/insight/views/panels/active_record.html.erb
@@ -302,7 +307,6 @@ files:
 - lib/rack/insight/views/panels/speedtracer/traces.html.erb
 - lib/rack/insight/views/panels/sphinx.html.erb
 - lib/rack/insight/views/panels/sql.html.erb
-- lib/rack/insight/views/panels/templates.html.erb
 - lib/rack/insight/views/panels/timer.html.erb
 - lib/rack/insight/views/panels/view_cache.html.erb
 - lib/rack/insight/views/redirect.html.erb

data/lib/rack/insight/views/default_invocation.html.erb

@@ -1,30 +0,0 @@
-<h3><%= name %></h3>
-<table>
-  <thead>
-    <tr>
-      <%- members = invocations.last.members # is a struct, so we have members, not keys %>
-      <%- members.each do |member| %>
-        <td><%= member  %></td>
-      <%- end %>
-    </tr>
-  </thead>
-  <tbody>
-  <%- invocations.each do |invocation| %>
-    <tr>
-      <%- members.each do |member| %>
-        <td>
-          <%- if member == :backtrace %>
-            <%- invocation.filtered_backtrace.each do |line| %>
-              <%= line %><br/>
-            <%- end %>
-          <%- elsif member == :time %>
-            <%= invocation.human_time %>
-          <%- else %>
-            <%= invocation.send(member).inspect %>
-          <%- end %>
-        </td>
-      <%- end %>
-    </tr>
-  <%- end %>
-  </tbody>
-</table>

data/lib/rack/insight/views/panels/templates.html.erb

@@ -1,6 +0,0 @@
-<h3>Templates</h3>
-<ul>
-  <% root_rendering.children.each do |child| %>
-    <%= child.html %>
-  <% end %>
-</ul>