rack-idempotent 0.0.2 → 0.0.3

data/lib/rack-idempotent/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Idempotent
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/rack-idempotent.rb

@@ -4,17 +4,17 @@ module Rack
   class Idempotent
     RETRY_LIMIT = 5
     RETRY_HTTP_CODES = [502, 503, 504]
-    IDEMPOTENT_HTTP_CODES = [*RETRY_HTTP_CODES, 408]
+    IDEMPOTENT_HTTP_CODES = RETRY_HTTP_CODES + [408]
     IDEMPOTENT_ERROR_CLASSES = [Errno::ETIMEDOUT, Errno::ECONNREFUSED, Errno::EHOSTUNREACH]
 
-    class RetryLimitExceeded < Exception
+    class RetryLimitExceeded < StandardError
       attr_reader :idempotent_exceptions
       def initialize(idempotent_exceptions)
         @idempotent_exceptions = idempotent_exceptions
       end
     end
 
-    class HTTPException < Exception
+    class HTTPException < StandardError
       attr_reader :status, :headers, :body
       def initialize(status, headers, body)
         @status, @headers, @body = status, headers, body
@@ -42,7 +42,7 @@ module Rack
         raise HTTPException.new(status, headers, body) if IDEMPOTENT_HTTP_CODES.include?(status)
         env.merge!(dup_env)
         [status, headers, body]
-      rescue *IDEMPOTENT_ERROR_CLASSES, HTTPException, Retryable => ie
+      rescue *(IDEMPOTENT_ERROR_CLASSES + [HTTPException, Retryable]) => ie
         idempotent_exceptions << ie
         if env['client.retries'] > RETRY_LIMIT - 1
           raise(RetryLimitExceeded.new(idempotent_exceptions))

data/spec/rack-idempotent_spec.rb

@@ -81,6 +81,16 @@ describe Rack::Idempotent do
     env['client.retries'].should == 0
   end
 
+  it "should be able to rescue http exception via standard error" do
+    RaiseUp.errors = [408]
+
+    begin
+      client.post("/something")
+    rescue => e
+      # works
+    end
+  end
+
   it "should store exceptions raised" do
     RaiseUp.errors = [502, Errno::ECONNREFUSED, 408, 504, Errno::EHOSTUNREACH, Errno::ETIMEDOUT]
     errors = RaiseUp.errors.dup
@@ -97,4 +107,14 @@ describe Rack::Idempotent do
     exception.idempotent_exceptions.map{|ie| ie.is_a?(Rack::Idempotent::HTTPException) ? ie.status : ie.class}.should == errors
   end
 
+  it "should be able to rescue retry limit exceeded via standard error" do
+    RaiseUp.errors = (0...Rack::Idempotent::RETRY_LIMIT.succ).map{|_| 503 }
+
+    begin
+      res = client.get("/doesntmatter")
+    rescue => e
+      # works
+    end
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-idempotent
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Ines Sombra
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-07 00:00:00 Z
+date: 2012-02-09 00:00:00 Z
 dependencies: []
 
 description: Retry logic for rack-client