rack-idempotency 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca24944f2339362d6a62ba819fbf8a1aee0b77a7
-  data.tar.gz: f2a778af3baa57d06eb2aaf429cf124a4fa06a3f
+  metadata.gz: cae375a11eb57a07c4cc39d3268b3b682ae72753
+  data.tar.gz: dbd1cc40c4bec020d060b9374b2355bac78e6dda
 SHA512:
-  metadata.gz: 5481ccc3dd5d30d29876fc4ef8d047bc6e42f975706aa2df5353c6849b8f09c048fded27d90b3d41ccb72df4c74c0c6ea831a3c3cf807f21835cca50342e8fa4
-  data.tar.gz: fb2480784debdc0b9427c192cb36a3b0a20f8341aa1c5b8a40970b54999a42052119828d3feff02867056f7c32cbf72aec85b2be918172b7643bf15bc66834e1
+  metadata.gz: 57fb2e7b113064b4543ad2c5f2d1a35316b3e13f5889c2a7961b86a21157879406b03b0a3f98021d4f24b9b65cacd0a22706ed25150b98e42e3af0a0a7752e05
+  data.tar.gz: aed9b10b6d6292b02e4be049511e0395383fa5e677ad732e33df1c3c99508dcad9e9fe9ae062d8ddf37d2c4e748fad614ff59faf905d9aeccd40132285ba78ad

data/README.md

@@ -41,7 +41,9 @@ The `store` argument should be any object that responds to both `read(id)` and `
 ## Using with Rails
 
 ```ruby
-config.middleware.use Rack::Idempotency, store: Rails.cache
+config.before_initialize do
+  config.middleware.use Rack::Idempotency, store: Rails.cache
+end
 ```
 
 ## Client Usage

data/lib/rack/idempotency.rb

@@ -2,6 +2,7 @@ require "json"
 
 require "rack/idempotency/version"
 
+require "rack/idempotency/errors"
 require "rack/idempotency/memory_store"
 require "rack/idempotency/null_store"
 require "rack/idempotency/request"
@@ -21,31 +22,18 @@ module Rack
     end
 
     def call(env)
-      @env     = env
-      @request = Request.new(env.dup.freeze)
+      request = Request.new(env.dup.freeze)
+      storage = RequestStorage.new(@store, request)
 
-      lookup || store_response
+      storage.read || store_response(storage, env)
     end
 
     private
 
-    attr_reader :app
-    attr_reader :env
-    attr_reader :request
-    attr_reader :store
-
-    def request_store
-      @request_store ||= RequestStorage.new(store, request)
-    end
-
-    def lookup
-      request_store.read
-    end
-
-    def store_response
+    def store_response(storage, env)
       response = Response.new(*@app.call(env))
 
-      request_store.write(response) if response.success?
+      storage.write(response) if response.success?
 
       response.to_a
     end

data/lib/rack/idempotency/errors.rb

@@ -0,0 +1,13 @@
+module Rack
+  class Idempotency
+    # For all errors
+    class Error < RuntimeError
+      attr :env
+      def initialize(env)
+        @env = env
+      end
+    end
+    
+    class InsecureKeyError < Error; end
+  end
+end

data/lib/rack/idempotency/request.rb

@@ -1,10 +1,14 @@
 require "rack/request"
 
 module Rack
-  class Idempotency
+  class Idempotency    
     class Request < Rack::Request
       def idempotency_key
-        get_header("HTTP_IDEMPOTENCY_KEY")
+        get_header("HTTP_IDEMPOTENCY_KEY").tap do |key|
+          unless key.nil? || key.match?(/^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i)
+            raise InsecureKeyError.new(env), 'Idempotency-Key must be a valid UUID'
+          end
+        end
       end
     end
   end

data/lib/rack/idempotency/response.rb

@@ -22,10 +22,6 @@ module Rack
       def to_json
         to_a.to_json
       end
-
-      def idempotency_key
-        headers["Idempotency-Key"]
-      end
     end
   end
 end

data/lib/rack/idempotency/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Idempotency
-    VERSION = "0.3.1".freeze
+    VERSION = "0.4.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-idempotency
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Matt Pruitt
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-16 00:00:00.000000000 Z
+date: 2017-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -112,6 +112,7 @@ files:
 - bin/console
 - bin/setup
 - lib/rack/idempotency.rb
+- lib/rack/idempotency/errors.rb
 - lib/rack/idempotency/memory_store.rb
 - lib/rack/idempotency/null_store.rb
 - lib/rack/idempotency/request.rb