rack-encoding_guard 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05413b164ca4a261a4b6366d8a44a7ca52f1370a
-  data.tar.gz: de38cb9bb4f4b741e89b2f5eefebf066d8546602
+  metadata.gz: a03cfd562d474ea8ca8fed6d4ddc49041ea547d8
+  data.tar.gz: b5c9080c796145afc48fe9b63e856717444eb1f9
 SHA512:
-  metadata.gz: 519c56b25550056d23c398d78032529f19e3574b3f59ca028e346432b1b040ddc4e716d2514edd455f16b1cf6daf3c4f77ce74daf2398d96b085b2367b9552c7
-  data.tar.gz: 2563866e335486605a9ee6e6d73eef371a6c570c4e0a163ff729e3d8001b74e30817b94501185b6c032015aecbf056a69829980834d5f1c514fce45cf491d9fe
+  metadata.gz: 91702c42498856445e047d50a97d3a65b1660688eb130e7e67ef8f5f105ee8fd4e4e0d48daee3581e9f3b3d413b561224af8269593ade2ae6faca22e01853487
+  data.tar.gz: 72de23f3b9f462fe5369e32e5318114d6184fe15fc485f41486d4501dae2e712a84826854a171dcc4a4e215287cf2a45ec256ce5292d6bbe171f18d76549d9df

data/README.md

@@ -27,28 +27,36 @@ If you are on Rails, you can insert the middleware to your application.rb
 config.middleware.use 'Rack::EncodingGuard::Middleware'
 ```
 
-### Reject Strategy
-By default, all requests containing characters with invalid encodings are rejected with a HTTP status 400 code ("Bad Request"). Additionally, you can configure which message will be shown to the requesting user in this case:
+### Sanitize Strategy
+This is the default strategy. When using it sanitization, all invalid characters
+will be stripped out of all relevant ENV vars. Subsequently, no encoding errors
+will occur down the middleware stack.
 ```ruby
-config.middleware.use 'Rack::EncodingGuard::Middleware', :reject, with: 'Check that URL, mate!'
+config.middleware.use 'Rack::EncodingGuard::Middleware', :sanitize
 ```
 
-### Sanitize Strategy
-When using the sanitize strategy it is also possible to allow requests containing invalid characters. All invalid characters will be stripped out of all relevant ENV vars so no encoding errors will occur down the middleware stack.
+### Reject Strategy
+When using this strategy, all requests containing invalid characters are
+rejected with a HTTP status 400 code ("Bad Request"). Additionally, you can
+configure which hint will be displayed to the requesting user:
 ```ruby
-config.middleware.use 'Rack::EncodingGuard::Middleware', :sanitize
+config.middleware.use 'Rack::EncodingGuard::Middleware', :reject, with: 'Check that URL, mate!'
 ```
 
 ## Contributing to Rack::EncodingGuard
-* Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
+* Check out the latest master to make sure the feature hasn't been implemented
+  or the bug hasn't been fixed yet.
+* Check out the issue tracker to make sure someone already hasn't requested it
+  and/or contributed it.
 * Fork the project.
 * Start a feature/bugfix branch.
 * Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+* Make sure to add tests for it. This is important so I don't break it in a
+  future version unintentionally.
+* Please try not to mess with the Rakefile, version, or history. If you want to
+  have your own version, or is otherwise necessary, that is fine, but please
+  isolate to its own commit so I can cherry-pick around it.
 
 ## Copyright
-Copyright (c) 2015 Tobias Casper. See LICENSE.txt for
-further details.
+Copyright (c) 2015 Tobias Casper. See LICENSE.txt for further details.
 

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/lib/rack/encoding_guard/middleware.rb

@@ -18,7 +18,7 @@ module Rack
 
       def resolve_strategy_object(strategy, options)
         case strategy
-        when nil then RejectStrategy.new(options)
+        when nil then SanitizeStrategy.new(options)
         when Class then strategy.new(options)
         when String then strategy.constantize.new(options)
         when Symbol

data/lib/rack/encoding_guard/reject_strategy.rb

@@ -16,7 +16,7 @@ module Rack
 
       def invalid_request?(env)
         Strategy::PROCESSIBLE_KEYS.any? do |key|
-          !env[key].to_s.valid_encoding?
+          !env[key].to_s.dup.force_encoding(Encoding::UTF_8).valid_encoding?
         end
       end
 

data/rack-encoding_guard.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rack-encoding_guard 0.1.1 ruby lib
+# stub: rack-encoding_guard 0.1.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rack-encoding_guard"
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]

data/spec/lib/rack/encoding_guard/middleware_spec.rb

@@ -13,14 +13,14 @@ describe Rack::EncodingGuard::Middleware do
     end
 
     context 'with strategies' do
-      it 'uses RejectStrategy when second argument is omitted' do
+      it 'uses SanitizeStrategy when second argument is omitted' do
         middleware = described_class.new(app)
-        expect(middleware.strategy).to be_a Rack::EncodingGuard::RejectStrategy
+        expect(middleware.strategy).to be_a Rack::EncodingGuard::SanitizeStrategy
       end
 
-      it 'uses RejectStrategy when second argument is nil' do
+      it 'uses SanitizeStrategy when second argument is nil' do
         middleware = described_class.new(app, nil)
-        expect(middleware.strategy).to be_a Rack::EncodingGuard::RejectStrategy
+        expect(middleware.strategy).to be_a Rack::EncodingGuard::SanitizeStrategy
       end
 
       it 'uses RejectStrategy when second argument is :reject' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-encoding_guard
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Tobias Casper