rack-content_disposition_helper 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65bb8f8c0b81289e8992dddcdc32ddf7be95aebbadf8c981a4c11a193670f6f1
-  data.tar.gz: 07f5d4a25e13bd83dc705513720c7b0835f7d29b0b794aab7a840b497232e672
+  metadata.gz: b3087bac2c96ea49d1175a3b7af9e6517156d120dc242243ea3b5c1c4c2843b4
+  data.tar.gz: 27b2a444a205e29a1ed225bd6a9dfb6aa612a30067f043f8088c60dcd4e06da8
 SHA512:
-  metadata.gz: 9a3884c9d2a6f6e757596cdf6354e02cf1fb7bf21454b8dfb0a27112f713ecb3998df85d90eb9114daa74215a0df6712f0d2344f5194234c7b2972a738b0d21e
-  data.tar.gz: 5e78b8f97f0b1939177f7229524cae99f566034431454f3776aaeabb38aa29c4dcc293346a4ae12ea45f1287156f38d51ee4b0c514d87c7f2e6a9f58894600dc
+  metadata.gz: 07cdcdf7d605a140b507955245c849486251ed39565fa0ad85dc9ccd1955fee721af8578c556cce5c35bb0fe9aa1880c17cdfce7186dc5501fae18f1bd4c1c1b
+  data.tar.gz: 9de09768d3f5d21e3c87f168a5c7aa6c5bf7f5c9600b6d2a96478912d0ae4a19b036c9ae147ec78931f150b9e6c59fc988ab386f70b1a247082e6a075f88b30e

data/CHANGELOG.md

@@ -1,5 +1,19 @@
-## [Unreleased]
+# Unreleased
 
-## [0.1.0] - 2022/03/24
+# 0.2.0 - 2022/04/04
+
+## Breaking Changes:
+
+- Rename Rack::ContentDispositionHelper::ContentDisposition to Rack::ContentDispositionHelper::Converter
+- Rename Rack::ContentDispositionHelper::Converter#long? to Rack::ContentDispositionHelper::Converter#length_limit_exceeded?
+- Rename Rack::ContentDispositionHelper::Converter#raw_filename_value to Rack::ContentDispositionHelper::Converter#convert
+- Rename Rack::ContentDispositionHelper::Converter#value to Rack::ContentDispositionHelper::Converter#original_value
+- Drop support for Ruby 2.6
+
+## Enhancement:
+
+- Rack::ContentDispositionHelper::Converter#convert now returns the original value if the `filename*` directive does not exist
+
+# 0.1.0 - 2022/03/24
 
 - Initial release.

data/README.md

@@ -1,3 +1,8 @@
+[![GitHub Actions](https://github.com/hana-da/rack-content_disposition_helper/actions/workflows/test.yml/badge.svg)](https://github.com/hana-da/rack-content_disposition_helper/actions/workflows/test.yml)
+[![Maintainability](https://api.codeclimate.com/v1/badges/27559fca466cbad7698d/maintainability)](https://codeclimate.com/github/hana-da/rack-content_disposition_helper/maintainability)
+[![Gem Version](https://badge.fury.io/rb/rack-content_disposition_helper.svg)](https://badge.fury.io/rb/rack-content_disposition_helper)
+[![GitHub](https://img.shields.io/github/license/hana-da/rack-content_disposition_helper)](https://github.com/hana-da/rack-content_disposition_helper/blob/main/MIT-LICENSE)
+
 # Rack::ContentDispositionHelper
 
 Rack::ContentDispositionHelper is Rack middleware that rewrites the decoded `filename*` directive in the Content-Disposition response header as the value of the `filename` directive.
@@ -47,6 +52,8 @@ For Sinatra and other Rack apps, add this to config.ru:
 
 ```ruby
 # config.ru
+
+# Bundler.require or require 'rack/content_disposition_helper'
 use Rack::ContentDispositionHelper
 ```
 

data/lib/rack/content_disposition_helper/{content_disposition.rb → converter.rb}

@@ -4,35 +4,35 @@ require 'cgi'
 
 module Rack
   class ContentDispositionHelper
-    class ContentDisposition
+    class Converter
       LIMIT = 254
       FILENAME_ASTERISK_PREFIX = "filename*=UTF-8''"
 
-      attr_reader :value, :parts
+      attr_reader :original_value, :parts
 
       def initialize(original_value)
-        @value = original_value
-        @parts = value&.split
+        @original_value = original_value
+        @parts = original_value&.split
       end
 
-      def long?
-        return nil unless value
+      def length_limit_exceeded?
+        return nil unless original_value
 
-        value.length > LIMIT
+        original_value.length > LIMIT
       end
 
       def disposition
         parts&.first
       end
 
-      def raw_filename_value
-        return unless disposition
+      def convert
+        return original_value if !disposition || !raw_filename
 
         "#{disposition} filename=\"#{raw_filename}\""
       end
 
       def raw_filename
-        filename_asterisk&.then { |v| CGI.unescape(v).delete_prefix!(FILENAME_ASTERISK_PREFIX) }
+        @raw_filename ||= filename_asterisk&.then { |v| CGI.unescape(v).delete_prefix!(FILENAME_ASTERISK_PREFIX) }
       end
 
       def filename_asterisk

data/lib/rack/content_disposition_helper/version.rb

@@ -2,6 +2,6 @@
 
 module Rack
   class ContentDispositionHelper
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/lib/rack/content_disposition_helper.rb

@@ -3,7 +3,7 @@
 require 'rack/content_disposition_helper/version'
 
 require 'rack/content_disposition_helper/user_agent'
-require 'rack/content_disposition_helper/content_disposition'
+require 'rack/content_disposition_helper/converter'
 
 require 'rack/content_disposition_helper/railtie' if defined?(::Rails::Railtie)
 
@@ -17,10 +17,10 @@ module Rack
       status_code, headers, body = @app.call(env)
 
       user_agent = UserAgent.new(env)
-      content_disposition = ContentDisposition.new(headers['Content-Disposition'])
+      converter = Converter.new(headers['Content-Disposition'])
 
-      if content_disposition.long? && user_agent.safari?
-        headers = headers.merge('Content-Disposition' => content_disposition.raw_filename_value)
+      if converter.length_limit_exceeded? && user_agent.safari?
+        headers = headers.merge('Content-Disposition' => converter.convert)
       end
 
       [status_code, headers, body]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-content_disposition_helper
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - hana-da
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-24 00:00:00.000000000 Z
+date: 2022-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -42,7 +42,7 @@ files:
 - MIT-LICENSE
 - README.md
 - lib/rack/content_disposition_helper.rb
-- lib/rack/content_disposition_helper/content_disposition.rb
+- lib/rack/content_disposition_helper/converter.rb
 - lib/rack/content_disposition_helper/railtie.rb
 - lib/rack/content_disposition_helper/user_agent.rb
 - lib/rack/content_disposition_helper/version.rb
@@ -54,7 +54,7 @@ metadata:
   homepage_uri: https://github.com/hana-da/rack-content_disposition_helper
   source_code_uri: https://github.com/hana-da/rack-content_disposition_helper
   bug_tracker_uri: https://github.com/hana-da/rack-content_disposition_helper/issues
-  changelog_uri: https://github.com/hana-da/rack-content_disposition_helper/CHANGELOG.md
+  changelog_uri: https://github.com/hana-da/rack-content_disposition_helper/blob/main/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -63,14 +63,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.9
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
+rubygems_version: 3.3.10
 signing_key: 
 specification_version: 4
 summary: Rack middleware that modifies Content-Disposition response header.