rack-cas 0.4.1 → 0.4.2

data/lib/rack-cas/cas_request.rb

@@ -7,11 +7,9 @@ class CASRequest
 
   def ticket
     @ticket ||= if single_sign_out?
-      xml = Nokogiri::XML(@request.params['logoutRequest'])
-      node = xml.root.children.find { |c| c.name =~ /SessionIndex/i }
-      node.text unless node.nil?
-    else
-      @request.params['ticket']
+      sso_ticket
+    elsif ticket_validation?
+      ticket_param
     end
   end
 
@@ -28,6 +26,20 @@ class CASRequest
   end
 
   def ticket_validation?
-    !!@request.params['ticket']
+    # The CAS protocol specifies 32 characters as the minimum length of a
+    # service ticket (including ST-) http://www.jasig.org/cas/protocol
+    !!(@request.get? && ticket_param && ticket_param.to_s =~ /\AST\-[^\s]{29}/)
+  end
+
+  private
+
+  def ticket_param
+    @request.params['ticket']
+  end
+
+  def sso_ticket
+    xml = Nokogiri::XML(@request.params['logoutRequest'])
+    node = xml.root.children.find { |c| c.name =~ /SessionIndex/i }
+    node.text unless node.nil?
   end
 end

data/lib/rack-cas/version.rb

@@ -1,3 +1,3 @@
 module RackCAS
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-cas
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-17 00:00:00.000000000 Z
+date: 2013-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -115,25 +115,25 @@ extra_rdoc_files: []
 files:
 - README.markdown
 - MIT-LICENSE
-- lib/generators/templates/migration.rb
-- lib/generators/cas_session_store_migration_generator.rb
-- lib/rack-cas.rb
+- lib/rack-cas/railtie.rb
 - lib/rack-cas/url.rb
 - lib/rack-cas/version.rb
-- lib/rack-cas/railtie.rb
-- lib/rack-cas/session_store/rails/mongo.rb
+- lib/rack-cas/service_validation_response.rb
+- lib/rack-cas/cas_request.rb
+- lib/rack-cas/server.rb
+- lib/rack-cas/session_store/active_record.rb
 - lib/rack-cas/session_store/rails/active_record.rb
+- lib/rack-cas/session_store/rails/mongo.rb
 - lib/rack-cas/session_store/rails/mongoid.rb
 - lib/rack-cas/session_store/mongo.rb
-- lib/rack-cas/session_store/active_record.rb
+- lib/rack-cas/session_store/mongoid.rb
 - lib/rack-cas/session_store/rack/mongo.rb
 - lib/rack-cas/session_store/rack/mongoid.rb
-- lib/rack-cas/session_store/mongoid.rb
-- lib/rack-cas/service_validation_response.rb
-- lib/rack-cas/server.rb
-- lib/rack-cas/cas_request.rb
-- lib/rack/fake_cas.rb
+- lib/rack-cas.rb
+- lib/generators/cas_session_store_migration_generator.rb
+- lib/generators/templates/migration.rb
 - lib/rack/cas.rb
+- lib/rack/fake_cas.rb
 homepage: https://github.com/biola/rack-cas
 licenses: []
 post_install_message: