rack-cachely 0.1.0 → 0.2.0

data/lib/rack-cachely/config.rb

@@ -5,10 +5,17 @@ module Rack
       attr_accessor :options
 
       def initialize(options = {})
-        self.options = options
+        self.options = {ignore_query_params: []}
+        options.each do |key, value|
+          self.send("#{key}=", value)
+        end
         self.options[:cachely_url] = "#{(self.options[:cachely_url] ||= ENV["CACHELY_URL"])}/v1/cache"
       end
 
+      def ignore_query_params=(*args)
+        self.options[:ignore_query_params] = [args].flatten.map {|x| x.downcase}
+      end
+
       def method_missing(sym, *args, &block)
         if /(.+)=$/.match(sym.to_s)
           self.options[$1.to_sym] = args[0]

data/lib/rack-cachely/context.rb

@@ -7,7 +7,7 @@ module Rack
       end
 
       def request
-        @request ||= Rack::Request.new(@env.dup.freeze)
+        @request ||= Rack::Request.new(@env.dup)
       end
 
       def call(env)
@@ -31,7 +31,7 @@ module Rack
         else
           @env['rack-cachely.perform_caching'].to_s == 'true'
         end
-        config && request.request_method == 'GET'
+        config && request.request_method == 'GET' && !request.params["no-cachely"]
       end
 
       def is_cacheable?(results)

data/lib/rack-cachely/key.rb

@@ -44,11 +44,10 @@ module Rack
       def query_string
         return nil if @request.query_string.nil?
 
-        @request.query_string.split(/[&;] */n).
-          map { |p| unescape(p).split('=', 2) }.
-          sort.
-          map { |k,v| "#{escape(k)}=#{escape(v)}" }.
-          join('&')
+        query = @request.query_string.split(/[&;] */n).map { |p| unescape(p).split('=', 2) }.sort
+        query = query.reject{|k,v| Rack::Cachely.config.ignore_query_params.include?(k)}.map{ |k,v| "#{escape(k)}=#{escape(v)}" }
+
+        query.join('&')
       end
     end
 

data/lib/rack-cachely/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Cachely
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/spec/rack-cachely/key_spec.rb

@@ -6,10 +6,15 @@ describe Rack::Cachely::Key do
 
   describe "generate" do
   
-    let(:request) { double(scheme: "http", host: "example.com", port: 80, script_name: "/foo", path_info: "/bar", query_string: "b=B&a=A") }
+    let(:request) { double(scheme: "http", host: "example.com", port: 80, script_name: "/foo", path_info: "/bar", query_string: "b=B&a=A&d=D&c=C") }
 
     it "returns a uniformed url" do
-      key.to_s.should eql("http://example.com/foo/bar?a=A&b=B")
+      key.to_s.should eql("http://example.com/foo/bar?a=A&b=B&c=C&d=D")
+    end
+
+    it "will ignore certain query params" do
+      Rack::Cachely.config.ignore_query_params = ["A", "c"]
+      key.to_s.should eql("http://example.com/foo/bar?b=B&d=D")
     end
   
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-cachely
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-17 00:00:00.000000000 Z
+date: 2012-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack