rack-bouncer 1.3.0 → 1.3.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-bouncer (1.2)
+    rack-bouncer (1.3.1)
 
 GEM
   remote: http://rubygems.org/

data/README.md

@@ -41,7 +41,7 @@ You can specify a set of safe paths:
 
 ## contributing
 
-Pull requests are very welcome.
+Pull requests are very welcome. You'd be doing me a favor if you could test cover your enhancement and ensure the test suite passes *before* initiating a pull request.
 
 ## acknowledgments
 

data/Rakefile

@@ -4,7 +4,7 @@ require "rake/testtask"
 task :default => [:test]
 
 Rake::TestTask.new do |t|
-  t.libs.push "lib"
+  t.libs += ["lib", "test"]
   t.test_files = FileList["test/**/*_test.rb"]
   t.verbose = true
 end

data/lib/rack/bouncer.rb

@@ -2,7 +2,7 @@
 
 module Rack
   class Bouncer
-    VERSION = "1.3.0"
+    VERSION = "1.3.1"
 
     DEFAULT_OPTIONS = {
       :safe_paths      => ["/asset", "/images", "/stylesheets", "/javascripts", "/feedback"],

data/test/lib/rack/bouncer/aol_test.rb

@@ -0,0 +1,52 @@
+require "test_helper"
+
+class Rack::Bouncer::AOLTest < MiniTest::Unit::TestCase
+  def test_expels_aol_6
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_7
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_7])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_8
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_8])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_9
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_9])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_9_1
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_9_1])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_9_5
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_9_5])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_aol_9_6
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:aol_9_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+end

data/test/lib/rack/bouncer/chrome_test.rb

@@ -0,0 +1,10 @@
+require "test_helper"
+
+class Rack::Bouncer::ChromeTest < MiniTest::Unit::TestCase
+  def test_allows_chrome_16
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:chrome_16])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+end

data/test/lib/rack/bouncer/firefox_test.rb

@@ -0,0 +1,94 @@
+require "test_helper"
+
+class Rack::Bouncer::FirefoxTest < MiniTest::Unit::TestCase
+  def test_expels_firefox_3_6
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_allows_firefox_3_6_when_minimum
+    request  = create_request(:minimum_firefox => 3.6)
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_6])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_expels_firefox_3_6_2
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_6_2])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_firefox_3_6_b5
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_6_b5])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_firefox_3_6_22
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_6_22])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_firefox_3_8
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_3_8])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_allows_firefox_4
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_4])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_4_0_1
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_4_0_1])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_5
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_5])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_6
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_6])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_9
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_9])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_9_0_a2
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_9_0_a2])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_firefox_10_0_a4
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:firefox_10_0_a4])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+end

data/test/lib/rack/bouncer/ie_test.rb

@@ -0,0 +1,73 @@
+require "test_helper"
+
+class Rack::Bouncer::IETest < MiniTest::Unit::TestCase
+  def test_allows_ie_if_no_version_available
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_no_version])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_expels_ie_6_and_redirects_to_default
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_expels_ie_6_and_redirects_to_internal_url
+    request  = create_request(:redirect => "/foo")
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "/foo"
+  end
+
+  def test_expels_ie_6_and_redirects_to_external_url
+    request  = create_request(:redirect => "http://getfirefox.com")
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://getfirefox.com"
+  end
+
+  def test_allows_ie_6_when_minimum
+    request  = create_request(:minimum_ie => 6.0)
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_expels_ie_7
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_7])
+    assert_equal 302, response.status
+    assert_equal response.location, "http://browsehappy.com/"
+  end
+
+  def test_allows_ie_7_when_minimum
+    request  = create_request(:minimum_ie => 7.0)
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_7])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_ie_8
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_8])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_ie_8_when_minimum
+    request  = create_request(:minimum_ie => 8.0)
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_8])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_ie_9
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:ie_9])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+end

data/test/lib/rack/bouncer/safari_test.rb

@@ -0,0 +1,17 @@
+require "test_helper"
+
+class Rack::Bouncer::SafariTest < MiniTest::Unit::TestCase
+  def test_allows_safari_5_0
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:safari_5_0])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+
+  def test_allows_safari_5_1
+    request  = create_request
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:safari_5_1])
+    assert_equal 200, response.status
+    assert_equal "Hi Internets!", response.body
+  end
+end

data/test/lib/rack/bouncer_test.rb

@@ -1,24 +1,9 @@
 # encoding: UTF-8
-require "rubygems"
-require "minitest/autorun"
-require "rack/mock"
-
-require "rack-bouncer"
-
-class TestApp
-  def call(env)
-    [200, {}, "Hi Internets!"]
-  end
-end
-
-def create_request(options = {})
-  Rack::MockRequest.new(Rack::Bouncer.new(TestApp.new, options))
-end
-
-class Rack::Bouncer::Test < MiniTest::Unit::TestCase
+require "test_helper"
 
+class Rack::BouncerTest < MiniTest::Unit::TestCase
   def test_version
-    assert_equal "1.3.0", Rack::Bouncer::VERSION
+    assert_equal "1.3.1", Rack::Bouncer::VERSION
   end
 
   def test_default_safe_paths
@@ -45,254 +30,9 @@ class Rack::Bouncer::Test < MiniTest::Unit::TestCase
     assert_equal "Hi Internets!", response.body
   end
 
-  # Internet Explorer
-  #################################################################################################
-
-  def test_allows_if_not_ie
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0"})
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_ie_if_no_version_available
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE l4me; Windows XP)"})
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_expels_ie_6_and_redirects_to_default
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_ie_6_and_redirects_to_internal_url
-    request  = create_request(:redirect => "/foo")
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "/foo"
-  end
-
-  def test_expels_ie_6_and_redirects_to_external_url
-    request  = create_request(:redirect => "http://getfirefox.com")
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://getfirefox.com"
-  end
-
-  def test_allows_ie_6_when_minimum
-    request  = create_request(:minimum_ie => 6.0)
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_expels_ie_7
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_allows_ie_7_when_minimum
-    request  = create_request(:minimum_ie => 7.0)
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0)" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_ie_8
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "User-Agent:Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0)" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_ie_8_when_minimum
-    request  = create_request(:minimum_ie => 8.0)
-    response = request.get("/", {"HTTP_USER_AGENT" => "User-Agent:Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0)" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_ie_9
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0;" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  # AOL
-  #################################################################################################
-
-  def test_expels_aol_6
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 5.5; AOL 6.0; Windows 98)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_7
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; AOL 7.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_8
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; AOL 8.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_9
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.0; Windows NT 5.1)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_9_1
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.1; AOLBuild 4334.5000; Windows NT 5.1; Trident/4.0)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_9_5
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.5; AOLBuild 4337.43; Windows NT 5.1; Trident/4.0)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_aol_9_6
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/4.0 (compatible; MSIE 8.0; AOL 9.6; AOLBuild 4340.5004; Windows NT 5.1; Trident/4.0)" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  # Firefox
-  #################################################################################################
-
-  def test_expels_firefox_3_6
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_allows_firefox_3_6_when_minimum
-    request  = create_request(:minimum_firefox => 3.6)
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_expels_firefox_3_6_2
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_firefox_3_6_b5
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b5) Gecko/20091204 Firefox/3.6b5" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_firefox_3_6_22
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.2.22) Gecko/20110902 Firefox/3.6.22" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_expels_firefox_3_8
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.9.0.2) Gecko/20121223 Ubuntu/9.25 (jaunty) Firefox/3.8" })
-    assert_equal 302, response.status
-    assert_equal response.location, "http://browsehappy.com/"
-  end
-
-  def test_allows_firefox_4
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Windows NT 6.1; rv:2.0.1) Gecko/20100101 Firefox/4.0" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_4_0_1
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (X11; Linux i686; rv:2.0.1) Gecko/20110518 Firefox/4.0.1" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_5
+  def test_allows_if_mozilla_non_specific
     request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Windows NT 5.1; U; rv:5.0) Gecko/20100101 Firefox/5.0" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_6
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20110814 Firefox/6.0" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_9
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_9_0_a2
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20111101 Firefox/9.0a2" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_firefox_10_0_a4
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/6.0 (Macintosh; I; Intel Mac OS X 11_7_9; de-LI; rv:1.9b4) Gecko/2012010317 Firefox/10.0a4" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  # Safari
-  #################################################################################################
-
-  def test_allows_safari_5_0
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/533.18.1 (KHTML, like Gecko) Version/5.0 Safari/533.16" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  def test_allows_safari_5_1
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_8; en-us) AppleWebKit/534.52.7 (KHTML, like Gecko) Version/5.1 Safari/534.52.7" })
-    assert_equal 200, response.status
-    assert_equal "Hi Internets!", response.body
-  end
-
-  # Chrome
-  #################################################################################################
-
-  def test_allows_chrome_16
-    request  = create_request
-    response = request.get("/", {"HTTP_USER_AGENT" => "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.77 Safari/535.7" })
+    response = request.get("/", "HTTP_USER_AGENT" => USER_AGENTS[:mozilla_non_specific])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
@@ -302,51 +42,50 @@ class Rack::Bouncer::Test < MiniTest::Unit::TestCase
 
   def test_allows_redirect_path
     request  = create_request(:redirect => "/browser")
-    response = request.get("/browser", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/browser", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
 
   def test_expels_non_redirect_path
     request  = create_request(:redirect => "/browser")
-    response = request.get("/wrong", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/wrong", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 302, response.status
     assert_equal response.location, "/browser"
   end
 
   def test_allows_assets_path
     request  = create_request
-    response = request.get("/asset", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/asset", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
 
   def test_allows_images_path
     request  = create_request
-    response = request.get("/images", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/images", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
 
   def test_allows_stylesheets_path
     request  = create_request
-    response = request.get("/stylesheets", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/stylesheets", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
 
   def test_allows_javascripts_path
     request  = create_request
-    response = request.get("/javascripts", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/javascripts", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
 
   def test_allows_feedback_path
     request  = create_request
-    response = request.get("/feedback", {"HTTP_USER_AGENT" => "Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)" })
+    response = request.get("/feedback", "HTTP_USER_AGENT" => USER_AGENTS[:ie_6])
     assert_equal 200, response.status
     assert_equal "Hi Internets!", response.body
   end
-
 end

data/test/test_helper.rb

@@ -0,0 +1,19 @@
+# encoding: UTF-8
+require "rubygems"
+require "minitest/autorun"
+require "rack/mock"
+require "yaml"
+
+require "rack-bouncer"
+
+USER_AGENTS = YAML.load_file(File.expand_path("user_agents.yml", File.dirname(__FILE__)))
+
+class TestApp
+  def call(env)
+    [200, {}, "Hi Internets!"]
+  end
+end
+
+def create_request(options = {})
+  Rack::MockRequest.new(Rack::Bouncer.new(TestApp.new, options))
+end

data/test/user_agents.yml

@@ -0,0 +1,81 @@
+# encoding: UTF-8
+
+# AOL
+###################################################################################################
+
+:aol_6:
+  Mozilla/4.0 (compatible; MSIE 5.5; AOL 6.0; Windows 98)
+:aol_7:
+  Mozilla/4.0 (compatible; MSIE 7.0; AOL 7.0; Windows NT 5.1)
+:aol_8:
+  Mozilla/4.0 (compatible; MSIE 7.0; AOL 8.0; Windows NT 5.1)
+:aol_9:
+  Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.0; Windows NT 5.1)
+:aol_9_1:
+  Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.1; AOLBuild 4334.5000; Windows NT 5.1; Trident/4.0)
+:aol_9_5:
+  Mozilla/4.0 (compatible; MSIE 7.0; AOL 9.5; AOLBuild 4337.43; Windows NT 5.1; Trident/4.0)
+:aol_9_6:
+  Mozilla/4.0 (compatible; MSIE 8.0; AOL 9.6; AOLBuild 4340.5004; Windows NT 5.1; Trident/4.0)
+
+# Chrome
+###################################################################################################
+
+:chrome_16:
+  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.77 Safari/535.7
+
+# Firefox
+###################################################################################################
+
+:firefox_3_6:
+  Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6
+:firefox_3_6_2:
+  Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2
+:firefox_3_6_b5:
+  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b5) Gecko/20091204 Firefox/3.6b5
+:firefox_3_6_22:
+  Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.2.22) Gecko/20110902 Firefox/3.6.22
+:firefox_3_8:
+  Mozilla/5.0 (X11; U; Linux i686; rv:1.9.0.2) Gecko/20121223 Ubuntu/9.25 (jaunty) Firefox/3.8
+:firefox_4:
+  Mozilla/5.0 (Windows NT 6.1; rv:2.0.1) Gecko/20100101 Firefox/4.0
+:firefox_4_0_1:
+  Mozilla/5.0 (X11; Linux i686; rv:2.0.1) Gecko/20110518 Firefox/4.0.1
+:firefox_5:
+  Mozilla/5.0 (Windows NT 5.1; U; rv:5.0) Gecko/20100101 Firefox/5.0
+:firefox_6:
+  Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20110814 Firefox/6.0
+:firefox_9:
+  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0
+:firefox_9_0_a2:
+  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20111101 Firefox/9.0a2
+:firefox_10_0_a4:
+  Mozilla/6.0 (Macintosh; I; Intel Mac OS X 11_7_9; rv:1.9b4) Gecko/2012010317 Firefox/10.0a4
+
+# Internet Explorer
+###################################################################################################
+
+:ie_no_version:
+  Mozilla/4.0 (compatible; MSIE l4me; Windows XP)
+:ie_6:
+  Mozilla/4.0 (MSIE 6.0; Windows NT 5.1)
+:ie_7:
+  Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0)
+:ie_8:
+  Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0)
+:ie_9:
+  Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)
+
+# Mozilla
+###################################################################################################
+
+:mozilla_non_specific:
+  Mozilla/5.0
+
+# Safari
+###################################################################################################
+
+:safari_5_0:
+  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/533.18.1 (KHTML, like Gecko) Version/5.0 Safari/533.16
+:safari_5_1:
+  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_8; en-us) AppleWebKit/534.52.7 (KHTML, like Gecko) Version/5.1 Safari/534.52.7

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-bouncer
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 1
   - 3
-  - 0
-  version: 1.3.0
+  - 1
+  version: 1.3.1
 platform: ruby
 authors: 
 - Julio Cesar Ody
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-08 00:00:00 -08:00
+date: 2012-02-09 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -71,7 +71,14 @@ files:
 - lib/rack-bouncer.rb
 - lib/rack/bouncer.rb
 - rack-bouncer.gemspec
+- test/lib/rack/bouncer/aol_test.rb
+- test/lib/rack/bouncer/chrome_test.rb
+- test/lib/rack/bouncer/firefox_test.rb
+- test/lib/rack/bouncer/ie_test.rb
+- test/lib/rack/bouncer/safari_test.rb
 - test/lib/rack/bouncer_test.rb
+- test/test_helper.rb
+- test/user_agents.yml
 has_rdoc: true
 homepage: https://github.com/ryansobol/rack-bouncer
 licenses: []