rack-bert-rpc 0.2.1 → 0.3.0

data/README.md

@@ -45,6 +45,10 @@ The `BertRpc` middle takes several configuration parameters:
 * `path`
   Any requests coming in to this path will be handled as RPC
   requests. Defaults to '/rpc'
+* `logger`
+  This is a `Logger` object that will be used for logging messages
+  from the RPC server. If no logger is provided a default one will be
+  created that logs to `STDOUT`
 * `server`
   Used for testing, switches out the backend `BertRpc::Server` so the
   requests can be handled by a different one

data/lib/rack/bert_rpc.rb

@@ -1,4 +1,5 @@
 require 'rack'
+require 'logger'
 
 module Rack
   class BertRpc
@@ -14,6 +15,14 @@ module Rack
       def clear_exposed
         @exposed_modules = []
       end
+
+      def logger
+        @logger ||= ::Logger.new(STDOUT)
+      end
+
+      def logger=(logger)
+        @logger = logger
+      end
     end
 
     attr_reader :path
@@ -21,7 +30,8 @@ module Rack
     def initialize(app, options = {})
       @path = options[:path] || '/rpc'
       @app = app
-      @server = options[:server] || Server.new
+      logger = options[:logger] || BertRpc.logger
+      @server = options[:server] || BertRpc::Server.new(logger)
 
       expose_defaults!
       options[:expose].each do |sym, mod|

data/lib/rack/bert_rpc/server.rb

@@ -9,7 +9,8 @@ module Rack
 
       attr_reader :mods
 
-      def initialize
+      def initialize(logger = nil)
+        @logger = logger
         @mods = {}
       end
 
@@ -20,26 +21,36 @@ module Rack
       def handle(input)
         rpc = read_rpc(input)
         if rpc.nil?
+          @logger.error("Invalid rpc request received: '#{input.inspect}'")
           return error_response(:server, "Invalid request: unrecognized")
         end
 
         if rpc.size == 4 && rpc[0] == :call
           begin
+            @logger.debug("RPC Call: '#{rpc.inspect}'")
             resp = dispatch(*rpc[1..3])
             reply_response(resp)
           rescue ServerError => e
+            @logger.error("Server error encountered on call: '#{e.inspect}'")
             error_response(:server, e)
           rescue Object => e
+            @logger.info("error encountered on call: '#{e.inspect}'")
             error_response(:user, e)
           end
         elsif rpc.size == 4 && rpc[0] == :cast
           begin
+            @logger.debug("RPC Call: '#{rpc.inspect}'")
             dispatch(*rpc[1..3])
+            noreply_response
+          rescue ServerError => e
+            @logger.error("Server error encountered on cast: '#{e.inspect}'")
+            error_response(:server, e)
           rescue Object => e
-            # Just ignore errors here
+            @logger.debug("error encountered on cast: '#{e.inspect}'")
+            noreply_response
           end
-          noreply_response
         else
+          @logger.fatal("Unexpected error: '#{e.inspect}'")
           error_response(:server, "Invalid request: #{rpc.inspect}")
         end
       end

data/lib/rack/bert_rpc/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class BertRpc
-    VERSION = "0.2.1"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-bert-rpc
 version: !ruby/object:Gem::Version 
+  hash: 19
   prerelease: false
   segments: 
   - 0
-  - 2
-  - 1
-  version: 0.2.1
+  - 3
+  - 0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Ryan Burrows
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-13 00:00:00 -07:00
+date: 2010-10-29 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: bert
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,38 +36,62 @@ dependencies:
   name: rack
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: bundler
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 23
         segments: 
+        - 1
         - 0
-        version: "0"
+        - 0
+        version: 1.0.0
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rack-test
+  name: rspec
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 13
+        segments: 
+        - 2
+        - 0
+        - 1
+        version: 2.0.1
+  type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: rack-test
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
   type: :development
-  version_requirements: *id004
+  version_requirements: *id005
 description: rack-bert-rpc is rack middleware that provides a BERT-RPC server implemenation for using BERT-RPC over HTTP
 email: rhburrows@gmail.com
 executables: []
@@ -93,16 +120,20 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 23
       segments: 
       - 1
       - 3
@@ -111,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Rack middleware BERT-RPC server