rack-attack 5.4.1 → 5.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21f1ecf9854b74958cacdb31211735c29b9a2f98f1ee848e0f60a3f409651cc6
-  data.tar.gz: 934f2ac2af420277f6d31052b56af24d2cbe93412a272aa753c25ce26228d7b1
+  metadata.gz: e666812691cc414692f7125979f0b152a9111ccee075e65b811fa4a6d8770daa
+  data.tar.gz: 3e8caba79f7ad09d4999cce6358de9cc29b815dee3c9f9c5adbf12763c764656
 SHA512:
-  metadata.gz: 32f63613544602a11c8af12a5ac764adf44ba22beda1dc8840bfc5431a32edd8ea1075eab6933f423405e71959ed0c5b5f8668d72262c5fb4787f89105259f5a
-  data.tar.gz: aad3b2d1ace4369f2605d863df03c86d0e008c934c5f9c6741b71d2a3e363bcf37c93685e436ff48c917a512d39b8fd059fb3db09f38250c609f5fa22244cda4
+  metadata.gz: f630c0cd1a34bd588e616653a2e6795e2ec6baafc0e0df8b489e6aa451cf47fb64065447fb3ceb2b029a51d87a0393d6d44cea02e58423626ea46165531f7da3
+  data.tar.gz: 22efc414db06b0a1bbbf8e6d34a3e0d0ead64f1832f48dc30af7ec0a374ef215d53cacf0a8e95c842bff0af84df0939f27820e4668c739eb8db3c51ebba4088e

data/lib/rack/attack/cache.rb

@@ -71,7 +71,7 @@ module Rack
 
       def enforce_store_method_presence!(method_name)
         if !store.respond_to?(method_name)
-          raise Rack::Attack::MisconfiguredStoreError, "Store needs to respond to ##{method_name}"
+          raise Rack::Attack::MisconfiguredStoreError, "Configured store #{store.class.name} doesn't respond to ##{method_name} method"
         end
       end
     end

data/lib/rack/attack/store_proxy/redis_cache_store_proxy.rb

@@ -5,7 +5,7 @@ module Rack
     module StoreProxy
       class RedisCacheStoreProxy < SimpleDelegator
         def self.handle?(store)
-          defined?(::Redis) && defined?(::ActiveSupport::Cache::RedisCacheStore) && store.is_a?(::ActiveSupport::Cache::RedisCacheStore)
+          store.class.name == "ActiveSupport::Cache::RedisCacheStore"
         end
 
         def increment(name, amount = 1, options = {})

data/lib/rack/attack/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Attack
-    VERSION = '5.4.1'
+    VERSION = '5.4.2'
   end
 end

data/spec/acceptance/cache_store_config_for_allow2ban_spec.rb

@@ -1,4 +1,5 @@
 require_relative "../spec_helper"
+require "minitest/stub_const"
 
 describe "Cache store config when using allow2ban" do
   before do
@@ -16,7 +17,9 @@ describe "Cache store config when using allow2ban" do
   end
 
   it "gives semantic error if store is missing #read method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def write(key, value)
       end
 
@@ -24,17 +27,21 @@ describe "Cache store config when using allow2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/scarce-resource"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/scarce-resource"
+      end
     end
 
-    assert_equal "Store needs to respond to #read", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #read method", raised_exception.message
   end
 
   it "gives semantic error if store is missing #write method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def read(key)
       end
 
@@ -42,17 +49,21 @@ describe "Cache store config when using allow2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/scarce-resource"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/scarce-resource"
+      end
     end
 
-    assert_equal "Store needs to respond to #write", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #write method", raised_exception.message
   end
 
   it "gives semantic error if store is missing #increment method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def read(key)
       end
 
@@ -60,17 +71,19 @@ describe "Cache store config when using allow2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/scarce-resource"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/scarce-resource"
+      end
     end
 
-    assert_equal "Store needs to respond to #increment", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #increment method", raised_exception.message
   end
 
   it "works with any object that responds to #read, #write and #increment" do
-    basic_store_class = Class.new do
+    fake_store_class = Class.new do
       attr_accessor :backend
 
       def initialize
@@ -91,21 +104,23 @@ describe "Cache store config when using allow2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    get "/"
-    assert_equal 200, last_response.status
+      get "/"
+      assert_equal 200, last_response.status
 
-    get "/scarce-resource"
-    assert_equal 200, last_response.status
+      get "/scarce-resource"
+      assert_equal 200, last_response.status
 
-    get "/scarce-resource"
-    assert_equal 200, last_response.status
+      get "/scarce-resource"
+      assert_equal 200, last_response.status
 
-    get "/scarce-resource"
-    assert_equal 403, last_response.status
+      get "/scarce-resource"
+      assert_equal 403, last_response.status
 
-    get "/"
-    assert_equal 403, last_response.status
+      get "/"
+      assert_equal 403, last_response.status
+    end
   end
 end

data/spec/acceptance/cache_store_config_for_fail2ban_spec.rb

@@ -1,4 +1,5 @@
 require_relative "../spec_helper"
+require "minitest/stub_const"
 
 describe "Cache store config when using fail2ban" do
   before do
@@ -16,7 +17,9 @@ describe "Cache store config when using fail2ban" do
   end
 
   it "gives semantic error if store is missing #read method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def write(key, value)
       end
 
@@ -24,17 +27,21 @@ describe "Cache store config when using fail2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/private-place"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/private-place"
+      end
     end
 
-    assert_equal "Store needs to respond to #read", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #read method", raised_exception.message
   end
 
   it "gives semantic error if store is missing #write method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def read(key)
       end
 
@@ -42,17 +49,21 @@ describe "Cache store config when using fail2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/private-place"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/private-place"
+      end
     end
 
-    assert_equal "Store needs to respond to #write", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #write method", raised_exception.message
   end
 
   it "gives semantic error if store is missing #increment method" do
-    basic_store_class = Class.new do
+    raised_exception = nil
+
+    fake_store_class = Class.new do
       def read(key)
       end
 
@@ -60,17 +71,19 @@ describe "Cache store config when using fail2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Object.stub_const(:FakeStore, fake_store_class) do
+      Rack::Attack.cache.store = FakeStore.new
 
-    raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
-      get "/private-place"
+      raised_exception = assert_raises(Rack::Attack::MisconfiguredStoreError) do
+        get "/private-place"
+      end
     end
 
-    assert_equal "Store needs to respond to #increment", raised_exception.message
+    assert_equal "Configured store FakeStore doesn't respond to #increment method", raised_exception.message
   end
 
   it "works with any object that responds to #read, #write and #increment" do
-    basic_store_class = Class.new do
+    FakeStore = Class.new do
       attr_accessor :backend
 
       def initialize
@@ -91,7 +104,7 @@ describe "Cache store config when using fail2ban" do
       end
     end
 
-    Rack::Attack.cache.store = basic_store_class.new
+    Rack::Attack.cache.store = FakeStore.new
 
     get "/"
     assert_equal 200, last_response.status

data/spec/acceptance/stores/active_support_redis_cache_store_pooled_spec.rb

@@ -1,6 +1,6 @@
 require_relative "../../spec_helper"
 
-if defined?(::ConnectionPool) && defined?(::Redis) && defined?(::ActiveSupport::Cache::RedisCacheStore)
+if defined?(::ConnectionPool) && defined?(::Redis) && Gem::Version.new(::Redis::VERSION) >= Gem::Version.new("4") && defined?(::ActiveSupport::Cache::RedisCacheStore)
   require_relative "../../support/cache_store_helper"
   require "timecop"
 

data/spec/acceptance/stores/active_support_redis_cache_store_spec.rb

@@ -1,6 +1,6 @@
 require_relative "../../spec_helper"
 
-if defined?(::Redis) && defined?(::ActiveSupport::Cache::RedisCacheStore)
+if defined?(::Redis) && Gem::Version.new(::Redis::VERSION) >= Gem::Version.new("4") && defined?(::ActiveSupport::Cache::RedisCacheStore)
   require_relative "../../support/cache_store_helper"
   require "timecop"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-attack
 version: !ruby/object:Gem::Version
-  version: 5.4.1
+  version: 5.4.2
 platform: ruby
 authors:
 - Aaron Suggs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-29 00:00:00.000000000 Z
+date: 2018-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -276,7 +276,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Block & throttle abusive requests