rack-app 5.2.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10f50fab86de1a0048be77118f717f557c3fcfc9
-  data.tar.gz: 84ec803fcb8677e60b56ef0b7c1362f792f62e2e
+  metadata.gz: 56ff6cb0ae7c0fe3de38e1e76bd6003eb11d0455
+  data.tar.gz: b2c795ba758dfcd5f9206e65d6baafc33ee4eedc
 SHA512:
-  metadata.gz: 0ed0aeb5c5e1969ded36b657d28265f1b9d5cec2120d9277a5515ec0ab441154bbb1744d6f03de288ce853daa471fe5175bf9354a30f2daa1c4ae1f52c4cf8c5
-  data.tar.gz: 5548b69b220ba01de870451750cb624b0e94f4ce41fb5bdb92b8563ebde88095c7bb46a74d53f744491e1684a231e27233fb2d9e533c1ea906a3454e2b75522d
+  metadata.gz: 750db656ebbc3f12667decd66bbdeed4e1ac1c5b7c3a0e6ad98dead9e963e5a54396f98b9c200767c3e2e0e774bdeb9dd5b8a8fe5734deee6cf5d20a1a537a90
+  data.tar.gz: 5002bd81d4ff647d98db7e8d5287a1902f0dc68a5b6656783f54e892ccc8960d808e9f667061761a59c85fbb60a161a8096e5012d5720727915400857896b744

data/CONTRIBUTORS.md

@@ -8,3 +8,7 @@ Contributors
 * **[Daniel Szpisjak](https://github.com/felin-arch)**
 
   * Pimp up the website descriptions
+
+* **[Jeremy Evans](https://github.com/jeremyevans)**
+
+  * suggestion for application stand up speed optimization

data/README.md

@@ -1,7 +1,7 @@
-# [Rack::App](http://rack-app.com/) [![Build Status][travis-image]][travis-link]
+# [Rack::App](http://www.rack-app.com/) [![Build Status][travis-image]][travis-link]
 
 [travis-image]: https://travis-ci.org/rack-app/rack-app.svg?branch=master
-[travis-link]: http://travis-ci.org/rack-app/rack-app
+[travis-link]: https://travis-ci.org/rack-app/rack-app
 [travis-home]: http://travis-ci.org/
 
 Your next favourite rack based micro framework that is totally addition free!
@@ -13,7 +13,7 @@ while able to write pure rack apps,
 that will do nothing more than what you defined.
 
 If you want see fancy magic, you are in a bad place buddy!
-This includes that it do not have such core extensions like activesupport that monkey patch the whole world.
+This also implies that the framework does not include extensions like ActiveSupport that monkey patch the whole world.
 
 Routing can handle any amount of endpoints that can fit in the memory,
 so if you that crazy to use more than 10k endpoint,
@@ -79,7 +79,7 @@ Yes, in fact it's already powering heroku hosted micro-services.
 * per endpoint middleware definitions
   * you can define middleware stack before endpoints and it will only applied to them, similar like protected method workflow
 * File Upload and file download in a efficient and elegant way with minimal memory consuming
-  * note that this is not only memory friendly way pure rack solution, but also 2x faster than the usualy solution which includes buffering in memory
+  * note that this is not only memory friendly way pure rack solution, but also 2x faster than the usually solution which includes buffering in memory
 * params validation with ease
 
 ## [Contributors](CONTRIBUTORS.md)
@@ -238,31 +238,39 @@ end
 
 ## [Benchmarking](https://github.com/rack-app/rack-app-benchmark)
 
+This is a repo that used for measure Rack::App project speed in order keep an eye on the performance in every release.
+
 the benchmarking was taken on the following hardware specification:
 * Processor: 2,7 GHz Intel Core i5
 * Memory: 16 GB 1867 MHz DDR3
-* Ruby: ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin15.0]
+* Ruby: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]
+
+
+### Endpoint to be call type: static
 
-### number of declared endpoints: 100
+
+#### number of declared endpoints: 100
 
 | name                   | version                | current / fastest      | real                   |
 | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
-| rack                   | 1.6.4                  | 1.0                    | 1.6942083333336455e-06 |
-| rack-app               | 3.5.2                  | 11.809                 | 2.0007499999999815e-05 |
-| rack-app               | 3.0.0.beta             | 12.323                 | 2.0877181818182224e-05 |
-| rack-app               | 3.0.0.gamma            | 12.683                 | 2.1487657142862254e-05 |
-| rack-app               | 0.23.0                 | 12.807                 | 2.169760000000045e-05  |
-| ramaze                 | 2012.12.08             | 24.125                 | 4.0872166666666577e-05 |
-| hobbit                 | 0.6.1                  | 40.55                  | 6.869933333333199e-05  |
-| brooklyn               | 0.0.1                  | 71.783                 | 0.00012161592857141858 |
-| nyny                   | 3.4.3                  | 77.255                 | 0.00013088600000000554 |
-| nancy                  | 0.3.0                  | 88.364                 | 0.00014970783333331968 |
-| scorched               | 0.25                   | 178.187                | 0.0003018852500000387  |
-| sinatra                | 1.4.7                  | 185.683                | 0.00031458616666666577 |
-| rails                  | 4.2.5.1                | 444.237                | 0.0007526308333333871  |
-| camping                | 2.1.532                | 553.434                | 0.0009376332499999672  |
-| grape                  | 0.14.0                 | 555.51                 | 0.0009411502499998971  |
-| cuba                   | 3.5.0                  | 786.805                | 0.0013330109166665822  |
+| rack-app               | 4.0.0                  | 1.0                    | 2.2053215187043942e-05 |
+| rack-app               | 5.2.0                  | 1.185                  | 2.6140331494390213e-05 |
+| rack-app               | 5.0.0.rc3              | 1.387                  | 3.0592694940592784e-05 |
+| ramaze                 | 2012.12.08             | 1.468                  | 3.236885466806858e-05  |
+| hobbit                 | 0.6.1                  | 2.996                  | 6.607205038890137e-05  |
+| brooklyn               | 0.0.1                  | 5.243                  | 0.00011562206838279088 |
+| nyny                   | 3.4.3                  | 5.272                  | 0.00011626420279498706 |
+| plezi                  | 0.14.1                 | 5.334                  | 0.00011763589749898317 |
+| nancy                  | 0.3.0                  | 5.649                  | 0.00012458588462322884 |
+| roda                   | 2.17.0                 | 10.646                 | 0.00023477471132838754 |
+| scorched               | 0.25                   | 12.728                 | 0.0002807019599946191  |
+| sinatra                | 1.4.7                  | 21.169                 | 0.0004668393424013356  |
+| grape                  | 0.17.0                 | 25.941                 | 0.0005720832234016178  |
+| rails                  | 5.0.0                  | 33.234                 | 0.0007329187002032537  |
+| camping                | 2.1.532                | 39.699                 | 0.0008754866444039887  |
+| cuba                   | 3.8.0                  | 54.196                 | 0.001195195165998367   |
+| almost-sinatra         | unknown                | 58.613                 | 0.0012926107780076503  |
+
 
 For more reports check the Benchmark repo out :)
 
@@ -280,7 +288,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/adamluzsi/rack-app.rb This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/rack-app/rack-app This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
 
 ## License and Copyright
 

data/VERSION

@@ -1 +1 @@
-5.2.0
+5.3.0

data/lib/rack/app/endpoint.rb

@@ -1,49 +1,33 @@
-require "rack/builder"
 class Rack::App::Endpoint
-  require "rack/app/endpoint/properties"
+
+  require "forwardable"
+  extend Forwardable
+  def_delegators :@config, :request_method, :request_path, :description
+
+  require "rack/app/endpoint/config"
+  require "rack/app/endpoint/builder"
   require "rack/app/endpoint/executor"
 
-  def properties
-    @properties.to_hash
-  end
+  attr_reader :config
 
   def initialize(properties)
-    @properties = Rack::App::Endpoint::Properties.new(properties)
-  end
-
-  def call(env)
-    to_app.call(env)
+    @config = Rack::App::Endpoint::Config.new(properties)
   end
 
-  def to_app
-    builder = Rack::Builder.new
-    apply_middleware_build_blocks(builder)
-    @properties.endpoint_method_name
-    builder.run(Rack::App::Endpoint::Executor.new(@properties))
-    builder.to_app
+  def fork(differences_in_properties)
+    self.class.new(self.properties.merge(differences_in_properties))
   end
 
-  protected
-
-  def apply_middleware_build_blocks(builder)
-    builder_blocks.each do |builder_block|
-      builder_block.call(builder)
-    end
-    builder.use(Rack::App::Middlewares::Configuration, @properties.to_hash)
-    apply_hook_middlewares(builder)
+  def properties
+    @config.to_hash
   end
 
-  def apply_hook_middlewares(builder)
-    @properties.app_class.before.each do |before_block|
-      builder.use(Rack::App::Middlewares::Hooks::Before, before_block)
-    end
-    @properties.app_class.after.each do |after_block|
-      builder.use(Rack::App::Middlewares::Hooks::After, after_block)
-    end
+  def call(env)
+    to_app.call(env)
   end
 
-  def builder_blocks
-    @properties.app_class.middlewares + @properties.middleware_builders_blocks
+  def to_app
+    @config.application || self.class::Builder.new(@config).build
   end
 
 end

data/lib/rack/app/endpoint/builder.rb

@@ -0,0 +1,39 @@
+require "rack/builder"
+class Rack::App::Endpoint::Builder
+
+  def initialize(config)
+    @config = config
+  end
+
+  def build
+    builder = Rack::Builder.new
+    apply_middleware_build_blocks(builder)
+    @config.endpoint_method_name
+    builder.run(Rack::App::Endpoint::Executor.new(@config))
+    builder.to_app
+  end
+
+  protected
+
+  def apply_middleware_build_blocks(builder)
+    builder_blocks.each do |builder_block|
+      builder_block.call(builder)
+    end
+    builder.use(Rack::App::Middlewares::Configuration, @config.to_hash)
+    apply_hook_middlewares(builder)
+  end
+
+  def apply_hook_middlewares(builder)
+    @config.app_class.before.each do |before_block|
+      builder.use(Rack::App::Middlewares::Hooks::Before, before_block)
+    end
+    @config.app_class.after.each do |after_block|
+      builder.use(Rack::App::Middlewares::Hooks::After, after_block)
+    end
+  end
+
+  def builder_blocks
+    @config.app_class.middlewares + @config.middleware_builders_blocks
+  end
+
+end

data/lib/rack/app/endpoint/{properties.rb → config.rb}

@@ -1,14 +1,18 @@
-class Rack::App::Endpoint::Properties
+class Rack::App::Endpoint::Config
 
   def to_hash
-    app_class
     serializer
     error_handler
     middleware_builders_blocks
-    endpoint_method_name
+    request_path
+    request_method
     return @raw
   end
 
+  def application
+    @raw[:application]
+  end
+
   def app_class
     @raw[:app_class] || raise('missing app class')
   end
@@ -29,6 +33,18 @@ class Rack::App::Endpoint::Properties
     @raw[:method_name] ||= register_method_to_app_class
   end
 
+  def request_method
+    (@raw[:request_method] || raise('missing request_method!')).to_s.upcase
+  end
+
+  def request_path
+    Rack::App::Utils.normalize_path(@raw[:request_path] || raise('missing request_path!'))
+  end
+
+  def description
+    @raw[:route][:description] || @raw[:route][:desc] rescue nil
+  end
+
   protected
 
   def initialize(raw)

data/lib/rack/app/file_server.rb

@@ -35,4 +35,4 @@ class Rack::App::FileServer
     ::Rack::Utils.clean_path_info(path_info)
   end
 
-end
+end

data/lib/rack/app/router.rb

@@ -17,43 +17,38 @@ class Rack::App::Router
 
     endpoints = self.endpoints
 
-    wd0 = endpoints.map { |endpoint| endpoint[:request_method].to_s.length }.max
-    wd1 = endpoints.map { |endpoint| endpoint[:request_path].to_s.length }.max
-    wd2 = endpoints.map { |endpoint| extract_description(endpoint).to_s.length }.max
+    wd0 = endpoints.map { |endpoint| endpoint.request_method.to_s.length }.max
+    wd1 = endpoints.map { |endpoint| endpoint.request_path.to_s.length }.max
+    wd2 = endpoints.map { |endpoint| endpoint.description.to_s.length }.max
 
-    return endpoints.sort_by { |endpoint| [endpoint[:request_method], endpoint[:request_path]] }.map do |endpoint|
+    return endpoints.sort_by { |endpoint| [endpoint.request_method, endpoint.request_path] }.map do |endpoint|
       [
-          endpoint[:request_method].to_s.ljust(wd0),
-          endpoint[:request_path].to_s.ljust(wd1),
-          extract_description(endpoint).to_s.ljust(wd2)
+          endpoint.request_method.to_s.ljust(wd0),
+          endpoint.request_path.to_s.ljust(wd1),
+          endpoint.description.to_s.ljust(wd2)
       ].join('   ')
     end
 
   end
 
-  def register_endpoint!(request_method, request_path, endpoint, properties)
-    router = router_for(request_path)
-    router.register_endpoint!(request_method, request_path, endpoint, properties)
+  def register_endpoint!(endpoint)
+    router = router_for(endpoint.request_path)
+    router.register_endpoint!(endpoint)
   end
 
   def merge_router!(router, prop={})
     raise(ArgumentError, 'invalid router object, must implement :endpoints interface') unless router.respond_to?(:endpoints)
     router.endpoints.each do |endpoint|
-      request_path = ::Rack::App::Utils.join(prop[:namespaces], endpoint[:request_path])
-
-      register_endpoint!(
-          endpoint[:request_method],
-          request_path,
-          endpoint[:endpoint],
-          endpoint[:properties]
-      )
+      new_request_path = ::Rack::App::Utils.join(prop[:namespaces], endpoint.request_path)
+      new_endpoint = endpoint.fork(:request_path => new_request_path)
+      register_endpoint!(new_endpoint)
     end
     nil
   end
 
   def reset
     [@static, @dynamic].each(&:reset)
-  end 
+  end
 
   protected
 
@@ -74,9 +69,4 @@ class Rack::App::Router
         path_str.include?(Rack::App::Constants::RACK_BASED_APPLICATION)
   end
 
-  def extract_description(endpoint_struct)
-    if endpoint_struct[:properties]
-      endpoint_struct[:properties][:description]
-    end
-  end
 end

data/lib/rack/app/router/base.rb

@@ -16,18 +16,9 @@ class Rack::App::Router::Base
     @endpoints ||= []
   end
 
-  def register_endpoint!(request_method, request_path, endpoint, properties={})
-    normalized_request_path = Rack::App::Utils.normalize_path(request_path)
-    endpoints.push(
-        {
-            :request_method => request_method,
-            :request_path => normalized_request_path,
-            :endpoint => endpoint,
-            :properties => properties
-        }
-    )
-
-    compile_endpoint!(request_method, normalized_request_path, endpoint)
+  def register_endpoint!(endpoint)
+    endpoints.push(endpoint)
+    compile_endpoint!(endpoint)
     return endpoint
   end
 
@@ -38,7 +29,7 @@ class Rack::App::Router::Base
 
   protected
 
-  def compile_endpoint!(request_method, request_path, endpoint)
+  def compile_endpoint!(endpoint)
     raise(NotImplementedError)
   end
 

data/lib/rack/app/router/dynamic.rb

@@ -38,12 +38,15 @@ class Rack::App::Router::Dynamic < Rack::App::Router::Base
   end
 
   def compile_registered_endpoints!
-    endpoints.each do |endpoint_prop|
-      compile_endpoint!(endpoint_prop[:request_method], endpoint_prop[:request_path], endpoint_prop[:endpoint])
+    endpoints.each do |endpoint|
+      compile_endpoint!(endpoint)
     end
   end
 
-  def compile_endpoint!(request_method, request_path, endpoint)
+  def compile_endpoint!(endpoint)
+    request_method = endpoint.request_method
+    request_path = endpoint.request_path
+
     clusters_for(request_method) do |current_cluster|
 
       break_build = false

data/lib/rack/app/router/static.rb

@@ -15,13 +15,14 @@ class Rack::App::Router::Static < Rack::App::Router::Base
     mapped_endpoint_routes.clear
   end
 
-  def compile_endpoint!(request_method, request_path, endpoint)
-    mapped_endpoint_routes[[request_method.to_s.upcase, request_path]]= as_app(endpoint)
+  def compile_endpoint!(endpoint)
+    routing_key = [endpoint.request_method, endpoint.request_path]
+    mapped_endpoint_routes[routing_key]= as_app(endpoint)
   end
 
   def compile_registered_endpoints!
     endpoints.each do |endpoint|
-      compile_endpoint!(endpoint[:request_method],endpoint[:request_path], endpoint[:endpoint])
+      compile_endpoint!(endpoint)
     end
   end
 

data/lib/rack/app/serializer.rb

@@ -2,12 +2,8 @@ class Rack::App::Serializer
 
   attr_reader :logic
 
-  def initialize
-    @logic = lambda { |o| o.to_s }
-  end
-
-  def set_serialization_logic(proc)
-    @logic = proc
+  def initialize(&block)
+    @logic = block || lambda { |o| o.to_s }
   end
 
   def serialize(object)

data/lib/rack/app/singleton_methods/http_methods.rb

@@ -33,7 +33,7 @@ module Rack::App::SingletonMethods::HttpMethods
   def link(path = '/', &block)
     add_route(::Rack::App::Constants::HTTP::METHOD::LINK, path, &block)
   end
-  
+
   def unlink(path = '/', &block)
     add_route(::Rack::App::Constants::HTTP::METHOD::UNLINK, path, &block)
   end
@@ -46,11 +46,9 @@ module Rack::App::SingletonMethods::HttpMethods
     new_request_path = Rack::App::Utils.normalize_path(new_request_path)
     original_request_path = Rack::App::Utils.normalize_path(original_request_path)
 
-    router.endpoints.select { |ep| ep[:request_path] == original_request_path }.each do |endpoint|
-      router.register_endpoint!(
-        endpoint[:request_method], new_request_path,
-        endpoint[:endpoint], endpoint[:properties]
-      )
+    router.endpoints.select { |ep| ep.request_path == original_request_path }.each do |endpoint|
+      new_endpoint = endpoint.fork(:request_path => new_request_path)
+      router.register_endpoint!(new_endpoint)
     end
   end
 

data/lib/rack/app/singleton_methods/middleware.rb

@@ -17,10 +17,18 @@ module Rack::App::SingletonMethods::Middleware
 
   protected
 
-  def only_next_endpoint_middlewares(&block)
-    @only_next_endpoint_middlewares ||= []
-    @only_next_endpoint_middlewares << block unless block.nil?
-    @only_next_endpoint_middlewares
+  def next_endpoint_middlewares(&block)
+    @next_endpoint_middlewares ||= []
+    @next_endpoint_middlewares << block unless block.nil?
+    @next_endpoint_middlewares
   end
 
+  alias only_next_endpoint_middlewares next_endpoint_middlewares
+
+  Rack::App::Utils.deprecate(self,
+    :only_next_endpoint_middlewares,
+    :next_endpoint_middlewares,
+    2016,9
+  )
+
 end

data/lib/rack/app/singleton_methods/mounting.rb

@@ -2,6 +2,17 @@ module Rack::App::SingletonMethods::Mounting
   MOUNT = Rack::App::SingletonMethods::Mounting
 
   def mount(app, options={})
+    case
+    when app.is_a?(Class) && app < ::Rack::App
+      mount_rack_app(app, options)
+    when app.respond_to?(:call)
+      mount_rack_interface_compatible_application(app, options)
+    else
+      raise(NotImplementedError)
+    end
+  end
+
+  def mount_rack_app(app, options={})
     options.freeze
 
     unless app.is_a?(Class) and app <= Rack::App
@@ -35,23 +46,45 @@ module Rack::App::SingletonMethods::Mounting
   end
 
   alias create_endpoints_for_files_in mount_directory
+  Rack::App::Utils.deprecate(self,:create_endpoints_for_files_in, :mount_directory, 2016,9)
 
   def serve_files_from(file_path, options={})
     file_server = Rack::App::FileServer.new(Rack::App::Utils.expand_path(file_path))
     request_path = Rack::App::Utils.join(@namespaces, options[:to], '**', '*')
-    router.register_endpoint!('GET', request_path, file_server, route_registration_properties)
+
+    endpoint = Rack::App::Endpoint.new(
+      route_registration_properties.merge(
+        :request_method => 'GET',
+        :request_path => request_path,
+        :application => file_server
+      )
+    )
+
+    router.register_endpoint!(endpoint)
+    route_registration_properties.clear
+    nil
   end
 
-  def mount_rack_based_application(rack_based_app, options={})
+  def mount_rack_interface_compatible_application(rack_based_app, options={})
     router.register_endpoint!(
-      ::Rack::App::Constants::HTTP::METHOD::ANY,
-      Rack::App::Utils.join(@namespaces, options[:to], ::Rack::App::Constants::RACK_BASED_APPLICATION),
-      rack_based_app,
-      route_registration_properties
+      Rack::App::Endpoint.new(
+        route_registration_properties.merge(
+          :request_method => ::Rack::App::Constants::HTTP::METHOD::ANY,
+          :request_path => Rack::App::Utils.join(
+            @namespaces,
+            options[:to],
+            ::Rack::App::Constants::RACK_BASED_APPLICATION
+          ),
+          :application => rack_based_app
+        )
+      )
     )
   end
 
-  alias mount_app mount_rack_based_application
+  alias mount_rack_based_application mount_rack_interface_compatible_application
+  Rack::App::Utils.deprecate(self,:mount_rack_based_application, "mount or mount_rack_interface_compatible_application", 2016,9)
+  alias mount_app mount_rack_interface_compatible_application
+  Rack::App::Utils.deprecate(self,:mount_app, "mount or mount_rack_interface_compatible_application", 2016,9)
 
   protected
 

data/lib/rack/app/singleton_methods/params_validator.rb

@@ -2,7 +2,7 @@ module Rack::App::SingletonMethods::ParamsValidator
   def validate_params(&block)
     descriptor = Rack::App::Middlewares::Params::Definition.new(&block).to_descriptor
     route_registration_properties[:params]= descriptor
-    only_next_endpoint_middlewares do |builder|
+    next_endpoint_middlewares do |builder|
       builder.use(Rack::App::Middlewares::Params::Setter)
       builder.use(Rack::App::Middlewares::Params::Validator, descriptor)
       builder.use(Rack::App::Middlewares::Params::Parser, descriptor)

data/lib/rack/app/singleton_methods/route_handling.rb

@@ -22,24 +22,22 @@ module Rack::App::SingletonMethods::RouteHandling
 
   def add_route(request_method, request_path, &block)
 
-    request_path = ::Rack::App::Utils.join(@namespaces, request_path)
-
-    properties = {
-        :user_defined_logic => block,
-        :request_method => request_method,
-        :request_path => request_path,
+    router.register_endpoint!(
+      Rack::App::Endpoint.new({
+        :app_class => self,
         :error_handler => error,
         :serializer => serializer,
-        :middleware_builders_blocks => only_next_endpoint_middlewares.dup,
-        :app_class => self
-    }
-
-    only_next_endpoint_middlewares.clear
-
-    endpoint = Rack::App::Endpoint.new(properties)
-    router.register_endpoint!(request_method, request_path, endpoint, route_registration_properties)
-    @route_registration_properties = nil
-    return endpoint
+        :user_defined_logic => block,
+        :request_method => request_method,
+        :route => route_registration_properties.dup,
+        :middleware_builders_blocks => next_endpoint_middlewares.dup,
+        :request_path => ::Rack::App::Utils.join(@namespaces, request_path)
+      })
+    )
+
+    next_endpoint_middlewares.clear
+    route_registration_properties.clear
+    return nil
 
   end
 

data/lib/rack/app/singleton_methods/settings.rb

@@ -10,11 +10,7 @@ module Rack::App::SingletonMethods::Settings
 
   def serializer(&definition_how_to_serialize)
     @serializer ||= Rack::App::Serializer.new
-
-    unless definition_how_to_serialize.nil?
-      @serializer.set_serialization_logic(definition_how_to_serialize)
-    end
-
+    @serializer = Rack::App::Serializer.new(&definition_how_to_serialize) unless definition_how_to_serialize.nil?
     return @serializer
   end
 

data/lib/rack/app/utils.rb

@@ -129,4 +129,27 @@ module Rack::App::Utils
     CGI.escape(str.to_s)
   end
 
+  ##
+  # Simple deprecation method that deprecates +name+ by wrapping it up
+  # in a dummy method. It warns on each call to the dummy method
+  # telling the user of +repl+ (unless +repl+ is :none) and the
+  # year/month that it is planned to go away.
+  def deprecate(object, name, repl, year, month)
+    object.class_eval {
+      old = "_deprecated_#{name}"
+      alias_method old, name
+      define_method name do |*args, &block|
+        klass = self.kind_of? Module
+        target = klass ? "#{self}." : "#{self.class}#"
+        msg = [ "NOTE: #{target}#{name} is deprecated",
+          repl == :none ? " with no replacement" : "; use #{repl} instead",
+          ". It will be removed on or after %4d-%02d-01." % [year, month],
+          "\n#{target}#{name} called from #{Gem.location_of_caller.join(":")}",
+        ]
+        warn "#{msg.join}."
+        __send__(old, *args, &block)
+      end
+    }
+  end
+
 end

data/spec_files.txt

@@ -1 +1 @@
-./spec/benchmark_spec.rb ./spec/rack/app/alias_endpoint_spec.rb ./spec/rack/app/bundled_extensions/logger_spec.rb ./spec/rack/app/cli_spec.rb ./spec/rack/app/endpoint_spec.rb ./spec/rack/app/extension_spec.rb ./spec/rack/app/file_server_spec.rb ./spec/rack/app/hooks_spec.rb ./spec/rack/app/inheritance_spec.rb ./spec/rack/app/instance_methods_spec.rb ./spec/rack/app/middlewares/header_setter_spec.rb ./spec/rack/app/mounting_spec.rb ./spec/rack/app/not_found_spec.rb ./spec/rack/app/only_next_endpoint_middlewares_spec.rb ./spec/rack/app/params_validation_spec/with_real_class_spec.rb ./spec/rack/app/params_validation_spec.rb ./spec/rack/app/redirect_spec.rb ./spec/rack/app/request_configurator_spec.rb ./spec/rack/app/router/dynamic_spec.rb ./spec/rack/app/router/static_spec.rb ./spec/rack/app/router_spec.rb ./spec/rack/app/streaming_spec.rb ./spec/rack/app/test_spec.rb ./spec/rack/app/utils/deep_dup_spec.rb ./spec/rack/app/utils/parser_spec.rb ./spec/rack/app/utils_spec.rb ./spec/rack/app_spec.rb
+./spec/benchmark_spec.rb ./spec/rack/app/alias_endpoint_spec.rb ./spec/rack/app/bundled_extensions/logger_spec.rb ./spec/rack/app/cli_spec.rb ./spec/rack/app/endpoint_spec.rb ./spec/rack/app/extension_spec.rb ./spec/rack/app/file_server_spec.rb ./spec/rack/app/hooks_spec.rb ./spec/rack/app/inheritance_spec.rb ./spec/rack/app/instance_methods_spec.rb ./spec/rack/app/middlewares/header_setter_spec.rb ./spec/rack/app/mounting_spec.rb ./spec/rack/app/not_found_spec.rb ./spec/rack/app/next_endpoint_middlewares_spec.rb ./spec/rack/app/params_validation_spec/with_real_class_spec.rb ./spec/rack/app/params_validation_spec.rb ./spec/rack/app/redirect_spec.rb ./spec/rack/app/request_configurator_spec.rb ./spec/rack/app/router/dynamic_spec.rb ./spec/rack/app/router/static_spec.rb ./spec/rack/app/router_spec.rb ./spec/rack/app/streaming_spec.rb ./spec/rack/app/test_spec.rb ./spec/rack/app/utils/deep_dup_spec.rb ./spec/rack/app/utils/parser_spec.rb ./spec/rack/app/utils_spec.rb ./spec/rack/app_spec.rb

data/spike/method_vs_hash.rb

@@ -0,0 +1,78 @@
+require 'benchmark'
+
+VALUE = 'OK'
+class A
+  attr_accessor :value
+end
+
+class B
+  def value=(new_value)
+    @value = new_value
+  end
+  def value
+    @value
+  end
+end
+
+class C
+  attr_reader :value
+  def value=(new_value)
+    @value = new_value
+  end
+end
+
+a = A.new
+a.value= VALUE
+
+b = B.new
+b.value= VALUE
+
+c = C.new
+c.value= VALUE
+
+o = Object.new
+o.define_singleton_method(:value){ VALUE }
+
+h = {:value => VALUE}
+
+TEST_AMOUNT = 10_000_000
+
+Benchmark.bm(30) do |x|
+
+  x.report('attr_accessor') do
+    TEST_AMOUNT.times do
+      a.value
+    end
+  end
+
+  x.report('defined + instance var') do
+    TEST_AMOUNT.times do
+      b.value
+    end
+  end
+
+  x.report('defined setter + attr_reader') do
+    TEST_AMOUNT.times do
+      c.value
+    end
+  end
+
+  x.report('attr_reader + __send__') do
+    TEST_AMOUNT.times do
+      c.__send__(:value)
+    end
+  end
+
+  x.report('anonimus method call') do
+    TEST_AMOUNT.times do
+      o.value
+    end
+  end
+
+  x.report('hash getter') do
+    TEST_AMOUNT.times do
+      h[:value]
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-app
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.0
 platform: ruby
 authors:
 - Adam Luzsi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-30 00:00:00.000000000 Z
+date: 2016-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,8 +106,9 @@ files:
 - lib/rack/app/cli/runner.rb
 - lib/rack/app/constants.rb
 - lib/rack/app/endpoint.rb
+- lib/rack/app/endpoint/builder.rb
+- lib/rack/app/endpoint/config.rb
 - lib/rack/app/endpoint/executor.rb
-- lib/rack/app/endpoint/properties.rb
 - lib/rack/app/error_handler.rb
 - lib/rack/app/extension.rb
 - lib/rack/app/file_server.rb
@@ -175,6 +176,7 @@ files:
 - spec_files.txt
 - spike/array_vs_proc.rb
 - spike/long_endpoint.rb
+- spike/method_vs_hash.rb
 - spike/method_vs_instance_exec.rb
 - spike/return_vs_throw.rb
 - src/Net__HTTP Cheat Sheet.pdf