rack-action 0.0.1 → 0.1.0

data/.gitignore

@@ -15,3 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+log/*.log
+*.swp

data/lib/rack/action.rb

@@ -2,6 +2,7 @@ require 'time'
 require 'json'
 require 'rack'
 require 'rack/filters'
+require 'rack/version'
 
 module Rack
   # Rack::Action provides functionality to generate a Rack response.
@@ -104,10 +105,12 @@ module Rack
     extend Filters
 
     # @private
-    RACK_ROUTE_PARAMS = 'route.route_params'.freeze
+    RACK_ROUTE_PARAMS = 'rack.route_params'.freeze
     # @private
     CONTENT_TYPE = 'Content-Type'.freeze
     # @private
+    TEXT_HTML = 'text/html'.freeze
+    # @private
     APPLICATION_JSON = 'application/json'.freeze
     # @private
     LOCATION = 'Location'.freeze
@@ -117,7 +120,7 @@ module Rack
     # This implements the Rack interface
     #
     # @param [Hash] env The Rack environment
-    # @return [Rack::Response] A Rack response
+    # @return [Array<Numeric, Hash, #each>] A Rack response
     def self.call(env)
       new(env).call
     end
@@ -137,11 +140,14 @@ module Rack
     end
 
     def params
-      @params ||= request.params.merge(env[RACK_ROUTE_PARAMS] || {})
+      @params ||= begin
+        p = request.params.merge(env[RACK_ROUTE_PARAMS] || {})
+        p.respond_to?(:with_indifferent_access) ? p.with_indifferent_access : p
+      end
     end
 
     # This is the main method responsible for generating a Rack response.
-    # You typically won't need to override this method of call it directly.
+    # You typically won't need to override this method or call it directly.
     # First this will run the before filters for this action.
     # If none of the before filters generate a response, this will call
     # {#respond} to generate a response.
@@ -150,6 +156,8 @@ module Rack
     #
     # @return [Array<Numeric, Hash, #each>] A Rack response
     def call
+      log_call
+      set_default_headers
       run_before_filters
       run_respond
       run_after_filters
@@ -195,11 +203,30 @@ module Rack
     def redirect_to(url, options={})
       full_url = absolute_url(url, options)
       response[LOCATION] = full_url
-      response.status = 302
-      response.write ''
+      respond_with 302
       full_url
     end
 
+    # Convenience method to return a 404
+    def not_found
+      respond_with 404
+    end
+
+    # Convenience method to return a 403
+    def forbidden
+      respond_with 403
+    end
+
+    # This is a convenience method to set the response code and
+    # set the response so that it stops respond process.
+    #
+    # @param [Fixnum] status_code The HTTP status code to use in the response
+    def respond_with(status_code)
+      response.status = status_code
+      response.write ''
+      nil
+    end
+
     # Generate an absolute url from the url.  If the url is already
     # an absolute url, this will return it unchanged.
     #
@@ -217,10 +244,26 @@ module Rack
     end
 
     protected
+    def log_call
+      if logger
+        logger.debug do
+          "#{self.class} #{request.env["REQUEST_METHOD"]} params: #{params.inspect}"
+        end
+      end
+    end
+
+    def set_default_headers
+      response[CONTENT_TYPE] = TEXT_HTML
+    end
+
     def run_before_filters
       self.class.before_filters.each do |filter|
+        logger.debug "Running #{filter} before filter" if logger
         send(filter)
-        return unless response.empty?
+        unless response.empty?
+          logger.debug "#{filter} responded, halting filter chain" if logger
+          return
+        end
       end
     end
 
@@ -236,6 +279,7 @@ module Rack
 
     def run_after_filters
       self.class.after_filters.each do |filter|
+        logger.debug "Running #{filter} after filter" if logger
         send(filter)
       end
     end
@@ -244,6 +288,22 @@ module Rack
       response.finish
     end
 
+    def logger
+      self.class.logger
+    end
+
+    def self.logger
+      if defined? @logger
+        @logger
+      else
+        @logger = superclass.logger if superclass.respond_to?(:logger)
+      end
+    end
+
+    def self.logger=(logger)
+      @logger = logger
+    end
+
     # @private
     class URL
       HTTPS = 'https'.freeze

data/lib/rack/version.rb

@@ -0,0 +1,5 @@
+module Rack
+  class Action
+    VERSION = '0.1.0'
+  end
+end

data/rack-action.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "rack-action"
   gem.require_paths = ["lib"]
-  gem.version       = "0.0.1"
+  gem.version       = "0.1.0"
 
   gem.add_runtime_dependency "rack"
 end

data/test/rack/action_test.rb

@@ -7,7 +7,6 @@ class Rack::ActionTest < RackTest
     app = Class.new(Rack::Action)
 
     response = get app, "/"
-
     assert_equal 200, response.status
     assert_equal Rack::Action::DEFAULT_RESPONSE.length, response.length
     assert_equal 'text/html', response["Content-Type"]

data/test/rack_test.rb

@@ -1,5 +1,15 @@
 require 'test/unit'
 require 'stringio'
+require 'logger'
+require 'fileutils'
+
+if ENV['RACK_ACTION_TEST_LOGGER'].to_s.downcase == 'stdout'
+  Rack::Action.logger = Logger.new(STDOUT)
+elsif ENV['RACK_ACTION_TEST_LOGGER']
+  log_file = File.expand_path(ENV['RACK_ACTION_TEST_LOGGER'])
+  FileUtils.mkdir_p File.dirname(log_file)
+  Rack::Action.logger = Logger.new(log_file)
+end
 
 class RackTest < Test::Unit::TestCase
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-action
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-03 00:00:00.000000000 Z
+date: 2013-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -45,6 +45,7 @@ files:
 - lib/rack-action.rb
 - lib/rack/action.rb
 - lib/rack/filters.rb
+- lib/rack/version.rb
 - lib/rack_action.rb
 - rack-action.gemspec
 - test/rack/action_test.rb
@@ -69,7 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: a small, simple framework for generating Rack responses