rabbitmq_client 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2b060865b600b3377cbb16799ecdc82fedbd874b8b9f158c58a57604925c7b8
-  data.tar.gz: 211d0b536583982f7248a188daab96c77ec2a37765f840bdf85b4dfb9bf27930
+  metadata.gz: f1ef09ac95da0ede5b1635fc2c1317f972e41c72868badb5ec79c9b3848d1b7d
+  data.tar.gz: c2798f711e2995e47b9e46649b04c730a2e7541769b9526498c1087771f6c2e3
 SHA512:
-  metadata.gz: 7ca283805742bb671e6f43818ba3c9ad4f2ad8587f708c1d41fd472ccfaefa6e50f8d615feffeb4699a7a5f1b8957ebe5eda770f77229cab60a8283c066640b5
-  data.tar.gz: 5431a7e2bfe7a6ef70ab1bdcdb9e79069178b1071f09a481c656c431d7e7174291efbf4861d6e4ee35fc7cfc6d0d3620e1fff7a188b5d83a6bc3c3765cbb2224
+  metadata.gz: 7df0e4e90fcf1ae255822730a5162209a69374a12f643e8ac9f0ea0d524f48ad797cdf3132e604bc816bf2a2590fdc77ece185c05a0b80e293501ed62e20312d
+  data.tar.gz: b5f09649b1a0c4937418bc19d61befe0b60bc74ddef757a684ffd0b14cf22901112b1602ab79badc886205365c7d9288e08a4e8ada68c18a12d7c4113ecfaf87

data/.overcommit.yml

@@ -31,3 +31,5 @@
 #
 #  IndexTags:
 #    enabled: true # Generate a tags file with `ctags` each time HEAD changes
+
+

data/.reek.yml

@@ -13,6 +13,8 @@ detectors:
       - "RabbitmqClient::Plugin#callback_block"
   UtilityFunction:
     exclude:
+      - 'RabbitmqClient::PublisherJob#notify'
+      - 'RabbitmqClient::PublisherJob#handle_publish_event'
       - 'RabbitmqClient::Publisher#notify'
       - 'LogSubscriberBase#logger'
       - 'RabbitmqClient::JsonLogSubscriber'

data/README.md

@@ -127,7 +127,7 @@ end
 ## <a name="plugins"></a> Plugins
 RabbitmqClient plugins are classes that define a callbacks that can be executed before or after events that occuers during RabbitmqClient lifecycle.
 Current supprted lifecycle events are:
-  - publish: occure when publisgin a massage is triggered.
+  - publish: occure when publishing a massage is triggered.
 
 Here is an example where we define a plugin to add some headers to message options before publishing the message.
 

data/lib/rabbitmq_client/publisher.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'message_publisher'
+require_relative 'publisher_job'
 
 module RabbitmqClient
   # Publisher class is responsible for publishing events to rabbitmq exhanges
@@ -17,14 +17,21 @@ module RabbitmqClient
     def publish(data, options)
       return nil unless @exchange_registry
 
-      handle_publish_event(data, options)
-    rescue StandardError => e
-      notify('network_error', error: e, options: options)
-      raise
+      if async
+        PublisherJob.perform_async(@exchange_registry,
+                                   @session_pool, data, options)
+      else
+        PublisherJob.new.perform(@exchange_registry,
+                                 @session_pool, data, options)
+      end
     end
 
     private
 
+    def async
+      @config.dig(:session_params, :async_publisher) || false
+    end
+
     def overwritten_config_notification
       return unless overwritten_config?
 
@@ -48,19 +55,6 @@ module RabbitmqClient
                     ) || 0)
     end
 
-    def handle_publish_event(data, options)
-      exchange = @exchange_registry.find(options.fetch(:exchange_name, nil))
-      @session_pool.with do |session|
-        session.start
-        channel = session.create_channel
-        channel.confirm_select
-        message = MessagePublisher.new(data, exchange, channel, options)
-        message.publish
-        message.wait_for_confirms
-        channel.close
-      end
-    end
-
     def create_connection_pool
       pool_size = @session_params.fetch(:session_pool, 1)
       ConnectionPool.new(size: pool_size) do

data/lib/rabbitmq_client/publisher_job.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require_relative 'message_publisher'
+require 'sucker_punch'
+
+module RabbitmqClient
+  # Publisher class is responsible for publishing events to rabbitmq exhanges
+  class PublisherJob
+    include SuckerPunch::Job
+
+    def perform(registry, session_pool, data, options)
+      handle_publish_event(registry, session_pool, data, options)
+    rescue StandardError => e
+      notify('network_error', error: e, options: options)
+      raise
+    end
+
+    private
+
+    def handle_publish_event(registry, session_pool, data, options)
+      exchange = registry.find(options.fetch(:exchange_name, nil))
+      session_pool.with do |session|
+        session.start
+        channel = session.create_channel
+        channel.confirm_select
+        message = MessagePublisher.new(data, exchange, channel, options)
+        message.publish
+        message.wait_for_confirms
+        channel.close
+      end
+    end
+
+    def notify(event, payload = {})
+      ActiveSupport::Notifications.instrument(
+        "#{event}.rabbitmq_client",
+        payload
+      )
+    end
+  end
+end

data/lib/rabbitmq_client/version.rb

@@ -2,5 +2,5 @@
 
 # :nodoc:
 module RabbitmqClient
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/rabbitmq_client.rb

@@ -53,6 +53,7 @@ module RabbitmqClient
   config_accessor(:session_params, instance_accessor: false) do
     {
       heartbeat_publisher: 0,
+      async_publisher: true,
       session_pool: 1
     }
   end

data/rabbitmq_client.gemspec

@@ -18,9 +18,10 @@ Gem::Specification.new do |spec|
   spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   spec.metadata['homepage_uri'] = spec.homepage
 
-  spec.add_runtime_dependency 'activesupport', '~> 6.0.0'
-  spec.add_runtime_dependency 'bunny', '~> 2.14.3'
+  spec.add_runtime_dependency 'activesupport', '> 5.0.0'
+  spec.add_runtime_dependency 'bunny', '>= 2.7.4'
   spec.add_runtime_dependency 'connection_pool', '~> 2.2.2'
+  spec.add_runtime_dependency 'sucker_punch', '~> 2.0'
 
   spec.add_development_dependency 'bundler', '~> 1.17.2'
   spec.add_development_dependency 'byebug', '~> 11.0.1'

data/spec/publisher_spec.rb

@@ -126,6 +126,30 @@ describe RabbitmqClient::Publisher do
       end
     end
 
+    context 'when async is enabled' do
+      let(:exchange_registry) { RabbitmqClient::ExchangeRegistry.new }
+      let(:publisher) do
+        described_class.new(exchange_registry: exchange_registry,
+                            session_params: { async_publisher: true })
+      end
+      let(:type) { 'test' }
+      let(:options) { {} }
+
+      before do
+        exchange_registry.add(exchange_name, type, options)
+        allow(RabbitmqClient::PublisherJob).to receive(:perform_async)
+      end
+
+      it 'defines exchange' do
+        publisher.publish('message',
+                          message_id: 'abc',
+                          exchange_name: exchange_name)
+        expect(
+          RabbitmqClient::PublisherJob
+        ).to have_received(:perform_async)
+      end
+    end
+
     context 'when error raised' do
       let(:error) { StandardError.new('network_error') }
       let(:exchange_registry) { double('exchange_registry') }

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: rabbitmq_client
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Al-waleed shihadeh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2020-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: bunny
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.3
+        version: 2.7.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.3
+        version: 2.7.4
 - !ruby/object:Gem::Dependency
   name: connection_pool
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.2.2
+- !ruby/object:Gem::Dependency
+  name: sucker_punch
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -257,6 +271,7 @@ files:
 - lib/rabbitmq_client/plain_log_subscriber.rb
 - lib/rabbitmq_client/plugin.rb
 - lib/rabbitmq_client/publisher.rb
+- lib/rabbitmq_client/publisher_job.rb
 - lib/rabbitmq_client/tags_filter.rb
 - lib/rabbitmq_client/text_formatter.rb
 - lib/rabbitmq_client/version.rb