rabarber 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b3ce45aa7325a095c750691a8633e323a57a987b2c4e4f45902726ce0d30458
-  data.tar.gz: 66be6c782c564ef658a405ec94c2ada4b46915820a0b9ac5afcfbf0a5bbcedd8
+  metadata.gz: f83c97e518621ea7749eab381d5e1e4f84785c8197036e923220fa0d29fcc43e
+  data.tar.gz: 9fe75afecf6c3066c0cbf779ffdf79a2e67716a8acdc0f15c72e85008528f5ab
 SHA512:
-  metadata.gz: bb12a4ed60e610cb9875243bb87d78ba0e0ab0713507d1967485e16b57fbe7856cbfcf855878b37c75827d02f81fa7baa8cd2f299020bb24dc621fa44aeaf902
-  data.tar.gz: 3e65bde49df87b1656eab0b92b8da9cd5fd5975e725911026d8ada08b95eedf912aea4dffb0aa39ba1319979ed4cbb90ff234c66a32b91bbd3c3cda224867e64
+  metadata.gz: 407ed9c374cbe8dafd964aa939f342d47a307bd101e2932bf8ae12c526f48a75524df6eb6f6f35a6a3fb4a023f7db5e50a7c04b580f56fde06ccfcc09f431df8
+  data.tar.gz: 4cfcde7d7b6ed23faff8d0e6f8f036c641ecf6dfb18e1b075dbdfd6aaa5f8391dfdf13ea7e25b70b7881489fc3b292791f663c6c70b1a32a634e7caf681a2355

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.0.3
+
+- Enhance clarity by improving error types and messages
+- Resolve inconsistency in types of role names
+
 ## 1.0.2
 
 - Various enhancements for gem development and release

data/README.md

@@ -7,7 +7,7 @@ Rabarber is an authorization library for Ruby on Rails, primarily designed for u
 
 ---
 
-#### Example of Usage:
+**Example of Usage**:
 
 Consider a CRM where users with different roles have distinct access levels. For instance, the role 'accountant' can interact with invoices but cannot access marketing information, while the role 'marketer' has access to marketing-related data. Such authorization rules can be easily defined with Rabarber.
 
@@ -78,7 +78,7 @@ end
 - `must_have_roles` must be a boolean determining whether a user with no roles can access endpoints permitted to everyone. The default value is `false` (allowing users without roles to access endpoints permitted to everyone).
 - `when_unauthorized` must be a lambda where you can define your actions when access is not authorized (`controller` is an instance of the controller where the code is executed). By default, the user is redirected back if the request format is HTML; otherwise, a 401 Unauthorized response is sent.
 
-## Usage
+## Roles
 
 Include `Rabarber::HasRoles` module in your model representing users in your application:
 
@@ -89,9 +89,9 @@ class User < ApplicationRecord
 end
 ```
 
-### This adds the following methods:
+This adds the following methods:
 
-#### `#assign_roles`
+**`#assign_roles`**
 
 To assign roles to the user, use:
 
@@ -110,7 +110,7 @@ Rabarber::Role.create(name: "manager")
 ```
 The role names are unique.
 
-#### `#revoke_roles`
+**`#revoke_roles`**
 
 To revoke roles, use:
 
@@ -119,7 +119,7 @@ user.revoke_roles(:accountant, :marketer)
 ```
 If any of the specified roles doesn't exist or the user doesn't have the role you want to revoke, it will be ignored.
 
-#### `#has_role?`
+**`#has_role?`**
 
 To check whether the user has a role, use:
 
@@ -129,7 +129,7 @@ user.has_role?(:accountant, :marketer)
 
 It returns `true` if the user has at least one role and `false` otherwise.
 
-#### `#roles`
+**`#roles`**
 
 To view all the roles assigned to the user, use:
 
@@ -147,9 +147,7 @@ Rabarber::Role.names
 
 Utilize the aforementioned methods to manipulate user roles. For example, create a custom UI for managing roles or assign necessary roles during migration or runtime (e.g., when the user is created). You can also write custom authorization policies based on `#has_role?` method (e.g., to scope the data that the user can access). Adapt these methods to fit the requirements of your application.
 
----
-
-### Authorization Rules
+## Authorization Rules
 
 Include `Rabarber::Authorization` module into the controller that needs authorization rules to be applied (authorization rules will be applied to the controller and its children). Typically, it is `ApplicationController`, but it can be any controller.
 
@@ -159,7 +157,7 @@ class ApplicationController < ActionController::Base
   ...
 end
 ```
-This adds `.grant_access` method to the controller and its children. This method allows you to define the authorization rules.
+This adds `.grant_access` method which allows you to define the authorization rules.
 
 The most basic usage of the method is as follows:
 
@@ -260,9 +258,7 @@ end
 ```
 This means that `Crm::InvoicesController` is still accessible to `admin` but is also accessible to `accountant`.
 
----
-
-### View Helpers
+## View Helpers
 
 Rabarber also provides a couple of helpers that can be used in views: `visible_to` and `hidden_from`. The usage is straightforward:
 

data/lib/rabarber/configuration.rb

@@ -21,21 +21,19 @@ module Rabarber
     end
 
     def current_user_method=(method_name)
-      unless [Symbol, String].include?(method_name.class)
-        raise ArgumentError, "Method name must be a symbol or a string"
-      end
+      raise ConfigurationError, "current_user_method must be a symbol" unless method_name.is_a?(Symbol)
 
       @current_user_method = method_name.to_sym
     end
 
     def must_have_roles=(value)
-      raise ArgumentError, "Value must be a boolean" unless [true, false].include?(value)
+      raise ConfigurationError, "must_have_roles must be a boolean" unless [true, false].include?(value)
 
       @must_have_roles = value
     end
 
     def when_unauthorized=(callable)
-      raise ArgumentError, "Proc is expected" unless callable.is_a?(Proc)
+      raise ConfigurationError, "when_unauthorized must be a proc" unless callable.is_a?(Proc)
 
       @when_unauthorized = callable
     end

data/lib/rabarber/models/concerns/has_roles.rb

@@ -41,13 +41,11 @@ module Rabarber
     private
 
     def validate_role_names(role_names)
-      return if role_names.all? do |role_name|
-        [Symbol, String].include?(role_name.class) && role_name.match?(/\A[a-z0-9_]+\z/)
-      end
+      return if role_names.all? { |role_name| role_name.is_a?(Symbol) && role_name.to_s.match?(Role::NAME_REGEX) }
 
       raise(
-        ArgumentError,
-        "Role names must be symbols or strings and may only contain lowercase letters and underscores"
+        InvalidArgumentError,
+        "Role names must be symbols and may only contain lowercase letters, numbers and underscores"
       )
     end
 

data/lib/rabarber/models/role.rb

@@ -4,7 +4,9 @@ module Rabarber
   class Role < ActiveRecord::Base
     self.table_name = "rabarber_roles"
 
-    validates :name, presence: true, uniqueness: true
+    NAME_REGEX = /\A[a-z0-9_]+\z/
+
+    validates :name, presence: true, uniqueness: true, format: { with: NAME_REGEX }
 
     def self.names
       pluck(:name).map(&:to_sym)

data/lib/rabarber/rule.rb

@@ -5,9 +5,9 @@ module Rabarber
     attr_reader :action, :roles, :custom
 
     def initialize(action, roles, custom)
-      @action = action
-      @roles = Array(roles)
-      @custom = custom
+      @action = validate_action(action)
+      @roles = validate_roles(roles)
+      @custom = validate_custom_rule(custom)
     end
 
     def verify_access(user_roles, custom_rule_receiver, action_name = nil)
@@ -37,5 +37,30 @@ module Rabarber
         custom_rule_receiver.send(custom)
       end
     end
+
+    def validate_action(action)
+      return action if action.nil? || action.is_a?(Symbol)
+
+      raise InvalidArgumentError, "Action name must be a symbol"
+    end
+
+    def validate_roles(roles)
+      roles_array = Array(roles)
+
+      return roles_array if roles_array.empty? || roles_array.all? do |role|
+        role.is_a?(Symbol) && role.match?(Role::NAME_REGEX)
+      end
+
+      raise(
+        InvalidArgumentError,
+        "Role names must be symbols and may only contain lowercase letters, numbers and underscores"
+      )
+    end
+
+    def validate_custom_rule(custom)
+      return custom if custom.nil? || custom.is_a?(Symbol) || custom.is_a?(Proc)
+
+      raise InvalidArgumentError, "Custom rule must be a symbol or a proc"
+    end
   end
 end

data/lib/rabarber/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rabarber
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/lib/rabarber.rb

@@ -23,4 +23,6 @@ module Rabarber
   end
 
   class Error < StandardError; end
+  class ConfigurationError < Error; end
+  class InvalidArgumentError < Error; end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rabarber
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - enjaku4