quo_vadis 2.1.7 → 2.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2f5586e06a0e01dd89d66bf9cae01317b0d302ba51e5a82cfcb4bc00dc0ea85
-  data.tar.gz: f37f34fbae6ab23081643aff844525b4ca8795c9e5057cbce737e7348d6a254f
+  metadata.gz: d11498bfa66e0397304c2d9a0f8ac504037f97beac4fd039fe6c8d0299696531
+  data.tar.gz: 2d1e267c7b55740c72087e297960ff6ececb1caee45a17eb588bf7e44ba64d31
 SHA512:
-  metadata.gz: de242f63f325f1520fb9fb209535a4dfcff1c6f3f2e80d6620bce3e940c1000d5452145e83b6917e9106deb844aa4f467be922880c92bbb357da2dcb6bbf563b
-  data.tar.gz: d706a441437cab9af6ee75f3581cc18df8edfd17414317555eecd58a1c984f7cc62a085297158fb5a42f9d244bcfdbde98bd6792220434a6118e32f801c0241e
+  metadata.gz: e4e7c7bb2996556b35b153c56916aef9834dcac2abea08ede8becc14e030d8f4ea1444f9286c1ca9b728c1a13c16d8d9b2e701255d57b769c7dc9abefa84a976
+  data.tar.gz: f466404a5ba44bfd506cbcd2fdc7b2f2d142ecab419363e3c368bb5eca67cfc78829afa698b8b0dc1cc76210b531a32a44c3bfdcd1ae709cf9eafe740861f089

data/CHANGELOG.md

@@ -4,6 +4,12 @@
 ## HEAD
 
 
+## 2.1.8 (18 June 2022)
+
+* Extract convenience method for has authentication account.
+* Only authenticating models react to email change.
+
+
 ## 2.1.7 (30 May 2022)
 
 * Use SHA256 digest for encryption.

data/README.md

@@ -1,6 +1,6 @@
 # Quo Vadis
 
-Multifactor authentication for your Rails 6 app.
+Multifactor authentication for your Rails 6 or Rails 7 app.
 
 Designed in accordance with the [OWASP Application Security Verification Standard](https://owasp.org/www-project-application-security-verification-standard/) and relevant [OWASP Cheatsheets](https://cheatsheetseries.owasp.org).
 
@@ -537,6 +537,6 @@ If you don't want a specific flash message at all, give the key an empty value i
 
 ## Intellectual Property
 
-Copyright 2011-2021 Andrew Stewart (boss@airbladesoftware.com).
+Copyright 2011-2022 Andrew Stewart (boss@airbladesoftware.com).
 
 Released under the MIT licence.

data/lib/quo_vadis/model.rb

@@ -14,7 +14,7 @@ module QuoVadis
 
         has_one :qv_account, as: :model, class_name: 'QuoVadis::Account', dependent: :destroy, autosave: true
 
-        before_validation :qv_copy_identifier_to_account, if: Proc.new { |m| m.qv_account }
+        before_validation :qv_copy_identifier_to_account, if: :has_authentication_account?
 
         validate :qv_copy_password_errors, if: Proc.new { |m| m.qv_account&.password }
 
@@ -29,8 +29,8 @@ module QuoVadis
           qv_account.identifier = send identifier
         end
 
-        after_update :qv_log_email_change, if: :saved_change_to_email?
-        after_update :qv_notify_email_change, if: :saved_change_to_email?
+        after_update :qv_log_email_change,    if: [:has_authentication_account?, :saved_change_to_email?]
+        after_update :qv_notify_email_change, if: [:has_authentication_account?, :saved_change_to_email?]
 
         QuoVadis.register_model self.name, identifier
       end
@@ -57,6 +57,10 @@ module QuoVadis
         qv_account.revoke
       end
 
+      def has_authentication_account?
+        !!qv_account
+      end
+
       private
 
       def qv_copy_password_errors

data/lib/quo_vadis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module QuoVadis
-  VERSION = '2.1.7'
+  VERSION = '2.1.8'
 end

data/test/models/model_test.rb

@@ -66,4 +66,14 @@ class ModelTest < ActiveSupport::TestCase
       u.update email: 'robert@example.com'
     end
   end
+
+
+  test 'does not notify or log on email change when no account' do
+    u = User.create! name: 'bob', email: 'bob@example.com'
+    assert_no_difference 'QuoVadis::Log.count' do
+      assert_no_enqueued_emails do
+        u.update email: 'robert@example.com'
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quo_vadis
 version: !ruby/object:Gem::Version
-  version: 2.1.7
+  version: 2.1.8
 platform: ruby
 authors:
 - Andy Stewart
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-30 00:00:00.000000000 Z
+date: 2022-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails