quiet_quality 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3084fe3f419db403944af870a9ccc39cccfe046f9f01841f52872808cd38b186
-  data.tar.gz: bc3b18bd54ec79e6adf72c9947142050cd0a14a329d665f58290fe40b3382b27
+  metadata.gz: f411385dc4547ecadf2e182ca8628a5f95973c43c7340314293b76489b5a5b5a
+  data.tar.gz: e414999cb5645c7d64fbcb8b52d02cae9b12be5ec8ea02ae640f2dbd434a5db2
 SHA512:
-  metadata.gz: 761966c658f578970e2d420d194d8d81a71e2d8808f95c8862366656a88e2ee3bf10e1ec8907ac21f4b4e62d799cd923ea481c7bbbd856da8a9b5c8656c3cf1e
-  data.tar.gz: 2a91a00a403943d7a6051dc788dae5d2a963740cfd6d543228d8dbc810a5efd2ac5bdc0d8fc9c5f6c799e97c0c81742fd17543a43b184b86e4be117365146a0c
+  metadata.gz: de6977b310cc518f46e81ca7404a3913419226c8723faa2554f52aa974759fbe572eab4486b29afe96880d8d5d80a4bc466b14ee85e8a51e2da52a46f2a335c1
+  data.tar.gz: 5bacf59ca7abd7004e2910f47e0cfc5fb5e4c8145faa6154b95d308ad73a0cc74a465b8a8a962b0471e4a417de09a486d11aea23f39972399633754c70be0bac

data/.gitignore

@@ -4,3 +4,4 @@ Gemfile.lock
 *.gem
 coverage/
 tmp/*
+.DS_Store

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Release 1.5.2
+
+* Support command/exec-command overrides (yaml-only) (#127)
+* Support ruby-git 2.x (#130 resolves #129)
+
 ## Release 1.5.1
 
 * Refactor ConfigParser to just parse the config into ParsedOptions, separating

data/lib/quiet_quality/config/builder.rb

@@ -129,13 +129,15 @@ module QuietQuality
           options.tools.each do |tool_options|
             update_tool_option(tool_options, :limit_targets)
             update_tool_option(tool_options, :filter_messages)
+            update_tool_option(tool_options, :command, global: false)
+            update_tool_option(tool_options, :exec_command, global: false)
             set_unless_nil(tool_options, :file_filter, build_file_filter(tool_options.tool_name))
           end
         end
 
-        def update_tool_option(tool_options, option_name)
+        def update_tool_option(tool_options, option_name, global: true)
           tool_name = tool_options.tool_name
-          set_unless_nil(tool_options, option_name, apply.global_option(option_name))
+          set_unless_nil(tool_options, option_name, apply.global_option(option_name)) if global
           set_unless_nil(tool_options, option_name, apply.tool_option(tool_name, option_name))
         end
 

data/lib/quiet_quality/config/parsed_options.rb

@@ -22,7 +22,9 @@ module QuietQuality
         :limit_targets,
         :filter_messages,
         :file_filter,
-        :excludes
+        :excludes,
+        :command,
+        :exec_command
       ].to_set
 
       def initialize

data/lib/quiet_quality/config/parser.rb

@@ -67,6 +67,8 @@ module QuietQuality
         read_tool_option(opts, tool_name, :all_files, :limit_targets, as: :reversed_boolean)
         read_tool_option(opts, tool_name, :file_filter, :file_filter, as: :string)
         read_tool_option(opts, tool_name, :excludes, :excludes, as: :strings)
+        read_tool_option(opts, tool_name, :command, :command, as: :strings)
+        read_tool_option(opts, tool_name, :exec_command, :exec_command, as: :strings)
       end
 
       def invalid!(message)

data/lib/quiet_quality/config/tool_options.rb

@@ -1,14 +1,16 @@
 module QuietQuality
   module Config
     class ToolOptions
-      def initialize(tool, limit_targets: true, filter_messages: true, file_filter: nil)
+      def initialize(tool, **options)
         @tool_name = tool.to_sym
-        @limit_targets = limit_targets
-        @filter_messages = filter_messages
-        @file_filter = file_filter
+        @limit_targets = options.fetch(:limit_targets, true)
+        @filter_messages = options.fetch(:filter_messages, true)
+        @file_filter = options.fetch(:file_filter, nil)
+        @command = options.fetch(:command, nil)
+        @exec_command = options.fetch(:exec_command, nil)
       end
 
-      attr_accessor :file_filter
+      attr_accessor :file_filter, :command, :exec_command
       attr_reader :tool_name
       attr_writer :limit_targets, :filter_messages
 
@@ -38,6 +40,8 @@ module QuietQuality
           limit_targets: limit_targets?,
           filter_messages: filter_messages?,
           file_filter: file_filter&.regex&.to_s,
+          command: command,
+          exec_command: exec_command,
           excludes: file_filter&.excludes&.map(&:to_s)
         }
       end

data/lib/quiet_quality/executors/execcer.rb

@@ -32,7 +32,9 @@ module QuietQuality
       def runner
         @_runner ||= tool_options.runner_class.new(
           changed_files: limit_targets? ? changed_files : nil,
-          file_filter: tool_options.file_filter
+          file_filter: tool_options.file_filter,
+          command_override: tool_options.command,
+          exec_override: tool_options.exec_command
         ).tap { |r| log_runner(r) }
       end
 

data/lib/quiet_quality/executors/pipeline.rb

@@ -49,7 +49,9 @@ module QuietQuality
       def runner
         @_runner ||= tool_options.runner_class.new(
           changed_files: limit_targets? ? changed_files : nil,
-          file_filter: tool_options.file_filter
+          file_filter: tool_options.file_filter,
+          command_override: tool_options.command,
+          exec_override: tool_options.exec_command
         ).tap { |r| log_runner(r) }
       end
 

data/lib/quiet_quality/tools/base_runner.rb

@@ -6,9 +6,11 @@ module QuietQuality
       # In general, we don't want to supply a huge number of arguments to a command-line tool.
       MAX_FILES = 100
 
-      def initialize(changed_files: nil, file_filter: nil)
+      def initialize(changed_files: nil, file_filter: nil, command_override: nil, exec_override: nil)
         @changed_files = changed_files
         @file_filter = file_filter
+        @command_override = command_override
+        @exec_override = exec_override
       end
 
       def invoke!
@@ -38,7 +40,7 @@ module QuietQuality
 
       private
 
-      attr_reader :changed_files, :file_filter
+      attr_reader :changed_files, :file_filter, :command_override, :exec_override
 
       def performed_outcome
         out, err, stat = Open3.capture3(*command)

data/lib/quiet_quality/tools/brakeman/runner.rb

@@ -7,11 +7,11 @@ module QuietQuality
         end
 
         def command
-          ["brakeman", "-f", "json"]
+          command_override || ["brakeman", "-f", "json"]
         end
 
         def exec_command
-          ["brakeman"]
+          exec_override || ["brakeman"]
         end
 
         # These are specified in constants at the top of brakeman.rb:

data/lib/quiet_quality/tools/markdown_lint/runner.rb

@@ -12,22 +12,27 @@ module QuietQuality
 
         def command(json: true)
           return nil if skip_execution?
-          base_command = ["mdl"]
-          base_command << "--json" if json
-          if target_files.any?
-            base_command + target_files.sort
-          else
-            base_command + ["."]
-          end
+          (command_override || ["mdl", "--json"]) + command_targets
         end
 
         def exec_command
-          command(json: false)
+          return nil if skip_execution?
+          (exec_override || ["mdl"]) + command_targets
         end
 
         def relevant_path?(path)
           path.end_with?(".md")
         end
+
+        private
+
+        def command_targets
+          if target_files.any?
+            target_files.sort
+          else
+            ["."]
+          end
+        end
       end
     end
   end

data/lib/quiet_quality/tools/relevant_runner.rb

@@ -13,12 +13,12 @@ module QuietQuality
 
       def command
         return nil if skip_execution?
-        base_command + target_files.sort
+        (command_override || base_command) + target_files.sort
       end
 
       def exec_command
         return nil if skip_execution?
-        base_exec_command + target_files.sort
+        (exec_override || base_exec_command) + target_files.sort
       end
 
       def relevant_path?(path)

data/lib/quiet_quality/version.rb

@@ -1,3 +1,3 @@
 module QuietQuality
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

data/quiet_quality.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
       .map { |path| path.sub(/^bin\//, "") }
   end
 
-  spec.add_dependency "git", "~> 1.18"
+  spec.add_dependency "git", ">= 1.18"
   spec.add_dependency "git_diff_parser", "~> 4"
 
   spec.add_development_dependency "rspec", "~> 3.13"

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: quiet_quality
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Eric Mueller
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-07 00:00:00.000000000 Z
+date: 2024-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.18'
 - !ruby/object:Gem::Dependency