quiet_assets 1.0.2 → 1.0.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: e44be74dccbd0d599faeb9b311e2d885dc2163ca
+  data.tar.gz: 0215c97043b1873b08decd328aadd88f90118e71
+SHA512:
+  metadata.gz: 267186f8e3efebee49e416d496e4a28fec1f1825fa10f2846555755283c9d946d70be5c082167a4afe4ba1ed1c14cb59f8a4375e5ba69814063780f612839bc6
+  data.tar.gz: d743dd75ab70996be06e22c1b51bd91a3c6be8261d3917597c4030978855b40c3a5f2d95a64f139698df996b1a93e1c8fac4b3eaae54c1ce0fff630d40c2f99c

data/README.md

@@ -1,7 +1,7 @@
-# Quiet assets
+# Quiet Assets
 [![Continuous Integration status](https://secure.travis-ci.org/evrone/quiet_assets.png)](http://travis-ci.org/evrone/quiet_assets)
 
-Quiet assets turn off assets pipeline log, kind of:
+Quiet Assets turns off the Rails asset pipeline log. This means that it suppresses messages in your development log such as:
 
     Started GET "/assets/application.js?body=1" for 127.0.0.1 at 2012-02-13 13:24:04 +0400
     Served asset /application.js - 304 Not Modified (8ms)
@@ -10,18 +10,19 @@ Support Ruby on Rails >= 3.1
 
 ## Installation
 
-We recommend you to use it only for development.
-Add this line to development group in your Gemfile:
+It is recommended that this gem only be used for development.
+To install, add this line to development group in your Gemfile:
 
-    gem 'quiet_assets', :group => :development
+    gem 'quiet_assets', group: :development
 
-And then execute:
+Then, from the command line, run:
 
     $ bundle
 
 ## Usage
 
-Nothing to do, but if you want to temporarily turn on back assets' log just write:
+Simply installing Quiet Assets will suppress the log messages automatically. However, if you wish to temporarily re-enable the logging of the asset pipeline messages,
+place the following in your `config/application.rb` file:
 
     config.quiet_assets = false
 
@@ -32,4 +33,4 @@ Dual licensed under the MIT or GPL licenses:
 + http://www.opensource.org/licenses/mit-license.php
 + http://www.gnu.org/licenses/gpl.html
 
-Copyright © 2011-2012 Dmitry [@KODerFunk](https://github.com/KODerFunk) Karpunun, Dmitry [@route](https://github.com/route) Vorotilin / [Evrone.com](http://evrone.com)
+Copyright © 2011-2014 Dmitry [@KODerFunk](https://github.com/KODerFunk) Karpunun, Dmitry [@route](https://github.com/route) Vorotilin / [Evrone.com](http://evrone.com)

data/lib/quiet_assets.rb

@@ -1,3 +1,5 @@
+require 'logger'
+
 module QuietAssets
   class Engine < ::Rails::Engine
     # Set as true but user can override it
@@ -6,19 +8,22 @@ module QuietAssets
     initializer 'quiet_assets', :after => 'sprockets.environment' do |app|
       next unless app.config.quiet_assets
       # Parse PATH_INFO by assets prefix
-      ASSETS_PREFIX = "/#{app.config.assets.prefix[/\A\/?(.*?)\/?\z/, 1]}/"
+      ASSETS_PREFIX = %r[\A/{0,2}#{app.config.assets.prefix}]
+      KEY = 'quiet_assets.old_level'
       app.config.assets.logger = false
 
       # Just create an alias for call in middleware
       Rails::Rack::Logger.class_eval do
         def call_with_quiet_assets(env)
-          old_logger_level, level = Rails.logger.level, Logger::ERROR
-          # Increase log level because of messages that have a low level should not be displayed
-          Rails.logger.level = level if env['PATH_INFO'].start_with?(ASSETS_PREFIX)
-          call_without_quiet_assets(env)
-        ensure
-          # Return back
-          Rails.logger.level = old_logger_level
+          begin
+            if env['PATH_INFO'] =~ ASSETS_PREFIX
+              env[KEY] = Rails.logger.level
+              Rails.logger.level = Logger::ERROR
+            end
+            call_without_quiet_assets(env)
+          ensure
+            Rails.logger.level = env[KEY] if env[KEY]
+          end
         end
         alias_method_chain :call, :quiet_assets
       end

data/quiet_assets.gemspec

@@ -1,11 +1,12 @@
 Gem::Specification.new do |gem|
   gem.name          = 'quiet_assets'
-  gem.version       = '1.0.2'
+  gem.version       = '1.0.3'
   gem.authors       = ['Dmitry Karpunin', 'Dmitry Vorotilin']
   gem.email         = ['koderfunk@gmail.com', 'd.vorotilin@gmail.com']
   gem.homepage      = 'http://github.com/evrone/quiet_assets'
-  gem.description   = 'Quiet assets turn off rails assets log.'
-  gem.summary       = 'Turn off rails assets log.'
+  gem.description   = 'Quiet Assets turns off Rails asset pipeline log.'
+  gem.summary       = 'Turns off Rails asset pipeline log.'
+  gem.licenses      = ['MIT', 'GPL']
 
   gem.files         = %w(LICENSE README.md lib/quiet_assets.rb quiet_assets.gemspec)
   gem.require_paths = %w(lib)

data/test/test_quiet_assets.rb

@@ -67,12 +67,37 @@ class HelperTest < Test::Unit::TestCase
     assert_equal '', output.string
   end
 
+  def test_in_multi_thread_env
+    initialize! { config.quiet_assets = true }
+
+    th1 = Thread.new do
+      sleep 0.1
+      app.call request('/assets/picture')
+    end
+
+    th2 = Thread.new do
+      sleep 0.1
+      app.call request('/')
+    end
+
+    th3 = Thread.new do
+      sleep 0.1
+      app.call request('/assets/picture')
+    end
+
+    [th1, th2, th3].map { |i| i.join }
+
+    n = output.string.lines.select{|i| i.match(/Started GET "\/"/) }
+
+    assert_equal n.size, 1
+  end
+
   def test_assets_url_with_turned_off_option
     initialize! { config.quiet_assets = false }
 
     app.call request('/assets/picture')
 
-    assert_match /Started GET \"\/assets\/picture\" for  at/, output.string
+    assert_match(/Started GET \"\/assets\/picture\" for  at/, output.string)
   end
 
   def test_regular_url
@@ -80,6 +105,14 @@ class HelperTest < Test::Unit::TestCase
 
     app.call request('/')
 
-    assert_match /Started GET \"\/\" for  at/, output.string
+    assert_match(/Started GET \"\/\" for  at/, output.string)
+  end
+
+  def test_full_url_with_couple_slashes
+    initialize!
+
+    app.call request('http://some-url.com//assets/picture')
+
+    assert_equal '', output.string
   end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quiet_assets
 version: !ruby/object:Gem::Version
-  version: 1.0.2
-  prerelease: 
+  version: 1.0.3
 platform: ruby
 authors:
 - Dmitry Karpunin
@@ -10,63 +9,57 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-22 00:00:00.000000000 Z
+date: 2014-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Quiet assets turn off rails assets log.
+description: Quiet Assets turns off Rails asset pipeline log.
 email:
 - koderfunk@gmail.com
 - d.vorotilin@gmail.com
@@ -80,28 +73,29 @@ files:
 - quiet_assets.gemspec
 - test/test_quiet_assets.rb
 homepage: http://github.com/evrone/quiet_assets
-licenses: []
+licenses:
+- MIT
+- GPL
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.18
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
-summary: Turn off rails assets log.
+specification_version: 4
+summary: Turns off Rails asset pipeline log.
 test_files:
 - test/test_quiet_assets.rb