quickbooks-ruby-base 1.6.0 → 2.1.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZDViYzQyNTdmNDE1NGQ5MDNiYWI0NzAzZGZiZTA2YmZkZjRiZmI5YQ==
-  data.tar.gz: !binary |-
-    MWVjMmE3ODlmMDZhZWUyMzUyMWNjZDNjYjgyZDYzMjY4MGViY2RjYg==
+SHA256:
+  metadata.gz: 927a2ed1e8c6ac7e3afefb37316610a89ffd2371881a25271ff791fde7b3ade9
+  data.tar.gz: e3808bdc6326a0dd1107d22062980a46dc075ec797a204941d934cc51d2e59fd
 SHA512:
-  metadata.gz: !binary |-
-    MGFlMjgyNTI3OTk5MzMzYjBjMzVhNmRhZTZkM2EzNGZmNTZkOWMwYmQwYTUw
-    ZGM4OGY4ZjIzYjg4MjIwZmVlZDY3OWVlZWU1MmFiMWYzMTA4M2Y4NjEzMDA1
-    ZmJlZWE0NmJlMTYyYTRlZGE2NGU2NmMyNWFhNzhhOWQ0OTdiM2E=
-  data.tar.gz: !binary |-
-    NTc3NDI0NmUyNjkxZjM1MTA1ODE5OTdmNzQ3NzA0MzU1Nzc5MWVlZDAwYmQw
-    OTJiNWQ1YjEyNmYxMThkYjljY2U3MmVkY2FiZjBiZWUxMDEyM2I1ZTdhZDAw
-    ZDBlZTJhM2U5YTg2Nzg4N2E4NmQ0MDFiZTRhMGFhOWM0YTY4Njc=
+  metadata.gz: 10f3e7d96d370329214f5b3c654d5af071fd019bd4d55d919f9c079b89d6dc219b99f8c1b793190861ac6dd050bf7450369ad86c8843b161f7935d5463030a74
+  data.tar.gz: 0e70e56ba9783fe87e13a1347826a99b44e64ba252e2105e8bcf3dca90159d50e50091dfca4a7c3079f33342bf51c6bc1a7c324eb82951d2bc2ebd963666d06e

data/HISTORY.md

@@ -0,0 +1,4 @@
+## 2.0.0 (2020)
+
+* Update to latest quickbooks-ruby, Dropped OAuth1 support
+* quickbooks-ruby updated `id` to parse as string instead of Integer, respect that change

data/README.md

@@ -104,10 +104,10 @@ base = Quickbooks::Base.new(account)
 
 As the first argument, the `Quickbooks::Base` class expects a persistent object that holds OAuth connection information.
 
-For example, if an account's OAuth information is stored like this:
+For example, if an account's OAuth2 information is stored like this:
 ```
 account.qb_token
-account.qb_secret
+account.qb_refresh_token
 account.qb_company_id
 ```
 
@@ -127,7 +127,7 @@ $qb_oauth_consumer = OAuth::Consumer.new(QB_KEY, QB_SECRET, {
 
 Quickbooks::Base.configure do |c|
   c.persistent_token = 'qb_token'
-  c.persistent_secret = 'qb_secret'
+  c.persistent_refresh_token = 'qb_refresh_token'
   c.persistent_company_id = 'qb_company_id'
 end
 

data/lib/quickbooks/base.rb

@@ -33,7 +33,7 @@ module Quickbooks
     alias_method :qr_service, :quickbooks_ruby_service
 
     def oauth_client
-      @oauth_client ||= OAuth::AccessToken.new(Quickbooks::Base.oauth_consumer, token, secret)
+      @oauth_client ||= OAuth2::AccessToken.new(Quickbooks::Base.oauth_consumer, token, refresh_token: refresh_token)
     end
 
     def show(options = {})
@@ -74,8 +74,8 @@ module Quickbooks
       retrieve(:token)
     end
 
-    def secret
-      retrieve(:secret)
+    def refresh_token
+      retrieve(:refresh_token)
     end
 
     def company_id

data/lib/quickbooks/base/configuration.rb

@@ -13,7 +13,7 @@ module Quickbooks
         @oauth_consumer ||= $qb_oauth_consumer
       end
 
-      %w(token secret company_id).each do |type|
+      %w(token refresh_token company_id).each do |type|
         class_eval <<-eos
           def persistent_#{type}=(location)
             @persistent_#{type} = location

data/quickbooks-ruby-base.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'quickbooks-ruby-base'
-  spec.version       = '1.6.0'
+  spec.version       = '2.1.0'
   spec.authors       = ["Christian"]
   spec.email         = ["christian@minimul.com"]
   spec.summary       = %q{Base class to provide common methods for the quickbooks-ruby gem}
@@ -15,7 +15,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep %r{^spec/}
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'quickbooks-ruby'
+  spec.add_dependency 'quickbooks-ruby', ">= 1.0.3"
+  spec.add_dependency 'oauth2', '~>1.4'
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"

data/spec/quickbooks_ruby_base_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Quickbooks::Base do
   let(:account) { double }
-  let(:full_account) { account = double(settings: double( qb_token: 'tttttttttt', qb_secret: 'ssssssss', qb_company_id: '1234567')) }
+  let(:full_account) { account = double(settings: double( qb_token: 'tttttttttt', qb_refresh_token: 'ssssssss', qb_company_id: '1234567')) }
   let(:qr_base) { Quickbooks::Base.new(account) }
 
   describe ".quickbooks_ruby_namespace" do
@@ -78,7 +78,7 @@ describe Quickbooks::Base do
 
   describe ".retrieve" do
     after do
-     Quickbooks::Base.configure { |c| c.persistent_token = nil; c.persistent_secret = nil; c.persistent_company_id = nil }
+     Quickbooks::Base.configure { |c| c.persistent_token = nil; c.persistent_refresh_token = nil; c.persistent_company_id = nil }
     end
 
     it "should set the persistence token location" do
@@ -121,16 +121,16 @@ describe Quickbooks::Base do
       xml = read_fixture('invoice') 
       stub_response(xml)
       qr = Quickbooks::Base.new(full_account, :invoice)
-      result = qr.find_by_id(28)
-      expect(result.id).to eq 156
+      result = qr.find_by_id('28')
+      expect(result.id).to eq '156'
     end
 
     it 'grabs object from different entity' do
       xml = read_fixture('item_5') 
       stub_response(xml)
       qr = Quickbooks::Base.new(full_account)
-      result = qr.find_by_id(5, :item)
-      expect(result.id).to eq 5
+      result = qr.find_by_id('5', :item)
+      expect(result.id).to eq '5'
     end
   end
 
@@ -153,7 +153,7 @@ describe Quickbooks::Base do
       stub_response(xml)
       qr = Quickbooks::Base.new(full_account, :employee)
       result = qr.find_by_display_name("Emily Platt")
-      expect(result.first.id).to eq 55
+      expect(result.first.id).to eq '55'
     end
 
     it 'passing in the entity' do
@@ -161,7 +161,7 @@ describe Quickbooks::Base do
       stub_response(xml)
       qr = Quickbooks::Base.new(full_account)
       result = qr.find_by_display_name("Bill's Windsurf Shop", entity: :customer)
-      expect(result.first.id).to eq 2
+      expect(result.first.id).to eq '2'
     end
   end
 
@@ -170,7 +170,7 @@ describe Quickbooks::Base do
   end
 
   def stub_response(xml)
-    response = Struct.new(:plain_body, :code).new(xml, 200)
-    allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
+    response = Struct.new(:body, :status).new(xml, 200)
+    allow_any_instance_of(OAuth2::AccessToken).to receive(:get).and_return(response)
   end
 end

data/spec/spec_helper.rb

@@ -2,5 +2,14 @@ require 'quickbooks/base'
 require 'quickbooks-ruby'
 
 RSpec.configure do |c|
-  c.color_enabled = true
+  #config.failure_color = :magenta
+  #config.tty = true
+  c.color = true
 end
+
+$qb_oauth_consumer = OAuth2::Client.new("app_key", "app_secret", {
+    :site            => "https://appcenter.intuit.com/connect/oauth2",
+    :authorize_url   => "https://appcenter.intuit.com/connect/oauth2",
+    :token_url       => "https://oauth.platform.intuit.com/oauth2/v1/tokens/bearer",
+    :connection_opts => {}
+})

metadata

@@ -1,69 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: quickbooks-ruby-base
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Christian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-13 00:00:00.000000000 Z
+date: 2020-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: quickbooks-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.3
+- !ruby/object:Gem::Dependency
+  name: oauth2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: ''
@@ -73,8 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
+- HISTORY.md
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -104,17 +119,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.0.0
 signing_key: 
 specification_version: 4
 summary: Base class to provide common methods for the quickbooks-ruby gem