quickbooks-ruby-base 1.3.0 → 1.4.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTc3MTNmZDU5Yjc1N2U0ODM1YTI0NzI4ZGE2ZDc0ZTYwYTEzYmVjMA==
+    NDY0NmRjNzY3NWIzZmRlNTc3MTIzMGZkMjI2MmViZTI0MDJkMTMxOQ==
   data.tar.gz: !binary |-
-    YjhkMTZlYzMyNGVmYmMzODA2MGQ0ZDUzNjI0MWNmMmUyZDAyMzlhMw==
+    YzkzYzQ1NThjMDM3YWEyN2Q5OTYyOGE5NzM3NmRjZTlhY2FkOWEzZQ==
 SHA512:
   metadata.gz: !binary |-
-    NzkxNTRhMDUwMzRlN2E0Y2ViODdkYTlhY2JlYTlkZTJhNTcyYWYzYjlmMjIx
-    MWM1NDE5ODk4NmZiNTQ4ZGJiOWU4ZTA4NmUwYzcwNjQxZjFjNDc1ZTJjYWI4
-    Mzc5ODAyNGZlMTcyNWJhZmU3Y2M1MzI1ZGJkYmU3YmYwYjI1NTA=
+    MmY3MWM5NmQ2MzY0MGM1NmU4N2EzMWYzZjllNzcyNjIyODMzN2Q0MDM1OGFk
+    MTdiNjEzM2UzMDI0NWRlNTFlMTM2MTVhN2FiNzA0MWI0Y2VlZjM5OWI1NTMx
+    Yjc0NjI4OTY0ZGQ3NTNiMmEyZGEyMmEzNzcyOTZmM2NjYWQxNjQ=
   data.tar.gz: !binary |-
-    OTcwMmE1MTJhY2Y0NzcwNmIxMTA4YTI1Yjk0NmNhNDE3YzVhNjRjZjY1Nzdm
-    N2YwZTA2ZDg3ODljODE5ZGU0ZTI1MTA3YTlkNzZiNjE1ODEwMzVjYjlkNjhk
-    ZWE4OWRkODJjZDQzMDEyNWUyZGM2NWFmM2Q3YzBlMDYyMGViZDk=
+    NDdmOWFhYjAxZTFlMTk5N2QwYjU5MjE2YjA4YzIyMjVhOTk5NTgzNjY3Njli
+    NGUzNTc2MGFhYmYyZThkZjEwNDY0MjMxYzdlOTgwNDE2OGYzMGZjNzcyZTIz
+    YWVhMmJhNjY3NzZhNmY1MDJhNTU5NDQ1MDc3NmIzYWZmZWM3MjI=

data/README.md

@@ -85,7 +85,7 @@ Note: Leverages proper escaping via the [Quickbooks::Util::QueryBuilder](https:/
 base = Quickbooks::Base.new(account, :customer)
 >> base.find_by_display_name('Chuck Russell')
 # Generates a query based on the following SQL
-# "Select Id, DisplayName From Customer WHERE DisplayName = 'Chuck Russell' LIMIT 1"
+# "SELECT Id, DisplayName FROM Customer WHERE DisplayName = 'Chuck Russell'"
 ```
 
 ## Configuration

data/lib/quickbooks/base/finders.rb

@@ -13,8 +13,7 @@ module Quickbooks
       def sql_builder(where, options = {})
         options[:entity] ||= @entity
         options[:select] ||= '*'
-        options[:limit] ||= 1
-        "Select #{options[:select]} From #{options[:entity]} WHERE #{where} LIMIT #{options[:limit]}"
+        "SELECT #{options[:select]} FROM #{options[:entity]} WHERE #{where}"
       end
 
       def display_name_sql(display_name, options = {})

data/quickbooks-ruby-base.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'quickbooks-ruby-base'
-  spec.version       = '1.3.0'
+  spec.version       = '1.4.0'
   spec.authors       = ["Christian"]
   spec.email         = ["christian@minimul.com"]
   spec.summary       = %q{Base class to provide common methods for the quickbooks-ruby gem}

data/spec/quickbooks_ruby_base_spec.rb

@@ -121,13 +121,13 @@ describe Quickbooks::Base do
   describe ".display_name_sql" do
     it 'for basic usage' do
       qr = Quickbooks::Base.new(full_account, :customer)
-      expect(qr.display_name_sql('Chuck Russell')).to eq "Select Id, DisplayName From Customer WHERE DisplayName = 'Chuck Russell' LIMIT 1"
+      expect(qr.display_name_sql('Chuck Russell')).to eq "SELECT Id, DisplayName FROM Customer WHERE DisplayName = 'Chuck Russell'"
     end
 
     it 'for custom usage' do
       qr = Quickbooks::Base.new(full_account, :customer)
-      sql = qr.display_name_sql('Chuck Russell', entity: 'Vendor', select: '*', limit: 5)
-      expect(sql).to eq "Select * From Vendor WHERE DisplayName = 'Chuck Russell' LIMIT 5"
+      sql = qr.display_name_sql('Chuck Russell', entity: 'Vendor', select: '*')
+      expect(sql).to eq "SELECT * FROM Vendor WHERE DisplayName = 'Chuck Russell'"
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quickbooks-ruby-base
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Christian