RubyGems - quickbooks-ruby-base - Versions diffs - 1.0.0 → 1.0.1 - Mend

quickbooks-ruby-base 1.0.0 → 1.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

checksums.yaml +8 -8
data/lib/quickbooks/base.rb +15 -4
data/quickbooks-ruby-base.gemspec +1 -1
data/spec/fixtures/dummy.xml +11 -0
data/spec/fixtures/payments.xml +46 -0
data/spec/quickbooks_ruby_base_spec.rb +21 -3
metadata +6 -2

checksums.yaml CHANGED Viewed

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTQ4YTRkMzhlOWMyMGZhNWEzNDVhNTY0ZjM1Zjc5ZGU0NTkyZGY3Yg==
+    ZTQ4MzMwYzE2MDZkYzY2N2QyNjVhOTkzZTkyZTRlMTFmZTMwOGFjOQ==
   data.tar.gz: !binary |-
-    MjU3N2RjMDgyNzE5ODEzMjMwNTYzODY3ZWM0NzY4N2UxYjAyZDcwZQ==
+    MDUxZmZjZmIzMzMyNjA2NzQ5OGYzNmM5ZTU4MDNmNGViYjIwOGE3ZA==
 SHA512:
   metadata.gz: !binary |-
-    MjcxODk1NDAxMzMzMTRlOGJhNzMwZWI4ZDM0NzlkMWM0Yzc4Y2M5YTE2YTdh
-    OWEwZmFlZTRmNjNhMjkzZjNmYzk1NTBjNDQ0YmJhNTIwODFhMGM1Yzg2NGVj
-    YmU5Mzk0ZTdjNjhlOWExMTViMmFlNDljMGZkYTBjNTM0NDg1NDI=
+    OWM0MWM5OWJhMWY5MTdmMjc0MDIyZjk5NDczYWUyMTEzYWY0M2UwY2JkZDcy
+    ZTdiZGEzMDJmN2NjZDJhZmFkNTZhYzBhNjlhMDk4YWJkZjhkYzJlMDg3Mzk0
+    MDBjMDRmYjNjNzY3YTYzZGEwNzY3OWYzNTg4YTNjMmI3OTU0ZGE=
   data.tar.gz: !binary |-
-    MzllMDg1NGFhOGRkNmE5MjMwZDRjNDE2Mjc4ZjFkMmU4YTY0MGFhMDNjMWVi
-    M2RmMTJiOGM3ODE2MzY4ZTI4NWRmNDJjMzg1ODI0Zjg2ZjM5ZDcxYWJiNWZl
-    ZjYyMDdjZWIwOTQwMTgxMWMxZjhhZjRlMjIzM2UxZmQyMWNlNzU=
+    NWU3NTVjYmZlODBjOGY4NGUyMDYzYjNjMGQ4ZGFhZjliNWI1YzBmY2VmMWQx
+    ODk5OWQ0ZjAyYTgyN2ZiN2QwYmFlZWFjMDVhMTBiNWZjNzNlODc3NjcyM2M3
+    ZTBhNDU0NWRmZDI1YWJiM2UzZmMyOWM1ZjJlNjE2ZGRkMTg5NWY=

data/lib/quickbooks/base.rb CHANGED Viewed

@@ -32,18 +32,29 @@ module Quickbooks
     def show(options = {})
       options = { per_page: 20, page: 1 }.merge(options)
-      method = describing_method
-      @service.query(nil, options).entries.collect { |e| "QBID: #{e.id} DESC: #{e.send(method) if method}" }
+      @service.query(nil, options).entries.collect do |e|
+        "QBID: #{e.id} DESC: #{description(e)}"
+      end
+    end
+    def description(e)
+      desc = (method = describing_method) =~ /(total)/ ? e.send(method).to_f : e.send(method)
+    rescue => e
+      'nil'
     end
     def describing_method
       case @service.class.name
-      when /(Item|TaxCode|PaymentMethod)/
+      when /(Item|TaxCode|PaymentMethod|Account)/
         'name'
-      when /(Invoice|Payment)/
+      when /(Invoice|CreditMemo)/
         'doc_number'
+      when /Payment/
+        'total'
       when /(Vendor|Customer|Employee)/
         'display_name'
+      else
+        'txn_date'
       end
     end

data/quickbooks-ruby-base.gemspec CHANGED Viewed

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 Gem::Specification.new do |spec|
   spec.name          = 'quickbooks-ruby-base'
-  spec.version       = '1.0.0'
+  spec.version       = '1.0.1'
   spec.authors       = ["Christian"]
   spec.email         = ["christian@minimul.com"]
   spec.summary       = %q{Base class to provide common methods for the quickbooks-ruby gem}

data/spec/fixtures/dummy.xml ADDED Viewed

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<IntuitResponse xmlns="http://schema.intuit.com/finance/v3" time="2014-04-04T04:52:19.963-07:00">
+  <QueryResponse startPosition="1" maxResults="20" totalCount="1">
+    <Dummy>
+      <Id>1</Id>
+    </Dummy>
+    <Dummy>
+      <Id>2</Id>
+    </Dummy>
+  </QueryResponse>
+</IntuitResponse>

data/spec/fixtures/payments.xml ADDED Viewed

@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<IntuitResponse xmlns="http://schema.intuit.com/finance/v3" time="2014-04-04T04:52:19.963-07:00">
+  <QueryResponse startPosition="1" maxResults="20" totalCount="20">
+    <Payment>
+      <Id>33</Id>
+      <SyncToken>0</SyncToken>
+      <MetaData>
+        <CreateTime>2014-04-15T10:21:16-0400</CreateTime>
+        <LastUpdatedTime>2014-04-15T10:21:16-0400</LastUpdatedTime>
+      </MetaData>
+      <TxnDate>2014-04-14</TxnDate>
+      <Line>
+        <Amount>100.0</Amount>
+        <LinkedTxn>
+          <TxnId>29</TxnId>
+          <TxnType>Invoice</TxnType>
+        </LinkedTxn>
+        <LinkedTxn>
+          <TxnId>29</TxnId>
+          <TxnType>Invoice</TxnType>
+        </LinkedTxn>
+      </Line>
+      <CustomerRef>6</CustomerRef>
+      <DepositToAccountRef>4</DepositToAccountRef>
+      <TotalAmt>100.0</TotalAmt>
+      <UnappliedAmt>0.0</UnappliedAmt>
+      <ProcessPayment>false</ProcessPayment>
+      <ExchangeRate>0.0</ExchangeRate>
+    </Payment>
+    <Payment>
+      <Id>32</Id>
+      <SyncToken>0</SyncToken>
+      <MetaData>
+        <CreateTime>2014-04-15T10:18:27-0400</CreateTime>
+        <LastUpdatedTime>2014-04-15T10:18:27-0400</LastUpdatedTime>
+      </MetaData>
+      <TxnDate>2014-04-14</TxnDate>
+      <CustomerRef>6</CustomerRef>
+      <DepositToAccountRef>4</DepositToAccountRef>
+      <TotalAmt>100.0</TotalAmt>
+      <UnappliedAmt>100.0</UnappliedAmt>
+      <ProcessPayment>false</ProcessPayment>
+      <ExchangeRate>0.0</ExchangeRate>
+    </Payment>
+  </QueryResponse>
+</IntuitResponse>

data/spec/quickbooks_ruby_base_spec.rb CHANGED Viewed

@@ -29,7 +29,7 @@ describe Quickbooks::Base do
   describe ".show" do
     let(:account) { account = double(settings: double( qb_token: 'tttttttttt', qb_secret: 'ssssssss', qb_company_id: '1234567')) }
-    it "should display using the name as the given name" do
+    it "description should display using the dispay_name for vendor" do
       xml = File.read(File.join('spec', 'fixtures', 'vendors.xml'))
       response = Struct.new(:plain_body, :code).new(xml, 200)
       allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
@@ -37,7 +37,7 @@ describe Quickbooks::Base do
       expect(qr.show.first).to match /Catherines Cupcakes/
     end
-    it "should display using the name and not doc_number" do
+    it "description should display using the name for tax_code" do
       xml = File.read(File.join('spec', 'fixtures', 'tax_codes.xml'))
       response = Struct.new(:plain_body, :code).new(xml, 200)
       allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
@@ -45,13 +45,31 @@ describe Quickbooks::Base do
       expect(qr.show.last).to match /New York City/
     end
-    it "should display using the doc_number and not name" do
+    it "description should display using the doc_number for invoice" do
       xml = File.read(File.join('spec', 'fixtures', 'invoices.xml'))
       response = Struct.new(:plain_body, :code).new(xml, 200)
       allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
       qr = Quickbooks::Base.new(account, :invoice)
       expect(qr.show.last).to match /1234/
     end
+    it "description should display using the total for payment" do
+      xml = File.read(File.join('spec', 'fixtures', 'payments.xml'))
+      response = Struct.new(:plain_body, :code).new(xml, 200)
+      allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
+      qr = Quickbooks::Base.new(account, :payment)
+      expect(qr.show.last).to match /100\.0/
+    end
+    it "description should display 'nil' as no description fits" do
+      xml = File.read(File.join('spec', 'fixtures', 'dummy.xml'))
+      xml.gsub!('Dummy', 'SalesReceipt')
+      response = Struct.new(:plain_body, :code).new(xml, 200)
+      allow_any_instance_of(OAuth::AccessToken).to receive(:get).and_return(response)
+      qr = Quickbooks::Base.new(account, :sales_receipt)
+      expect(qr.show.last).to match /nil/
+    end
   end
   describe ".retrieve" do

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quickbooks-ruby-base
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Christian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-04-05 00:00:00.000000000 Z
+date: 2014-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: quickbooks-ruby
@@ -82,7 +82,9 @@ files:
 - lib/quickbooks/base.rb
 - lib/quickbooks/base/configuration.rb
 - quickbooks-ruby-base.gemspec
+- spec/fixtures/dummy.xml
 - spec/fixtures/invoices.xml
+- spec/fixtures/payments.xml
 - spec/fixtures/tax_codes.xml
 - spec/fixtures/vendors.xml
 - spec/quickbooks_ruby_base_spec.rb
@@ -112,7 +114,9 @@ signing_key:
 specification_version: 4
 summary: Base class to provide common methods for the quickbooks-ruby gem
 test_files:
+- spec/fixtures/dummy.xml
 - spec/fixtures/invoices.xml
+- spec/fixtures/payments.xml
 - spec/fixtures/tax_codes.xml
 - spec/fixtures/vendors.xml
 - spec/quickbooks_ruby_base_spec.rb