quick_shoulda 0.1.0 → 0.1.1

data/.rspec

@@ -1,4 +1,3 @@
 --color
---debug
 -f documentation
 -p

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - "1.8.7"
   - "1.9.2"
   - "1.9.3"  
 # uncomment this line if your project needs to run something other than `rake`:

data/Rakefile

@@ -1,9 +1,13 @@
 require "bundler/gem_tasks"
 require "quick_shoulda/version.rb"
+require 'rspec/core/rake_task'
 
 task :install_mah_gem do
   exec %{ 
   	gem uninstall quick_shoulda; 
   	gem build quick_shoulda.gemspec;
   	gem install quick_shoulda-#{QuickShoulda::VERSION}.gem; }
-end
+end
+
+task :default => :spec
+RSpec::Core::RakeTask.new

data/lib/quick_shoulda/helpers/string_helpers.rb

@@ -11,7 +11,8 @@ module QuickShoulda
       elsif value.is_a? Symbol
         "(:#{value})"
       else
-        "(#{value})"
+        #fix for 1.8.7
+        "(#{value.inspect})"
       end
     end
   end

data/lib/quick_shoulda/path_resolver.rb

@@ -29,7 +29,7 @@ module QuickShoulda
 			end	
 
 			def is_a_constant?(path)
-				( path[0] =~ /[A-Z]/ || path[0] =~ /:/ ) && File.extname(path).empty? && !path.include?('/')
+				( path[0].chr =~ /[A-Z]/ || path[0].chr =~ /:/ ) && File.extname(path).empty? && !path.include?('/')
 			end
 		end
 	end

data/lib/quick_shoulda/version.rb

@@ -1,3 +1,3 @@
 module QuickShoulda
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/quick_shoulda.gemspec

@@ -20,6 +20,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "random_string"
-  spec.add_development_dependency "debugger", "~> 1.3"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rake"
 end

data/spec/generator/association_spec.rb

@@ -23,6 +23,11 @@ describe 'QuickShoulda::Generator::Association' do
       "it { should belong_to(:friendly_user).dependent(:destroy).class_name('User').order('users.email DESC').with_foreign_key('friendly_user_id') }"
     end
 
+    before do
+      should_receive(:shoulda_assciation_option_methods_chain).with(options).
+      and_return(".dependent(:destroy).class_name('User').order('users.email DESC').with_foreign_key('friendly_user_id')")
+    end
+
     it 'should return valid shoulda test case' do
       send(:generate_for_association, association).should eq expected
     end

data/spec/generator/validation_spec.rb

@@ -4,54 +4,25 @@ describe 'QuickShoulda::Generator::Validation' do
   include QuickShoulda::StringHelpers
   include QuickShoulda::Generator::Validation
 
-  describe '#generate' do    
-    let(:attribute) { :student }
-
-    let(:presence_options) { {} }    
-    let(:uniqueness_options) { { scope: [:class, :college]} }    
-    let(:format_options) { { with: /abc/} }
-    let(:length_options) { { minimum: 1, maximum: 20}}
-    let(:inclusion_options) { { within: (1..20), :allow_nil => true, :allow_blank => true} }
-    let(:exclusion_options) { { in: ['a', 'b', 'c']} }
-    let(:numericality_options) { { only_integer: true, message: 'must be an integer' } }
-
-    let(:random_strings) do
-      {
-        matched_strings: ['abc'],
-        unmatched_strings: ['nqtien310@gmail.com', 'nqtien310@hotdev.com']
-      }
-    end
-
-    ['presence', 'format', 'uniqueness', 'length', 'inclusion', 'exclusion', 'numericality'].each do | type |      
-      let("#{type}_validator_class") { mock("#{type}_validator_class".to_sym, to_s: "ActiveModel::Validations::#{type.upcase}Validator") }
-      let("#{type}_validator".to_sym) do        
-        mock("#{type}_validator".to_sym, :class => eval("#{type}_validator_class"), 
-                                    attributes: [attribute], options: eval("#{type}_options") )
-      end
-    end
-
-    let(:validators) { [presence_validator, uniqueness_validator, format_validator, length_validator, 
-                    inclusion_validator, exclusion_validator, numericality_validator] }
-    let(:model) { mock(:model, validators: validators) }
-
-    before { RandomString.should_receive(:generate).with(/abc/).and_return(random_strings) }
-
-    let(:expected) {
-      [
-        'it { should validate_presence_of(:student) }',        
-        'it { should validate_uniqueness_of(:student).scoped_to(:class).scoped_to(:college) }',
-        "it { should allow_value('abc').for(:student) }",
-        "it { should_not allow_value('nqtien310@gmail.com').for(:student) }",
-        "it { should_not allow_value('nqtien310@hotdev.com').for(:student) }",
-        "it { should ensure_length_of(:student).is_at_least(1).is_at_most(20) }",
-        "it { should ensure_inclusion_of(:student).in_range(1..20).allow_nil(true).allow_blank(true) }",
-        'it { should ensure_exclusion_of(:student).in_array(["a", "b", "c"]) }',
-        "it { should validate_numericality_of(:student).only_integer.with_message('must be an integer') }"
-      ]
+  describe '#generate_validators' do
+    let(:validator1){ mock(:validator)}
+    let(:validator2){ mock(:validator)}
+    let(:validator3){ mock(:validator)}
+    let(:validator4){ mock(:validator)}
+
+    let(:validators) {
+      [validator1, validator2, validator3, validator4]
     }
 
-    it 'should return exact array of strings' do      
-      generate_validations(model).should eq expected
+    let(:model) { mock(:model, :validators => validators)}
+
+    it 'should invoke #generate_for_validator for each validator' do
+      should_receive(:generate_for_validator).with(validator1).and_return("it should do something")
+      should_receive(:generate_for_validator).with(validator2).and_return("it should do another thing")
+      should_receive(:generate_for_validator).with(validator3).and_return(nil)
+      should_receive(:generate_for_validator).with(validator4).and_return(["another thing"])
+      result = generate_validations(model)
+      result.should eq ['it should do something', 'it should do another thing', 'another thing']
     end
   end
 
@@ -233,8 +204,8 @@ describe 'QuickShoulda::Generator::Validation' do
         end
 
         context 'do not contain invalid option' do
-          let(:options) { {:minimum=>1, :maximum=>20} }
-          let(:expected) { ".is_at_least(1).is_at_most(20)" }
+          let(:options) { {:maximum=>20, :minimum=>1} }
+          let(:expected) { ".is_at_most(20).is_at_least(1)" }
           it 'should return shoulda option methods corresponded with given options' do
             send(:shoulda_option_methods_chain, options).should eq expected
           end
@@ -263,8 +234,8 @@ describe 'QuickShoulda::Generator::Validation' do
 
     context 'other types' do
       let(:type) { 'length' }
-      let(:options) { {:minimum=>1, :maximum=>20} }
-      let(:expected) { ['it { should ensure_length_of(:username).is_at_least(1).is_at_most(20) }'] }
+      let(:options) { {:maximum=>20, :minimum=>1} }
+      let(:expected) { ['it { should ensure_length_of(:username).is_at_most(20).is_at_least(1) }'] }
 
       it 'should return 1 complete shoulda test case' do
         should_receive(:validation_type).at_least(1).and_return(type) 
@@ -360,12 +331,12 @@ describe 'QuickShoulda::Generator::Validation' do
     let(:attr) { 'email' }
     let(:matched_strings) { ['123','456'] }
     let(:unmatched_strings) { ['abc'] }
-    let(:options) { {with: /123|456/ } }
+    let(:options) { { :with => /123|456/ } }
 
     let(:random_strings) {
       {
-        matched_strings: matched_strings,
-        unmatched_strings: unmatched_strings
+        :matched_strings => matched_strings,
+        :unmatched_strings => unmatched_strings
       }
     }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quick_shoulda
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-01 00:00:00.000000000 Z
+date: 2013-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: random_string
@@ -28,23 +28,23 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: debugger
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -116,12 +116,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3326814885739799411
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3326814885739799411
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25