queue_classic_plus 4.0.0.alpha16 → 4.0.0.alpha17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ca2467a415dbb231b97492a6b223945a08c79a704209c9f5cbdcc6317a51643
-  data.tar.gz: 497545d4065d6cd1c03a39591b04174fbff95899871a1b0dcb1d33a4d5cc4bdf
+  metadata.gz: 3b17bbec023aa5f8fa91527f15c91db3ca6a9975da20c304188b5100757bab9b
+  data.tar.gz: 57ce60a1dfd1912b7a6b57c6b8c312f78fc3f903dc674739099dc27bb138d8aa
 SHA512:
-  metadata.gz: 2c46e104255d291c0bee0e2c5517bb72c1ced81f860fb8f7ee1474973ed806f92c5352bfb060e9f538dcacd9e43dfd8ad2100539931bf21f9d567a4456e6e64c
-  data.tar.gz: 6102b297532d4cc30c30825deb42a82121460d773f0881a250ea5280803aa0d959279cf4e1baee8e4719d41840afbb1e332a9b598b9ef9711ceed1b31da31cbe
+  metadata.gz: e45d48b488c7cc0bdea10fbea03397539a5533b1d98647aaf9f942150caaa121dc958bc57cc183782ffc7b74c98305a90ef14c9d07dfcb00b562372bf0c7048b
+  data.tar.gz: 23932d46b74e4f994b4e8a09d6b81e933f0798fa45608968e63f37b39476de0428c6315ebb925e18b043dabc4b10d0d8336e72d65407f61ba5e678c591d9918a

data/lib/queue_classic_plus/base.rb

@@ -2,18 +2,10 @@ module QueueClassicPlus
   class Base
     extend QueueClassicPlus::InheritableAttribute
 
-    # Max value for bigint calculated from
-    # https://stackoverflow.com/questions/28960478/postgres-maximum-value-for-bigint
-    PG_BIGINT_MAX = 9223372036854775807.freeze
-
     def self.queue
       QC::Queue.new(@queue)
     end
 
-    def self.queue_name_digest
-      @queue_name_digest ||= @queue.to_s.to_i(36) % PG_BIGINT_MAX
-    end
-
     inheritable_attr :locked
     inheritable_attr :skip_transaction
     inheritable_attr :retries_on
@@ -60,42 +52,8 @@ module QueueClassicPlus
       QueueClassicPlus.logger
     end
 
-    def self.can_enqueue?(method, *args)
-      if locked?
-        max_lock_time = ENV.fetch("QUEUE_CLASSIC_MAX_LOCK_TIME", 10 * 60).to_i
-
-        q = "SELECT COUNT(1) AS count
-             FROM
-               (
-                 SELECT 1
-                 FROM queue_classic_jobs
-                 WHERE q_name = $1 AND method = $2 AND args::text = $3::text
-                   AND (locked_at IS NULL OR locked_at > current_timestamp - interval '#{max_lock_time} seconds')
-                 LIMIT 1
-               )
-             AS x"
-
-        result = QC.default_conn_adapter.execute(q, @queue, method, JSON.dump(serialized(args)))
-        result['count'].to_i == 0
-      else
-        true
-      end
-    end
-
     def self.enqueue(method, *args)
-       conn = QC.default_conn_adapter.connection
-       check_and_enqueue = proc do
-         conn.exec("SELECT pg_advisory_xact_lock(#{queue_name_digest})")
-         if can_enqueue?(method, *args)
-           queue.enqueue(method, *serialized(args))
-         end
-       end
-
-       if [PG::PQTRANS_ACTIVE, PG::PQTRANS_INTRANS].include?(conn.transaction_status)
-         check_and_enqueue.call
-       else
-         conn.transaction &check_and_enqueue
-       end
+      queue.enqueue(method, *serialized(args), lock: locked?)
     end
 
     def self.enqueue_perform(*args)

data/lib/queue_classic_plus/queue_classic/queue.rb

@@ -50,5 +50,25 @@ module QC
       end
     end
 
+    def enqueue(method, *args, lock: false)
+      QC.log_yield(:measure => 'queue.enqueue') do
+        insert_sql = <<-EOF
+          INSERT INTO #{QC.table_name} (q_name, method, args, lock)
+          VALUES ($1, $2, $3, $4)
+          ON CONFLICT (q_name, method, args) WHERE lock IS TRUE DO NOTHING
+          RETURNING id
+        EOF
+        begin
+          retries ||= 0
+          conn_adapter.execute(insert_sql, name, method, JSON.dump(args), lock)
+        rescue PG::Error => error
+          if (retries += 1) < 2
+            retry
+          else
+            raise
+          end
+        end
+      end
+    end
   end
 end

data/lib/queue_classic_plus/version.rb

@@ -1,3 +1,3 @@
 module QueueClassicPlus
-  VERSION = '4.0.0.alpha16'.freeze
+  VERSION = '4.0.0.alpha17'.freeze
 end

data/lib/queue_classic_plus.rb

@@ -15,14 +15,18 @@ module QueueClassicPlus
 
   def self.migrate(c = QC::default_conn_adapter.connection)
     conn = QC::ConnAdapter.new(connection: c)
-    conn.execute("ALTER TABLE queue_classic_jobs ADD COLUMN last_error TEXT")
-    conn.execute("ALTER TABLE queue_classic_jobs ADD COLUMN remaining_retries INTEGER")
+    conn.execute("ALTER TABLE queue_classic_jobs ADD COLUMN IF NOT EXISTS last_error TEXT")
+    conn.execute("ALTER TABLE queue_classic_jobs ADD COLUMN IF NOT EXISTS remaining_retries INTEGER")
+    conn.execute("ALTER TABLE queue_classic_jobs ADD COLUMN IF NOT EXISTS lock BOOLEAN NOT NULL DEFAULT FALSE")
+    conn.execute("CREATE UNIQUE INDEX IF NOT EXISTS index_queue_classic_jobs_enqueue_lock on queue_classic_jobs(q_name, method, args) WHERE lock IS TRUE")
   end
 
   def self.demigrate(c = QC::default_conn_adapter.connection)
     conn = QC::ConnAdapter.new(connection: c)
-    conn.execute("ALTER TABLE queue_classic_jobs DROP COLUMN last_error")
-    conn.execute("ALTER TABLE queue_classic_jobs DROP COLUMN remaining_retries")
+    conn.execute("ALTER TABLE queue_classic_jobs DROP COLUMN IF EXISTS last_error")
+    conn.execute("ALTER TABLE queue_classic_jobs DROP COLUMN IF EXISTS remaining_retries")
+    conn.execute("DROP INDEX IF EXISTS index_queue_classic_jobs_enqueue_lock")
+    conn.execute("ALTER TABLE queue_classic_jobs DROP COLUMN IF EXISTS lock")
   end
 
   def self.exception_handler

data/spec/base_spec.rb

@@ -3,6 +3,24 @@ require 'active_record'
 
 describe QueueClassicPlus::Base do
   context "A child of QueueClassicPlus::Base" do
+    subject do
+      Class.new(QueueClassicPlus::Base) do
+        @queue = :test
+      end
+    end
+
+    it "allows multiple enqueues" do
+      threads = []
+      10.times do
+        threads << Thread.new do
+          subject.do
+        end
+      end
+      threads.each(&:join)
+
+      expect(subject).to have_queue_size_of(10)
+    end
+
     context "that is locked" do
       subject do
         Class.new(QueueClassicPlus::Base) do
@@ -13,14 +31,27 @@ describe QueueClassicPlus::Base do
 
       it "does not allow multiple enqueues" do
         threads = []
-        50.times do
+        10.times do
           threads << Thread.new do
             subject.do
             expect(subject).to have_queue_size_of(1)
           end
         end
+        threads.each(&:join)
+      end
 
+      it "allows enqueueing same job with different arguments" do
+        threads = []
+        (1..3).each do |arg|
+          10.times do
+            threads << Thread.new do
+              subject.do(arg)
+            end
+          end
+        end
         threads.each(&:join)
+
+        expect(subject).to have_queue_size_of(3)
       end
 
       it "checks for an existing job using the same serializing as job enqueuing" do
@@ -34,14 +65,6 @@ describe QueueClassicPlus::Base do
         subject.do(date)
         expect(subject).to have_queue_size_of(1)
       end
-
-      it "does allow multiple enqueues if something got locked for too long" do
-        subject.do
-        one_day_ago = Time.now - 60*60*24
-        execute "UPDATE queue_classic_jobs SET locked_at = '#{one_day_ago}' WHERE q_name = 'test'"
-        subject.do
-        expect(subject).to have_queue_size_of(2)
-      end
     end
 
     context "when in a transaction" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: queue_classic_plus
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha16
+  version: 4.0.0.alpha17
 platform: ruby
 authors:
 - Simon Mathieu
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-11 00:00:00.000000000 Z
+date: 2023-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: queue_classic