queue_classic 4.0.0.pre.alpha1 → 4.0.0.pre.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '048980a61b1882135be9a0379bcd9e76c1353f361e1320c99478e0f4486dcab8'
-  data.tar.gz: b54392096329149b1d11195be20cac1ca8213174602e265d0e392a9816dc2ddb
+  metadata.gz: 1e57fa8cff0c8e6772dda85c9e4a83c5b851f3dc4e5093d36d53b5607bdad99c
+  data.tar.gz: '06691d8784eaed7f920319e1e413d2ac0fde11797673726022ee4c99713e7687'
 SHA512:
-  metadata.gz: 1c25ab7cc785b3715b3328e2214f2efd186a962dfcae86d31bfe75cecd6d4bcd0e2d68f7c9f38bc4727784f07b0fa48511fc04769ff13fc4d4056ceccd107272
-  data.tar.gz: adb4e07cbb115645ec6e54db85437b3e10388329ffd1d3688516ef00f4e1a8112dafecad1921e1ee12232650cd6a22c468bbc5e719affaf452f56b12f068141c
+  metadata.gz: 58822f3b1458c8ee9f10c8e54784a357b48cfee4ee7bd8dae0b722a0ba2a21f2e994f20df58b7160627a0c210d03f616598c92d314afd763773fbb1b784472d2
+  data.tar.gz: 30c9691284a280ef1efd234a9a404f97421349b620b083aaefa0d2350f6f8a079b980610a1cd787cf05c04ffadc935bc16c9f3f199cdc685de585b84f18b9198

data/.circleci/config.yml

@@ -3,7 +3,7 @@ jobs:
   test_fresh_install_rails_5_2_3:
     parallelism: 2
     docker:
-    - image: circleci/ruby:2.6.3
+    - image: circleci/ruby:2.6
       environment:
         RAILS_ENV: test
         RACK_ENV: test
@@ -21,9 +21,9 @@ jobs:
         command: |
           cd test/rails-tests/
           sh rails523.sh
-  test_ruby_2_4_6:
+  test_ruby_2_4:
     docker:
-    - image: circleci/ruby:2.4.6
+    - image: circleci/ruby:2.4
       environment:
         RAILS_ENV: test
         RACK_ENV: test
@@ -61,9 +61,9 @@ jobs:
         path: test/reports/
     - store_test_results:
         path: test/reports/
-  test_ruby_2_5_4:
+  test_ruby_2_5:
     docker:
-    - image: circleci/ruby:2.5.4
+    - image: circleci/ruby:2.5
       environment:
         RAILS_ENV: test
         RACK_ENV: test
@@ -101,9 +101,49 @@ jobs:
         path: test/reports/
     - store_test_results:
         path: test/reports/
-  test_ruby_2_6_3:
+  test_ruby_2_6:
     docker:
-    - image: circleci/ruby:2.6.3
+    - image: circleci/ruby:2.6
+      environment:
+        RAILS_ENV: test
+        RACK_ENV: test
+        POSTGRES_USER: root
+        PGHOST: 127.0.0.1
+        DATABASE_URL: postgres://postgres@127.0.0.1/circle_test
+        QC_DATABASE_URL: postgres://postgres@127.0.0.1/circle_test
+        QC_BENCHMARK: true
+        QC_BENCHMARK_MAX_TIME_DEQUEUE: 60
+    - image: circleci/postgres:9.6.6-alpine
+    steps:
+    - checkout
+    - run:
+        name: Install env dependencies
+        command: |
+          sudo apt-get update
+          sudo apt-get install postgresql-client
+    - restore_cache:
+        key: v1-qc-bundler-{{ checksum "Gemfile" }}-{{ checksum "queue_classic.gemspec"
+          }}
+    - run:
+        name: Install Ruby gems
+        command: |
+          bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3
+    - save_cache:
+        key: v1-qc-bundler-{{ checksum "Gemfile" }}-{{ checksum "queue_classic.gemspec"
+          }}
+        paths:
+        - ~/project/vendor/bundle
+    - run:
+        name: Minitest
+        command: |
+          bundle exec rake
+    - store_artifacts:
+        path: test/reports/
+    - store_test_results:
+        path: test/reports/
+  test_ruby_2_7:
+    docker:
+    - image: circleci/ruby:2.7
       environment:
         RAILS_ENV: test
         RACK_ENV: test
@@ -145,7 +185,8 @@ workflows:
   version: 2
   test:
     jobs:
-    - test_ruby_2_4_6
-    - test_ruby_2_5_4
-    - test_ruby_2_6_3
+    - test_ruby_2_4
+    - test_ruby_2_5
+    - test_ruby_2_6
+    - test_ruby_2_7
     - test_fresh_install_rails_5_2_3

data/README.md

@@ -1,5 +1,10 @@
 # queue_classic
-A simple, efficient worker queue for Ruby & PostgreSQL
+A simple, efficient worker queue for Ruby & PostgreSQL.
+
+Why this over something like Resque. Two reasons:
+
+1. Your jobs can be equeued in the same transaction as other modifications to the database, and will only be processed when everything is commited. This is a hard pattern to develop around for queues done outside your database
+2. Less things to run, if you don't already have Redis or a dedicated queue in your stack.
 
 [![CircleCI](https://circleci.com/gh/QueueClassic/queue_classic/tree/master.svg?style=svg)](https://circleci.com/gh/QueueClassic/queue_classic/tree/master)
 
@@ -11,6 +16,16 @@ You can always find the latest and previous releases here:
 
 https://github.com/QueueClassic/queue_classic/releases
 
+## Other related projects
+
+If you're interested in this project, you might also want to checkout:
+
+ * [Que](https://github.com/que-rb/que)
+ * [GoodJob](https://github.com/bensheldon/good_job)
+ * [Delayed Job](https://github.com/collectiveidea/delayed_job)
+
+For a list of other queues (which may or may not be Postgres backed), checkout - https://edgeapi.rubyonrails.org/classes/ActiveJob/QueueAdapters.html
+
 ## What is queue_classic?
 
 queue_classic provides a simple interface to a PostgreSQL-backed message queue. queue_classic specializes in concurrent locking and minimizing database load while providing a simple, intuitive developer experience. queue_classic assumes that you are already using PostgreSQL in your production environment and that adding another dependency (e.g. redis, beanstalkd, 0mq) is undesirable.
@@ -34,7 +49,7 @@ A major benefit is the ability to enqueue inside transactions, ensuring things a
 ### Requirements
 
 For this version, the requirements are as follows:
-* Ruby 2.4, 2.5 or 2.6
+* Ruby 2.4, 2.5, 2.6 or 2.7
 * Postgres ~> 9.6
 * Rubygem: pg ~> 0.17
 

data/lib/queue_classic/conn_adapter.rb

@@ -107,7 +107,7 @@ module QC
       [
        host, # host or percent-encoded socket path
        url.port || 5432,
-       nil, '', #opts, tty
+       nil, nil, #opts, tty
        url.path.gsub("/",""), # database name
        url.user,
        url.password

data/lib/queue_classic/queue.rb

@@ -117,7 +117,7 @@ module QC
             job[:method] = r["method"]
             job[:args] = JSON.parse(r["args"])
             if r["scheduled_at"]
-              job[:scheduled_at] = Time.parse(r["scheduled_at"])
+              job[:scheduled_at] = r["scheduled_at"].kind_of?(Time) ? r["scheduled_at"] : Time.parse(r["scheduled_at"])
               ttl = Integer((Time.now - job[:scheduled_at]) * 1000)
               QC.measure("time-to-lock=#{ttl}ms source=#{name}")
             end

data/lib/queue_classic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module QC
-  VERSION = "4.0.0-alpha1"
+  VERSION = "4.0.0-beta1"
 end

data/queue_classic.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = %w[lib]
 
   spec.add_dependency "pg", ">= 0.17", "< 2.0"
+  spec.add_development_dependency "activerecord", ">= 5.0.0", "< 6.1"
 end

data/test/lib/queue_classic_test_with_activerecord_typecast.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require File.expand_path("../../helper.rb", __FILE__)
+
+class QueueClassicTest < QCTest
+  def before_teardown
+    ActiveRecord.send :remove_const, :Base
+    Object.send :remove_const, :ActiveRecord
+
+    QC.default_conn_adapter = @original_conn_adapter
+  end
+
+  def test_lock_with_active_record_timestamp_type_cast
+    # Insert an unlocked job
+    p_queue = QC::Queue.new("priority_queue")
+    conn_adapter = Minitest::Mock.new
+    conn_adapter.expect(:execute, {"id" => '1', "q_name" => 'test', "method" => "Kernel.puts", "args" => "[]", "scheduled_at" => Time.now}, [String, String])
+    QC.default_conn_adapter = conn_adapter
+    assert_equal(p_queue.lock, {})
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: queue_classic
 version: !ruby/object:Gem::Version
-  version: 4.0.0.pre.alpha1
+  version: 4.0.0.pre.beta1
 platform: ruby
 authors:
 - Ryan Smith (♠ ace hacker)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-24 00:00:00.000000000 Z
+date: 2021-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -30,6 +30,26 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
 description: queue_classic is a queueing library for Ruby apps. (Rails, Sinatra, Etc...)
   queue_classic features asynchronous job polling, database maintained locks and no
   ridiculous dependencies. As a matter of fact, queue_classic only requires pg.
@@ -78,6 +98,7 @@ files:
 - test/helper.sql
 - test/lib/queue_classic_rails_connection_test.rb
 - test/lib/queue_classic_test.rb
+- test/lib/queue_classic_test_with_activerecord_typecast.rb
 - test/queue_test.rb
 - test/rails-tests/.gitignore
 - test/rails-tests/rails523.sh
@@ -101,8 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Simple, efficient worker queue for Ruby & PostgreSQL.
@@ -113,6 +133,7 @@ test_files:
 - test/helper.sql
 - test/lib/queue_classic_rails_connection_test.rb
 - test/lib/queue_classic_test.rb
+- test/lib/queue_classic_test_with_activerecord_typecast.rb
 - test/queue_test.rb
 - test/rails-tests/.gitignore
 - test/rails-tests/rails523.sh