questrade_api 0.0.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc55678c85117d92ad613586840f18ea4a380e47
-  data.tar.gz: a4ca8fc7f3a6c99714f6d17cf0a18c1287879ca2
+  metadata.gz: 3648ccbf7f83b5173c5606b74b047e0e3c0e71d0
+  data.tar.gz: 8ae0d104853ccb59ae7604ba53749dde2c5bb625
 SHA512:
-  metadata.gz: 5f627f715a2b4ad662954cd32ba0e6ffbfa5f7ea8678087fa32549244f8268ae22217d0fd914dd0bf52d0d3ba0a72d1a3f6a661968b64e49008a20e4f67a2c27
-  data.tar.gz: 41d579f99b870df5b496ac94dfe7127d5e72a4424e93eeb18a98c80cf582fb7046f90bbda10bfd55fdbc11bd1356acc9c11a18dbcdfbe9ce0926e587e2b6285a
+  metadata.gz: e8153c221b4f6e8250bfe1e0aa6c83fda5432e702c38cafb398b22dd610a437b397dc759755638c4d33cb92931a18cb4b3284b8995cec581f07b13350eb9bdd3
+  data.tar.gz: c59f4a154528e5d44d56ce8bc93c6cad553454327f3ebd4ec072aedb343ec8068d1db04260aa3102a86c2e54656018f8e22e978d9dbc823223d4546d3371768d

data/CHANGELOG.md

@@ -0,0 +1,4 @@
+# Changelog
+
+## 1.0.0
+* Initial version. Disregard the previous versions

data/README.md

@@ -1,7 +1,7 @@
 [![Build Status](https://travis-ci.org/brunomeira/questrade_api.svg?branch=master)](https://travis-ci.org/brunomeira/questrade_api) 
 [![Code Climate](https://codeclimate.com/github/brunomeira/questrade_api/badges/gpa.svg)](https://codeclimate.com/github/brunomeira/questrade_api)
 
-# QuestradeApi
+# The Questrade Ruby Api Gem
 
 A Ruby interface to use the [Questrade API](http://www.questrade.com/api).
 
@@ -53,7 +53,7 @@ client.search_symbols(prefix: 'BMO')
 # In case you already have a valid access token and its respective URL, you can use the QuestradeApi::REST objects. Example:
 # authorization can be any object that responds to url and access_token
 authorization = QuestradeApi::Authorization.new(access_token: 'access_token', api_server: 'url')
-accounts = QuestradeApi::REST::Account.all(accounts)
+accounts = QuestradeApi::REST::Account.fetch(accounts)
 ```
 For more advanced options, check out our [documentation](http://www.rubydoc.info/gems/questrade_api/0.0.4).
 

data/lib/questrade_api/client.rb

@@ -1,119 +1,31 @@
 require 'questrade_api/authorization'
-require 'questrade_api/rest/time'
-require 'questrade_api/rest/account'
-require 'questrade_api/rest/balance'
-require 'questrade_api/rest/position'
-require 'questrade_api/rest/execution'
-require 'questrade_api/rest/activity'
-require 'questrade_api/rest/order'
 
-require 'questrade_api/rest/market'
-require 'questrade_api/rest/symbol'
-require 'questrade_api/rest/quote'
-require 'questrade_api/rest/candle'
-require 'questrade_api/rest/option'
+require 'questrade_api/modules/account_call'
+require 'questrade_api/modules/market_call'
 
 module QuestradeApi
   # @author Bruno Meira <goesmeira@gmail.com>
   class Client
-    attr_reader :authorization
+    include QuestradeApi::AccountCall
+    include QuestradeApi::MarketCall
+
+    attr_accessor :authorization
 
     # @see QuestradeApi::Client#initialize for more details
     def initialize(params = {}, mode = :practice)
-      @authorization = QuestradeApi::Authorization.new(params, mode)
+      self.authorization = QuestradeApi::Authorization.new(params, mode)
       refresh_token if refresh_token?
     end
 
     # Fetches a new access_token. (see QuestradeApi::Authorization#refresh_token)
     def refresh_token
-      @authorization.refresh_token
-    end
-
-    # Fetch current server time.
-    #
-    # @return [DateTime] if no issues to call /time endpoint occurs.
-    # @return [nil] if current server time cannot be fetched.
-    def time
-      time = QuestradeApi::REST::Time.new(@authorization)
-      time.get
-
-      time.data && time.data.time
-    end
-
-    # Fetch all accounts associated with user.
-    #
-    # @return [Array<QuestradeApi::REST::Account>]
-    def accounts
-      QuestradeApi::REST::Account.all(@authorization).accounts
-    end
-
-    # Fetch all positions associated with account.
-    #
-    # @param account_id [String] to which positions will be fetched.
-    #
-    # @return [Array<QuestradeApi::REST::Position>]
-    def positions(account_id)
-      QuestradeApi::REST::Position.all(@authorization, account_id).positions
-    end
-
-    # Fetch all balances associated with account.
-    #
-    # @param account_id [String] to which balances will be fetched.
-    #
-    # @return [OpenStruct(per_currency_balances)]
-    def balances(account_id)
-      QuestradeApi::REST::Balance.all(@authorization, account_id)
-    end
-
-    def executions(account_id, params = {})
-      QuestradeApi::REST::Execution.all(@authorization, account_id, params)
-    end
-
-    def activities(account_id, params = {})
-      QuestradeApi::REST::Activity.all(@authorization, account_id, params)
-    end
-
-    def orders(account_id, params = {})
-      QuestradeApi::REST::Activity.all(@authorization, account_id, params)
-    end
-
-    def markets
-      QuestradeApi::REST::Market.all(@authorization)
-    end
-
-    def symbols(params)
-      QuestradeApi::REST::Symbol.all(@authorization, params)
-    end
-
-    def search_symbols(params)
-      QuestradeApi::REST::Symbol.search(@authorization, params)
-    end
-
-    def quotes(ids)
-      QuestradeApi::REST::Quote.all(@authorization, ids)
-    end
-
-    def quote(id)
-      quote =
-        QuestradeApi::REST::Quote.new(authorization: @authorization, id: id)
-
-      quote.get
-
-      quote
-    end
-
-    def candles(symbol_id, params)
-      QuestradeApi::REST::Candle.all(@authorization, symbol_id, params)
-    end
-
-    def symbol_options(symbol_id)
-      QuestradeApi::REST::Option.all(@authorization, symbol_id)
+      authorization.refresh_token
     end
 
     private
 
     def refresh_token?
-      data = @authorization.data
+      data = authorization.data
       data.refresh_token && !data.api_server && !data.access_token
     end
   end

data/lib/questrade_api/modules/account_call.rb

@@ -0,0 +1,57 @@
+require 'questrade_api/rest/time'
+require 'questrade_api/rest/account'
+require 'questrade_api/rest/balance'
+require 'questrade_api/rest/position'
+require 'questrade_api/rest/execution'
+require 'questrade_api/rest/activity'
+require 'questrade_api/rest/order'
+
+module QuestradeApi
+  module AccountCall
+    # Fetch current server time.
+    #
+    # @return [DateTime] if no issues to call /time endpoint occurs.
+    # @return [Faraday::Response] if current server time cannot be fetched.
+    def time
+      time = QuestradeApi::REST::Time.new(authorization)
+      time.fetch
+    end
+
+    # Fetch all accounts associated with user.
+    #
+    # @return [Array<QuestradeApi::REST::Account>]
+    def accounts
+      QuestradeApi::REST::Account.fetch(authorization)
+    end
+
+    # Fetch all positions associated with account.
+    #
+    # @param account_id [String] to which positions will be fetched.
+    #
+    # @return [OpenStruct(accounts: Array<QuestradeApi::REST::Position>)]
+    def positions(account_id)
+      QuestradeApi::REST::Position.fetch(authorization, account_id)
+    end
+
+    # Fetch all balances associated with account.
+    #
+    # @param account_id [String] to which balances will be fetched.
+    #
+    # @return [OpenStruct(per_currency_balances)]
+    def balances(account_id)
+      QuestradeApi::REST::Balance.fetch(authorization, account_id)
+    end
+
+    def executions(account_id, params = {})
+      QuestradeApi::REST::Execution.fetch(authorization, account_id, params)
+    end
+
+    def activities(account_id, params = {})
+      QuestradeApi::REST::Activity.fetch(authorization, account_id, params)
+    end
+
+    def orders(account_id, params = {})
+      QuestradeApi::REST::Order.fetch(authorization, account_id, params)
+    end
+  end
+end

data/lib/questrade_api/modules/market_call.rb

@@ -0,0 +1,42 @@
+require 'questrade_api/rest/market'
+require 'questrade_api/rest/symbol'
+require 'questrade_api/rest/quote'
+require 'questrade_api/rest/candle'
+require 'questrade_api/rest/option'
+
+module QuestradeApi
+  module MarketCall
+    def markets
+      QuestradeApi::REST::Market.fetch(authorization)
+    end
+
+    def symbols(params)
+      QuestradeApi::REST::Symbol.fetch(authorization, params)
+    end
+
+    def search_symbols(params)
+      QuestradeApi::REST::Symbol.search(authorization, params)
+    end
+
+    def quotes(ids)
+      QuestradeApi::REST::Quote.fetch(authorization, ids)
+    end
+
+    def quote(id)
+      quote =
+        QuestradeApi::REST::Quote.new(authorization: authorization, id: id)
+
+      quote.fetch
+
+      quote
+    end
+
+    def candles(symbol_id, params)
+      QuestradeApi::REST::Candle.fetch(authorization, symbol_id, params)
+    end
+
+    def symbol_options(symbol_id)
+      QuestradeApi::REST::Option.fetch(authorization, symbol_id)
+    end
+  end
+end

data/lib/questrade_api/rest/account.rb

@@ -25,34 +25,34 @@ module QuestradeApi
       #
       # Fetch activities associated with account.
       #
-      # @param see QuestradeApi::REST::Activity.all
+      # @param see QuestradeApi::REST::Activity.fetch
       #
       # @return [OpenStruct(executions: [QuestradeApi::REST::Activity)]
       def activities(params)
-        QuestradeApi::REST::Activity.all(authorization, id, params)
+        QuestradeApi::REST::Activity.fetch(authorization, id, params)
       end
 
       # Fetch executions associated with account.
       #
-      # @param see QuestradeApi::REST::Execution.all
+      # @param see QuestradeApi::REST::Execution.fetch
       #
       # @return [OpenStruct(executions: [QuestradeApi::REST::Execution)]
       def executions(params)
-        QuestradeApi::REST::Execution.all(authorization, id, params)
+        QuestradeApi::REST::Execution.fetch(authorization, id, params)
       end
 
       # Fetch balances associated with account.
       #
       # @return [OpenStruct(per_currency_balances)]
       def balances
-        QuestradeApi::REST::Balance.all(authorization, id)
+        QuestradeApi::REST::Balance.fetch(authorization, id)
       end
 
       # Fetch positions associated with account.
       #
       # @return [OpenStruct(positions: [QuestradeApi::REST::Position])]
       def positions
-        QuestradeApi::REST::Position.all(authorization, id)
+        QuestradeApi::REST::Position.fetch(authorization, id)
       end
 
       # Fetch accounts for specific authorized user.
@@ -62,7 +62,7 @@ module QuestradeApi
       #
       # @return [OpenStruct(accounts: [QuestradeApi::REST::Account])] if call to server is successful
       # @return [Faraday::Response] if call to server is not successful
-      def self.all(authorization)
+      def self.fetch(authorization)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint,
                          url: authorization.url)

data/lib/questrade_api/rest/activity.rb

@@ -21,7 +21,7 @@ module QuestradeApi
       # @param params [Hash] with the range of dates the activities will be fetched
       # @option params [String] :startTime The start time. ex: '2011-02-16T00:00:00.000000-05:00'
       # @option params [String] :endTime The end time. ex: '2011-02-16T00:00:00.000000-05:00'
-      def self.all(authorization, account_number, params)
+      def self.fetch(authorization, account_number, params)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(account_number),
                          url: authorization.url,

data/lib/questrade_api/rest/balance.rb

@@ -20,7 +20,7 @@ module QuestradeApi
       # @param account_number [String] with the account the activities will be fetched
       # @return [OpenStruct(per_currency_balances, combined_balances, sod_per_currency_balances, sod_combined_balances)] If call succeeds. Each method returns an array of QuestradeApi::REST::Balance
       # @return [Faraday::Response] if call fails.
-      def self.all(authorization, account_number)
+      def self.fetch(authorization, account_number)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(account_number),
                          url: authorization.url)

data/lib/questrade_api/rest/base.rb

@@ -56,7 +56,7 @@ module QuestradeApi
         @raw_body = JSON.parse(response.body)
       end
 
-      def get(params = {})
+      def fetch(params = {})
         response = @connection.get do |req|
           req.path = params[:endpoint] || self.class.endpoint
 
@@ -71,7 +71,7 @@ module QuestradeApi
       end
 
       class << self
-        def all(params = {})
+        def fetch(params = {})
           connection = connection(params)
 
           connection.get do |req|

data/lib/questrade_api/rest/candle.rb

@@ -8,7 +8,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def self.all(authorization, symbol_id, params)
+      def self.fetch(authorization, symbol_id, params)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(symbol_id),
                          url: authorization.url,

data/lib/questrade_api/rest/execution.rb

@@ -21,7 +21,7 @@ module QuestradeApi
       # @param params [Hash] with the range of dates the activities will be fetched
       # @option params [String] :startTime The start time. ex: '2011-02-16T00:00:00.000000-05:00'
       # @option params [String] :endTime The end time. ex: '2011-02-16T00:00:00.000000-05:00'
-      def self.all(authorization, account_number, params)
+      def self.fetch(authorization, account_number, params)
 
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(account_number),

data/lib/questrade_api/rest/market.rb

@@ -8,7 +8,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def self.all(authorization)
+      def self.fetch(authorization)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint,
                          url: authorization.url)

data/lib/questrade_api/rest/option.rb

@@ -8,7 +8,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def self.all(authorization, symbol_id)
+      def self.fetch(authorization, symbol_id)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(symbol_id),
                          url: authorization.url)

data/lib/questrade_api/rest/order.rb

@@ -15,7 +15,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def self.all(authorization, account_number, params)
+      def self.fetch(authorization, account_number, params)
 
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(account_number),

data/lib/questrade_api/rest/position.rb

@@ -12,7 +12,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def self.all(authorization, account_number)
+      def self.fetch(authorization, account_number)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint(account_number),
                          url: authorization.url)

data/lib/questrade_api/rest/quote.rb

@@ -13,7 +13,7 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
-      def get
+      def fetch
         response = super(endpoint: endpoint)
 
         if response.status == 200
@@ -23,7 +23,7 @@ module QuestradeApi
         response
       end
 
-      def self.all(authorization, ids)
+      def self.fetch(authorization, ids)
         response = super(access_token: authorization.access_token,
                          endpoint: endpoint,
                          url: authorization.url,

data/lib/questrade_api/rest/symbol.rb

@@ -14,15 +14,29 @@ module QuestradeApi
         build_data(params[:data]) if @raw_body
       end
 
+      def fetch
+        response = super(endpoint: endpoint)
+
+        if response.status == 200
+          parse_symbols(response.body)
+        end
+
+        response
+      end
+
+      def endpoint
+        self.class.endpoint + "#{id}"
+      end
+
       def self.endpoint(extra = '')
         "#{BASE_ENDPOINT}/symbols/#{extra}"
       end
 
       def self.search(authorization, params = {})
-        response = superclass.all(access_token: authorization.access_token,
-                                  endpoint: endpoint('search'),
-                                  url: authorization.url,
-                                  params: params)
+        response = superclass.fetch(access_token: authorization.access_token,
+                                    endpoint: endpoint('search'),
+                                    url: authorization.url,
+                                    params: params)
 
         if response.status == 200
           result = OpenStruct.new(symbols: [])
@@ -33,7 +47,7 @@ module QuestradeApi
         response
       end
 
-      def self.all(authorization, params = {})
+      def self.fetch(authorization, params = {})
         params[:ids] = params[:ids].join(',') if params[:ids]
         params[:names] = params[:names].join(',') if params[:names]
 
@@ -73,6 +87,16 @@ module QuestradeApi
       end
 
       private_class_method :parse_symbols
+
+      private
+
+      def parse_symbols(body)
+        raw = JSON.parse(body)
+
+        raw['symbols'].each do |symbol|
+          build_data(symbol)
+        end
+      end
     end
   end
 end

data/lib/questrade_api/rest/time.rb

@@ -10,10 +10,14 @@ module QuestradeApi
         super(authorization)
       end
 
-      def get
+      def fetch
         response = super
 
-        build_data(raw_body) if raw_body
+        if raw_body
+          build_data(raw_body)
+          data.time = DateTime.parse(data.time)
+          response = data.time
+        end
 
         response
       end

data/lib/questrade_api/version.rb

@@ -1,3 +1,3 @@
 module QuestradeApi
-  VERSION = '0.0.4'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/spec/fixtures/json/symbol_01.json

@@ -0,0 +1,51 @@
+{
+  "symbols": [
+    {
+      "symbol": "AAPL",
+      "symbolId": 8049,
+      "prevDayClosePrice": 102.5,
+      "highPrice52": 102.9,
+      "lowPrice52": 63.89,
+      "averageVol3Months": 43769680,
+      "averageVol20Days": 12860370,
+      "outstandingShares": 5987867000,
+      "eps": 6.2,
+      "pe": 16.54,
+      "dividend": 0.47,
+      "yield": 1.84,
+      "exDate": "2014-08-07T00:00:00.000000-04:00",
+      "marketCap": 613756367500,
+      "tradeUnit": 1,
+      "optionType": null,
+      "optionDurationType": null,
+      "optionRoot": "",
+      "optionContractDeliverables": {
+        "underlyings": [],
+        "cashInLieu": 0
+      },
+      "optionExerciseType": null,
+      "listingExchange": "NASDAQ",
+      "description": "APPLE INC",
+      "securityType": "Stock",
+      "optionExpiryDate": null,
+      "dividendDate": "2014-08-14T00:00:00.000000-04:00",
+      "optionStrikePrice": null,
+      "isTradable": true,
+      "isQuotable": true,
+      "hasOptions": true,
+      "minTicks": [
+        {
+          "pivot": 0,
+          "minTick": 0.0001
+        },
+        {
+          "pivot": 1,
+          "minTick": 0.01
+        }
+      ],
+      "industrySector": "BasicMaterials",
+      "industryGroup":  "Steel",
+      "industrySubGroup": "Steel"
+    }
+  ]
+}

data/spec/questrade_api/modules/account_call_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+require 'questrade_api/modules/account_call'
+
+describe QuestradeApi::AccountCall do
+  class DummyClass
+    attr_accessor :authorization
+
+    def initialize(authorization)
+      @authorization = authorization
+    end
+  end
+
+  let(:authorization) do
+    OpenStruct.new(access_token: '123', url: 'test')
+  end
+
+  subject { DummyClass.new(authorization).extend(QuestradeApi::AccountCall) }
+
+  context '.time' do
+    it 'calls proper endpoint' do
+      time = DateTime.now
+      expect_any_instance_of(QuestradeApi::REST::Time).to receive(:fetch).and_return(time)
+
+      expect(subject.time).to be(time)
+    end
+  end
+
+  context '.accounts' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Account).to receive(:fetch).and_return([])
+      expect(subject.accounts).to eq([])
+    end
+  end
+
+  context '.positions' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Position).to receive(:fetch).and_return([])
+      expect(subject.positions('1')).to eq([])
+    end
+  end
+
+  context '.balances' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Balance).to receive(:fetch).and_return([])
+      expect(subject.balances('1')).to eq([])
+    end
+  end
+
+  context '.executions' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Execution).to receive(:fetch).and_return([])
+      expect(subject.executions('1')).to eq([])
+    end
+  end
+
+  context '.activities' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Activity).to receive(:fetch).and_return([])
+      expect(subject.activities('1')).to eq([])
+    end
+  end
+
+  context '.orders' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Order).to receive(:fetch).and_return([])
+      expect(subject.orders('1')).to eq([])
+    end
+  end
+end

data/spec/questrade_api/modules/market_call_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+require 'questrade_api/modules/market_call'
+
+describe QuestradeApi::MarketCall do
+  class DummyClass
+    attr_accessor :authorization
+
+    def initialize(authorization)
+      @authorization = authorization
+    end
+  end
+
+  let(:authorization) do
+    OpenStruct.new(access_token: '123', url: 'test')
+  end
+
+  subject { DummyClass.new(authorization).extend(QuestradeApi::MarketCall) }
+
+  context '.markets' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Market).to receive(:fetch).and_return([])
+      expect(subject.markets).to eq([])
+    end
+  end
+
+  context '.symbols' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Symbol).to receive(:fetch).and_return([])
+      expect(subject.symbols('')).to eq([])
+    end
+  end
+
+  context '.search_symbols' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Symbol).to receive(:search).and_return([])
+      expect(subject.search_symbols('')).to eq([])
+    end
+  end
+
+  context '.quotes' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Quote).to receive(:fetch).and_return([])
+      expect(subject.quotes([123])).to eq([])
+    end
+  end
+
+  context '.quote' do
+    it 'calls proper endpoint' do
+      expect_any_instance_of(QuestradeApi::REST::Quote).to receive(:fetch).and_return([])
+      expect(subject.quote(1)).to be_a(QuestradeApi::REST::Quote)
+    end
+  end
+
+  context '.candles' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Candle).to receive(:fetch).and_return([])
+      expect(subject.candles('', '12')).to eq([])
+    end
+  end
+
+  context '.symbol_options' do
+    it 'calls proper endpoint' do
+      expect(QuestradeApi::REST::Market).to receive(:fetch).and_return([])
+      expect(subject.markets).to eq([])
+    end
+  end
+end

data/spec/questrade_api/rest/account_spec.rb

@@ -15,7 +15,7 @@ describe QuestradeApi::REST::Account do
 
     it 'returns a list of activities' do
       expect(QuestradeApi::REST::Activity)
-        .to(receive(:all).with(authorization, id, {}))
+        .to(receive(:fetch).with(authorization, id, {}))
         .once
 
       subject.activities({})
@@ -23,7 +23,7 @@ describe QuestradeApi::REST::Account do
 
     it 'returns a list of executions' do
       expect(QuestradeApi::REST::Execution)
-        .to(receive(:all).with(authorization, id, {}))
+        .to(receive(:fetch).with(authorization, id, {}))
         .once
 
       subject.executions({})
@@ -31,7 +31,7 @@ describe QuestradeApi::REST::Account do
 
     it 'returns a list of positions' do
       expect(QuestradeApi::REST::Position)
-        .to(receive(:all).with(authorization, id))
+        .to(receive(:fetch).with(authorization, id))
         .once
 
       subject.positions
@@ -39,21 +39,21 @@ describe QuestradeApi::REST::Account do
 
     it 'returns a list of balances' do
       expect(QuestradeApi::REST::Balance)
-        .to(receive(:all).with(authorization, id))
+        .to(receive(:fetch).with(authorization, id))
         .once
 
       subject.balances
     end
   end
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's accounts" do
       full_url = url + QuestradeApi::REST::Account.endpoint
       stub_request(:get, full_url).to_return(status: 200,
                                              body: json_string('accounts.json'),
                                              headers: {})
 
-      response = QuestradeApi::REST::Account.all(authorization)
+      response = QuestradeApi::REST::Account.fetch(authorization)
 
       expect(response.accounts.size).to be(2)
 

data/spec/questrade_api/rest/activity_spec.rb

@@ -10,7 +10,7 @@ describe QuestradeApi::REST::Activity do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's activities for the specific period" do
       start_time = '2011-02-16T00:00:00.000000-05:00'
       end_time = '2011-02-16T00:00:00.000000-05:00'
@@ -19,7 +19,7 @@ describe QuestradeApi::REST::Activity do
         url + QuestradeApi::REST::Activity.endpoint(account_id) + "?#{params}"
       stub_request(:get, full_url).to_return(status: 200, body: json_string('activities.json'))
 
-      response = QuestradeApi::REST::Activity.all(authorization, account_id,
+      response = QuestradeApi::REST::Activity.fetch(authorization, account_id,
                                                   { startTime: start_time,
                                                     endTime: end_time })
 

data/spec/questrade_api/rest/balance_spec.rb

@@ -10,13 +10,13 @@ describe QuestradeApi::REST::Balance do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's balances" do
       full_url =
         url + QuestradeApi::REST::Balance.endpoint(account_id)
       stub_request(:get, full_url).to_return(status: 200, body: json_string('balances.json'))
 
-      response = QuestradeApi::REST::Balance.all(authorization, account_id)
+      response = QuestradeApi::REST::Balance.fetch(authorization, account_id)
 
       expect(response.per_currency_balances.size).to be(2)
       expect(response.combined_balances.size).to be(1)

data/spec/questrade_api/rest/candle_spec.rb

@@ -8,7 +8,7 @@ describe QuestradeApi::REST::Candle do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it 'fetches candle for an specific symbol' do
       start_time = '2014-10-01T00:00:00-05:00'
       end_time = '2014-10-01T00:00:00-05:00'
@@ -22,7 +22,7 @@ describe QuestradeApi::REST::Candle do
         interval: interval
       }
 
-      response = QuestradeApi::REST::Candle.all(authorization, 1010, params)
+      response = QuestradeApi::REST::Candle.fetch(authorization, 1010, params)
 
       expect(response.candles.size).to be(1)
 

data/spec/questrade_api/rest/execution_spec.rb

@@ -10,7 +10,7 @@ describe QuestradeApi::REST::Execution do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's executions for the specific period" do
       start_time = '2014-03-31T13:38:29-04:00'
       end_time = '2014-03-31T13:38:29-04:00'
@@ -19,7 +19,7 @@ describe QuestradeApi::REST::Execution do
         url + QuestradeApi::REST::Execution.endpoint(account_id) + "?#{params}"
       stub_request(:get, full_url).to_return(status: 200, body: json_string('executions.json'))
 
-      response = QuestradeApi::REST::Execution.all(authorization, account_id,
+      response = QuestradeApi::REST::Execution.fetch(authorization, account_id,
                                                    startTime: start_time,
                                                    endTime: end_time)
 

data/spec/questrade_api/rest/market_spec.rb

@@ -10,13 +10,13 @@ describe QuestradeApi::REST::Market do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all supported" do
       full_url = url + QuestradeApi::REST::Market.endpoint
 
       stub_request(:get, full_url).to_return(status: 200, body: json_string('markets.json'))
 
-      response = QuestradeApi::REST::Market.all(authorization)
+      response = QuestradeApi::REST::Market.fetch(authorization)
 
       expect(response.markets.size).to be(1)
 

data/spec/questrade_api/rest/option_spec.rb

@@ -8,12 +8,12 @@ describe QuestradeApi::REST::Option do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it 'fetches option chain for an specific symbol' do
        stub_request(:get, 'http://test.com/v1/symbol/9291/options')
          .to_return(status: 200, body: json_string('options.json'))
 
-      response = QuestradeApi::REST::Option.all(authorization, 9291)
+      response = QuestradeApi::REST::Option.fetch(authorization, 9291)
 
       expect(response.options.size).to be(1)
 

data/spec/questrade_api/rest/order_spec.rb

@@ -10,7 +10,7 @@ describe QuestradeApi::REST::Order do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's orders" do
       time = '2014-03-31T13:38:29-04:00'
       params = "startTime=#{time}&endTime=#{time}&stateFilter=All"
@@ -19,7 +19,7 @@ describe QuestradeApi::REST::Order do
 
       stub_request(:get, full_url).to_return(status: 200, body: json_string('orders.json'))
 
-      response = QuestradeApi::REST::Order.all(authorization, account_id,
+      response = QuestradeApi::REST::Order.fetch(authorization, account_id,
                                                startTime: time, endTime: time, stateFilter: 'All')
 
       expect(response.orders.size).to be(1)

data/spec/questrade_api/rest/position_spec.rb

@@ -10,13 +10,13 @@ describe QuestradeApi::REST::Position do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '.all' do
+  context '.fetch' do
     it "returns an object that contains a list of all user's positions" do
       full_url = url + QuestradeApi::REST::Position.endpoint(account_id)
 
       stub_request(:get, full_url).to_return(status: 200, body: json_string('positions.json'))
 
-      response = QuestradeApi::REST::Position.all(authorization, account_id)
+      response = QuestradeApi::REST::Position.fetch(authorization, account_id)
 
       expect(response.positions.size).to be(1)
 

data/spec/questrade_api/rest/quote_spec.rb

@@ -27,7 +27,7 @@ describe QuestradeApi::REST::Quote do
 
       expect(subject.data).to be_nil
 
-      subject.get
+      subject.fetch
 
       expect(subject.data.to_h).to eq(
         symbol: "THI.TO",
@@ -52,12 +52,12 @@ describe QuestradeApi::REST::Quote do
     end
   end
 
-  context '.all' do
+  context '.fetch' do
     it 'fetches quote for an specific symbol' do
       stub_request(:get, 'http://test.com/v1/markets/quotes?ids=12,11')
          .to_return(status: 200, body: json_string('quotes.json'))
 
-      response = QuestradeApi::REST::Quote.all(authorization, [12, 11])
+      response = QuestradeApi::REST::Quote.fetch(authorization, [12, 11])
 
       expect(response.quotes.size).to be(1)
 

data/spec/questrade_api/rest/symbol_spec.rb

@@ -10,8 +10,73 @@ describe QuestradeApi::REST::Symbol do
   let(:url) { 'http://test.com'}
   let(:authorization) { OpenStruct.new(access_token: access_token, url: url) }
 
-  context '#get' do
-    
+  context '#fetch' do
+    subject { QuestradeApi::REST::Symbol.new(authorization, id: 10) }
+
+    it 'fetches symbol data' do
+      stub_request(:get, "http://test.com/v1/symbols/10")
+        .to_return(status: 200, body: json_string('symbol_01.json'))
+
+
+      expect(subject.data).to be_nil
+      subject.fetch
+      expect(subject.data.to_h).to eq(
+        symbol: 'AAPL',
+        symbol_id: 8049,
+        prev_day_close_price: 102.5,
+        high_price52: 102.9,
+        low_price52: 63.89,
+        average_vol3_months: 43769680,
+        average_vol20_days: 12860370,
+        outstanding_shares: 5987867000,
+        eps: 6.2,
+        pe: 16.54,
+        dividend: 0.47,
+        yield: 1.84,
+        ex_date: "2014-08-07T00:00:00.000000-04:00",
+        market_cap: 613756367500,
+        trade_unit: 1,
+        option_type: nil,
+        option_duration_type: nil,
+        option_root: "",
+        option_contract_deliverables: {
+          'underlyings' => [],
+          'cashInLieu' => 0
+        },
+        option_exercise_type: nil,
+        listing_exchange: "NASDAQ",
+        description: "APPLE INC",
+        security_type: "Stock",
+        option_expiry_date: nil,
+        dividend_date: "2014-08-14T00:00:00.000000-04:00",
+        option_strike_price: nil,
+        is_tradable: true,
+        is_quotable: true,
+        has_options: true,
+        min_ticks: [
+          {
+            'pivot' => 0,
+            'minTick' => 0.0001
+          },
+          {
+            'pivot' => 1,
+            'minTick' => 0.01
+          }
+        ],
+        industry_sector: "BasicMaterials",
+        industry_group:  "Steel",
+        industry_sub_group: "Steel")
+    end
+
+  end
+
+  context '#endpoint' do
+    subject { QuestradeApi::REST::Symbol.new(authorization, id: 10) }
+
+    it 'calls endpoint' do
+      url = "/v1/symbols/10"
+      expect(subject.endpoint).to eq(url)
+    end
   end
 
   context '.search' do
@@ -68,14 +133,14 @@ describe QuestradeApi::REST::Symbol do
     end
   end
 
-  context '.all' do
+  context '.fetch' do
     let(:ids) { [8049, 8050] }
     let(:names) { ['AAPL', 'GOOGL'] }
 
     it 'calls endpoint passing a list of ids' do
       stub_request(:get, "http://test.com/v1/symbols/?ids=8049,8050")
         .to_return(status: 200, body: '{}').times(1)
-      response = QuestradeApi::REST::Symbol.all(authorization, ids: ids)
+      response = QuestradeApi::REST::Symbol.fetch(authorization, ids: ids)
 
       expect(response.symbols.size).to be(0)
     end
@@ -83,7 +148,7 @@ describe QuestradeApi::REST::Symbol do
     it 'calls endpoint passing a list of names' do
       stub_request(:get, "http://test.com/v1/symbols/?names=AAPL,GOOGL")
         .to_return(status: 200, body: '{}')
-      response = QuestradeApi::REST::Symbol.all(authorization, names: names)
+      response = QuestradeApi::REST::Symbol.fetch(authorization, names: names)
 
       expect(response.symbols.size).to be(0)
     end
@@ -92,7 +157,7 @@ describe QuestradeApi::REST::Symbol do
       stub_request(:get, "http://test.com/v1/symbols/")
         .to_return(status: 200, body: json_string('symbols.json'))
 
-      response = QuestradeApi::REST::Symbol.all(authorization)
+      response = QuestradeApi::REST::Symbol.fetch(authorization)
 
       expect(response.symbols.size).to be(1)
 

data/spec/questrade_api/rest/time_spec.rb

@@ -11,7 +11,7 @@ describe QuestradeApi::REST::Time do
 
   subject { QuestradeApi::REST::Time.new(authorization) }
 
-  context '#get' do
+  context '#fetch' do
     let(:url) { 'http://test.com/v1/time' }
 
     it 'calls the proper endpoint with proper data' do
@@ -19,10 +19,21 @@ describe QuestradeApi::REST::Time do
 
       stub_request(:get, url).to_return(status: 200,
                                         body: json_string('time.json'))
-      subject.get
+      subject.fetch
+
+      expected_return = DateTime.parse('2017-01-24T12:14:42.730000-04:00')
 
       expect(subject.data).to_not be_nil
-      expect(subject.data.time).to eq('2017-01-24T12:14:42.730000-04:00')
+      expect(subject.data.time).to eq(expected_return)
+    end
+
+    it 'returns time' do
+      stub_request(:get, url).to_return(status: 200,
+                                        body: json_string('time.json'))
+      result = subject.fetch
+
+      expected_return = DateTime.parse('2017-01-24T12:14:42.730000-04:00')
+      expect(result).to eq(expected_return)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: questrade_api
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Bruno Meira
@@ -77,6 +77,7 @@ files:
 - ".rspec"
 - ".travis.yml"
 - ".yardopts"
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE
@@ -85,6 +86,8 @@ files:
 - lib/questrade_api.rb
 - lib/questrade_api/authorization.rb
 - lib/questrade_api/client.rb
+- lib/questrade_api/modules/account_call.rb
+- lib/questrade_api/modules/market_call.rb
 - lib/questrade_api/modules/util.rb
 - lib/questrade_api/rest/account.rb
 - lib/questrade_api/rest/activity.rb
@@ -112,11 +115,14 @@ files:
 - spec/fixtures/json/positions.json
 - spec/fixtures/json/quote_01.json
 - spec/fixtures/json/quotes.json
+- spec/fixtures/json/symbol_01.json
 - spec/fixtures/json/symbols.json
 - spec/fixtures/json/symbols_search.json
 - spec/fixtures/json/time.json
 - spec/questrade_api/authorization_spec.rb
 - spec/questrade_api/client_spec.rb
+- spec/questrade_api/modules/account_call_spec.rb
+- spec/questrade_api/modules/market_call_spec.rb
 - spec/questrade_api/rest/account_spec.rb
 - spec/questrade_api/rest/activity_spec.rb
 - spec/questrade_api/rest/balance_spec.rb
@@ -167,11 +173,14 @@ test_files:
 - spec/fixtures/json/positions.json
 - spec/fixtures/json/quote_01.json
 - spec/fixtures/json/quotes.json
+- spec/fixtures/json/symbol_01.json
 - spec/fixtures/json/symbols.json
 - spec/fixtures/json/symbols_search.json
 - spec/fixtures/json/time.json
 - spec/questrade_api/authorization_spec.rb
 - spec/questrade_api/client_spec.rb
+- spec/questrade_api/modules/account_call_spec.rb
+- spec/questrade_api/modules/market_call_spec.rb
 - spec/questrade_api/rest/account_spec.rb
 - spec/questrade_api/rest/activity_spec.rb
 - spec/questrade_api/rest/balance_spec.rb