query_reviewer 0.1.8 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 374e1e04da1ecd76345bc0d2d5fa27b271353d82
+  data.tar.gz: fba57820f216e24ee0e761cbfe7288b3009114c2
+SHA512:
+  metadata.gz: 01928b657a61a7d6e01f6a8540299c706d2a3484faff16936b473e0262f8e7d264a70873990d65e0d01faa3be01486268ce9eafc2c2db56aff1209ea262b5a0f
+  data.tar.gz: 333bb606fafad2f1bf5db506335e1f364437d426ec64d2f6ee4ac97396eae838b7705ead69be8cbb1caba57468bc00fc5e4208f56f3bf5739d816d690921fb71

data/README.md

@@ -11,8 +11,8 @@ QueryReviewer is an advanced SQL query analyzer.  It accomplishes the following
 
 ## Use This Fork ##
 
-I use this utility for most of my MySQL-backed Rails projects. Still the best out there in my opinion for analyzing and understanding your generated SQL queries. 
-I forked the original [query_reviewer](https://github.com/dsboulder/query_reviewer) and applied a collection of patches that have been made since the plugin was created. 
+I use this utility for most of my MySQL-backed Rails projects. Still the best out there in my opinion for analyzing and understanding your generated SQL queries.
+I forked the original [query_reviewer](https://github.com/dsboulder/query_reviewer) and applied a collection of patches that have been made since the plugin was created.
 A list of the biggest additions below:
 
  * Snazzed up the README into markdown for better readability
@@ -24,8 +24,8 @@ A list of the biggest additions below:
  * Fixes for deprecation warnings and for 1.9 compatiblity
  * Converts templates to more modern foo.html.erb naming
 
-As of August 2011, This has become the "official" version to use. David has deprecated the [original repo](https://github.com/dsboulder/query_reviewer) and recommends that people looking for this utility use this fork instead. 
-This fork compiles a variety of patches that were made since that time along with additional work to support compatibility with 1.9 and Rails 3. 
+As of August 2011, This has become the "official" version to use. David has deprecated the [original repo](https://github.com/dsboulder/query_reviewer) and recommends that people looking for this utility use this fork instead.
+This fork compiles a variety of patches that were made since that time along with additional work to support compatibility with 1.9 and Rails 3.
 **Also:** If anyone else creates generally useful enhancements to this utility please start by forking this and then issue me a pull request.
 
 **Note:** This plugin should work for Rails 2.X and Rails 3. If you run into issues, please file a bug report or send a pull request. I consider this new fork to be a group effort
@@ -33,7 +33,7 @@ so if you want to be added as a contributor to help maintain this, please let me
 
 ## Database Limitations ##
 
-As of right now, this plugin  supports analyzing queries **only for MySQL**. I consider this the primary **limitation** of this gem. 
+As of right now, this plugin  supports analyzing queries **only for MySQL**. I consider this the primary **limitation** of this gem.
 I am now using PostgreSQL for a number of my projects and the "EXPLAIN" output is totally different. Several people have started a PostgreSQL adapter for
 this plugin, but none that are mature enough to include here.
 
@@ -49,7 +49,12 @@ All you have to do is install it into your Rails 2 or 3 project.
 Right now if you use bundler, simply add this to your Gemfile:
 
     # Gemfile
-    gem "query_reviewer", :git => "git://github.com/nesquena/query_reviewer.git"
+    gem "query_reviewer"
+
+or to use the latest from github:
+
+    # Gemfile
+    gem "query_reviewer", :github => "nesquena/query_reviewer"
 
 If you are not using bundler, you might want to [start using it](http://gembundler.com/rails23.html). You can also install this as a plugin:
 
@@ -129,8 +134,7 @@ Know of a better alternative? Let me know!
 
 ## Acknowledgements ##
 
-Created by Kongregate & David Stevenson.
-Refactorings and compilations of all fixes since was done by Nathan Esquenazi.
-Also, ajvargo for helping with some fixes.
+Created by Kongregate & David Stevenson. Refactorings and maintenance done by Nathan Esquenazi.
+Also [@ajvargo](http://github.com/ajvargo) helped with several fixes.
 
 Copyright (c) 2007-2008 Kongregate & David Stevenson, released under the MIT license

data/Rakefile

@@ -1,6 +1,6 @@
 require 'rake'
 require 'rake/testtask'
-require 'rake/rdoctask'
+require 'rdoc/task'
 require 'bundler'
 Bundler::GemHelper.install_tasks
 

data/lib/query_reviewer/mysql_adapter_extensions.rb

@@ -17,11 +17,14 @@ module QueryReviewer
       result
     end
 
-    def insert_with_review(sql, *args)
+    def insert_with_review(arel, name = nil, pk = nil, id_value = nil, sequence_name = nil, binds = [])
+      bind_params = binds.clone
+
       t1 = Time.now
-      result = insert_without_review(sql, *args)
+      result = insert_without_review(arel, name, pk, id_value, sequence_name, binds)
       t2 = Time.now
 
+      sql = to_sql(arel, bind_params)
       create_or_add_query_to_query_reviewer!(sql, nil, t2 - t1, nil, "INSERT")
 
       result

data/lib/query_reviewer/mysql_analyzer.rb

@@ -34,7 +34,7 @@ module QueryReviewer
     def analyze_key!
       if self.key == "const"
         praise "Way to go!"
-      elsif self.key.blank? && !self.extra.include?("select tables optimized away")
+      elsif self.key.blank? && !self.extra.include?("select tables optimized away") && !self.extra.include?("impossible where noticed after reading const tables")
         warn :severity => 6, :field => "key", :desc => "No index was used here. In this case, that meant scanning #{self.rows} rows."
       end
     end

data/lib/query_reviewer/sql_query.rb

@@ -23,7 +23,7 @@ module QueryReviewer
     end
 
     def add(sql, duration, profile)
-      sql << sql
+      sqls << sql
       durations << duration
       profiles << profile
     end
@@ -65,7 +65,7 @@ module QueryReviewer
     end
 
     def table
-      @subqueries.first.table
+      @subqueries.first.try(:table)
     end
 
     def analyze!

data/lib/query_reviewer/views/_query_with_warning.html.erb

@@ -12,12 +12,15 @@
             <%= query_with_warning.count  %> identical queries
         </b>
       <% end %>
-      <i>Table <%= (query_with_warning.warnings.detect {|w| !w.table.blank? } || query_with_warning.warnings.last).table %>:</i>
-			<% query_with_warning.warnings.sort{|a,b| a.severity <=> b.severity}.reverse.each_with_index do |warn, index| %>
-				<span style="color: <%= severity_color warn.severity%>;" title="<%= warn.desc%>"><%= warn.problem %></span><%= ", " if index < query_with_warning.warnings.length - 1 %>
-			<% end %>
-			<a href="#" onclick="query_review_toggle('warning_<%= query_with_warning.id %>_desc')" title="show/hide warning message">MSG</a>
-			<a href="#" onclick="query_review_toggle('warning_<%= query_with_warning.id %>_sql')" title="show/hide sql">SQL</a>
+      <i>Table <%= (query_with_warning.warnings.detect {|w| !w.table.blank? } || query_with_warning.warnings.last).table.presence || 'unknown'%>:</i>
+      <% query_with_warning.warnings.sort{|a,b| a.severity <=> b.severity}.reverse.each_with_index do |warn, index| %>
+        <span style = "color: <%= severity_color warn.severity%>;" title="<%= warn.desc%>"><%= warn.problem %></span><%= ", " if index < query_with_warning.warnings.length - 1 %>
+      <% end %>
+      <% if query_with_warning.warnings.any?{|w|w.desc.present?} %>
+        <a href      = "#" onclick="query_review_toggle('warning_<%= query_with_warning.id %>_desc')" title="show/hide warning message">MSG</a>
+      <% end %>
+      <a href      = "#" onclick="query_review_toggle('warning_<%= query_with_warning.id %>_sql')" title="show/hide sql">SQL</a>
+
       <% if query_with_warning.select? %>
       	<a href="#" onclick="query_review_toggle('warning_<%= query_with_warning.id %>_explain')" title="show/hide explain output">EXPLN</a>
       <% end %>

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: query_reviewer
 version: !ruby/object:Gem::Version
-  version: 0.1.8
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - dsboulder, nesquena
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-08 00:00:00.000000000 Z
+date: 2013-09-16 00:00:00.000000000 Z
 dependencies: []
 description: Runs explain before each select query and displays results in an overlayed
   div
@@ -52,27 +51,27 @@ files:
 homepage: https://github.com/nesquena/query_reviewer
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Runs explain before each select query and displays results in an overlayed
   div
 test_files: []
+has_rdoc: