query_reviewer 0.1.2 → 0.1.3

data/README.md

@@ -9,9 +9,11 @@ QueryReviewer is an advanced SQL query analyzer.  It accomplishes the following
  * Attach meaningful warnings to individual queries, and collections of queries
  * Display interactive summary on page
 
-## This Fork ##
+## Use This Fork ##
 
-I use this utility for most of my rails projects. Still the best out there in my opinion for analyzing and understanding your generated SQL queries. I forked the original [query_reviewer](https://github.com/dsboulder/query_reviewer) and applied a collection of patches that have been made since the plugin was created. A list of the biggest additions below:
+I use this utility for most of my MySQL-backed Rails projects. Still the best out there in my opinion for analyzing and understanding your generated SQL queries. 
+I forked the original [query_reviewer](https://github.com/dsboulder/query_reviewer) and applied a collection of patches that have been made since the plugin was created. 
+A list of the biggest additions below:
 
  * Snazzed up the README into markdown for better readability
  * Full compatibility for Rails 3 (including Railtie)
@@ -22,9 +24,21 @@ I use this utility for most of my rails projects. Still the best out there in my
  * Fixes for deprecation warnings and for 1.9 compatiblity
  * Converts templates to more modern foo.html.erb naming
 
-Last commit to the main repository was on March 30th, 2009. This fork compiles a variety of patches that were made since that time along with additional work to support compatibility with 1.9 and Rails 3. **Also:** If anyone else creates generally useful enhancements to this utility please start by forking this and then issue me a pull request.
+As of August 2011, This has become the "official" version to use. David has deprecated the [original repo](https://github.com/dsboulder/query_reviewer) and recommends that people looking for this utility use this fork instead. 
+This fork compiles a variety of patches that were made since that time along with additional work to support compatibility with 1.9 and Rails 3. 
+**Also:** If anyone else creates generally useful enhancements to this utility please start by forking this and then issue me a pull request.
 
-**Note:** This plugin should work for Rails 2.X and Rails 3. Support for Rails 3 has been confirmed in the latest revision (with fixed deprecation warnings).
+**Note:** This plugin should work for Rails 2.X and Rails 3. If you run into issues, please file a bug report or send a pull request. I consider this new fork to be a group effort
+so if you want to be added as a contributor to help maintain this, please let me know!
+
+## Database Limitations ##
+
+As of right now, this plugin  supports analyzing queries **only for MySQL**. I consider this the primary **limitation** of this gem. 
+I am now using PostgreSQL for a number of my projects and the "EXPLAIN" output is totally different. Several people have started a PostgreSQL adapter for
+this plugin, but none that are mature enough to include here.
+
+If anyone is interested at taking a stab at implementing PostgreSQL support for this utility, that would be hugely appreciated! I hope this plugin can come to support
+all the major Rails adapters over time.
 
 ## Installation ##
 
@@ -66,8 +80,8 @@ The configuration file allows you to set configuration parameters shared across
  * `profiling`: when enabled, runs the MySQL SET PROFILING=1 for queries longer than the `warn_duration_threshold` / 2.0
  * `production_data`: whether the duration of a query should be taken into account
  * `stack_trace_lines`: number of lines of call stack to include in the "short" version of the stack trace
- * `trace_includes_vendor`: whether the "short" verison of the stack trace should include files in /vendor
- * `trace_includes_lib`: whether the "short" verison of the stack trace should include files in /lib
+ * `trace_includes_vendor`: whether the "short" version of the stack trace should include files in /vendor
+ * `trace_includes_lib`: whether the "short" version of the stack trace should include files in /lib
  * `warn_severity`: the severity of problem that merits "WARNING" status
  * `critical_severity`: the severity of problem that merits "CRITICAL" status
  * `warn_query_count`: the number of queries in a single request that merits "WARNING" status

data/lib/query_reviewer.rb

@@ -22,7 +22,12 @@ module QueryReviewer
 
     if enabled?
       begin
-        CONFIGURATION["uv"] ||= !Gem.searcher.find("uv").nil?
+        CONFIGURATION["uv"] ||= if Gem::Specification.respond_to?(:find_all_by_name)
+          !Gem::Specification.find_all_by_name('uv').empty?
+        else # RubyGems < 1.8.0
+          !Gem.searcher.find("uv").nil?
+        end
+
         if CONFIGURATION["uv"]
           require "uv"
         end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: query_reviewer
 version: !ruby/object:Gem::Version 
-  hash: 31
-  prerelease: false
+  hash: 29
+  prerelease: 
   segments: 
   - 0
   - 1
-  - 2
-  version: 0.1.2
+  - 3
+  version: 0.1.3
 platform: ruby
 authors: 
 - dsboulder, nesquena
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-07 00:00:00 -08:00
+date: 2011-09-01 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -89,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Runs explain before each select query and displays results in an overlayed div