que 0.13.1 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84236991a2c98675b76421acf236b3b2eaa08573
-  data.tar.gz: a4b012520d11a41263be5364e32262a68a263cb2
+  metadata.gz: 4843d8fd43b830ae0e1d7c55704bafe7b6e6a495
+  data.tar.gz: a94cc144ad4f965741832cbaad85b4c0dd512163
 SHA512:
-  metadata.gz: 4e9f11a615eb6493f5d94d715bc2b167164913e12c3b67e911efbd49a9c94c7d93c016f789f1fc1126bf86b3a495e9fc0c700e32ff8445c18230e3a4870b43de
-  data.tar.gz: 6a94dc98d719b0ce042dac9c0e259a2f7a73d707c4bddeaec5ba6574cc63343735b9d263ec399d80cf98f8302eb0a122247effd16b4d83d736c37e2845921adf
+  metadata.gz: eff7a4cf805af9ebf2953aa28dfd7f4fc655b05c833d1ce33d6002acda23948c526aa0896724aa234f80d9e3fd73a3a87c06f950ff3b66486f4a4512bd8187e4
+  data.tar.gz: c61e4dd27ea718bee177047eff158d4d18cc57d4c73a810e985a58749b65a7ea854bb7de1bcf3663d33c2329dfefeee91ef842356467be92b913c3ad015c51fa

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 0.14.0 (2017-08-11)
+
+*   Fix incompatibility with Rails 5.1.
+
+*   Drop support for waking an in-process worker when an ActiveRecord transaction commits.
+
 ### 0.13.1 (2017-07-05)
 
 *   Fix issue that caused error stacktraces to not be persisted in most cases.

data/lib/que/adapters/active_record.rb

@@ -7,15 +7,6 @@ module Que
         checkout_activerecord_adapter { |conn| yield conn.raw_connection }
       end
 
-      def wake_worker_after_commit
-        # Works with ActiveRecord 3.2 and 4 (possibly earlier, didn't check)
-        if in_transaction?
-          checkout_activerecord_adapter { |adapter| adapter.add_transaction_record(TransactionCallback.new) }
-        else
-          Que.wake!
-        end
-      end
-
       def cleanup!
         # ActiveRecord will check out connections to the current thread when
         # queries are executed and not return them to the pool until
@@ -30,32 +21,6 @@ module Que
         ::ActiveRecord::Base.clear_active_connections!
       end
 
-      class TransactionCallback
-        def has_transactional_callbacks?
-          true
-        end
-
-        def rolledback!(force_restore_state = false, should_run_callbacks = true)
-          # no-op
-        end
-
-        def committed!(should_run_callbacks = true)
-          Que.wake!
-        end
-
-        def before_committed!(*)
-          # no-op
-        end
-
-        def add_to_transaction
-          # no-op.
-          #
-          # This is called when we're in a nested transaction. Ideally we would
-          # `wake!` when the outer transaction gets committed, but that would be
-          # a bigger refactor!
-        end
-      end
-
       private
 
       def checkout_activerecord_adapter(&block)

data/lib/que/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Que
-  Version = '0.13.1'
+  Version = '0.14.0'
 end

data/spec/adapters/active_record_spec.rb

@@ -104,6 +104,8 @@ unless defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
     end
 
     it "should wake up a Worker after queueing a job in async mode, waiting for a transaction to commit if necessary" do
+      pending
+
       Que.mode = :async
       Que.worker_count = 4
       sleep_until { Que::Worker.workers.all? &:sleeping? }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: que
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.14.0
 platform: ruby
 authors:
 - Chris Hanks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-05 00:00:00.000000000 Z
+date: 2017-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -127,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A PostgreSQL-based Job Queue