quartermaster 1.0.0 → 1.0.1

data/README.txt

@@ -4,7 +4,9 @@
 
 == DESCRIPTION:
 
-A collection of shortcuts and helpers for leveraging a request's env in Rails, such as including a browser-specific stylesheet if one exists or putting a short version of the user agent in the CSS classes of the body tag. This removes the need for most hacks or conditional comments since you can now do get browser-specific with your CSS rules (ex. body.ie6 div { ... })
+A collection of shortcuts and helpers for leveraging a request's env in Rails, such as including a browser-specific stylesheet if one exists or putting a short version of the user agent in the CSS classes of the body tag. 
+
+This eliminates the need for most hacks or conditional comments since you can now get browser-specific with your CSS rules (ex. body.ie6 div { ... })
 
 == FEATURES/PROBLEMS:
 
@@ -33,6 +35,7 @@ Another trade-off if you're using stylesheet_link_tag_for_browser is that you ha
 == INSTALL:
 
 * sudo gem install quartermaster
+* In config/environment.rb (or something in config/initializers/), just require 'quartermaster'. It automatically adds its helpers to ActionView::Base
 
 == LICENSE:
 

data/lib/quartermaster.rb

@@ -1,5 +1,5 @@
 module Quartermaster
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
   
   module Helper
     # Uses the output of +browser_from_user_agent+ to figure out what stylesheets to look for and then uses +stylesheet_link_tag+ 
@@ -19,7 +19,7 @@ module Quartermaster
     
     # Returns a space-separated string of the OS and the short user agents for the requesting browser
     def user_agent_for_css
-      "#{os_from_user_agent} #{browser_from_user_agent.join(' ')}"
+      "#{os_from_user_agent} #{browser_from_user_agent.join(' ')}".chomp(' ')
     end
     
     # Returns an array containing the base browser name and a version-specific name (except for Konqueror) for the given +user_agent+ which defaults to Rails' +request.user_agent+
@@ -32,7 +32,7 @@ module Quartermaster
         when /rv:([^)]+)\) gecko/ then "gecko gecko#{$1}"
         when /applewebkit\/(\d)/  then "webkit webkit#{$1}"
         when /konqueror/          then 'konqueror'
-      end.split(' ')
+      end.to_s.split(' ')
     end
     
     # Returns a short version of the OS name for the given +user_agent+ which defaults to Rails' +request.user_agent+

data/test/test_quartermaster.rb

@@ -158,4 +158,15 @@ describe 'Quartermaster' do
       end
     end
   end
+  
+  describe 'when request is from an unrecognized user agent' do
+    before(:each) do
+      @request = mock('Request', :user_agent => 'An unknown user agent')
+      @qm.stub!(:request).and_return(@request)
+    end
+    
+    it "should return an empty string for the CSS classes" do
+      @qm.user_agent_for_css.should == ''
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: quartermaster
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Dave Myron
@@ -30,7 +30,7 @@ cert_chain:
   arkBVHd8TABNoJ+MQvwL/7sCwSTiTg==
   -----END CERTIFICATE-----
 
-date: 2008-05-06 00:00:00 -07:00
+date: 2008-05-08 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -42,7 +42,7 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 1.5.1
     version: 
-description: A collection of shortcuts and helpers for leveraging a request's env in Rails, such as including a browser-specific stylesheet if one exists or putting a short version of the user agent in the CSS classes of the body tag. This removes the need for most hacks or conditional comments since you can now do get browser-specific with your CSS rules (ex. body.ie6 div { ... })
+description: A collection of shortcuts and helpers for leveraging a request's env in Rails, such as including a browser-specific stylesheet if one exists or putting a short version of the user agent in the CSS classes of the body tag.   This eliminates the need for most hacks or conditional comments since you can now get browser-specific with your CSS rules (ex. body.ie6 div { ... })
 email: 
 - dave.myron@contentfree.com
 executables: []