quandl_data 1.0.0 → 1.1.0

data/UPGRADE.md

@@ -1,3 +1,8 @@
+## 1.1.0
+
+* it rejects invalid transforms
+* it rejects invalid collapse
+
 ## 1.0.0
 
 * Quandl::Data::Table is removed. Replaced by: Quandl::Data

data/lib/quandl/data/operations.rb

@@ -118,6 +118,7 @@ module Quandl::Data::Operations
     self
   end
   def transform=(value)
+    return false unless Transform.valid?(value)
     @transform = value
     @data_array = Transform.perform( data_array, value )
   end
@@ -128,6 +129,7 @@ module Quandl::Data::Operations
     self
   end
   def collapse=(collapse)
+    return false unless Collapse.valid?(collapse)
     @collapse = collapse
     @frequency = collapse
     @data_array = Collapse.perform( data_array, collapse )

data/lib/quandl/data/version.rb

@@ -1,5 +1,5 @@
 module Quandl
 class Data
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end
 end

data/spec/lib/quandl/data_spec.rb

@@ -2,11 +2,25 @@
 require 'spec_helper'
 
 describe Quandl::Data do
-  subject { Quandl::Fabricate::Data.rand( nils: false, rows: 4, columns: 4 ) }
+  let(:data){ Quandl::Fabricate::Data.rand( nils: false, rows: 4, columns: 4 ) }
+  subject { data }
 
   its(:to_h){ should be_a Hash }
   its(:count){ should eq 4 }
+  
+  describe "#collapse=" do
 
+    it "should collapse to monthly" do
+      subject.collapse(:monthly).count.should eq 1
+    end
+    
+    it "should reject invalid collapse" do
+      subject.collapse(:invalid)
+      subject.collapse.should_not eq :invalid
+    end
+    
+  end
+  
   it "should parse csv" do
     Quandl::Data.new(subject.to_csv).count.should eq 4
   end
@@ -24,6 +38,12 @@ describe Quandl::Data do
   end
 
   describe "#transform" do
+
+    it "should reject invalid transform" do
+      subject.transform(:invalid)
+      subject.transform.should_not eq :invalid
+    end
+    
     it "should rdiff" do
       value = subject.first[1]
       subject.transform(:rdiff).first[1].should_not eq value
@@ -38,10 +58,6 @@ describe Quandl::Data do
     end
   end
 
-  it "should collapse the data" do
-    subject.collapse(:monthly).count.should eq 1
-  end
-
   it "should limit the data" do
     subject.limit(2).count.should eq 2
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quandl_data
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors: