quandl_client 2.6.0 → 2.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 143f4ec1982c74d12e16b00bb624f1b2002ce8dc
-  data.tar.gz: 79e557b77dfe07589dace275a5e15e676d267934
+  metadata.gz: 8f3c7b2e6d00eae927b27582c0639e2335f8baaf
+  data.tar.gz: 92fab0d74f709dffc8ee74694ba2508caf0e1122
 SHA512:
-  metadata.gz: 7a42782c545a694c737a9320c7492d6b19ec727fb463e955affaa19b3fcdf534c372dc584764915378bd80fe2a050fe25e52ae6f9d8c99d2bc3d9bfa9028c4a5
-  data.tar.gz: ff681713db7ec3b8bf1b6664a916f4ea5223df2ac72971ab7d3540141f62297371e33eacdddfd3ffb65e09742e40686ff2aa225560d8ab792e2cd56804769f9d
+  metadata.gz: a4e52c2c6c007ae90725f3dd46bec811e599e446fdfcbdc8598997cf5901c3d5fd8b7161aef6985dab70090a5aa9a5721542c18a7bbdc2f219f29511ea5977bf
+  data.tar.gz: 06d31ce69a4f5d0ce1d24de67bd6269a53acc71bcecd969770e9cf2dbcd89653c0f22043af0088d22ce6b215654e33112ab8417d1cfbbfff2406fc7c95c7765c

data/README.md

@@ -1,4 +1,11 @@
-# Installation
+# Quandl::Client
+
+## Purpose
+
+The purpose of this gem is to interact with the [quandl api](http://www.quandl.com/help/api)
+
+
+## Installation
 
 ```ruby
 
@@ -9,7 +16,7 @@ gem 'quandl_client'
 
 
 
-# Configuration
+## Configuration
 
 ```ruby
 
@@ -24,10 +31,10 @@ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN']
 
 
 
-# Usage
+## Usage
 
 
-## Quandl::Client::Dataset
+### Quandl::Client::Dataset
 
 
 #### Search
@@ -151,7 +158,7 @@ d.error_messages
 
 
 
-## Quandl::Client::Source
+### Quandl::Client::Source
 
 
 #### Search
@@ -214,7 +221,7 @@ Source.destroy_existing(52352)
 
 
 
-## Quandl::Client::Sheet
+### Quandl::Client::Sheet
 
 
 #### Search
@@ -277,7 +284,7 @@ Quandl::Client::Sheet.destroy_existing(15252)
 
 
 
-# Authentication
+### Authentication
 
 ```ruby
 

data/Rakefile

@@ -9,8 +9,8 @@ require "quandl/client"
 
 include Quandl::Client
 
-Quandl::Client.use ENV['QUANDL_TEST_URL']
-Quandl::Client.token = ENV['QUANDL_TEST_TOKEN']
+Quandl::Client.use ENV['QUANDL_URL']
+Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN']
 
 task :default => :spec
 

data/UPGRADE.md

@@ -1,3 +1,10 @@
+## 2.6.1 
+
+* QUGC-113 fix Dataset#data errors dont propagate to parent object
+* QUGC-113 Write failing specs for Dataset#data errors dont propagate to parent object
+
+
+
 ## 2.6.0 
 
 * QUGC-104 Fixes when upload fails output is not json

data/VERSION

@@ -1 +1 @@
-2.6.0
+2.6.1

data/lib/quandl/client/base/validation.rb

@@ -7,6 +7,18 @@ module Validation
   
     before_save :halt_unless_valid!
     
+    validate :response_errors_should_be_blank!
+    
+    def response_errors_should_be_blank!
+      return unless response_errors.respond_to?(:each)
+      response_errors.each do |key, messages|
+        if messages.respond_to?(:each)
+          messages.each{|message| errors.add(key, message) }
+        end
+      end
+      true
+    end
+    
     def valid_with_server?
       return false unless valid?
       return false unless errors_params.blank?

data/lib/quandl/client/models/dataset.rb

@@ -47,6 +47,7 @@ class Quandl::Client::Dataset < Quandl::Client::Base
   validates :code, presence: true, format: { with: Quandl::Pattern.code, message: "is invalid. Expected format: #{Quandl::Pattern.code.to_example}" }
   validates :display_url, allow_blank: true, url: true
   validate :data_should_be_valid!
+  validate :dataset_data_should_be_valid!
   validate :data_row_count_should_match_column_count!
   validate :data_columns_should_not_exceed_column_names!
   validate :data_rows_should_have_equal_columns!
@@ -124,6 +125,10 @@ class Quandl::Client::Dataset < Quandl::Client::Base
     @dataset_data ||= Quandl::Client::Dataset::Data.new( id: id )
   end
   
+  def dataset_data?
+    @dataset_data.is_a?(Quandl::Client::Dataset::Data)
+  end
+  
   def reload
     @dataset_data = nil
     @data_scope = nil
@@ -140,6 +145,14 @@ class Quandl::Client::Dataset < Quandl::Client::Base
     true
   end
   
+  def dataset_data_should_be_valid!
+    if dataset_data? && !dataset_data.valid?
+      dataset_data.errors.each{|k,v| self.errors.add( k,v ) }
+      return false
+    end
+    true
+  end
+  
   def ambiguous_code_requires_source_code!
     if code.to_s.numeric? && source_code.blank?
       message = %Q{Pure numerical codes like "#{code}" are not allowed unless you include a source code. Do this:\nsource_code: <USERNAME>\ncode: #{code}}
@@ -200,7 +213,20 @@ class Quandl::Client::Dataset < Quandl::Client::Base
     dataset_data.save
     # update dataset's attributes with dataset_data's attributes
     attributes.each{|k,v| attributes[k] = dataset_data.attributes[k] if dataset_data.attributes.has_key?(k) }
+    # update dataset errors with dataset_data
     @metadata[:status] = dataset_data.status unless dataset_data.saved?
+    # inherit_errors(dataset_data) unless dataset_data.saved?
+  end
+  
+  def inherit_errors(object)
+    return unless object.respond_to?(:response_errors) && object.response_errors.respond_to?(:each)
+    object.response_errors.each do |key, messages|
+      if messages.respond_to?(:each)
+        messages.each{|message| errors.add(key, message) }
+      end
+    end
+    @metadata[:status] = object.status
+    object
   end
   
   def enforce_required_formats

data/spec/lib/quandl/client/scraper_spec.rb

@@ -15,7 +15,8 @@ describe Scraper do
     
     context "save" do
       before(:each){ scraper.save }
-      its(:error_messages){ should eq( {:response_errors => {"location" => ["You must provide one of: [ scraper_url, git_url ]"]}}) }
+      its("error_messages.to_s"){ should match "You must provide one of" }
+      its("error_messages.to_s"){ should match "scraper_url, git_url" }
     end
     
     context "scraper= File" do
@@ -49,7 +50,7 @@ describe Scraper do
         scraper.git_url = "git@github.com:tammer/scrapers.git" 
         scraper.save
       }
-      its(:error_messages){ should eq({:response_errors=>{"location.reference"=>["can't be blank"]}}) }
+      its("error_messages.to_s"){ should match %Q{can't be blank} }
     end
     
     context "git_url='git@github.com:tammer/scrapers.git' & git_reference='master'" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quandl_client
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.6.1
 platform: ruby
 authors:
 - Blake Hilscher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-05 00:00:00.000000000 Z
+date: 2014-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: quandl_data