quandl_client 2.4.5 → 2.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7125726d7cceeb967eeea4dee62a6defd9609ac3
-  data.tar.gz: 019a336addadb9238b9290054730b926cf7ba1ac
+  metadata.gz: 14ef2307a4ae4d35586ec924b530d4d6a130bb1c
+  data.tar.gz: 49c4b0c24f13a74a3211a6f0ad4ae5c0cab4f945
 SHA512:
-  metadata.gz: 287b3674ebd754821827d74d044b5362af1af32eb68967c980fb25d6638227f21183dd7b6007de54d16569025566abb6c8ec75e163a221ab325cb68f5ceaba4f
-  data.tar.gz: 670806360ff1824f7c9963daa6d1fdde4a24e3599e3baeac17d3a4d1a7aba980813af601236b7b6cf41a16be19c47b0d79ba437238e312987cf56d03307fcd40
+  metadata.gz: 3236ed60a30d3159f1face6085eae6dc4cbb213f53c862c071862ac904041b96cc58f8ae55ad5b95108b706ea80dd40ff1be2c33ea1f20efd5c51c1a38454390
+  data.tar.gz: 331e27847d1e1cd3e015b91a72db6826033628498b74381479fa78cf8d2e15c4932eb2d6fba64adab64358c0e9d3b74ffb3b891797d694ce071b702cc7acee91

data/UPGRADE.md

@@ -1,3 +1,11 @@
+# 2.4.6
+
+* QUGC-43 improved message on wrong number of colums
+* QUGC-41 enforce code formatting. always upcase codes
+* improved example of valid code
+* revise code pattern
+
+
 # 2.4.5
 
 * QUGC-40 add validation to enforce: You may not change number of columns in a dataset

data/lib/quandl/client/models/dataset.rb

@@ -11,8 +11,13 @@ class Quandl::Client::Dataset < Quandl::Client::Base
     end
   
     def find(value)
-      # ensure slashes are forward facing
-      value = value.gsub("\\","/") if value.is_a?(String)
+      # enforce code formatting
+      if value.is_a?(String)
+        # ensure slashes are forward facing
+        value = value.gsub("\\","/")
+        # ensure uppercase
+        value = value.upcase
+      end
       # short-circuit if value is illegal
       return nil unless value.is_a?(Integer) || value.to_s =~ %r{^#{Quandl::Pattern.full_code}$}
       super(value)
@@ -118,7 +123,7 @@ class Quandl::Client::Dataset < Quandl::Client::Base
   
   def data_columns_should_not_exceed_column_names!
     if dataset_data.data? && column_names.present? && data.first.count != column_names.count
-      self.errors.add( :data, "You may not change the number of columns in a dataset!" )
+      self.errors.add( :data, "You may not change the number of columns in a dataset. This dataset has #{column_names.count} columns but you tried to send #{data.first.count} columns." )
       return false
     end
     true 

data/lib/quandl/client/version.rb

@@ -1,6 +1,6 @@
 module Quandl
 module Client
-  VERSION = '2.4.5'
+  VERSION = '2.4.6'
   API_VERSION = 'v2'
   
   class << self

data/lib/quandl/pattern/client.rb

@@ -2,8 +2,8 @@ module Quandl
 class Pattern
   
   define_pattern :dataset_date, /[0-9]{4}\-[0-9]{2}\-[0-9]{2}/, example: "yyyy-mm-dd"
-  define_pattern :code, /[A-Z0-9_]{2,}+/, example: 'ALPHA_NUMERIC_1024'
-  define_pattern :full_code, /(#{code}\/)?(#{code})/, example: "(SOURCE_CODE/)#{code.to_example}"
+  define_pattern :code, /[A-Z0-9_]+/, example: 'ALPHA_NUMERIC_ALL_CAPS'
+  define_pattern :full_code, /(#{code}+)\/?(#{code})?/, example: "(SOURCE_CODE/)#{code.to_example}"
   
 end
 end

data/spec/lib/quandl/client/dataset/data_spec.rb

@@ -51,7 +51,7 @@ describe Quandl::Client::Dataset::Data do
     end
   
     context "#column_spec" do
-      before(:each){ subject.column_spec = "[0,[\"Date \\n\",{}],[\"Column 1 \",{}],[\"New Column Name \",{}]]"; sleep(1); subject.save }
+      before(:each){ subject.column_spec = "[0,[\"Date\",{}],[\"c1 \",{}],[\"c2 \",{}],[\"c3 \",{}],[\"c234 \",{}]]"; sleep(1); subject.save }
       its(:updated_at){ should_not eq dataset.updated_at }
       its(:column_spec){ should_not eq dataset.column_spec }
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quandl_client
 version: !ruby/object:Gem::Version
-  version: 2.4.5
+  version: 2.4.6
 platform: ruby
 authors:
 - Blake Hilscher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-28 00:00:00.000000000 Z
+date: 2014-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake