quandl_client 2.4.4 → 2.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad925197e4d222a17552a4e4bc06fe5f1371bdc7
-  data.tar.gz: f1d89d66da1cdecdb3511ecb6d4d25b96fdc1d37
+  metadata.gz: 7125726d7cceeb967eeea4dee62a6defd9609ac3
+  data.tar.gz: 019a336addadb9238b9290054730b926cf7ba1ac
 SHA512:
-  metadata.gz: 0ee1c3f4830d012faffce633af7026114e9ccf8f5eb43ec244d73c5151a33a56f840ea164373d688536d104b8543a122b4558a67549e288b31ee9da8f23f49a0
-  data.tar.gz: 1c6de22b70669757693e9eb91fe3536ee5e5303b4b5f643ceafe62c2165ac93e597c509b4b4385ef15e323e5b708e4c31880626408526104965c0394399668f0
+  metadata.gz: 287b3674ebd754821827d74d044b5362af1af32eb68967c980fb25d6638227f21183dd7b6007de54d16569025566abb6c8ec75e163a221ab325cb68f5ceaba4f
+  data.tar.gz: 670806360ff1824f7c9963daa6d1fdde4a24e3599e3baeac17d3a4d1a7aba980813af601236b7b6cf41a16be19c47b0d79ba437238e312987cf56d03307fcd40

data/UPGRADE.md

@@ -1,3 +1,9 @@
+# 2.4.5
+
+* QUGC-40 add validation to enforce: You may not change number of columns in a dataset
+* QUGC-37 Dataest.find accept backslash or forward slash interchangeably
+
+
 # 2.4.4
 
 * Dataset#data to_table assigns column_names to headers

data/lib/quandl/client/models/dataset.rb

@@ -11,6 +11,8 @@ class Quandl::Client::Dataset < Quandl::Client::Base
     end
   
     def find(value)
+      # ensure slashes are forward facing
+      value = value.gsub("\\","/") if value.is_a?(String)
       # short-circuit if value is illegal
       return nil unless value.is_a?(Integer) || value.to_s =~ %r{^#{Quandl::Pattern.full_code}$}
       super(value)
@@ -37,6 +39,7 @@ class Quandl::Client::Dataset < Quandl::Client::Base
   
   validates :code, presence: true, format: { with: Quandl::Pattern.code, message: "is invalid. Expected format: #{Quandl::Pattern.code.to_example}" }
   validates :display_url, allow_blank: true, url: true
+  validate :data_columns_should_not_exceed_column_names!
   
   ##############
   # PROPERTIES #
@@ -113,13 +116,23 @@ class Quandl::Client::Dataset < Quandl::Client::Base
   
   protected
   
+  def data_columns_should_not_exceed_column_names!
+    if dataset_data.data? && column_names.present? && data.first.count != column_names.count
+      self.errors.add( :data, "You may not change the number of columns in a dataset!" )
+      return false
+    end
+    true 
+  end
+  
   def save_dataset_data
-    return if !saved? && id.blank?
+    return if (!saved? && id.blank?)
+    return if !dataset_data.data?
     
     dataset_data.id = id
     dataset_data.save
     # update dataset's attributes with dataset_data's attributes
     attributes.each{|k,v| attributes[k] = dataset_data.attributes[k] if dataset_data.attributes.has_key?(k) }
+    @metadata[:status] = dataset_data.status
   end
   
   def enforce_required_formats

data/lib/quandl/client/models/user.rb

@@ -1,5 +1,6 @@
 class Quandl::Client::User < Quandl::Client::Base
   
+  custom_get :info
   custom_post :login
   
   attributes :auth_token

data/lib/quandl/client/version.rb

@@ -1,6 +1,6 @@
 module Quandl
 module Client
-  VERSION = '2.4.4'
+  VERSION = '2.4.5'
   API_VERSION = 'v2'
   
   class << self

data/spec/factories/dataset.rb

@@ -5,7 +5,7 @@ FactoryGirl.define do
     sequence(:code) { |n| "QUANDL_CLIENT_#{(Time.now.to_f * 1000).to_i}_#{n}" }
     name "Quandl Client Dataset"
     description "Quandl Client Dataset Spec"
-    column_spec "[0,[\"Date \\n\",{}],[\"Column 1 \",{}],[\"Column 2 \",{}]]"
+    # column_names ['Date', "Column 1", "Column 2"]
   end
 
 end

data/spec/lib/quandl/client/dataset/data_spec.rb

@@ -4,8 +4,11 @@ require 'spec_helper'
 describe Quandl::Client::Dataset::Data do
 
   let(:dataset){ 
-    create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data.rand( rows: 10, columns: 4 ) )
+    create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data.rand( rows: 10, columns: 4 ), column_names: ["Date", "C1", 'c2', 'c3', 'c4'] )
   }
+  subject{ dataset }
+  
+  its(:valid?){ should be_true }
   
   describe ".with_id('NSE/OIL')" do
     let(:id){ Dataset.find("NSE/OIL").id }
@@ -27,6 +30,7 @@ describe Quandl::Client::Dataset::Data do
   
   describe "#data" do
     subject{ Dataset.find( dataset.id ).data }
+
     its(:count){ should eq 10 }
     its(:to_h){ should be_a Hash }
   end

data/spec/lib/quandl/client/dataset/persistence_spec.rb

@@ -41,9 +41,9 @@ describe Dataset do
       
       let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data.rand(rows: 20, columns: 2, nils: false) ) }
       subject{ dataset }
-  
+      
       its(:saved?){ should be_true }
-      its(:status){ should eq 201 }
+      its(:status){ should eq 200 }
   
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quandl_client
 version: !ruby/object:Gem::Version
-  version: 2.4.4
+  version: 2.4.5
 platform: ruby
 authors:
 - Blake Hilscher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-27 00:00:00.000000000 Z
+date: 2014-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake