quandl_client 0.1.16 → 0.1.17

data/README.md

@@ -95,7 +95,7 @@ d = Dataset.create( attributes )
 
 d = Dataset.find( d.full_code )
 d.name = 'New Name'
-d.data = Quandl::Data::Random.table.to_csv
+d.data = Quandl::Fabricate::Data::Table.rand.to_csv
 d.save
 
 d = Dataset.collapse(:weekly).find( d.full_code )

data/UPGRADE.md

@@ -1,3 +1,8 @@
+## 0.1.17
+
+* Dataset#source_code is optional
+
+
 ## 0.1.16
 
 * add sheet description

data/lib/quandl/client/models/dataset.rb

@@ -35,8 +35,7 @@ class Dataset
   ###############
   # VALIDATIONS #
   ###############
-   
-  validates :source_code, presence: true
+  
   validates :code, presence: true, format: { with: /[A-Z0-9_]+/ }
   validates :name, presence: true, :length => { :maximum => 1000 }
   
@@ -49,7 +48,7 @@ class Dataset
     :description, :updated_at, :frequency,
     :from_date, :to_date, :column_names, :private, :type,
     :display_url, :column_spec, :import_spec, :import_url,
-    :locations_attributes, :data, :availability_delay
+    :locations_attributes, :data, :availability_delay, :refreshed_at
     
   before_save :enforce_required_formats
   

data/lib/quandl/client/version.rb

@@ -1,6 +1,6 @@
 module Quandl
 module Client
-  VERSION = '0.1.16'
+  VERSION = '0.1.17'
   API_VERSION = 'v1'
   
   class << self

data/spec/lib/quandl/client/dataset/attributes_spec.rb

@@ -0,0 +1,31 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Dataset do
+  
+  let(:source){
+    s = Source.find("QUANDL_CLIENT_TEST_SOURCE")
+    s = create(:source, code: "QUANDL_CLIENT_TEST_SOURCE") unless s.exists?
+    s
+  }
+  subject{ create(:dataset, source_code: source.code, private: true ) }
+  
+  describe "#private" do
+    
+    it "should update to false" do
+      subject.private = false
+      subject.save
+      Dataset.find(subject.id).private.should be_false
+    end
+    
+    it "should update to true" do
+      subject.private = false
+      subject.save
+      subject.private = true
+      subject.save
+      Dataset.find(subject.id).private.should be_true
+    end
+    
+  end
+  
+end

data/spec/lib/quandl/client/dataset/data_spec.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Dataset do
+
+  let(:dataset){ 
+    create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data::Table.rand( rows: 10, columns: 4 ) )
+  }
+
+  describe "#data" do
+    subject{ Dataset.find( dataset.id ).data }
+    its(:count){ should eq 10 }
+  end
+  
+  context "updated" do
+    
+    subject{
+      sleep(0.75)
+      Dataset.find( dataset.id )
+    }
+    
+    describe "#data" do
+      before(:each){ subject.data = Quandl::Fabricate::Data::Table.rand( rows: 12, columns: 4 ); subject.save }
+      its(:updated_at){ should_not eq dataset.updated_at }
+      its(:data){ should_not eq dataset.data }
+      its(:refreshed_at){ should_not eq dataset.refreshed_at }
+    end
+  
+    context "#column_spec" do
+      before(:each){ subject.column_spec = "[0,[\"Date \\n\",{}],[\"Column 1 \",{}],[\"New Column Name \",{}]]"; subject.save }
+      its(:updated_at){ should_not eq dataset.updated_at }
+      its(:column_spec){ should_not eq dataset.column_spec }
+    end
+  
+  end
+  
+
+end

data/spec/{quandl → lib/quandl}/client/dataset/location_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 describe Dataset do
   
   subject{
-    build(:dataset, source_code: create(:source).code )
+    build(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE" )
   }
   
   describe "#availability_delay" do
@@ -46,8 +46,8 @@ describe Dataset do
     context "datasets sharing location" do
       
       let(:location){ [{ category: "http", url: "http://www.bankofcanada.ca/rates/price-indexes/cpi/"}] }
-      let(:dataset1){ create(:dataset, source_code: create(:source).code, locations: location ) }
-      let(:dataset2){ create(:dataset, source_code: create(:source).code, locations: location ) }
+      let(:dataset1){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", locations: location ) }
+      let(:dataset2){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", locations: location ) }
       
       it "should share the location" do
         Dataset.find(dataset1.id).locations.should eq Dataset.find(dataset2.id).locations

data/spec/lib/quandl/client/dataset/persistence_spec.rb

@@ -0,0 +1,93 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Dataset do
+  context "when built" do
+    subject{ build(:dataset) }
+    its(:saved?){ should be_false }
+    its(:valid?){ should be_true }
+  end
+  
+  context "when created" do
+    context "without token" do
+      before(:all){ Quandl::Client.token = '' }
+      
+      let(:dataset){ create(:dataset) }
+      subject{ dataset }
+  
+      its(:saved?){ should be_false }
+      its(:status){ should eq 401 }
+    
+      after(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
+    end
+    context "with token" do
+      
+      let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE" ) }
+      subject{ dataset }
+  
+      its(:saved?){ should be_true }
+      its(:status){ should eq 201 }
+  
+    end
+    context "with data" do
+      
+      let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data::Table.rand(rows: 20, columns: 2, nils: false) ) }
+      subject{ dataset }
+  
+      its(:saved?){ should be_true }
+      its(:status){ should eq 201 }
+  
+    end
+  end
+  
+  context "when updated" do
+  
+    let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data::Table.rand(rows: 20, columns: 2, nils: false).to_csv ) }
+    subject{ Dataset.find(dataset.id) }
+    
+    it "should include new row" do
+      new_data = 10.times.collect{|i| [Date.parse(subject.to_date) + i + 1, rand(12), rand(12) ] }
+      new_data = Quandl::Data::Table.new(new_data).sort_descending
+      subject.data = new_data
+      subject.save
+      updated_dataset = Dataset.find(subject.id)
+      updated_dataset.data_table.to_date[0].should eq new_data.to_date[0]
+    end
+      
+    it "should include old rows" do
+      new_data = 10.times.collect{|i| [Date.parse(subject.to_date) + i + 2, rand(12), rand(12) ] }
+      new_data = Quandl::Data::Table.new(new_data).sort_descending
+      subject.data = new_data
+      subject.save
+      updated_dataset = Dataset.find(subject.id)
+      updated_dataset.data_table.count.should eq 30
+    end
+    
+  end
+  
+  context "when deleted" do
+    
+    let(:dataset){ create(:dataset, private: false ) }
+    
+    it "should delete the dataset" do
+      dataset.destroy
+      dataset.status.should eq 200
+    end
+    
+    context "as a user" do
+
+      it "should not delete the dataset with a user token" do
+        id = dataset.id
+        # behave as a user
+        Quandl::Client.token = ENV['QUANDL_USER_TOKEN']
+        user_dataset = Dataset.find(id)
+        user_dataset.destroy
+        user_dataset.status.should eq 403
+      end
+    
+      after(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
+    
+    end
+  end
+  
+end

data/spec/{quandl → lib/quandl}/client/dataset/search_spec.rb

@@ -2,9 +2,8 @@
 require 'spec_helper'
 
 describe Dataset do
-  
-  let(:source){ create(:source) }
-  let(:dataset){ create(:dataset, source_code: source.code ) }
+
+  let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE" ) }
   
   it "should find the dataset by id" do
     Dataset.find(dataset.id).id.should eq dataset.id

data/spec/lib/quandl/client/dataset/source_spec.rb

@@ -0,0 +1,46 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Dataset do
+  
+  let(:dataset){ create(:dataset, source_code: nil ) }
+  subject{ dataset }
+  
+  context "admin user" do
+    its(:saved?){ should be_true }
+    its(:source_code){ should be_present }
+    
+    describe "#source_code=" do
+      before(:each){
+        subject.source_code = 'WHO'
+        subject.save
+      }
+      its(:status){ should be 200 }
+      its(:source_code){ should eq 'WHO' }
+    end
+    
+  end
+  
+  context "normal user" do
+    # behave as a user
+    before(:all){ Quandl::Client.token = ENV['QUANDL_USER_TOKEN'] }
+  
+    its(:saved?){ should be_true }
+    its(:source_code){ should be_present }
+  
+    it "should find the source" do
+      Source.find(dataset.source_code).exists?.should be_true
+    end
+  
+    describe "#source_code=" do
+      before(:each){
+        subject.source_code = 'WHO'
+        subject.save
+      }
+      its(:status){ should be 422 }
+    end
+    
+    after(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
+  end
+  
+end

data/spec/{quandl → lib/quandl}/client/dataset/trim_spec.rb

@@ -3,8 +3,7 @@ require 'spec_helper'
 
 describe Dataset do
   
-  let(:source){ create(:source) }
-  subject{ build(:dataset, source_code: source.code, data: Quandl::Data::Random.table(rows: 20, columns: 2) ) }
+  subject{ build(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", data: Quandl::Fabricate::Data::Table.rand(rows: 20, columns: 2) ) }
   
   describe "#from_date" do
     context "before_save" do

data/spec/{quandl → lib/quandl}/client/dataset/validation_spec.rb

@@ -7,9 +7,8 @@ describe Dataset do
 
     before(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
     
-    let(:source){ create(:source) }
-    let(:dataset){ create(:dataset, source_code: source.code ) }
-    let(:invalid_dataset){ create(:dataset, source_code: source.code, code: dataset.code ) }
+    let(:dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE" ) }
+    let(:invalid_dataset){ create(:dataset, source_code: "QUANDL_CLIENT_TEST_SOURCE", code: dataset.code ) }
     subject{ invalid_dataset }
     
     it "should create the dataset" do

data/spec/{quandl → lib/quandl}/client/sheet_spec.rb

@@ -14,6 +14,7 @@ describe Sheet do
   context "when saved" do
     
     before(:each){ subject.save }
+    
     its(:saved?){ should be_true }
     
     describe "#description" do

data/spec/{quandl → lib/quandl}/client/source_spec.rb

@@ -44,7 +44,6 @@ describe Source do
       
     end
     
-    
   end
   
   

data/spec/spec_helper.rb

@@ -8,10 +8,12 @@ factory_dir = File.join( File.dirname(__FILE__), 'factories/**/*.rb' )
 Dir.glob( factory_dir ).each{|f| require(f); puts f }
 
 require "quandl/client"
+require "quandl/fabricate"
 
 include Quandl::Client
 Quandl::Client.use 'http://localhost:3000/api/'
 # Quandl::Client.use 'http://staging.quandl.com/api/'
+# Quandl::Client.use 'http://quandl.com/api/'
 Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN']
 
 RSpec.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quandl_client
 version: !ruby/object:Gem::Version
-  version: 0.1.16
+  version: 0.1.17
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-09 00:00:00.000000000 Z
+date: 2013-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -253,13 +253,16 @@ files:
 - spec/factories/dataset.rb
 - spec/factories/sheet.rb
 - spec/factories/source.rb
-- spec/quandl/client/dataset/location_spec.rb
-- spec/quandl/client/dataset/persistence_spec.rb
-- spec/quandl/client/dataset/search_spec.rb
-- spec/quandl/client/dataset/trim_spec.rb
-- spec/quandl/client/dataset/validation_spec.rb
-- spec/quandl/client/sheet_spec.rb
-- spec/quandl/client/source_spec.rb
+- spec/lib/quandl/client/dataset/attributes_spec.rb
+- spec/lib/quandl/client/dataset/data_spec.rb
+- spec/lib/quandl/client/dataset/location_spec.rb
+- spec/lib/quandl/client/dataset/persistence_spec.rb
+- spec/lib/quandl/client/dataset/search_spec.rb
+- spec/lib/quandl/client/dataset/source_spec.rb
+- spec/lib/quandl/client/dataset/trim_spec.rb
+- spec/lib/quandl/client/dataset/validation_spec.rb
+- spec/lib/quandl/client/sheet_spec.rb
+- spec/lib/quandl/client/source_spec.rb
 - spec/spec_helper.rb
 homepage: http://blake.hilscher.ca/
 licenses:
@@ -290,11 +293,14 @@ test_files:
 - spec/factories/dataset.rb
 - spec/factories/sheet.rb
 - spec/factories/source.rb
-- spec/quandl/client/dataset/location_spec.rb
-- spec/quandl/client/dataset/persistence_spec.rb
-- spec/quandl/client/dataset/search_spec.rb
-- spec/quandl/client/dataset/trim_spec.rb
-- spec/quandl/client/dataset/validation_spec.rb
-- spec/quandl/client/sheet_spec.rb
-- spec/quandl/client/source_spec.rb
+- spec/lib/quandl/client/dataset/attributes_spec.rb
+- spec/lib/quandl/client/dataset/data_spec.rb
+- spec/lib/quandl/client/dataset/location_spec.rb
+- spec/lib/quandl/client/dataset/persistence_spec.rb
+- spec/lib/quandl/client/dataset/search_spec.rb
+- spec/lib/quandl/client/dataset/source_spec.rb
+- spec/lib/quandl/client/dataset/trim_spec.rb
+- spec/lib/quandl/client/dataset/validation_spec.rb
+- spec/lib/quandl/client/sheet_spec.rb
+- spec/lib/quandl/client/source_spec.rb
 - spec/spec_helper.rb

data/spec/quandl/client/dataset/persistence_spec.rb

@@ -1,94 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe Dataset do
-  context "when built" do
-    subject{ build(:dataset) }
-    its(:saved?){ should be_false }
-    its(:valid?){ should be_true }
-  end
-  
-  context "when created" do
-    context "without token" do
-  
-      before(:all){ Quandl::Client.token = '' }
-      
-      let(:dataset){ create(:dataset) }
-      subject{ dataset }
-  
-      its(:saved?){ should be_false }
-      its(:status){ should eq 401 }
-    
-    end
-    context "with token" do
-
-      before(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
-      
-      let(:source){ create(:source) }
-      let(:dataset){ create(:dataset, source_code: source.code ) }
-      subject{ dataset }
-  
-      its(:saved?){ should be_true }
-      its(:status){ should eq 201 }
-  
-    end
-    context "with data" do
-
-      before(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
-      
-      let(:source){ create(:source) }
-      let(:dataset){ create(:dataset, source_code: source.code, data: Quandl::Data::Random.table(rows: 20, columns: 2, nils: false) ) }
-      subject{ dataset }
-  
-      its(:saved?){ should be_true }
-      its(:status){ should eq 201 }
-  
-    end
-  end
-  
-  context "when updated" do
-
-    let(:source){ create(:source) }
-    let(:dataset){ create(:dataset, source_code: source.code, data: Quandl::Data::Random.table(rows: 20, columns: 2, nils: false).to_csv ) }
-    subject{ Dataset.find(dataset.id) }
-    
-    
-    it "should update data" do
-      # update the dataset
-      new_row = [ subject.data_table[0][0], 1.0, 2.0]
-      subject.data = [ new_row ]
-      subject.save
-      # check the data
-      Dataset.find(dataset.id).data_table.sort_descending[0].should eq new_row
-    end
-    
-    it "should update column_spec" do
-      subject.column_spec = "[0,[\"Date \\n\",{}],[\"Column 1 \",{}],[\"New Column Name \",{}]]"
-      subject.save
-      Dataset.find(dataset.id).column_spec.should eq subject.column_spec
-    end
-    
-    context "with new rows" do
-      
-      it "should include new row" do
-        new_data = 10.times.collect{|i| [Date.parse(subject.to_date) + i + 1, rand(12), rand(12) ] }
-        new_data = Quandl::Data::Table.new(new_data).sort_descending
-        subject.data = new_data
-        subject.save
-        updated_dataset = Dataset.find(subject.id)
-        updated_dataset.data_table.to_date[0].should eq new_data.to_date[0]
-      end
-      
-      it "should include old rows" do
-        new_data = 10.times.collect{|i| [Date.parse(subject.to_date) + i + 2, rand(12), rand(12) ] }
-        new_data = Quandl::Data::Table.new(new_data).sort_descending
-        subject.data = new_data
-        subject.save
-        updated_dataset = Dataset.find(subject.id)
-        updated_dataset.data_table.count.should eq 30
-      end
-    end
-    
-  end
-  
-end