quandl_client 0.1.10 → 0.1.11

data/UPGRADE.md

@@ -1,3 +1,10 @@
+## 0.1.11
+
+* add spec for Dataset#availability_delay
+* add present?, exists?, blank? that check against response status.
+* remove erroneous source_code and code validations.
+
+
 ## 0.1.10
 
 * Add Dataset#availability_delay

data/lib/quandl/client/concerns/properties.rb

@@ -26,8 +26,20 @@ module Properties
       save
     end
     
+    def blank?
+      !present?
+    end
+    
+    def exists?
+      present?
+    end
+    
+    def present?
+      status >= 200 && status < 300
+    end
+    
     def saved?
-      status == 200 || status == 201
+      status >= 201 && status <= 206
     end
     
     def status
@@ -48,7 +60,9 @@ module Properties
     end
     
     def errors_server
-      self.attributes[:errors] || {}
+      messages = self.attributes[:errors] || {}
+      messages[:message] = self.error if self.error.present?
+      messages
     end
     
     def errors_params

data/lib/quandl/client/models/dataset.rb

@@ -36,9 +36,9 @@ class Dataset
   # VALIDATIONS #
   ###############
    
-  validates :source_code, presence: true, length: { minimum: 2 }, format: { with: /([A-Z0-9_]+)/ }
-  validates :code, presence: true, length: { minimum: 2 }, format: { with: /([A-Z0-9_]+)/ }
-  validates :name, presence: true
+  validates :source_code, presence: true
+  validates :code, presence: true, format: { with: /[A-Z0-9_]+/ }
+  validates :name, presence: true, :length => { :maximum => 1000 }
   
   
   ##############

data/lib/quandl/client/version.rb

@@ -1,6 +1,6 @@
 module Quandl
 module Client
-  VERSION = '0.1.10'
+  VERSION = '0.1.11'
   API_VERSION = 'v1'
   
   class << self

data/spec/factories/dataset.rb

@@ -2,7 +2,7 @@ FactoryGirl.define do
 
   factory :dataset do
     source_code "QUANDL_CLIENT_TEST_SOURCE"
-    sequence(:code) { |n| "QUANDL_CLIENT_#{n}" }
+    sequence(:code) { |n| "QUANDL_CLIENT_#{(Time.now.to_f * 1000).to_i}_#{n}" }
     name "Quandl Client Dataset"
     description "Quandl Client Dataset Spec"
     column_spec "[0,[\"Date \\n\",{}],[\"Column 1 \",{}],[\"Column 2 \",{}]]"

data/spec/quandl/client/models/dataset/location_spec.rb

@@ -0,0 +1,22 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Dataset do
+  
+  subject{
+    build(:dataset, source_code: create(:source).code )
+  }
+  
+  describe "#availability_delay" do
+    context "given valid input" do
+      it "saves the delay" do
+        delay = '02:00:10'
+        subject.availability_delay = delay
+        subject.save
+        Dataset.find(subject.id).availability_delay.should eq delay
+      end
+      
+    end
+  end
+  
+end

data/spec/quandl/client/models/dataset/persistence_spec.rb

@@ -11,7 +11,7 @@ describe Dataset do
     context "without token" do
   
       before(:all){ Quandl::Client.token = '' }
-    
+      
       let(:dataset){ create(:dataset) }
       subject{ dataset }
   
@@ -20,9 +20,9 @@ describe Dataset do
     
     end
     context "with token" do
-    
-      before(:all){ Quandl::Client.token = AUTH_TOKEN }
-  
+
+      before(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
+      
       let(:source){ create(:source) }
       let(:dataset){ create(:dataset, source_code: source.code ) }
       subject{ dataset }
@@ -34,8 +34,7 @@ describe Dataset do
   end
   
   context "when updated" do
-    before(:all){ Quandl::Client.token = AUTH_TOKEN }
-  
+
     let(:source){ create(:source) }
     let(:dataset){ create(:dataset, source_code: source.code, data: Quandl::Data::Random.table(rows: 20, columns: 2).to_csv ) }
         

data/spec/quandl/client/models/dataset/search_spec.rb

@@ -3,8 +3,6 @@ require 'spec_helper'
 
 describe Dataset do
   
-  before(:all){ Quandl::Client.token = AUTH_TOKEN }
-
   let(:source){ create(:source) }
   let(:dataset){ create(:dataset, source_code: source.code ) }
   

data/spec/quandl/client/models/source_spec.rb

@@ -24,8 +24,8 @@ describe Source do
   end
   
   context "with token" do
-    
-    before(:all){ Quandl::Client.token = AUTH_TOKEN }
+
+    before(:all){ Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN'] }
     
     describe "#save" do
       

data/spec/spec_helper.rb

@@ -11,7 +11,7 @@ require "quandl/client"
 
 include Quandl::Client
 Quandl::Client.use 'http://localhost:3000/api/'
-AUTH_TOKEN = ENV['QUANDL_AUTH_TOKEN']
+Quandl::Client.token = ENV['QUANDL_AUTH_TOKEN']
 
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quandl_client
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-13 00:00:00.000000000 Z
+date: 2013-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -252,9 +252,9 @@ files:
 - quandl_client.gemspec
 - spec/factories/dataset.rb
 - spec/factories/source.rb
+- spec/quandl/client/models/dataset/location_spec.rb
 - spec/quandl/client/models/dataset/persistence_spec.rb
 - spec/quandl/client/models/dataset/search_spec.rb
-- spec/quandl/client/models/dataset_spec.rb
 - spec/quandl/client/models/source_spec.rb
 - spec/spec_helper.rb
 homepage: http://blake.hilscher.ca/
@@ -285,8 +285,8 @@ summary: Client rest orm.
 test_files:
 - spec/factories/dataset.rb
 - spec/factories/source.rb
+- spec/quandl/client/models/dataset/location_spec.rb
 - spec/quandl/client/models/dataset/persistence_spec.rb
 - spec/quandl/client/models/dataset/search_spec.rb
-- spec/quandl/client/models/dataset_spec.rb
 - spec/quandl/client/models/source_spec.rb
 - spec/spec_helper.rb

data/spec/quandl/client/models/dataset_spec.rb

@@ -1,5 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe Dataset do
-end