quality 37.0.0 → 37.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c6e41075a75632729495d06a8d99f5a96a5d3256ab509f99fda27a20c90425e
-  data.tar.gz: bb0f8c7a16417cd6c240d40c846f89518977a4a729a5f7102f63476922eca0e6
+  metadata.gz: 1f3738877156fe9182600b12933dd6ccb263a9d8ec38b2e86944a5f7843e258f
+  data.tar.gz: bcdd36ad23df7f6848dc1d87afe56c884336e5f687c5ded25f93562c16db264f
 SHA512:
-  metadata.gz: 79be96733f293dffc553f942a66357becbd953061df2dfed6f3d4d7f8e78abdc6459e45da26a835bf068d1206912690a1124f9abc922aca84d309316fa6b15c9
-  data.tar.gz: 6a17209dd3f51ad443e3ebcfcce37a36c08d4e6b8ffeda64399dcfcc23484c49e63eca3782a6e0ca1a9adbb7f10683e85fdb520e9cc609f3e41ccaf798412aab
+  metadata.gz: b807ad9512e12db9b7c46cc5d424be2cf2d3e71507bcaeff5d19ee3f9990143426fea9c9a3a7517e019450911613e4433c8ea7f92ee5506f04ddfe5dfccfceb9
+  data.tar.gz: 010b14dbb8d410598db108bccb66389d25c7771fbeb6d32838a3f0fab23a395f0ddca138b75c6997bbfe4b3515f1c98cb1e374ed046c5d6361337e1d843c4c3a

data/lib/quality/quality_checker.rb

@@ -3,7 +3,7 @@
 require_relative 'command_output_processor'
 require_relative 'process'
 require_relative 'ruby_spawn'
-require_relative 'threshold'
+require 'high_water_mark/threshold'
 
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
@@ -29,10 +29,10 @@ module Quality
       @command_options = command_options
       @verbose = verbose
       @count_dir.mkdir(output_dir) unless @count_file.exists?(output_dir)
-      @threshold = Quality::Threshold.new(cmd,
-                                          count_io: count_io,
-                                          count_file: count_file,
-                                          output_dir: output_dir)
+      @threshold = HighWaterMark::Threshold.new(cmd,
+                                                count_io: count_io,
+                                                count_file: count_file,
+                                                output_dir: output_dir)
       @process_class = process_class
     end
 

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '37.0.0'
+  VERSION = '37.0.1'
 end

data/quality.gemspec

@@ -43,13 +43,15 @@ Gem::Specification.new do |s|
   # https://github.com/bbatsov/rubocop#installation
   s.add_runtime_dependency('mdl')
   s.add_runtime_dependency('rubocop', '~> 0.78.0')
-  # 1.19.0 was a RuboCop 0.51.0 compatibility release
-  s.add_runtime_dependency('bigfiles', ['>= 0.1'])
+  # 0.2.0 had a fatal bug
+  s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0'])
   s.add_runtime_dependency('brakeman')
+  s.add_runtime_dependency('high_water_mark')
   s.add_runtime_dependency('punchlist', ['>= 1.1'])
   s.add_runtime_dependency('rails_best_practices')
   s.add_runtime_dependency('rubocop-minitest')
   s.add_runtime_dependency('rubocop-rake')
+  # 1.19.0 was a RuboCop 0.51.0 compatibility release
   s.add_runtime_dependency('rubocop-rspec', ['>=1.19.0'])
   # not directly required - this is to workaround this issue:
   #  https://github.com/octokit/octokit.rb/issues/1177

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 37.0.0
+  version: 37.0.1
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2020-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -163,6 +163,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -170,6 +173,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
@@ -184,6 +190,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: high_water_mark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: punchlist
   requirement: !ruby/object:Gem::Requirement
@@ -448,7 +468,6 @@ files:
 - lib/quality/rake/task.rb
 - lib/quality/ruby_spawn.rb
 - lib/quality/runner.rb
-- lib/quality/threshold.rb
 - lib/quality/tool.rb
 - lib/quality/tools/bigfiles.rb
 - lib/quality/tools/brakeman.rb

data/lib/quality/threshold.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module Quality
-  # Calculate threshold for quality gem tool
-  class Threshold
-    attr_reader :tool_name
-
-    def initialize(tool_name,
-                   count_file: File,
-                   count_io: IO,
-                   output_dir: 'metrics')
-      @tool_name = tool_name
-      @count_file = count_file
-      @count_io = count_io
-      @filename = File.join(output_dir, "#{tool_name}_high_water_mark")
-    end
-
-    def threshold
-      return @count_io.read(@filename).to_i if @count_file.exist?(@filename)
-    end
-
-    def write_violations(new_violations)
-      @count_file.open(@filename, 'w') do |file|
-        file.write(new_violations.to_s + "\n")
-      end
-    end
-  end
-end