quality 27.3.1 → 27.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bfcd41bd56230180baf3c53dd928594ca894ecf3
-  data.tar.gz: 0b265177f4aa7ad0b47c17f384744bc3908d327c
+  metadata.gz: 9e7d5c912404289b0414f2f8efa3f28374e1c698
+  data.tar.gz: e26e1eed73d85f7895ba3110e60474053dcd02df
 SHA512:
-  metadata.gz: 0490189adadc58f5a161e829344967fc4145b5bc7b3f9c107f37663c704cafaa7755b96820659544b311a9546cc9fadbaecd71b0bd95700a0c5857a5829837f2
-  data.tar.gz: 318f1dabb9fea7ae89963dd526f090bb8e5106380554464f701424d7a0625f560799f42e651819b5e9ba4dd6683c2e572876190926ca6b61dea0f3f3f0d5e51f
+  metadata.gz: 44634291db8c0f7b5803a204aef4839c1c495da354f01b3acc9118861d3a5de2f4f02995330e794fe078a7c1d2c9ded10e791e76bed747d88d8aaf7079584558
+  data.tar.gz: d76c732f3b3eddd05abccb43c28b726ed9d084fbbd2e6415adc7fa9c8bf8bce69b30248901c7b6466854ca695fd360b05bf7a505171609a77321af2f6b19fda5

data/README.md

@@ -102,6 +102,13 @@ Quality::Rake::Task.new do |t|
   # Defaults to :ratchet.
   t.ratchet_name = 'ratchet'
 
+  #
+  # Set minimum values to ratchet to.
+  #
+  # Defaults to { bigfiles: 300 }
+  #
+  t.minimum_threshold = { bigfiles: 300 }
+
   # Array of strings describing tools to be skipped--e.g., ["cane"]
   #
   # Defaults to []

data/lib/quality/command_output_processor.rb

@@ -28,20 +28,22 @@ module Quality
       out
     end
 
+    def processed_output
+      if emacs_format
+        preprocess_line_for_emacs
+      else
+        @current_line
+      end
+    end
+
     def process_line(&block)
-      output =
-        if emacs_format
-          preprocess_line_for_emacs
-        else
-          @current_line
-        end
       @found_output = true
       @violations += if block
                        yield @current_line
                      else
                        1
                      end
-      output
+      processed_output
     end
 
     def preprocess_line_for_emacs

data/lib/quality/config.rb

@@ -12,7 +12,7 @@ module Quality
                   :output_dir, :punchlist_regexp,
                   :scalastyle_config, :scalastyle_exclude
 
-    attr_writer :source_files_exclude_glob
+    attr_writer :source_files_exclude_glob, :minimum_threshold
 
     extend Forwardable
 
@@ -48,6 +48,10 @@ module Quality
       @dir.glob("#{output_dir}/*_high_water_mark")
     end
 
+    def minimum_threshold
+      @minimum_threshold ||= { bigfiles: 300 }
+    end
+
     def initialize(quality_name: 'quality',
                    ratchet_name: 'ratchet',
                    source_file_globber: Quality::LinguistSourceFileGlobber.new,

data/lib/quality/quality_checker.rb

@@ -9,15 +9,19 @@ module Quality
   # if possible, or outputs data if the number of violations increased.
   class QualityChecker
     def initialize(cmd, command_options, output_dir, verbose,
+                   minimum_threshold,
+                   logger: STDOUT,
                    count_file: File,
                    count_io: IO,
                    command_output_processor_class:
                      Quality::CommandOutputProcessor,
                    count_dir: Dir,
                    process_class: Process)
+      @minimum_threshold = minimum_threshold
       @count_file = count_file
       @count_io = count_io
       @command_output_processor_class = command_output_processor_class
+      @logger = logger
       @count_dir = count_dir
       @cmd = cmd
       @command_options = command_options
@@ -60,30 +64,51 @@ module Quality
             "Exit status is #{exit_status}") if exit_status.nonzero?
     end
 
+    MAX_VIOLATIONS = 9_999_999_999
+
     def existing_violations
-      if @count_file.exist?(@filename)
-        @count_io.read(@filename).to_i
-      else
-        9_999_999_999
+      @existing_violations ||=
+        begin
+          if @count_file.exist?(@filename)
+            @count_io.read(@filename).to_i
+          else
+            MAX_VIOLATIONS
+          end
+        end
+    end
+
+    def error_too_many_violations!
+      raise("Output from #{@cmd}\n\n#{@command_output}\n\n" \
+            "Reduce total number of #{@cmd} violations " \
+            "to #{existing_violations} or below!")
+    end
+
+    def violations_to_write
+      @violations_to_write ||= [@violations, @minimum_threshold].max
+    end
+
+    def report_ratchet
+      if @violations < existing_violations &&
+         existing_violations != MAX_VIOLATIONS
+        @logger.puts 'Ratcheting quality up...'
       end
     end
 
     def ratchet_violations
-      existing = existing_violations
-      report_violations(existing)
-      if @violations > existing
-        raise("Output from #{@cmd}\n\n#{@command_output}\n\n" \
-              "Reduce total number of #{@cmd} violations " \
-              "to #{existing} or below!")
-      elsif @violations < existing
-        puts 'Ratcheting quality up...'
-        write_violations(@violations)
+      report_violations(existing_violations)
+      if @violations > [existing_violations, @minimum_threshold].max
+        error_too_many_violations!
+      elsif violations_to_write != existing_violations
+        report_ratchet
+        write_violations(violations_to_write)
       end
     end
 
     def report_violations(existing)
-      puts "Existing violations: #{existing}"
-      puts "Found #{@violations} #{@cmd} violations"
+      if existing != MAX_VIOLATIONS
+        @logger.puts "Existing violations: #{existing}"
+      end
+      @logger.puts "Found #{@violations} #{@cmd} violations"
     end
 
     def full_cmd

data/lib/quality/runner.rb

@@ -22,13 +22,10 @@ module Quality
 
     extend ::Forwardable
 
-    def initialize(config,
-                   gem_spec: Gem::Specification,
+    def initialize(config, gem_spec: Gem::Specification,
                    quality_checker_class: Quality::QualityChecker,
-                   count_io: IO,
-                   count_file: File,
-                   globber: Dir,
-                   which: Which.new)
+                   count_io: IO, count_file: File,
+                   globber: Dir, which: Which.new)
       @config = config
       @gem_spec = gem_spec
       @quality_checker_class = quality_checker_class
@@ -96,13 +93,18 @@ module Quality
       end.compact
     end
 
+    def minimum_threshold_for(cmd)
+      @config.minimum_threshold[cmd.to_sym] || 0
+    end
+
     def ratchet_quality_cmd(cmd,
                             command_options,
                             &count_violations_on_line)
       quality_checker = @quality_checker_class.new(cmd,
                                                    command_options,
                                                    @config.output_dir,
-                                                   @config.verbose)
+                                                   @config.verbose,
+                                                   minimum_threshold_for(cmd))
       quality_checker.execute(&count_violations_on_line)
     end
 

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '27.3.1'
+  VERSION = '27.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 27.3.1
+  version: 27.4.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-05 00:00:00.000000000 Z
+date: 2017-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Code quality tools for Ruby