quality 22.0.0 → 23.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34c649082351ada4e29748634b94f0cb25784b4a
-  data.tar.gz: be28c5baec25bf09c2db42b78d15ab81b5fecc0d
+  metadata.gz: bd52cb5919480dc82d9e95238fe80a35c122eb58
+  data.tar.gz: c5a666f18a628c1bd4b1e86ba1eeb7291c7bb603
 SHA512:
-  metadata.gz: 8fcd7499757198b78ab88052cc2a788fd89c7dfd2d3f3547a17a2c18788877d2cc33e518d6a8e41902b8a1c1babddec465703b9977cc657e07d05aedb475bc1d
-  data.tar.gz: 1f655f360e13af9c419821b0e8bbf97edc15c9c8d0a6d164e877b17b9abe4441061d02f5870ca05327a54c3a31cafcece8bf9c23621ad72f3ba3945772b54731
+  metadata.gz: 69cfc8ff0644cf6312d1092035a4c2048dcc12d01d748761629a15f203119c0be4d4a1ad977755aed64d6adc0780a2918d16632fea61258f1b1d5722aaabf268
+  data.tar.gz: 8bf0350a853947282c525fc49cfdd76950a07e8bbc04d1f667baa804e3bf626a331e12da6526461db1dcb54e1ae32035b7b9ea9fb9446dbfcb78002a91ded8ce

data/README.md

@@ -6,32 +6,54 @@
 
 ##Overview
 
-Quality is a tool that runs quality checks on Ruby code using cane,
-reek, flog, flay and rubocop and makes sure your numbers don't get any
+Quality is a tool that runs quality checks on code in git repos using
+different analysis tools and makes sure your numbers don't get any
 worse over time.
 
 ## Why
 
 See [this post](http://blog.apiology.cc/2014/06/scalable-quality-part-1.html) or [these slides](https://docs.google.com/presentation/d/1Op4FH34-enm8luEIuAAVLkuAJ-sB4LKaMm57RJzvfeI/edit#slide) for more information on the problem the quality gem solves.
 
+### Tools
+
+Quality makes use of the following other tools, which do the actual checking:
+
+* [bigfiles](https://github.com/apiology/bigfiles)
+* [brakeman](http://brakemanscanner.org/)
+* [bundler_audit](https://github.com/rubysec/bundler-audit)
+* [cane](https://github.com/square/cane)
+* [eslint](http://eslint.org/)
+* [flake8](https://pypi.python.org/pypi/flake8)
+* [flay](https://github.com/seattlerb/flay)
+* [flog](https://github.com/seattlerb/flog)
+* [jscs](http://jscs.info/)
+* [pep8](https://pypi.python.org/pypi/pep8)
+* [punchlist](https://github.com/apiology/punchlist)
+* [rails_best_practices](https://github.com/railsbp/rails_best_practices)
+* [reek](https://github.com/troessner/reek)
+* [rubocop](https://github.com/bbatsov/rubocop)
+
 ## How to use - using Docker
 
 These basic steps assume you have a working Docker installation.
 
 ```
-docker run -v `pwd`:/usr/app apiology/quality
+docker run -v `pwd`:/usr/app apiology/quality:latest
 ```
 
 If you'd like to customize, you can link in your own Rakefile like this:
 
 ```
-docker run -v `pwd`:/usr/app -v `pwd`/Rakefile.quality:/usr/quality/Rakefile apiology/quality
+docker run -v `pwd`:/usr/app -v `pwd`/Rakefile.quality:/usr/quality/Rakefile apiology/quality:latest
 ```
 
+The default 'latest' tag contains the Ruby tools in a relatively small image.  You can also get additional tools (see `Dockerfile.jumbo` in this directory) by using the tag `jumbo-`(version) (e.g., jumbo-latest, jumbo-x.y.z, etc)
+
 
 ## How to use - as part of a Ruby-based Rakefile
 
 ```bash
+$ brew install cmake # OS X
 $ gem install quality
 ```
 
@@ -91,25 +113,17 @@ Quality::Rake::Task.new do |t|
   # Defaults to false
   t.verbose = false
 
-  # Array of directory names which contain ruby files to analyze.
+  # Relative path to output directory where *_high_water_mark
+  # files will be read/written
   #
-  # Defaults to %w(app lib test spec feature), which translates to
-  # *.rb in the base directory, as well as those directories.
-  t.ruby_dirs = %w(app lib test spec feature)
+  # Defaults to 'metrics'
+  t.output_dir = 'metrics'
 
-  # Array of directory names which contain any type of source files to
-  # analyze.
+  # Pipe-separated regexp string describing what to look for in
+  # files as 'todo'-like 'punchlist' comments.
   #
-  # Defaults to t.ruby_dirs
-  t.source_dirs.concat(%w(MyProject MyProjectTests))
-
-  # Pick any extra files that are source files, but may not have
-  # extensions--defaults to %w(Rakefile Dockerfile)
-  t.extra_source_files = ['tools/check-script', 'Rakefile']
-
-  # Pick any extra files that are source files, but may not have
-  # extensions--defaults to %w(Rakefile)
-  t.extra_ruby_files = ['Rakefile']
+  # Defaults to 'XXX|TODO'
+  t.punchlist_regexp = 'XXX|TODO'
 
   # Exclude the specified list of files--defaults to ['db/schema.rb']
   t.exclude_files = ['lib/whatever/imported_file.rb',
@@ -121,28 +135,18 @@ Quality::Rake::Task.new do |t|
   t.source_files_exclude_glob =
     '{lib/whatever/imported_file.rb,lib/vendor/**/*.rb}'
 
-  # Extensions for Ruby language files--defaults to rb,rake
-  t.ruby_file_extensions_arr = %w(rb rake)
-
-  # Extensions for all source files--defaults to
-  # rb,rake,swift,cpp,c,java,py,clj,cljs,scala,js,yml,sh,json
-  t.source_file_extensions_arr =
-    %w(rb rake swift cpp c java py clj cljs scala js yml sh json)
-
-  # Relative path to output directory where *_high_water_mark
-  # files will be read/written
   #
-  # Defaults to 'metrics'
-  t.output_dir = 'metrics'
-
-  # Pipe-separated regexp string describing what to look for in
-  # files as 'todo'-like 'punchlist' comments.
+  # For configuration on classifying files as the correct language,
+  # see https://github.com/github/linguist
   #
-  # Defaults to 'XXX|TODO'
-  t.punchlist_regexp = 'XXX|TODO'
 end
 ```
 
+## Vendored files
+
+Quality uses GitHub's [linguist](https://github.com/github/linguist) gem to find and classify source files to analyze.  In addition to the `exclude_files` and `source_files_exclude_glob` options in Quality, you can refer to Linguists's documentation on [overrides](https://github.com/github/linguist#overrides) to use the `gitattributes` file to mark files as vendored, at which point Quality will not try to analyze them.
+  
+
 ## Code coverage
 
 You can pull a similar trick with code coverage using SimpleCov in Ruby--put 'simplecov' in your Gemfile, and add the code below into your test_helper.rb or spec_helper.rb.
@@ -155,13 +159,13 @@ SimpleCov.refuse_coverage_drop
 
 After your first run, check in your coverage/.last_run.json.
 
-## Maturity
+## Caveats
 
 Quality uses [semantic versioning](http://semver.org/)--any incompatible changes (including new tools being added) will come out as major number updates.
 
 ## Supported Ruby Versions
 
-Tested against Ruby >=2.0--does not support Ruby 1.9.x.
+Tested against Ruby >=2.2--does not support Ruby 1.9.x or JRuby.
 
 ## Contributing
 
@@ -171,18 +175,6 @@ Tested against Ruby >=2.0--does not support Ruby 1.9.x.
 
 Many thanks to all contributors, especially [@andyw8](https://github.com/andyw8), who has contributed some great improvements.
 
-### Dependencies
-
-Quality makes use of the following other gems, which do the actual checking:
-
-* [reek](https://github.com/troessner/reek)
-* [cane](https://github.com/square/cane)
-* [flog](https://github.com/seattlerb/flog)
-* [flay](https://github.com/seattlerb/flay)
-* [rubocop](https://github.com/bbatsov/rubocop)
-* [bigfiles](https://github.com/apiology/bigfiles)
-* [punchlist](https://github.com/apiology/punchlist)
-
 ### Learn More
 
 * Browse the code or install the latest development version from [https://github.com/apiology/quality/tree](https://github.com/apiology/quality/tree)

data/lib/quality/command_output_processor.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Quality
   # Class processes output from a code quality command, tweaking it
   # for editor output and counting the number of violations found
@@ -22,8 +23,7 @@ module Quality
     def process_file(file, &count_violations_on_line)
       out = ''
       while (@current_line = file.gets)
-        out <<
-          process_line(&count_violations_on_line)
+        out += process_line(&count_violations_on_line)
       end
       out
     end

data/lib/quality/config.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 # XXX: I should figure out how to use tagged releases in github.  Example:
 # https://github.com/xsc/lein-ancient/issues/29
 # https://github.com/xsc/lein-ancient/releases
 
-require 'source_finder/source_file_globber'
+require_relative 'linguist_source_file_globber'
 
 module Quality
   # Configuration for running quality tool
@@ -10,84 +11,49 @@ module Quality
     attr_accessor :skip_tools, :verbose, :quality_name, :ratchet_name,
                   :output_dir, :punchlist_regexp
 
-    extend Forwardable
-
-    def_delegators(:source_file_globber,
-                   :ruby_dirs_arr=, :ruby_dirs_arr,
-                   :extra_ruby_files_arr=, :extra_ruby_files_arr,
-                   :ruby_file_extensions_arr=, :ruby_file_extensions_arr,
-                   :ruby_file_extensions_glob=, :ruby_file_extensions_glob,
-                   :ruby_files_glob, :ruby_files_arr)
+    attr_writer :source_files_exclude_glob, :exclude_files
 
-    def_delegators(:source_file_globber,
-                   :js_dirs_arr=, :js_dirs_arr,
-                   :extra_js_files_arr=, :extra_js_files_arr,
-                   :js_file_extensions_arr=, :js_file_extensions_arr,
-                   :js_file_extensions_glob=, :js_file_extensions_glob,
-                   :js_files_glob, :js_files_arr)
+    extend Forwardable
 
-    def_delegators(:source_file_globber,
-                   :python_dirs_arr=, :python_dirs_arr,
-                   :extra_python_files_arr=, :extra_python_files_arr,
-                   :python_file_extensions_arr=, :python_file_extensions_arr,
-                   :python_file_extensions_glob=, :python_file_extensions_glob,
-                   :python_files_glob, :python_files_arr)
+    def_delegators(:@source_file_globber, :ruby_files, :python_files,
+                   :js_files, :source_and_doc_files, :source_files)
 
-    def_delegators(:source_file_globber,
-                   :source_dirs_arr=, :source_dirs_arr,
-                   :extra_source_files_arr=, :extra_source_files_arr,
-                   :exclude_files_arr=, :exclude_files_arr,
-                   :source_file_extensions_arr=, :source_file_extensions_arr,
-                   :source_file_extensions_glob=, :source_file_extensions_glob,
-                   :source_and_doc_files_glob,
-                   :source_files_glob,
-                   :source_files_exclude_glob,
-                   :source_files_exclude_glob=)
+    def to_glob(files)
+      "{#{files.join(',')}}"
+    end
 
-    alias_method(:extra_ruby_files, :extra_ruby_files_arr)
-    alias_method(:extra_ruby_files=, :extra_ruby_files_arr=)
-    alias_method(:ruby_files, :ruby_files_arr)
-    alias_method(:python_files, :python_files_arr)
-    alias_method(:ruby_dirs, :ruby_dirs_arr)
-    alias_method(:ruby_dirs=, :ruby_dirs_arr=)
-    alias_method(:ruby_file_extensions, :ruby_file_extensions_glob)
-    alias_method(:ruby_file_extensions=, :ruby_file_extensions_glob=)
+    def source_files_glob
+      to_glob(source_files)
+    end
 
-    alias_method(:extra_files, :extra_source_files_arr)
-    alias_method(:extra_files=, :extra_source_files_arr=)
-    alias_method(:extra_source_files, :extra_source_files_arr)
-    alias_method(:extra_source_files=, :extra_source_files_arr=)
-    alias_method(:source_dirs, :source_dirs_arr)
-    alias_method(:source_dirs=, :source_dirs_arr=)
-    alias_method(:exclude_files, :exclude_files_arr)
-    alias_method(:exclude_files=, :exclude_files_arr=)
+    def source_and_doc_files_glob
+      to_glob(source_and_doc_files)
+    end
 
-    # This was named and documented poorly early on
-    alias_method(:source_file_extensions, :source_file_extensions_glob)
-    alias_method(:source_file_extensions=, :source_file_extensions_glob=)
+    def exclude_files
+      @exclude_files || []
+    end
 
-    def source_file_globber
-      @source_file_globber ||=
-        SourceFinder::SourceFileGlobber.new(globber: @globber)
+    def source_files_exclude_glob
+      @source_files_exclude_glob || to_glob(exclude_files)
     end
 
     def all_output_files
-      @globber.glob("#{output_dir}/*_high_water_mark")
+      @dir.glob("#{output_dir}/*_high_water_mark")
     end
 
     def initialize(quality_name: 'quality',
                    ratchet_name: 'ratchet',
-                   globber: raise)
+                   source_file_globber: Quality::LinguistSourceFileGlobber.new,
+                   dir: Dir)
       @quality_name = quality_name
       @ratchet_name = ratchet_name
       @skip_tools = []
       @output_dir = 'metrics'
       @verbose = false
-      @globber = globber
-      source_file_globber.source_files_exclude_glob =
-        '{' + source_file_globber.source_files_exclude_glob +
-        ',db/schema.rb' \
-        '}'
+      @source_file_globber = source_file_globber
+      @dir = dir
+      @source_files_exclude_glob = nil
     end
   end
 end

data/lib/quality/directory_of_classes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'active_support'
 require 'active_support/core_ext'
 

data/lib/quality/linguist_source_file_globber.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+require 'rugged'
+require 'linguist'
+
+module Quality
+  # Uses the Linguist gem to find and classify source files.
+  #
+  # Note: Requires files to be commited within a git repo.
+  class LinguistSourceFileGlobber
+    def initialize(repo: Rugged::Repository.new('.'),
+                   commit: repo.head,
+                   project: Linguist::Repository.new(repo, commit.target_id),
+                   file_blob: Linguist::FileBlob,
+                   pwd: Dir.pwd)
+      @repo = repo
+      @commit = commit
+      @project = project
+      @breakdown_by_file = @project.breakdown_by_file
+      @file_blob = file_blob
+      @pwd = pwd
+    end
+
+    def all_files
+      @source_files ||= begin
+        files = []
+        tree = @commit.target.tree
+        tree.walk(:preorder) do |root, file|
+          files << "#{root}#{file[:name]}" if file[:type] == :blob
+        end
+        files
+      end
+    end
+
+    def ruby_files
+      @breakdown_by_file['Ruby'] || []
+    end
+
+    def python_files
+      @breakdown_by_file['Python'] || []
+    end
+
+    def js_files
+      @breakdown_by_file['JavaScript'] || []
+    end
+
+    def real_files_matching
+      all_files.select do |filename|
+        blob = @file_blob.new(filename, @pwd)
+        if blob.generated? || blob.vendored?
+          false
+        else
+          yield blob, filename
+        end
+      end
+    end
+
+    def source_files
+      @source_files ||= begin
+        real_files_matching do |blob|
+          !blob.language.nil?
+        end
+      end
+    end
+
+    def source_and_doc_files
+      @source_and_doc_files ||= begin
+        real_files_matching do |blob, _filename|
+          if blob.documentation? || !blob.language.nil?
+            true
+          else
+            # puts "Excluding #{filename} from source_and_doc_files"
+            false
+          end
+        end
+      end
+    end
+  end
+end

data/lib/quality/process.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'English'
 
 module Quality

data/lib/quality/quality_checker.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'command_output_processor'
 require_relative 'process'
 require_relative 'ruby_spawn'

data/lib/quality/rake/task.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # XXX: There's an underlying issue with bundler, and knowing my luck,
 # probably RVM that is causing confusion on which version of rake is
@@ -45,15 +46,14 @@ module Quality
                      cmd_runner: Kernel,
                      count_file: File,
                      count_io: IO,
-                     globber: Dir,
                      gem_spec: Gem::Specification,
                      quality_checker_class:
                        Quality::QualityChecker,
-                     which: Which.new)
+                     which: Which.new,
+                     config: Quality::Config.new)
         @dsl = dsl
         @cmd_runner = cmd_runner
-        @globber = globber
-        @config = Quality::Config.new(globber: globber)
+        @config = config
         yield @config if block_given?
         @runner = Quality::Runner.new(@config,
                                       gem_spec: gem_spec,

data/lib/quality/ruby_spawn.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   # Spawn a ruby process
   class RubySpawn

data/lib/quality/runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/inflector'
 require 'forwardable'
 require_relative 'which'
@@ -70,7 +72,7 @@ module Quality
 
     def count_existing_violations(filename)
       existing_violations = @count_io.read(filename).to_i
-      raise("Problem with file #{filename}") if existing_violations < 0
+      raise("Problem with file #{filename}") if existing_violations.negative?
       existing_violations
     end
 
@@ -98,10 +100,16 @@ module Quality
       quality_checker.execute(&count_violations_on_line)
     end
 
-    def_delegators :@config, :ruby_files, :ruby_files_glob,
-                   :python_files, :python_files_glob,
-                   :source_files_glob, :punchlist_regexp,
-                   :source_files_exclude_glob, :exclude_files,
-                   :source_and_doc_files_glob, :js_files_arr
+    def_delegators :@config,
+                   :ruby_files,
+                   :python_files,
+                   :source_files,
+                   :source_files_glob,
+                   :source_and_doc_files,
+                   :source_and_doc_files_glob,
+                   :exclude_files,
+                   :source_files_exclude_glob,
+                   :punchlist_regexp,
+                   :js_files
   end
 end

data/lib/quality/tools/bigfiles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem
@@ -5,8 +7,8 @@ module Quality
       private
 
       def bigfiles_args
-        args = ['--glob', "'#{source_files_glob}'"]
-        if !exclude_files.empty?
+        args = ['--glob', "'#{source_and_doc_files_glob}'"]
+        unless source_files_exclude_glob == '{}'
           args << ['--exclude-glob', "'#{source_files_exclude_glob}'"]
         end
         args.join(' ')

data/lib/quality/tools/brakeman.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'rubocop' tool support to quality gem

data/lib/quality/tools/bundle_audit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'bundler_audit' tool support to quality gem

data/lib/quality/tools/cane.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'cane' tool support to quality gem
@@ -12,11 +14,17 @@ module Quality
         ]
       end
 
+      def ruby_files_glob
+        "{#{ruby_files.join(',')}}"
+      end
+
       def cane_args
         args = [
           "-f '#{ruby_files_glob}'",
         ]
-        args += cane_exclude_args unless exclude_files.empty?
+        unless exclude_files.nil? || exclude_files.empty?
+          args += cane_exclude_args
+        end
         args.join(' ')
       end
 

data/lib/quality/tools/eslint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem
@@ -5,7 +7,7 @@ module Quality
       private
 
       def eslint_args
-        '-f unix ' + js_files_arr.join(' ')
+        '-f unix ' + js_files.join(' ')
       end
 
       def quality_eslint

data/lib/quality/tools/flake8.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'flake8' tool support to quality gem

data/lib/quality/tools/flay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'flay' tool support to quality gem

data/lib/quality/tools/flog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'flog' tool support to quality gem

data/lib/quality/tools/jscs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem
@@ -5,11 +7,11 @@ module Quality
       private
 
       def jscs_args
-        '-r unix ' + js_files_arr.join(' ')
+        '-r unix ' + js_files.join(' ')
       end
 
       def jscs_check_configured
-        return 0 if js_files_arr.empty?
+        return 0 if js_files.empty?
 
         puts 'No JSCS config found!  To generate one, run ' \
              'jscs --auto-configure representative_file.js'

data/lib/quality/tools/pep8.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'pep8' tool support to quality gem

data/lib/quality/tools/punchlist.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'punchlist' tool support to quality gem
@@ -7,7 +9,7 @@ module Quality
       def punchlist_args
         glob = "--glob '#{source_and_doc_files_glob}'"
         regexp = " --regexp '#{punchlist_regexp}'" if punchlist_regexp
-        unless exclude_files.empty?
+        unless exclude_files.nil? || exclude_files.empty?
           exclude = " --exclude-glob '#{source_files_exclude_glob}'"
         end
 

data/lib/quality/tools/rails_best_practices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'rubocop' tool support to quality gem

data/lib/quality/tools/reek.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'reek' tool support to quality gem

data/lib/quality/tools/rubocop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Quality
   module Tools
     # Adds 'rubocop' tool support to quality gem

data/lib/quality/version.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # Quality is a tool that runs quality checks on Ruby code using cane,
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '22.0.0'.freeze
+  VERSION = '23.0.0'
 end

data/lib/quality/which.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # http://stackoverflow.com/questions/2108727/
 #   which-in-ruby-checking-if-program-exists-in-path-from-ruby
 module Quality

data/quality.gemspec

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # ; -*-Ruby-*-
 # -*- encoding: utf-8 -*-
 $LOAD_PATH.push File.join(File.dirname(__FILE__), 'lib')
@@ -10,10 +11,10 @@ Gem::Specification.new do |s|
   s.authors = ['Vince Broz']
   # s.default_executable = %q{quality}
   s.description =
-    'Quality is a tool that runs quality checks on your code using ' \
+    "Quality is a tool that runs quality checks on your code using " \
     "community tools, and makes sure your numbers don't get any " \
     "worse over time. Just add 'rake quality' as part of your " \
-    'Continuous Integration'
+    "Continuous Integration"
   s.email = ['vince@broz.cc']
   # s.executables = ["quality"]
   # s.extra_rdoc_files = ["CHANGELOG", "License.txt"]
@@ -30,7 +31,7 @@ Gem::Specification.new do |s|
   s.summary = 'Code quality tools for Ruby'
 
   s.add_runtime_dependency('activesupport')
-  s.add_runtime_dependency('source_finder', ['>=3.0.0'])
+  s.add_runtime_dependency('github-linguist')
   s.add_runtime_dependency('cane', ['>= 2.6'])
   s.add_runtime_dependency('reek', ['>= 1.3.4'])
   s.add_runtime_dependency('flog', ['>= 4.1.1'])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 22.0.0
+  version: 23.0.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-28 00:00:00.000000000 Z
+date: 2016-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: source_finder
+  name: github-linguist
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement
@@ -316,6 +316,7 @@ files:
 - lib/quality/command_output_processor.rb
 - lib/quality/config.rb
 - lib/quality/directory_of_classes.rb
+- lib/quality/linguist_source_file_globber.rb
 - lib/quality/process.rb
 - lib/quality/quality_checker.rb
 - lib/quality/rake/task.rb