quality 13.0.0 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9f0c2e57cde483dbe36d747786158aeecc033bb
-  data.tar.gz: aca2c88e639a3fc5136acba3e6157080c7cb41ee
+  metadata.gz: 1005c04aae87d441e5a4206c4c4e7771d0e0a354
+  data.tar.gz: ce749018195f340fb7e80b77bbb1b4ea807bc10e
 SHA512:
-  metadata.gz: 780738abc2e816cbaf8cdd1e79e204296aeb0e8d63cbb14f760987616c4e7f742999ca77a47dd5ae2dc41af1cdf7159c424d376f7051a37702445cc12d75aa73
-  data.tar.gz: 8e0ac78008dd7fc927621f537549981e52f2460b36739b6ae89444b3a07bc81e45df12f9cdc4fca797f342290ff41273613ad7272b0935cff4f09e2b98184e3d
+  metadata.gz: a2807707cd4a03836f3deadd69ba4fcb59bc48ef4bf092744a71385a8a0fe8f2958754a807002463927e737d7a06c93d361237408f4102f27d6dfcc42eb90a90
+  data.tar.gz: 79636bb7472afcc74b819a78ed829b1f7b010429c297b80c77f84bc2a70d9e14a8ce4399d998e1eaaf25a1ee4a69afa1091bd2d0bbf723109202257864d433db

data/lib/quality/{process_runner.rb → process.rb}

@@ -2,7 +2,7 @@ require 'English'
 
 module Quality
   # Wrapper around IO.popen that allows exit status to be mocked in tests.
-  class ProcessRunner
+  class Process
     def initialize(full_cmd,
                    dependencies = {})
       @full_cmd = full_cmd

data/lib/quality/quality_checker.rb

@@ -1,8 +1,7 @@
 require_relative 'command_output_processor'
-require_relative 'process_runner'
+require_relative 'process'
 require_relative 'ruby_spawn'
 
-# XXX: Should add *.gemspec to glob
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
   # number of violations for that command, and decreases that number
@@ -14,7 +13,7 @@ module Quality
                    command_output_processor_class:
                      Quality::CommandOutputProcessor,
                    count_dir: Dir,
-                   process_runner_class: ProcessRunner)
+                   process_class: Process)
       @count_file = count_file
       @count_io = count_io
       @command_output_processor_class = command_output_processor_class
@@ -24,7 +23,7 @@ module Quality
       @verbose = verbose
       @count_dir.mkdir(output_dir) unless @count_file.exists?(output_dir)
       @filename = File.join(output_dir, "#{cmd}_high_water_mark")
-      @process_runner_class = process_runner_class
+      @process_class = process_class
     end
 
     def execute(&count_violations_on_line)
@@ -44,7 +43,7 @@ module Quality
     end
 
     def run_command(processor, &count_violations_on_line)
-      runner = @process_runner_class.new(full_cmd)
+      runner = @process_class.new(full_cmd)
 
       puts full_cmd if @verbose
       runner.run do |file|
@@ -54,11 +53,11 @@ module Quality
     end
 
     def check_exit_status(exit_status)
-      return if @command_options[:gives_error_code_on_violations]
+      return if @command_options[:gives_error_code_on_violations] ||
+                @command_options[:gives_error_code_on_no_relevant_code]
 
       fail("Error detected running #{full_cmd}.  " \
-           "Exit status is #{exit_status}, " \
-           "output is [#{out}]") if exit_status != 0
+           "Exit status is #{exit_status}") if exit_status != 0
     end
 
     def existing_violations

data/lib/quality/rake/task.rb

@@ -1,5 +1,18 @@
 #!/usr/bin/env ruby
 
+# XXX: There's an underlying issue with bundler, and knowing my luck,
+# probably RVM that is causing confusion on which version of rake is
+# being pulled in in this situation.  Similar issues from the past:
+#
+# http://stackoverflow.com/questions/6085610/
+#     ruby-on-rails-and-rake-problems-uninitialized-constant-rakedsl
+module Rake
+  # Define this in advance so that confused requires succeed
+  module DSL
+  end
+  class Task
+  end
+end
 require 'rake'
 require 'rake/tasklib'
 require 'rbconfig'

data/lib/quality/runner.rb

@@ -6,8 +6,7 @@ require_relative 'tools/reek'
 require_relative 'tools/rubocop'
 require_relative 'tools/bigfiles'
 require_relative 'tools/punchlist'
-
-# XXX: This name is too similar to process_runner
+require_relative 'tools/brakeman'
 
 module Quality
   # Knows how to run different quality tools based on a configuration
@@ -20,6 +19,7 @@ module Quality
     include Tools::Rubocop
     include Tools::BigFiles
     include Tools::Punchlist
+    include Tools::Brakeman
 
     extend ::Forwardable
 

data/lib/quality/tools/bigfiles.rb

@@ -1,6 +1,6 @@
 module Quality
   module Tools
-    # Adds 'rubocop' tool support to quality gem
+    # Adds 'bigfiles' tool support to quality gem
     module BigFiles
       private
 

data/lib/quality/tools/brakeman.rb

@@ -0,0 +1,20 @@
+module Quality
+  module Tools
+    # Adds 'rubocop' tool support to quality gem
+    module Brakeman
+      private
+
+      def quality_brakeman
+        ratchet_quality_cmd('brakeman',
+                            args: '-q --summary -f csv 2>/dev/null',
+                            gives_error_code_on_no_relevant_code: true) do |line|
+          if line =~ /Security Warnings,([0-9]*) \([0-9]*\)$/
+            $1.to_i
+          else
+            0
+          end
+        end
+      end
+    end
+  end
+end

data/lib/quality/version.rb

@@ -2,5 +2,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '13.0.0'
+  VERSION = '14.0.0'
 end

data/quality.gemspec

@@ -9,9 +9,11 @@ Gem::Specification.new do |s|
 
   s.authors = ['Vince Broz']
   # s.default_executable = %q{quality}
-  s.description = "Quality is a tool that runs quality checks on Ruby
-code using rubocop, cane, reek, flog and flay, and makes sure
-your numbers don't get any worse over time."
+  s.description =
+    'Quality is a tool that runs quality checks on your code using ' \
+    "community tools, and makes sure your numbers don't get any " \
+    "worse over time. Just add 'rake quality' as part of your " \
+    'Continuous Integration'
   s.email = ['vince@broz.cc']
   # s.executables = ["quality"]
   # s.extra_rdoc_files = ["CHANGELOG", "License.txt"]
@@ -36,6 +38,7 @@ your numbers don't get any worse over time."
   s.add_runtime_dependency('rubocop')
   s.add_runtime_dependency('bigfiles')
   s.add_runtime_dependency('punchlist')
+  s.add_runtime_dependency('brakeman')
 
   # need above 3.2.2 to support Ruby 2.0 syntax
   #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 14.0.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-17 00:00:00.000000000 Z
+date: 2015-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cane
@@ -114,6 +114,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: brakeman
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -218,10 +232,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '5'
-description: |-
-  Quality is a tool that runs quality checks on Ruby
-  code using rubocop, cane, reek, flog and flay, and makes sure
-  your numbers don't get any worse over time.
+description: Quality is a tool that runs quality checks on your code using community
+  tools, and makes sure your numbers don't get any worse over time. Just add 'rake
+  quality' as part of your Continuous Integration
 email:
 - vince@broz.cc
 executables: []
@@ -232,13 +245,14 @@ files:
 - README.md
 - Rakefile
 - lib/quality/command_output_processor.rb
-- lib/quality/process_runner.rb
+- lib/quality/process.rb
 - lib/quality/quality_checker.rb
 - lib/quality/rake/config.rb
 - lib/quality/rake/task.rb
 - lib/quality/ruby_spawn.rb
 - lib/quality/runner.rb
 - lib/quality/tools/bigfiles.rb
+- lib/quality/tools/brakeman.rb
 - lib/quality/tools/cane.rb
 - lib/quality/tools/flay.rb
 - lib/quality/tools/flog.rb