quality 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b7bcd6756df46794914fc8b3bd3a11b4b025382
-  data.tar.gz: f5384081e32874f06ea30117585748477b76e7c8
+  metadata.gz: 350f6c6730ee079bb5d55ac825ccbfd41e2fdfd2
+  data.tar.gz: 4c6c2f025cde6d119766c48c945e9edbd18fe032
 SHA512:
-  metadata.gz: dae206fcd6c6013da70740077620154f77f09ed436634ceadf4b9d6e7d63c53cfe2bfab2d394eea8fe44c2854a216136fe50c5490c8dbe410ecdf9ad1a25ceae
-  data.tar.gz: 601e6a2d4b8339580a0802742ebd5e308461d2a6816be27f37543513f90df2ee48365ee0b566b05fba1e98f05aa94504d2e4c793de50c9e93197a80016ed1257
+  metadata.gz: c77587613d9841670e38b35623dd180326b3fc12c1a01b671a6ceec66eddc9c9b5fa4a7cabb9eef3b395a5fecc8801b6bba9277e07927ddcc571adccf49bfbf1
+  data.tar.gz: 27690620eda4e95a5cd3f53590b06235ec28e8c7f4ca870f8dc3a2f447203d6a6cd898fff7e8ccd9b874e4b5daada3a318268ed5771c6b8e281138a872af7b43

data/Rakefile

@@ -16,9 +16,9 @@ CLOBBER.include("#{BUILD_DIR}/*")
 
 Dir['tasks/**/*.rake'].each { |t| load t }
 
-task :default => [:test]
-
-Quality::Rake::Task.new
+Quality::Rake::Task.new do |t|
+  t.skip_tools = ['reek']
+end
 
 task :clear_metrics do |t|
   puts Time.now
@@ -30,3 +30,5 @@ task :clear_metrics do |t|
 end
 
 task :localtest => [:clear_metrics, :test, :quality]
+
+task :default => [:localtest]

data/lib/quality/command_output_processor.rb

@@ -28,7 +28,7 @@ module Quality
       out
     end
 
-    def process_line(&count_violations_on_line)
+    def process_line
       output =
         if emacs_format
           preprocess_line_for_emacs

data/lib/quality/quality_checker.rb

@@ -1,4 +1,5 @@
 require_relative 'command_output_processor'
+require 'English'
 
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
@@ -30,7 +31,7 @@ module Quality
       processor = @command_output_processor_class.new
       processor.emacs_format = @command_options[:emacs_format]
       exit_status = run_command(processor, &count_violations_on_line)
-      [processor, $?.exitstatus]
+      [processor, exit_status]
     end
 
     def run_command(processor, &count_violations_on_line)
@@ -38,14 +39,15 @@ module Quality
         processor.file = file
         @command_output = processor.process!(&count_violations_on_line)
       end
+      $CHILD_STATUS.exitstatus
     end
 
     def check_exit_status(exit_status)
-      unless @command_options[:gives_error_code_on_violations]
-        if exit_status != 0
-          fail("Error detected running #{full_cmd}.  " +
-               "Exit status is #{exit_status}, output is [#{out}]")
-        end
+      return if @command_options[:gives_error_code_on_violations]
+
+      if exit_status != 0
+        fail("Error detected running #{full_cmd}.  " \
+             "Exit status is #{exit_status}, output is [#{out}]")
       end
     end
 
@@ -61,8 +63,8 @@ module Quality
       existing = existing_violations
       report_violations(existing)
       if @violations > existing
-        fail("Output from #{@cmd}\n\n#{@command_output}\n\n" +
-             "Reduce total number of #{@cmd} violations " +
+        fail("Output from #{@cmd}\n\n#{@command_output}\n\n" \
+             "Reduce total number of #{@cmd} violations " \
              "to #{existing} or below!")
       elsif @violations < existing
         puts 'Ratcheting quality up...'

data/lib/quality/rake/task.rb

@@ -6,12 +6,10 @@ require 'rbconfig'
 require_relative '../quality_checker'
 
 module Quality
-
   #
   # Defines a task library for running quality's various tools
   #
   module Rake
-
     # A Rake task that run quality tools on a set of source files, and
     # enforce a ratcheting quality level.
     #
@@ -26,7 +24,6 @@ module Quality
     #
     #   rake quality
     class Task < ::Rake::TaskLib
-
       # Name of quality task.
       # Defaults to :quality.
       attr_accessor :quality_name
@@ -42,7 +39,7 @@ module Quality
 
       # Array of directory names which contain ruby files to analyze.
       #
-      # Defaults to %w{lib test spec feature}, which translates to *.rb in
+      # Defaults to %w(lib test spec feature), which translates to *.rb in
       # the base directory, as well as lib, test, and feature.
       attr_writer :ruby_dirs
 
@@ -97,14 +94,20 @@ module Quality
       private
 
       def define # :nodoc:
-        desc 'Verify quality has increased or stayed ' +
+        desc 'Verify quality has increased or stayed ' \
           'the same' unless ::Rake.application.last_comment
         @dsl.define_task(quality_name) { run_quality }
         @dsl.define_task(ratchet_name) { run_ratchet }
+        tools.each do |tool|
+          @dsl.define_task(tool) { run_quality_with_tool(tool) }
+        end
+      end
+
+      def tools
+        %w(cane flog flay reek rubocop)
       end
 
       def run_quality
-        tools = ['cane', 'flog', 'flay', 'reek', 'rubocop']
         tools.each do |tool|
           run_quality_with_tool(tool)
         end
@@ -181,7 +184,7 @@ module Quality
       end
 
       def ruby_dirs
-        @ruby_dirs ||= %w{lib test spec feature}
+        @ruby_dirs ||= %w(lib test spec feature)
       end
 
       def ruby_files

data/lib/quality/version.rb

@@ -1,3 +1,3 @@
 module Quality
-  VERSION = '1.2.0'
+  VERSION = '1.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-29 00:00:00.000000000 Z
+date: 2014-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cane