quadrigacx 0.8.2 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34289e6667fbe12fe3309842415f0c5ebbe4e3f5
-  data.tar.gz: a39c7459d075f3532d6f153bf4d4d36f0f744a9e
+  metadata.gz: ededb3c30e830783a32bd82dcde5f52b103af055
+  data.tar.gz: 00f503b7428beaabae9644957ed55a4efd0c5ab0
 SHA512:
-  metadata.gz: 6619d03340a4bfacdf9e5a06ba2b391e999c245f39ff825cec9d9d002c2b1d8b7f8912d0ac7b14a218832c5e4afa1ec142c1e272141496e8f700bc1637cae114
-  data.tar.gz: 366091c14a7d5cbff6d459097d7e405883283d5a96112bea4252b13f8e67f0d540d4194248d984733abb52e6c473eaca8cb6b8923127c23b291332ff14e10b3d
+  metadata.gz: 519489d2486a0483c4d2858f855deee6134aace4b69fab684fba07b2ef048f20266af3e3c9c860b3a7a67deec17d28f80f9f4102413bf3f2bc70f40208b4a69e
+  data.tar.gz: f9180c16614b594c451d67e5ba21d925c48b96e2dcf87dfb7cac350e0989fa9ae41fa98fc2198bee3d17bbfcefb23ee3114aa046708a76672ceb65eee2049b12

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    quadrigacx (0.8.0)
+    quadrigacx (0.8.2)
       hashie (~> 3.3)
       json (~> 1.8)
       rest-client (~> 1.7)
@@ -10,6 +10,9 @@ GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.3.6)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
+    columnize (0.9.0)
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.2.5)
@@ -17,12 +20,12 @@ GEM
       unf (>= 0.0.5, < 1.0.0)
     dotenv (1.0.2)
     gem-release (0.7.3)
-    hashie (3.4.1)
+    hashie (3.4.2)
     http-cookie (1.0.2)
       domain_name (~> 0.5)
-    json (1.8.2)
-    mime-types (2.5)
-    netrc (0.10.2)
+    json (1.8.3)
+    mime-types (2.6.1)
+    netrc (0.10.3)
     rest-client (1.8.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 3.0)
@@ -52,6 +55,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  byebug (~> 5.0)
   dotenv (~> 1.0)
   gem-release (~> 0.7)
   quadrigacx!

data/lib/quadrigacx/client.rb

@@ -19,7 +19,6 @@ module QuadrigaCX
         raise ArgumentError, "Options hash required"
       end
 
-      @use_hmac   = true
       @client_id  = options[:client_id]
       @api_key    = options[:api_key]
       @api_secret = options[:api_secret]

data/lib/quadrigacx/error.rb

@@ -1,6 +1,9 @@
 module QuadrigaCX
-  class Error              < StandardError; end
-  class ConfigurationError < Error; end
-  class Unauthorized       < Error; end
-  class NotFound           < Error; end
+  class Error                   < StandardError; end
+  class ConfigurationError      < Error; end
+  class Unauthorized            < Error; end
+  class NotFound                < Error; end
+  class ExceedsAvailableBalance < Error; end
+  class BelowMinimumOrderValue  < Error; end
+  class AboveMaximumOrderValue  < Error; end
 end

data/lib/quadrigacx/request.rb

@@ -13,22 +13,23 @@ module QuadrigaCX
     protected
 
     def request *args
-      resp = @use_hmac ? self.hmac_request(*args) : self.oauth_request(*args)
+      resp = hmac_request(*args)
+      json = JSON.parse(resp) rescue (return fix_json(resp))
+      json.kind_of?(Array) ? json.map { |i| to_hashie(i) } : to_hashie(json)
+    end
+
+    private
 
+    def fix_json response
       begin
-        json = JSON.parse(resp.body)
+        JSON.parse(response)
 
       # The `/cancel_order` route returns `"true"` instead of valid JSON.
       rescue JSON::ParserError
-        return true  if resp.body.strip == '"true"'
-        return false if resp.body.strip == '"false"'
-
-        match = resp.body.match(/"(.*)"/)
-
-        return match ? match[1] : resp.body
+        return true  if response.strip == '"true"'
+        return false if response.strip == '"false"'
+        response[/"(.*)"/, 1] || response
       end
-
-      json.kind_of?(Array) ? json.map { |i| to_hashie(i) } : to_hashie(json)
     end
 
     def hmac_request http_method, path, body={}
@@ -65,24 +66,22 @@ module QuadrigaCX
       )
     end
 
-    # Perform an OAuth API request. The client must be initialized
-    # with a valid OAuth access token to make requests with this method
-    #
-    # path   - Request path
-    # body -   Parameters for requests - GET and POST
-    #
-    # TODO(maros): Implement this when QuadrigaCX supports it.
-    def oauth_request http_method, path, body={}
+    def raise_error hash
+      errorClass =
+        case hash.error.code
+        when 21 then ExceedsAvailableBalance
+        when 22 then BelowMinimumOrderValue
+        when 23 then AboveMaximumOrderValue
+        else Error
+        end
+
+      raise errorClass.new(hash.error) if hash.error
+      raise errorClass.new(hash.errors.join(',')) if hash.errors
     end
 
-    private
-
     def to_hashie json
       hash = Hashie::Mash.new(json)
-
-      raise Error.new(hash.error) if hash.error
-      raise Error.new(hash.errors.join(',')) if hash.errors
-
+      raise_error(hash) if hash.error
       hash
     end
   end

data/lib/quadrigacx/version.rb

@@ -1,5 +1,5 @@
 module QuadrigaCX
   unless defined?(QuadrigaCX::VERSION)
-    VERSION = '0.8.2'
+    VERSION = '0.9.0'
   end
 end

data/lib/quadrigacx.rb

@@ -16,7 +16,6 @@ module QuadrigaCX
       raise ArgumentError, "Options hash required"
     end
 
-    @@options[:use_hmac]   = true
     @@options[:client_id]  = options[:client_id]
     @@options[:api_key]    = options[:api_key]
     @@options[:api_secret] = options[:api_secret]

data/quadrigacx.gemspec

@@ -11,6 +11,7 @@ Gem::Specification.new do |s|
   s.homepage    = "http://mhluska.com/"
   s.license     = "MIT"
 
+  s.add_development_dependency 'byebug',      '~> 5.0'
   s.add_development_dependency 'rspec',       '~> 3.1'
   s.add_development_dependency 'webmock',     '~> 1.20'
   s.add_development_dependency 'vcr',         '~> 2.9'

data/spec/client_spec.rb

@@ -98,6 +98,24 @@ describe QuadrigaCX::Client do
           expect(order.id).not_to be_nil
         end
       end
+
+      it 'throws an error when exceeding balance' do
+        VCR.use_cassette('limit_buy_above_maximum_order_value') do
+          expect { client.limit_buy(price: 1_000_000, amount: 1) }.to raise_error(QuadrigaCX::AboveMaximumOrderValue)
+        end
+      end
+
+      it 'throws an error when the amount is too small' do
+        VCR.use_cassette('limit_buy_below_minimum_order_value') do
+          expect { client.limit_buy(price: 100, amount: 0.00000001) }.to raise_error(QuadrigaCX::BelowMinimumOrderValue)
+        end
+      end
+
+      it 'throws an error when exceeding available balance' do
+        VCR.use_cassette('limit_buy_exceeds_available_balance') do
+          expect { client.limit_buy(price: 4999, amount: 1) }.to raise_error(QuadrigaCX::ExceedsAvailableBalance)
+        end
+      end
     end
 
     describe '#limit_sell' do

data/spec/fixtures/vcr_cassettes/limit_buy_above_maximum_order_value.yml

@@ -0,0 +1,56 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.quadrigacx.com/v2/buy
+    body:
+      encoding: UTF-8
+      string: '{"price":1000000,"amount":1,"key":"kOnVDjfPPh","nonce":"1436134811802","signature":"08e90f76f7f5d2d5deda2bd2254d2ace2a60fde5c8c9fb21f90e93394268351d"}'
+    headers:
+      Accept:
+      - application/json
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '150'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - cloudflare-nginx
+      Date:
+      - Sun, 05 Jul 2015 22:20:14 GMT
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '111'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d32dff9e85d8cfd61f02b3ce7236432441436134814; expires=Mon, 04-Jul-16
+        22:20:14 GMT; path=/; domain=.quadrigacx.com; HttpOnly
+      - ci_session=a65b3c51701e5c4897d5cdf591000bb4; expires=Mon, 06-Jul-2015 22:20:14
+        GMT; Max-Age=86400; path=/
+      Content-Encoding:
+      - gzip
+      Vary:
+      - Accept-Encoding
+      X-Powered-By:
+      - PHP/5.5.9-1ubuntu4.9
+      Cf-Ray:
+      - 201674bbbfc92192-EWR
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAA6tWSi0qyi9SsqpWSs5PSVWyMjLWUcpNLS5OTAdylDzzkvOL
+        ilKTSxQKijKTUxVUDHUMDAxAWM/AwNnRRSGzWCExKb8sVaEkI1UhN7EiM7c0
+        VyE/TUHFFKFIqbYWALUjnkdnAAAA
+    http_version: 
+  recorded_at: Sun, 05 Jul 2015 22:20:14 GMT
+recorded_with: VCR 2.9.3

data/spec/fixtures/vcr_cassettes/limit_buy_below_minimum_order_value.yml

@@ -0,0 +1,55 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.quadrigacx.com/v2/buy
+    body:
+      encoding: UTF-8
+      string: '{"price":100,"amount":1.0e-08,"key":"kOnVDjfPPh","nonce":"1436134814405","signature":"021c293df298e506a10a662d18deb6aa81f0be90ff9d770a3abc44bdf045415f"}'
+    headers:
+      Accept:
+      - application/json
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '152'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - cloudflare-nginx
+      Date:
+      - Sun, 05 Jul 2015 22:20:14 GMT
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '75'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d35efbfc1bfd0e98c5f4642689836fea91436134814; expires=Mon, 04-Jul-16
+        22:20:14 GMT; path=/; domain=.quadrigacx.com; HttpOnly
+      - ci_session=5b530dab54071514991afb20690f4a78; expires=Mon, 06-Jul-2015 22:20:14
+        GMT; Max-Age=86400; path=/
+      Content-Encoding:
+      - gzip
+      Vary:
+      - Accept-Encoding
+      X-Powered-By:
+      - PHP/5.5.9-1ubuntu4.9
+      Cf-Ray:
+      - 201674bf2f2d21e0-EWR
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAA6tWSi0qyi9SsqpWSs5PSVWyMjLSUcpNLS5OTAdylDzzkvOL
+        ilKTSxQSc/NL80oUDPUMXHUtlGprAeoB5yg5AAAA
+    http_version: 
+  recorded_at: Sun, 05 Jul 2015 22:20:14 GMT
+recorded_with: VCR 2.9.3

data/spec/fixtures/vcr_cassettes/limit_buy_exceeds_available_balance.yml

@@ -0,0 +1,56 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.quadrigacx.com/v2/buy
+    body:
+      encoding: UTF-8
+      string: '{"price":4999,"amount":1,"key":"kOnVDjfPPh","nonce":"1436134814778","signature":"246305d318a717ac373310b7175910f973b4fe39ba52eadc0c3db8841d740f6e"}'
+    headers:
+      Accept:
+      - application/json
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '147'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - cloudflare-nginx
+      Date:
+      - Sun, 05 Jul 2015 22:20:15 GMT
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '103'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d5bb9c9c4d1d088e64cfafc3043de58701436134814; expires=Mon, 04-Jul-16
+        22:20:14 GMT; path=/; domain=.quadrigacx.com; HttpOnly
+      - ci_session=19acf8226619ccc168dc931e16994281; expires=Mon, 06-Jul-2015 22:20:15
+        GMT; Max-Age=86400; path=/
+      Content-Encoding:
+      - gzip
+      Vary:
+      - Accept-Encoding
+      X-Powered-By:
+      - PHP/5.5.9-1ubuntu4.9
+      Cf-Ray:
+      - 201674c16332219e-EWR
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAAxXIwQpAQBAG4FeZJkcJuezexMVjjPEntWzNSkr77jh+38Mw
+        i8b+YY0L2LdNyTtSkvUDT4dGM+hJnoqudM5VdT30I+FWYEkkl2xB5gD6d5Yg
+        h4JzfgFV7vSrWAAAAA==
+    http_version: 
+  recorded_at: Sun, 05 Jul 2015 22:20:15 GMT
+recorded_with: VCR 2.9.3

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: quadrigacx
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.9.0
 platform: ruby
 authors:
 - Maros Hluska
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-24 00:00:00.000000000 Z
+date: 2015-07-05 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -147,7 +161,10 @@ files:
 - spec/fixtures/vcr_cassettes/balance.yml
 - spec/fixtures/vcr_cassettes/cancel.yml
 - spec/fixtures/vcr_cassettes/limit_buy.yml
+- spec/fixtures/vcr_cassettes/limit_buy_above_maximum_order_value.yml
+- spec/fixtures/vcr_cassettes/limit_buy_below_minimum_order_value.yml
 - spec/fixtures/vcr_cassettes/limit_buy_cancel_order.yml
+- spec/fixtures/vcr_cassettes/limit_buy_exceeds_available_balance.yml
 - spec/fixtures/vcr_cassettes/limit_sell_cancel_order.yml
 - spec/fixtures/vcr_cassettes/market_buy.yml
 - spec/fixtures/vcr_cassettes/open_orders.yml
@@ -192,7 +209,10 @@ test_files:
 - spec/fixtures/vcr_cassettes/balance.yml
 - spec/fixtures/vcr_cassettes/cancel.yml
 - spec/fixtures/vcr_cassettes/limit_buy.yml
+- spec/fixtures/vcr_cassettes/limit_buy_above_maximum_order_value.yml
+- spec/fixtures/vcr_cassettes/limit_buy_below_minimum_order_value.yml
 - spec/fixtures/vcr_cassettes/limit_buy_cancel_order.yml
+- spec/fixtures/vcr_cassettes/limit_buy_exceeds_available_balance.yml
 - spec/fixtures/vcr_cassettes/limit_sell_cancel_order.yml
 - spec/fixtures/vcr_cassettes/market_buy.yml
 - spec/fixtures/vcr_cassettes/open_orders.yml