quack_pool 0.0.0 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e99542e0d54f7d86d03719c0cdd3caed78da2dc5
-  data.tar.gz: 696ec9dedffd4e8d5a4bad879efc5b1a60db6c0a
+  metadata.gz: 6251b9300303dfa23b3d17b3ae8a692f1b3726f8
+  data.tar.gz: f50cc41da67d8ca9dc5b210589d1b99c8dfdbb62
 SHA512:
-  metadata.gz: 7ee146d9ed9182397ba63a8a2c9b8e5868486ea21a4581ab47369ca1abf02af809f0d45b69410c2d4fe0db529624270d9fe0728dcb5b74cb321e59c3140dcbc7
-  data.tar.gz: 54c20fa04f7dff1f3bf759289bf3166d231a35735aca1e5fdf31323a6df9be1396936d314f4d3c9421a9ec76836cbb558b0991d7282e0b45b3ba532f802bbbc4
+  metadata.gz: 3cf28ec57b7f24a43d23ea9549d905291f326dfa178f64499c355eb340df32848646f8ebbd1d334d082e89841ad3c1b24aa7069da3fa171029c485d08e9dc2df
+  data.tar.gz: 26e735a2154ec0dee52fa476174f9e9a068c576414449fc2550e205f2abdd0f7edac9b82a09c715ed4480711251687de445474c0f4a7c922e188edf65ce75155

data/lib/quack_pool.rb

@@ -1,3 +1,8 @@
+require 'reentrant_mutex'
+
+require 'quack_pool/error'
+
+
 class QuackPool
 
   def initialize(resource_class: , size: Float::INFINITY)
@@ -7,10 +12,27 @@ class QuackPool
     @max_size = size
     @resources = []
     @available_resources = []
-    @mutex = Mutex.new
+    @mutex = ReentrantMutex.new
     @condition_variable = ConditionVariable.new
   end
   
+  def absorb_resource(resource)
+    @mutex.synchronize do
+      raise Error, "resource does not belong to this pool" unless has_resource?(resource)
+      raise Error, "resource already in pool" if resource_available?(resource)
+      @available_resources.push(resource)
+      @condition_variable.signal
+    end
+    nil
+  end
+  
+  def has_resource?(resource)
+    @mutex.synchronize do
+      raise Error, "resource is not an instance of 'resource_class'" unless resource.is_a?(@resource_class)
+      @resources.include?(resource)
+    end
+  end
+  
   def release_resource
     @mutex.synchronize do
       if @available_resources.any?
@@ -23,29 +45,26 @@ class QuackPool
     end
   end
   
-  def absorb_resource(resource)
+  def resource_available?(resource)
     @mutex.synchronize do
-      raise ArgumentError, "'resource' does not belong to this pool" unless @resources.include?(resource)
-      raise ArgumentError, "'resource' already in pool" if @available_resources.include?(resource)
-      @available_resources.push(resource)
-      @condition_variable.signal
+      raise Error, "resource does not belong to this pool" unless has_resource?(resource)
+      @available_resources.include?(resource)
     end
-    nil
   end
   
   private
   
-  def release_available_resource
-    @available_resources.pop
-  end
-  
   def build_new_resource
     new_resource = @resource_class.new
-    raise "'new_resource' must be unique" if @resources.include?(new_resource)
+    raise Error, "'new_resource' must be unique" if has_resource?(new_resource)
     @resources << new_resource
     new_resource
   end
   
+  def release_available_resource
+    @available_resources.pop
+  end
+  
   def release_next_available_resource
     @condition_variable.wait(@mutex)
     release_available_resource

data/lib/quack_pool/error.rb

@@ -0,0 +1,4 @@
+class QuackPool
+  class Error < StandardError
+  end
+end

data/spec/quack_pool_spec.rb

@@ -47,7 +47,7 @@ RSpec.describe QuackPool do
         it "should raise error" do
           resource = pool.release_resource
           pool.absorb_resource(resource)
-          expect { pool.absorb_resource(resource) }.to raise_error ArgumentError
+          expect { pool.absorb_resource(resource) }.to raise_error QuackPool::Error
         end
       end
       
@@ -55,12 +55,70 @@ RSpec.describe QuackPool do
         it "should raise error" do
           resource = pool.release_resource
           pool2 = QuackPool.new(resource_class: resource_class)
-          expect { pool2.absorb_resource(resource) }.to raise_error ArgumentError
+          expect { pool2.absorb_resource(resource) }.to raise_error QuackPool::Error
         end
       end
     
     end
     
+    describe "#has_resource?" do
+    
+      context "after releasing a new resource" do
+        it "should reutrn true" do
+          resource = pool.release_resource
+          expect(pool.has_resource?(resource)).to eql true
+        end
+      end
+      
+      context "after absorbing a resource" do
+        it "should reutrn true" do
+          resource = pool.release_resource
+          pool.absorb_resource(resource)
+          expect(pool.has_resource?(resource)).to eql true
+        end
+      end
+      
+      context "when passed a non resource object" do
+        it "should raise error" do
+          expect { pool.has_resource?(1) }.to raise_error QuackPool::Error
+        end
+      end
+      
+    end
+    
+    describe "#resource_available?" do
+    
+      context "after releasing a new resource" do
+        it "should reutrn false" do
+          resource = pool.release_resource
+          expect(pool.resource_available?(resource)).to eql false
+        end
+      end
+      
+      context "after absorbing the resource" do
+        it "should reutrn true" do
+          resource = pool.release_resource
+          pool.absorb_resource(resource)
+          expect(pool.resource_available?(resource)).to eql true
+        end
+      end
+      
+      context "when passed a non resource object" do
+        it "should raise error" do
+          expect { pool.resource_available?(1) }.to raise_error QuackPool::Error
+        end
+      end
+      
+      context "when resource is from other pool" do
+        it "should raise error" do
+          pool2 = QuackPool.new(resource_class: resource_class)
+          resource = pool2.release_resource
+          expect { pool.resource_available?(resource) }.to raise_error QuackPool::Error
+        end
+      end
+      
+    end
+    
   end
   
   context "when size is specified" do

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: quack_pool
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.1.0
 platform: ruby
 authors:
 - Rob Fors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-03 00:00:00.000000000 Z
-dependencies: []
+date: 2018-04-13 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: reentrant_mutex
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
 description: A simple resource pool that accepts a resource class to build the pool's
   resources from.
 email: mail@robfors.com
@@ -21,6 +35,7 @@ files:
 - README.md
 - Rakefile
 - lib/quack_pool.rb
+- lib/quack_pool/error.rb
 - spec/quack_pool_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/robfors/quack_pool