qti 2.11.0 → 2.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 783579cd76121396d891a45730e833ebed9967a7366f75b61c8dca97dd429091
-  data.tar.gz: 15193545fbe7b76ae5e66906a1794f19d3b5d175c7719adb8b01b48223ffe1d2
+  metadata.gz: 36f18933b8d36d5a0c9ff5a5b4788852a9061c434385c3dd542b9cfb6c736c8d
+  data.tar.gz: 97641eb71ae7efa662ed2e6052e7cb4f35297e8927a3c01c808dc85dcacbf6e3
 SHA512:
-  metadata.gz: e2a783e103895c2f88d98e7e79c8a8024b1ef8726b7d54a03021213ac5745d6c85f0d5cb822e2034e64812e63ac2b8501067ef584a1167521be89401d08bc4b6
-  data.tar.gz: 82a518e1b780ebc9ca5177212bde1108e7980efe4f4bee9473bc753a238268b1f9bfd1ba57bf8341d668faa8ed02166e5566dcfdb61215ddd817c6b8e6d34e05
+  metadata.gz: db6f0e6c2987afa8da40dd633ae1ecbb3fd5e099ddf6de86d6bf3b65d075caf8cfd4e1a4070810fdca2452ee669f347c33dfbb3d508f8ab44b26ccbc651f2009
+  data.tar.gz: bb12cf21f40ea16f3238d7a04f73b8a203b4a54881fd1f1576841abbf26045501e745b358ad77b94d8b4ee1f0ff16fe88876f7d7df073a85efa92ada6e14c75d

data/lib/qti/v2/models/assessment_item.rb

@@ -10,7 +10,7 @@ module Qti
             # ensure a prompt is carried into the html
             prompt = node.at_xpath('//xmlns:prompt')
             filter_item_body(node)
-            node.add_child(prompt) if prompt&.parent && prompt.parent != node
+            node.add_child(prompt&.dup) if prompt&.parent && prompt.parent != node
             sanitize_content!(node.to_html)
           end
         end

data/lib/qti/v2/models/interactions/gap_match_interaction.rb

@@ -59,9 +59,11 @@ module Qti
           def stem_text
             clean_stem_items.search('p').children.map do |stem_item|
               if stem_item.name == 'gap'
+                blank_id = stem_item.attributes['identifier'].value
                 {
                   type: 'blank',
-                  blank_id: stem_item.attributes['identifier'].value
+                  blank_id: blank_id,
+                  blank_name: correct_choice_value(blank_id)
                 }
               else
                 {
@@ -84,12 +86,15 @@ module Qti
             end
           end
 
+          def correct_choice_value(node_id)
+            answer_choice(choices, question_response_id_mapping[node_id]).content
+          end
+
           def scoring_data_structs
-            mapping = question_response_id_mapping
             answer_nodes.map do |value_node|
               node_id = value_node.attributes['identifier']&.value
               ScoringData.new(
-                answer_choice(choices, mapping[node_id]).content,
+                correct_choice_value(node_id),
                 'directedPair',
                 id: node_id,
                 case: false
@@ -114,11 +119,13 @@ module Qti
           end
 
           def question_response_id_mapping
-            question_response_pairs = node.xpath('.//xmlns:correctResponse//xmlns:value').map do |value|
-              value.content.split
+            @question_response_id_mapping ||= begin
+              question_response_pairs = node.xpath('.//xmlns:correctResponse//xmlns:value').map do |value|
+                value.content.split
+              end
+              question_response_pairs.map!(&:reverse)
+              Hash[question_response_pairs]
             end
-            question_response_pairs.map!(&:reverse)
-            Hash[question_response_pairs]
           end
         end
       end

data/lib/qti/version.rb

@@ -1,3 +1,3 @@
 module Qti
-  VERSION = '2.11.0'.freeze
+  VERSION = '2.12.0'.freeze
 end

data/spec/lib/qti/v2/models/assessment_item_spec.rb

@@ -20,6 +20,10 @@ describe Qti::V2::Models::AssessmentItem do
       expect(loaded_class.item_body).to include 'Look at the text in the picture.'
     end
 
+    it 'includes the prompt in the item_body' do
+      expect(loaded_class.item_body).to include 'What does it say?'
+    end
+
     it 'falls back onto nil points possible value' do
       expect(loaded_class.points_possible).to eq nil
     end
@@ -43,6 +47,19 @@ describe Qti::V2::Models::AssessmentItem do
     end
   end
 
+  context 'gap_match.xml' do
+    let(:fixtures_path) { File.join('spec', 'fixtures') }
+    let(:file_path) { File.join(fixtures_path, 'items_2.1', 'gap_match.xml') }
+    let(:loaded_class) { described_class.from_path!(file_path) }
+
+    it 'returns the prompt as the first stem item even after calculating item_body' do
+      loaded_class.item_body
+      stem_items = loaded_class.interaction_model.stem_items
+      expect(stem_items.count).to equal(12)
+      expect(stem_items.first[:value]).to include('Identify the missing words')
+    end
+  end
+
   context 'all test files' do
     test_files = Dir.glob(File.join('spec', 'fixtures', 'items_2.1', '*.xml'))
     test_files.each do |file|

data/spec/lib/qti/v2/models/interactions/gap_match_interaction_spec.rb

@@ -11,11 +11,11 @@ describe Qti::V2::Models::Interactions::GapMatchInteraction do
           value: "Identify the missing words in this famous quote from Shakespeare's Richard III.",
           id: 'stem_0', position: 1 },
         { type: 'text', value: 'Now is the ', id: 'stem_1', position: 2 },
-        { type: 'blank', blank_id: 'G1', id: 'stem_2', position: 3 },
+        { type: 'blank', blank_id: 'G1', blank_name: 'winter', id: 'stem_2', position: 3 },
         { type: 'text', value: ' of our discontent', id: 'stem_3', position: 4 },
         { type: 'text', value: ' ', id: 'stem_4', position: 5 },
         { type: 'text', value: ' Made glorious ', id: 'stem_5', position: 6 },
-        { type: 'blank', blank_id: 'G2', id: 'stem_6', position: 7 },
+        { type: 'blank', blank_id: 'G2', blank_name: 'summer', id: 'stem_6', position: 7 },
         { type: 'text', value: ' by this sun of York;', id: 'stem_7', position: 8 },
         { type: 'text', value: ' ', id: 'stem_8', position: 9 },
         { type: 'text', value: " And all the clouds that lour'd\n          upon our house",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qti
 version: !ruby/object:Gem::Version
-  version: 2.11.0
+  version: 2.12.0
 platform: ruby
 authors:
 - Adrian Diaz
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-19 00:00:00.000000000 Z
+date: 2022-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview