qti 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 96229366751c574392ef6478af9c08bad96cec41
-  data.tar.gz: ef9619aa3bdf5d8f83c46839f8d04953a79a717b
+  metadata.gz: 202d9ba3ef99c4e0df030cf13a8e25f4e19441c2
+  data.tar.gz: 077f7118e61d94d1d7796494e481355e0b399833
 SHA512:
-  metadata.gz: e9b5a5f1d726675d1cf1b5e161120c73a23ac1c20e633cd738787c9d3f5edbfad5618ac52fcabcb779789c4a2d04b019b386ba99a1819d8316c0c6d5da6dae61
-  data.tar.gz: 9fa1abca8886f8f5c86bc4e1bcd84a5890dc99ba2facc8e5aad2aa4642af7c95894f1970924b2018b7078400b210c7b8da5e8e43380125894416279f6fbe6074
+  metadata.gz: 6119e426a2f6c4b91cfb84ac7da7ca78317490439c0ace3ec067fc65ffa1b8b929979dfa76a4cb648b9d44781e5cb55d38490c89151ab1e66581c9315c8b88ff
+  data.tar.gz: 76f7caf87c7c9efd299b770d2adfcfa5737991dbaa3b2ee450616d0ae987bac40bd2a362932769f462006e80a11b40b4cb00c249cf48b1565c70fa50b71d559e

data/lib/null_logger.rb

@@ -1,7 +1,5 @@
 class NullLogger < Logger
-  def initialize(*args)
-  end
+  def initialize(*args); end
 
-  def add(*args, &block)
-  end
+  def add(*args, &block); end
 end

data/lib/qti/models/base.rb

@@ -113,7 +113,7 @@ module Qti
           case node[:type]
           when /^image\//
             return replace_with_image(node, node[:data])
-          when "text/html"
+          when 'text/html'
             return replace_with_html(node, path)
           end
         end
@@ -127,15 +127,13 @@ module Qti
       end
 
       def replace_with_html(node, path)
-        begin
-          content = File.read(path)
-          html_content = Sanitize.fragment(content, sanitize_config(import_objects: false))
-          node.name = 'div'
-          node.add_child(Nokogiri::HTML.fragment(html_content))
-        rescue StandardError => e
-          warn "failed to import html object #{path}: #{e.message}"
-          node.unlink
-        end
+        content = File.read(path)
+        html_content = Sanitize.fragment(content, sanitize_config(import_objects: false))
+        node.name = 'div'
+        node.add_child(Nokogiri::HTML.fragment(html_content))
+      rescue StandardError => e
+        warn "failed to import html object #{path}: #{e.message}"
+        node.unlink
       end
     end
   end

data/lib/qti/models/manifest.rb

@@ -3,29 +3,25 @@ require 'qti/v1/models/base'
 module Qti
   module Models
     class Manifest < Qti::Models::Base
-
       def assessment_test
         qti_2_x_href || qti_1_href || qti_2_non_assessment_href || unknown_type
       end
 
       def qti_1_href
         test_path = xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_xmlv1p2']/@href")&.content ||
-          xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_xmlv1p2']/xmlns:file/@href")&.content
+                    xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_xmlv1p2']/xmlns:file/@href")&.content
         Qti::V1::Models::Assessment.from_path!(remap_href_path(test_path), @package_root) if test_path
       end
 
       def qti_2_x_href
         test_path = xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_test_xmlv2p1']/@href")&.content ||
-          xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_test_xmlv2p2']/@href")&.content
+                    xpath_with_single_check("//xmlns:resources/xmlns:resource[@type='imsqti_test_xmlv2p2']/@href")&.content
         Qti::V2::Models::AssessmentTest.from_path!(remap_href_path(test_path), @package_root) if test_path
       end
 
       def qti_2_non_assessment_href
-        qti2_ns = ["http://www.imsglobal.org/xsd/imsqti_metadata_v2p1", "http://www.imsglobal.org/xsd/imsqti_v2p1"]
-        if qti2_ns.include?(xpath_with_single_check("//xmlns:manifest")&.namespaces["xmlns:imsqti"])
-          # use imsmanifest.xml as the assessment XML if there is no assessment xml
-          Qti::V2::Models::NonAssessmentTest.from_path!(@path, @package_root)
-        end
+        item_path = @doc.at_xpath("//xmlns:resources/xmlns:resource[@type='imsqti_item_xmlv2p1']/@href")&.content
+        Qti::V2::Models::NonAssessmentTest.from_path!(@path, @package_root) if item_path
       end
 
       def unknown_type

data/lib/qti/v1/models/assessment.rb

@@ -16,12 +16,12 @@ module Qti
           Qti::V1::Models::AssessmentItem.new(assessment_item, @package_root)
         end
 
-        def stimulus_ref(ref)
-          return nil
+        def stimulus_ref(_ref)
+          nil
         end
 
-        def create_stimulus(stimulus)
-          raise "Stimulus type not supported for QTI version"
+        def create_stimulus(_stimulus)
+          raise 'Stimulus type not supported for QTI version'
         end
       end
     end

data/lib/qti/v1/models/assessment_item.rb

@@ -36,7 +36,7 @@ module Qti
 
         def has_points_possible_qti_metadata?
           if @doc.at_xpath('.//xmlns:qtimetadata').present?
-            points_possible_label = qti_metadata_children.children.find {|node| node.text == "points_possible"}
+            points_possible_label = qti_metadata_children.children.find { |node| node.text == 'points_possible' }
             points_possible_label.present?
           else
             false
@@ -46,7 +46,7 @@ module Qti
         def points_possible
           @points_possible ||= begin
             if has_points_possible_qti_metadata?
-              points_possible_label = qti_metadata_children.children.find {|node| node.text == "points_possible"}
+              points_possible_label = qti_metadata_children.children.find { |node| node.text == 'points_possible' }
               points_possible_node = points_possible_label.next.text
             else
               decvar_maxvalue

data/lib/qti/v1/models/choices/fill_blank_choice.rb

@@ -12,7 +12,7 @@ module Qti
 
           def identifier
             @identifier ||= @node.attributes['respident']&.value ||
-              @node.attributes['ident']&.value
+                            @node.attributes['ident']&.value
           end
 
           def item_body

data/lib/qti/v1/models/interactions/base_interaction.rb

@@ -5,7 +5,7 @@ module Qti
         class BaseInteraction < Qti::V1::Models::Base
           attr_reader :node
 
-          def self.matches(node, parent)
+          def self.matches(_node, _parent)
             false
           end
 

data/lib/qti/v1/models/interactions/choice_interaction.rb

@@ -6,7 +6,7 @@ module Qti
           # This will know if a class matches
           def self.matches(node, parent)
             matches = node.xpath('.//xmlns:response_lid')
-            return false if matches.count > 1  || matches.empty?
+            return false if matches.count > 1 || matches.empty?
             rcardinality = matches.first.attributes['rcardinality']&.value || 'Single'
             return false if rcardinality == 'Ordered'
             new(node, parent)

data/lib/qti/v1/models/interactions/fill_blank_interaction.rb

@@ -45,22 +45,21 @@ module Qti
           end
 
           def scoring_data_structs
-            answer_nodes.map { |value_node| ScoringData.new(
+            answer_nodes.map do |value_node|
+              ScoringData.new(
                 value_node.content,
                 rcardinality,
-                {
-                  id: value_node.attributes['respident']&.value,
-                  case: value_node.attributes['case']&.value || 'no'
-                }
+                id: value_node.attributes['respident']&.value,
+                case: value_node.attributes['case']&.value || 'no'
               )
-            }
+            end
           end
 
           private
 
           def rcardinality
             @rcardinality ||= @node.at_xpath('.//xmlns:response_str/@rcardinality')&.value ||
-              @node.at_xpath('.//xmlns:response_num/@rcardinality')&.value
+                              @node.at_xpath('.//xmlns:response_num/@rcardinality')&.value
           end
 
           def answer_nodes

data/lib/qti/v1/models/interactions/ordering_interaction.rb

@@ -6,7 +6,7 @@ module Qti
           # This will know if a class matches
           def self.matches(node, parent)
             matches = node.xpath('.//xmlns:response_lid')
-            return false if matches.count > 1  || matches.empty?
+            return false if matches.count > 1 || matches.empty?
             rcardinality = matches.first.attributes['rcardinality']&.value || 'Single'
             return false if rcardinality != 'Ordered'
             new(node, parent)

data/lib/qti/v1/models/scoring_data.rb

@@ -2,7 +2,7 @@ module Qti
   module V1
     module Models
       ScoringData = Struct.new(:values, :rcardinality, :id, :case) do
-        def initialize(values, rcardinality, options={})
+        def initialize(values, rcardinality, options = {})
           super(values, rcardinality, options[:id], options[:case])
         end
       end

data/lib/qti/v2/models/assessment_item.rb

@@ -35,7 +35,7 @@ module Qti
         def points_possible
           @points_possible ||= begin
             xpath_with_single_check("//xmlns:outcomeDeclaration[@identifier='SCORE']/@normalMaximum")&.content ||
-            xpath_with_single_check("//xmlns:outcomeDeclaration[@identifier='MAXSCORE']//xmlns:value")&.content
+              xpath_with_single_check("//xmlns:outcomeDeclaration[@identifier='MAXSCORE']//xmlns:value")&.content
           end
         end
 

data/lib/qti/v2/models/assessment_test.rb

@@ -5,7 +5,7 @@ module Qti
     module Models
       class AssessmentTest < Qti::V2::Models::Base
         def title
-          @title ||= xpath_with_single_check('//xmlns:assessmentTest/@title')&.content || File.basename(@path, ".xml")
+          @title ||= xpath_with_single_check('//xmlns:assessmentTest/@title')&.content || File.basename(@path, '.xml')
         end
 
         def assessment_items
@@ -29,8 +29,8 @@ module Qti
           Qti::V2::Models::AssessmentItem.from_path!(assessment_item_ref, @package_root)
         end
 
-        def stimulus_ref(ref)
-          return nil
+        def stimulus_ref(_ref)
+          nil
         end
 
         def create_stimulus(stimulus_ref)

data/lib/qti/v2/models/base.rb

@@ -4,7 +4,7 @@ module Qti
   module V2
     module Models
       class Base < Qti::Models::Base
-        BODY_ELEMENTS_CSS = %w(
+        BODY_ELEMENTS_CSS = %w[
           atomicBlock
           atomicInline
           caption
@@ -33,9 +33,9 @@ module Qti
           tr
           ul
           infoControl
-        ).join(',').freeze
+        ].join(',').freeze
 
-        INTERACTION_ELEMENTS_CSS = %w(
+        INTERACTION_ELEMENTS_CSS = %w[
           blockInteraction
           customInteraction
           inlineInteraction
@@ -55,11 +55,11 @@ module Qti
           orderInteraction
           sliderInteraction
           uploadInteraction
-        ).join(',').freeze
+        ].join(',').freeze
 
-        CHOICE_ELEMENTS_CSS = %w(
+        CHOICE_ELEMENTS_CSS = %w[
           simpleChoice
-        ).join(',').freeze
+        ].join(',').freeze
 
         def qti_version
           2

data/lib/qti/v2/models/choices/simple_choice.rb

@@ -5,7 +5,7 @@ module Qti
     module Models
       module Choices
         class SimpleChoice < Qti::V2::Models::Base
-          PROHIBITED_NODE_NAMES = %w(feedbackInline).join(',').freeze
+          PROHIBITED_NODE_NAMES = %w[feedbackInline].join(',').freeze
 
           def initialize(node, parent)
             @node = node

data/lib/qti/v2/models/interactions/base_interaction.rb

@@ -5,7 +5,7 @@ module Qti
         class BaseInteraction < Qti::V2::Models::Base
           attr_reader :node
 
-          def self.matches(node)
+          def self.matches(_node)
             false
           end
 

data/lib/qti/v2/models/interactions/categorization_interaction.rb

@@ -16,7 +16,7 @@ module Qti
           def self.use_match_interaction_implementation?(node)
             MatchItemTagProcessors::MatchInteractionTagProcessor.match_interaction_tag?(node) &&
               MatchItemTagProcessors::MatchInteractionTagProcessor.number_of_questions_per_answer(node)
-                                                                   .any? { |n| n != 1 }
+                                                                  .any? { |n| n != 1 }
           end
 
           def scoring_data_structs

data/lib/qti/v2/models/interactions/gap_match_interaction.rb

@@ -20,9 +20,7 @@ module Qti
               gap_node.children.filter('gapText').each(&:remove)
 
               gap_node.children.each do |child|
-                if child.inner_text.strip.empty?
-                  child.remove
-                end
+                child.remove if child.inner_text.strip.empty?
               end
 
               gap_node
@@ -68,7 +66,7 @@ module Qti
               else
                 {
                   type: 'text',
-                  value: stem_item.text.empty? ? " " : stem_item.text
+                  value: stem_item.text.empty? ? ' ' : stem_item.text
                 }
               end
             end
@@ -90,20 +88,18 @@ module Qti
             question_response_pairs = node.xpath('.//xmlns:correctResponse//xmlns:value').map do |value|
               value.content.split
             end
-            question_response_pairs.map!{ |qrp| qrp.reverse }
+            question_response_pairs.map!(&:reverse)
             question_response_id_mapping = Hash[question_response_pairs]
-            answer_nodes.map { |value_node|
+            answer_nodes.map do |value_node|
               node_id = value_node.attributes['identifier']&.value
-              answer_choice = choices.find{ |choice| choice.attributes['identifier']&.value == question_response_id_mapping[node_id] }
+              answer_choice = choices.find { |choice| choice.attributes['identifier']&.value == question_response_id_mapping[node_id] }
               ScoringData.new(
                 answer_choice.content,
                 'directedPair',
-                {
-                  id: node_id,
-                  case: false
-                }
+                id: node_id,
+                case: false
               )
-            }
+            end
           end
 
           def choices

data/lib/qti/v2/models/interactions/match_interaction.rb

@@ -36,13 +36,13 @@ module Qti
           def self.use_associate_interaction_implementation?(node)
             MatchItemTagProcessors::AssociateInteractionTagProcessor.associate_interaction_tag?(node) &&
               MatchItemTagProcessors::AssociateInteractionTagProcessor.number_of_questions_per_answer(node)
-                                                                       .all? { |n| n == 1 }
+                                                                      .all? { |n| n == 1 }
           end
 
           def self.use_match_interaction_implementation?(node)
             MatchItemTagProcessors::MatchInteractionTagProcessor.match_interaction_tag?(node) &&
               MatchItemTagProcessors::MatchInteractionTagProcessor.number_of_questions_per_answer(node)
-                                                                   .all? { |n| n == 1 }
+                                                                  .all? { |n| n == 1 }
           end
         end
       end

data/lib/qti/v2/models/non_assessment_test.rb

@@ -16,11 +16,11 @@ module Qti
         def stimulus_ref(assessment_item_ref)
           ref = assessment_item_ref.sub(@package_root, '')
           dependencies = @doc.xpath("//xmlns:resource[@href='#{ref}']/xmlns:dependency/@identifierref")
-          return unless dependencies && dependencies.count == 1
+          return unless dependencies&.count == 1
           href = xpath_with_single_check("//xmlns:resource[@identifier='#{dependencies.first}']/@href")
           remap_href_path(href)
         end
       end
     end
   end
-end
+end

data/lib/qti/v2/models/scoring_data.rb

@@ -2,7 +2,7 @@ module Qti
   module V2
     module Models
       ScoringData = Struct.new(:values, :type, :id, :case, :question_id, :questions_ids) do
-        def initialize(values, type, options={})
+        def initialize(values, type, options = {})
           super(values, type, options[:id], options[:case], options[:question_id], options[:questions_ids])
         end
       end

data/lib/qti/v2/models/stimulus_item.rb

@@ -2,7 +2,6 @@ module Qti
   module V2
     module Models
       class StimulusItem < Qti::V2::Models::Base
-
         def body
           @body ||= begin
             item_body_node = xpath_with_single_check('//html/body')

data/lib/qti/version.rb

@@ -1,3 +1,3 @@
 module Qti
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

data/spec/gemfiles/nokogiri-1.6.gemfile.lock

@@ -0,0 +1,126 @@
+PATH
+  remote: ../..
+  specs:
+    qti (0.9.1)
+      activesupport (>= 4.2.9, < 5.2)
+      dry-struct (~> 0.2.1)
+      nokogiri (>= 1.6.8, < 1.9)
+      rubyzip (~> 1.2)
+      sanitize (>= 4.2.0, < 5.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (5.1.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    ast (2.3.0)
+    byebug (9.1.0)
+    coderay (1.1.2)
+    concurrent-ruby (1.0.5)
+    crass (1.0.2)
+    diff-lcs (1.3)
+    docile (1.1.5)
+    dry-configurable (0.7.0)
+      concurrent-ruby (~> 1.0)
+    dry-container (0.6.0)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 0.1, >= 0.1.3)
+    dry-core (0.3.3)
+      concurrent-ruby (~> 1.0)
+    dry-equalizer (0.2.0)
+    dry-logic (0.4.2)
+      dry-container (~> 0.2, >= 0.2.6)
+      dry-core (~> 0.2)
+      dry-equalizer (~> 0.2)
+    dry-struct (0.2.1)
+      dry-configurable (~> 0.1)
+      dry-equalizer (~> 0.2)
+      dry-types (~> 0.9, >= 0.9.0)
+      ice_nine (~> 0.11)
+    dry-types (0.12.0)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 0.1)
+      dry-container (~> 0.3)
+      dry-core (~> 0.2, >= 0.2.1)
+      dry-equalizer (~> 0.2)
+      dry-logic (~> 0.4, >= 0.4.2)
+      inflecto (~> 0.0.0, >= 0.0.2)
+    i18n (0.8.6)
+    ice_nine (0.11.2)
+    inflecto (0.0.2)
+    json (2.1.0)
+    method_source (0.9.0)
+    mini_portile2 (2.1.0)
+    minitest (5.10.3)
+    nokogiri (1.6.8.1)
+      mini_portile2 (~> 2.1.0)
+    nokogumbo (1.4.13)
+      nokogiri
+    parallel (1.12.0)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.11.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    rainbow (2.2.2)
+      rake
+    rake (0.9.6)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    rubocop (0.50.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.3)
+    rubyzip (1.2.1)
+    sanitize (4.5.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.4.4)
+      nokogumbo (~> 1.4.1)
+    simplecov (0.15.1)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.3.0)
+    wwtd (1.3.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.15)
+  byebug (~> 9.0)
+  nokogiri (~> 1.6.8)
+  pry (~> 0)
+  qti!
+  rake (~> 0)
+  rspec (~> 3.6)
+  rspec-mocks (~> 3.6)
+  rubocop (~> 0.50.0)
+  simplecov (~> 0)
+  wwtd (~> 1.3)
+
+BUNDLED WITH
+   1.15.4