qmin 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 224035ccd522282d02bb6c6020a115ffe5353d14
-  data.tar.gz: 9c0f5ac6458d44113c9ecf656c3b5e82120510bc
+  metadata.gz: 3ff3f0d1fbde9d321b9724c17b8509ee901767be
+  data.tar.gz: 544629dc2e489f2cfab3502fe4057c5e3c44f850
 SHA512:
-  metadata.gz: 597fbd9165320d0183e3c7bb523722bdec58f6ccb9fbb189dbc816706f34ae6de13be56c2e499fdc10dbe0b2f531255ae83505d0e4ddf06a64386165a94277e0
-  data.tar.gz: 2797a8f514bd41aefb36dda45a50a86a8c13a1dcd89a8d4c9ac04ee1d450c36d96de19536539e2a95f6743f3facfc1814b411f5295e0ebb89e5e88881d6626b8
+  metadata.gz: 24f64d0830c27904e64e72e015e90ef46941689362065eb4ec4b50ebb70141ad23994ad2b393d4ad5af1c89534fcfae94715f8c471592d3dd35ab4163f34437b
+  data.tar.gz: 2fdb9d6d4ca92329e51f72a8e32d3d37f633fc83014ca9fbdc29036e48e76bdc29aabf3ca442b129e87fd2d7b1a74590448829c51d6c2c416fa2a3fa0b070b56

data/.travis.yml

@@ -4,10 +4,11 @@ gemfile: Gemfile.ci
 before_install:
  - gem update --system 2.1.11
  - gem --version
+ - gem install bundler
 
 rvm:
-  - ruby-head
-  - 2.0.0-p0
+  - 2.1.0
+  - 2.0.0
   - 1.9.3
   - 1.9.2
   - 1.8.7

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source 'http://rubygems.org'
 
 # Specify your gem's dependencies in qmin.gemspec
 gemspec

data/lib/qmin/reporting/mail.rb

@@ -1,4 +1,5 @@
 require 'mail'
+require 'qmin/reporting/mail/mail_builder'
 
 module Qmin
   module Reporting
@@ -50,42 +51,6 @@ module Qmin
         mail.deliver
       end
 
-
-      class MailBuilder
-        def initialize(exception, mail_to, mail_from)
-          @exception, @mail_to, @mail_from = exception, mail_to, mail_from
-        end
-
-        attr_reader :exception, :mail_to, :mail_from
-
-        def build
-          mail = ::Mail.new
-
-          mail.to       mail_to
-          mail.from     mail_from
-          mail.subject  subject
-          mail.body     clean_backtrace.join("\n")
-
-          mail
-        end
-
-        private
-
-        def subject
-          "[ERROR] Qmin Report: #{exception.message}"
-        end
-
-        # copied from exception_notification gem
-        # http://github.com/smartinez87/exception_notification
-        def clean_backtrace
-          if defined?(Rails) && Rails.respond_to?(:backtrace_cleaner)
-            Rails.backtrace_cleaner.send(:filter, exception.backtrace)
-          else
-            exception.backtrace
-          end
-        end
-      end
-
     end
   end
 end

data/lib/qmin/reporting/mail/mail_builder.rb

@@ -0,0 +1,38 @@
+module Qmin
+  module Reporting
+    class MailBuilder
+      def initialize(exception, mail_to, mail_from)
+        @exception, @mail_to, @mail_from = exception, mail_to, mail_from
+      end
+
+      attr_reader :exception, :mail_to, :mail_from
+
+      def build
+        mail = ::Mail.new
+
+        mail.to       mail_to
+        mail.from     mail_from
+        mail.subject  subject
+        mail.body     clean_backtrace.join("\n")
+
+        mail
+      end
+
+      private
+
+      def subject
+        "[ERROR] Qmin Report: #{exception.message}"
+      end
+
+      # copied from exception_notification gem
+      # http://github.com/smartinez87/exception_notification
+      def clean_backtrace
+        if defined?(Rails) && Rails.respond_to?(:backtrace_cleaner)
+          Rails.backtrace_cleaner.send(:filter, exception.backtrace)
+        else
+          exception.backtrace
+        end
+      end
+    end
+  end
+end

data/lib/qmin/resque/background_call_job.rb

@@ -2,13 +2,21 @@ module Qmin
   module Resque
     class BackgroundCallJob
       def self.perform(*args)
-        new(*args).perform
+        begin
+          new(*args).perform
+        rescue => e
+          ::Qmin::Qmin.current.report(e)
+        end
       end
 
       def initialize(klass, method_name, id)
-        @klass = klass.is_a?(Class) ? klass : klass.constantize
-        @method_name = method_name
-        @id = id
+        begin
+          @klass = klass.is_a?(Class) ? klass : klass.constantize
+          @method_name = method_name
+          @id = id
+        rescue => e
+          ::Qmin::Qmin.current.report(e)
+        end
       end
 
       def perform

data/lib/qmin/strategy/inline.rb

@@ -8,7 +8,11 @@ module Qmin
 
       # call method directly
       def background_call(instance, method_name, *args)
-        instance.send(::Qmin.method_name_for_instance(instance, method_name), *args)
+        begin
+          instance.send(::Qmin.method_name_for_instance(instance, method_name), *args)
+        rescue => e
+          ::Qmin::Qmin.current.report(e)
+        end
       end
     end
   end

data/lib/qmin/version.rb

@@ -1,3 +1,3 @@
 module Qmin
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/spec/qmin/reporting/inline_spec.rb

@@ -1,5 +1,5 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/qmin'
+require File.expand_path '../../spec_helper', File.dirname(__FILE__)
+require File.expand_path '../../../lib/qmin', File.dirname(__FILE__)
 
 describe 'Qmin::Reporting::Inline' do
   let(:error_producer){ TestClass.new(123) }
@@ -14,7 +14,7 @@ describe 'Qmin::Reporting::Inline' do
     Qmin::Qmin.default_strategy = Qmin::Strategy::Noop
     lambda{
       error_producer.raise_error
-    }.should_not raise_error(TestClass::CustomError)
+    }.should_not raise_error
   end
 
   describe 'resque strategy' do
@@ -25,7 +25,7 @@ describe 'Qmin::Reporting::Inline' do
     it 'raises no error with resque strategy when enqueueing the job' do
       lambda{
         error_producer.raise_error
-      }.should_not raise_error(TestClass::CustomError)
+      }.should_not raise_error
     end
 
     it 'raises error when job is performing' do

data/spec/qmin/reporting/mail/mail_builder_spec.rb

@@ -0,0 +1,23 @@
+require File.expand_path '../../../spec_helper', File.dirname(__FILE__)
+require File.expand_path '../../../../lib/qmin', File.dirname(__FILE__)
+
+describe 'Qmin::Reporting::MailBuilder' do
+
+
+  let(:message)   { 'Exceptional' }
+  let(:backtrace) { ['Line 1', 'Line 2'] }
+  let(:exception) { err = StandardError.new(message); err.set_backtrace(backtrace); err }
+  let(:mail_to)   { 'receiver@example.com' }
+  let(:mail_from) { 'notifier@example.com' }
+
+  it 'builds mail' do
+    mail = Qmin::Reporting::MailBuilder.new(exception, mail_to, mail_from).build
+    mail.should_not be_blank
+    mail.should be_kind_of(Mail::Message)
+    mail.subject.should match(%r/#{message}$/)
+    mail.body.should include(backtrace.join("\n"))
+    mail.to.should eql [mail_to]
+    mail.from.should eql [mail_from]
+  end
+
+end

data/spec/qmin/reporting/mail_spec.rb

@@ -1,5 +1,5 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/qmin'
+require File.expand_path '../../spec_helper', File.dirname(__FILE__)
+require File.expand_path '../../../lib/qmin', File.dirname(__FILE__)
 
 describe 'Qmin::Reporting::Mail' do
 
@@ -16,10 +16,12 @@ describe 'Qmin::Reporting::Mail' do
 
   let(:error_producer){ TestClass.new(123) }
 
-  it 'raises error for inline strategy' do
+  it 'report mail for inline strategy' do
     lambda{
       error_producer.raise_error
-    }.should raise_error(TestClass::CustomError)
+    }.should_not raise_error(TestClass::CustomError)
+
+    Mail::TestMailer.deliveries.should_not be_empty
   end
 
   describe 'resque strategy' do
@@ -30,13 +32,13 @@ describe 'Qmin::Reporting::Mail' do
     it 'raises no error with resque strategy when enqueuing the job' do
       lambda{
         error_producer.raise_error
-      }.should_not raise_error(TestClass::CustomError)
+      }.should_not raise_error
     end
 
     it 'raises error when job is performing' do
       lambda{
         Qmin::Resque::BackgroundCallJob.new(TestClass, :raise_error, error_producer.id).perform
-      }.should_not raise_error(TestClass::CustomError)
+      }.should_not raise_error
 
       Mail::TestMailer.deliveries.should_not be_empty
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qmin
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - the-architect
@@ -101,6 +101,7 @@ files:
 - lib/qmin/qmin.rb
 - lib/qmin/reporting/inline.rb
 - lib/qmin/reporting/mail.rb
+- lib/qmin/reporting/mail/mail_builder.rb
 - lib/qmin/reporting/noop.rb
 - lib/qmin/resque/background_call_job.rb
 - lib/qmin/resque/base_job.rb
@@ -113,6 +114,7 @@ files:
 - spec/qmin/core_ext/string_spec.rb
 - spec/qmin/qmin_spec.rb
 - spec/qmin/reporting/inline_spec.rb
+- spec/qmin/reporting/mail/mail_builder_spec.rb
 - spec/qmin/reporting/mail_spec.rb
 - spec/qmin/resque/background_call_job_spec.rb
 - spec/qmin/resque/base_job_spec.rb
@@ -149,6 +151,7 @@ test_files:
 - spec/qmin/core_ext/string_spec.rb
 - spec/qmin/qmin_spec.rb
 - spec/qmin/reporting/inline_spec.rb
+- spec/qmin/reporting/mail/mail_builder_spec.rb
 - spec/qmin/reporting/mail_spec.rb
 - spec/qmin/resque/background_call_job_spec.rb
 - spec/qmin/resque/base_job_spec.rb